| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-08-01 | |||
| 18:32:46 | frickler | melwitt: is there anything missing except reviews on https://review.opendev.org/c/openstack/nova/+/888513? got a customer that seems affected by this, too | |
| 18:37:18 | melwitt | frickler: nope, just needs reviews. it doesn't have test coverage but that's just bc I couldn't think of a meaningful test for it. I'll add a comment on the review to that effect | |
| 18:43:23 | frickler | yes, I don't see how you could test that, either. fwiw we saw this after upgrading y->z | |
| 18:48:23 | sean-k-mooney | without poisoning the decorator to detech nesting or somehting like that im not sure iether | |
| 18:49:04 | sean-k-mooney | that said i feel like this si reversing our normal pattern | |
| 18:50:01 | sean-k-mooney | i.e. we normally decorat the generic inner function and then call it form the less geneeric singel use functions | |
| 18:50:45 | melwitt | the generic function isn't executing the query though. it's just returning a query object. you need the session manager to wrap the actual query execution | |
| 18:51:06 | sean-k-mooney | ya which makes this diffent then our normal pattern | |
| 18:51:20 | sean-k-mooney | so i think the pathc makes sense | |
| 18:52:00 | sean-k-mooney | your moving the reader decorator to where the execute happens | |
| 18:54:22 | melwitt | oh, yeah. I agree the query building helper function is different than the usual pattern (which is probably part of why this happened) | |
| 18:55:38 | melwitt | that said, it's been like this for a very long time so I'm not sure what more recent thing could have made the problem occur more often, or otherwise got people to report it | |
| 18:56:54 | sean-k-mooney | the only way i cna think to test this is to make _flavor_get_query_from_db a spy and assert that the read context is heald before and after callign it | |
| 18:58:51 | sean-k-mooney | we are usign this context manager as a decorrator correct https://github.com/openstack/nova/blob/a6126881244da66edc59028ea0ef21741c6fd492/nova/db/api/api.py#L23 | |
| 18:58:59 | melwitt | yeah.. I was kinda thinking if there's a way we could test for this generically like for everything. something like a spy | |
| 18:59:39 | frickler | the only change on that file from yoga to zed is https://review.opendev.org/c/openstack/nova/+/837156/1/nova/objects/flavor.py , but I don't understand enough alchemy to see how that might affect things | |
| 19:00:10 | frickler | might of course also be something happening somewhere else | |
| 19:00:26 | sean-k-mooney | frickler this is more likely to be realted to sqlachemy version i think | |
| 19:17:59 | sean-k-mooney | melwitt: frickler maybe im too tired to think of a clear test case but i dont see anything wrong with the patch so +2 | |
| 19:19:15 | melwitt | thanks sean-k-mooney | |
| 21:15:54 | opendevreview | Merged openstack/nova master: Add integrated job to test the Nova RBAC old defaults https://review.opendev.org/c/openstack/nova/+/883557 | |
| 21:16:01 | opendevreview | Merged openstack/nova stable/zed: Save cell socket correctly when updating host NUMA topology https://review.opendev.org/c/openstack/nova/+/882316 | |
| 21:41:45 | opendevreview | Merged openstack/nova master: Add online migration for Instance.compute_id https://review.opendev.org/c/openstack/nova/+/884752 | |
| 21:41:54 | dansmith | work starting to pay off ^ | |
| 22:06:06 | gmann | \o/ | |
| #openstack-nova - 2023-08-02 | |||
| 00:23:25 | opendevreview | melanie witt proposed openstack/nova master: block_device: Add encryption attributes to swap disks https://review.opendev.org/c/openstack/nova/+/884312 | |
| 00:23:25 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Configure and teardown ephemeral encryption secrets https://review.opendev.org/c/openstack/nova/+/826754 | |
| 00:23:26 | opendevreview | melanie witt proposed openstack/nova master: imagebackend: Add support to libvirt_info for LUKS based encryption https://review.opendev.org/c/openstack/nova/+/826755 | |
| 00:23:26 | opendevreview | melanie witt proposed openstack/nova master: Add encryption support to convert_image https://review.opendev.org/c/openstack/nova/+/870934 | |
| 00:23:27 | opendevreview | melanie witt proposed openstack/nova master: Support create with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870932 | |
| 00:23:27 | opendevreview | melanie witt proposed openstack/nova master: Support resize with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870933 | |
| 00:23:28 | opendevreview | melanie witt proposed openstack/nova master: Add hw_ephemeral_encryption_secret_uuid image property https://review.opendev.org/c/openstack/nova/+/870935 | |
| 00:23:29 | opendevreview | melanie witt proposed openstack/nova master: Add encryption support to qemu-img rebase https://review.opendev.org/c/openstack/nova/+/870936 | |
| 00:23:29 | opendevreview | melanie witt proposed openstack/nova master: Support snapshot with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870937 | |
| 00:23:31 | opendevreview | melanie witt proposed openstack/nova master: Support rebuild and unshelve with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/870939 | |
| 00:23:31 | opendevreview | melanie witt proposed openstack/nova master: WIP Support rescue with ephemeral encryption https://review.opendev.org/c/openstack/nova/+/873675 | |
| 00:23:33 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Introduce support for qcow2 with LUKS https://review.opendev.org/c/openstack/nova/+/772273 | |
| 00:23:33 | opendevreview | melanie witt proposed openstack/nova master: WIP libvirt: Introduce support for raw with LUKS https://review.opendev.org/c/openstack/nova/+/884313 | |
| 00:23:35 | opendevreview | melanie witt proposed openstack/nova master: WIP libvirt: Introduce support for rbd with LUKS https://review.opendev.org/c/openstack/nova/+/889912 | |
| 00:31:59 | opendevreview | melanie witt proposed openstack/nova master: DNM test ephemeral encryption + resize: qcow2, raw, rbd https://review.opendev.org/c/openstack/nova/+/862416 | |
| 00:40:31 | opendevreview | melanie witt proposed openstack/nova master: DNM test ephemeral encryption + resize: qcow2, raw, rbd https://review.opendev.org/c/openstack/nova/+/862416 | |
| 05:22:39 | auniyal | thanks sean-k-mooney | |
| 08:15:02 | opendevreview | suzhengwei proposed openstack/nova master: rename 'recreate' to 'evacuate' https://review.opendev.org/c/openstack/nova/+/883810 | |
| 08:39:35 | dvo-plv | bauzas, dansmith melwitt Hello, maybe you will have a chance today to review patchset ? https://review.opendev.org/c/openstack/nova/+/876075 | |
| 11:03:14 | opendevreview | Merged openstack/nova stable/wallaby: Fix segment-aware scheduling permissions error https://review.opendev.org/c/openstack/nova/+/884830 | |
| 12:09:12 | opendevreview | Amit Uniyal proposed openstack/nova master: [WIP] add healthcheck utils and constants https://review.opendev.org/c/openstack/nova/+/829469 | |
| 12:09:12 | opendevreview | Amit Uniyal proposed openstack/nova master: add healthcheck endpoint to proxy commands https://review.opendev.org/c/openstack/nova/+/830703 | |
| 13:17:19 | opendevreview | Amit Uniyal proposed openstack/nova master: [WIP] add healthcheck manager to manager base https://review.opendev.org/c/openstack/nova/+/827844 | |
| 13:17:19 | opendevreview | Amit Uniyal proposed openstack/nova master: [WIP] add healthcheck tracker to nova context https://review.opendev.org/c/openstack/nova/+/829468 | |
| 13:17:20 | opendevreview | Amit Uniyal proposed openstack/nova master: [WIP] add healthcheck utils and constants https://review.opendev.org/c/openstack/nova/+/829469 | |
| 13:17:20 | opendevreview | Amit Uniyal proposed openstack/nova master: add healthcheck endpoint to proxy commands https://review.opendev.org/c/openstack/nova/+/830703 | |
| 14:23:47 | opendevreview | ribaudr proposed openstack/nova master: Allow config to support virtiofs (driver) https://review.opendev.org/c/openstack/nova/+/886522 | |
| 14:23:48 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (db) https://review.opendev.org/c/openstack/nova/+/831193 | |
| 14:23:48 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (objects) https://review.opendev.org/c/openstack/nova/+/839401 | |
| 14:23:49 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | |
| 14:23:51 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 14:23:52 | opendevreview | ribaudr proposed openstack/nova master: Mounting the shares as part of the initialization process https://review.opendev.org/c/openstack/nova/+/880075 | |
| 14:23:52 | opendevreview | ribaudr proposed openstack/nova master: Deletion of associated share mappings on instance deletion https://review.opendev.org/c/openstack/nova/+/881472 | |
| 14:23:53 | opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | |
| 14:23:53 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/854823 | |
| 14:23:54 | opendevreview | ribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/854824 | |
| 14:23:55 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to resume method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/860284 | |
| 14:23:55 | opendevreview | ribaudr proposed openstack/nova master: Support resuming an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/860285 | |
| 14:23:56 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to rescue/unrescue shares https://review.opendev.org/c/openstack/nova/+/860286 | |
| 14:23:56 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (driver part) https://review.opendev.org/c/openstack/nova/+/860287 | |
| 14:23:58 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/860288 | |
| 14:23:58 | opendevreview | ribaudr proposed openstack/nova master: Allow to mount manila share using Cephfs protocol https://review.opendev.org/c/openstack/nova/+/883862 | |
| 14:24:00 | opendevreview | ribaudr proposed openstack/nova master: Check shares support (compute manager) https://review.opendev.org/c/openstack/nova/+/885751 | |
| 14:24:00 | opendevreview | ribaudr proposed openstack/nova master: Check shares support (only API exception) https://review.opendev.org/c/openstack/nova/+/885752 | |
| 14:24:02 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (API) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 14:24:02 | opendevreview | ribaudr proposed openstack/nova master: Check shares support (API) https://review.opendev.org/c/openstack/nova/+/850499 | |
| 14:24:04 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/885753 | |
| 14:24:04 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| 14:24:06 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | |
| 14:24:06 | opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | |
| 14:24:08 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach_error notification https://review.opendev.org/c/openstack/nova/+/860282 | |
| 14:24:08 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach_error notification https://review.opendev.org/c/openstack/nova/+/860283 | |
| 14:24:10 | opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | |
| 14:24:10 | opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | |
| 14:24:12 | opendevreview | ribaudr proposed openstack/nova master: Docs about Manila shares API usage https://review.opendev.org/c/openstack/nova/+/871642 | |
| 14:24:12 | opendevreview | ribaudr proposed openstack/nova master: Add share lock/unlock and restrict visibility https://review.opendev.org/c/openstack/nova/+/890340 | |
| 16:08:01 | stephenfin | Has anyone seen HTTP 502 errors being returned from Placement's API? I added traits support to placement recently and we've started seeing gate failures as a result | |
| 16:08:08 | stephenfin | https://zuul.opendev.org/t/openstack/builds?job_name=openstacksdk-functional-devstack&project=openstack%2Fdevstack&branch=master&skip=0 | |
| 16:09:09 | stephenfin | I can reproduce it locally against a "stock" (no non-password configuration in local.conf) DevStack install running in a VM if I run the tests repeatedly | |
| 16:09:10 | stephenfin | OS_TEST_TIMEOUT=60 tox -e functional-py310 -- -n openstack/tests/functional/placement/v1/test_trait.py --until-failure | |
| 16:09:59 | stephenfin | but I have no idea how to even start debugging it. My inclination is to disable the test temporarily but it would seem there's _something_ off in the Apache2-uWSGI-placement stack | |
| 16:17:59 | dansmith | stephenfin: I saw one case of it where it looked like apache made one query, which never made it to placement, | |
| 16:18:18 | dansmith | then apache trying to resolve the error document ended up actually making the call to placement which did succeed, | |
| 16:18:26 | dansmith | but it was too late for apache to return the result to the client | |
| 16:18:28 | dansmith | it was strange | |
| 16:19:27 | dansmith | if you can repro it locally I'm definitely less willing to blame an overworked apache | |
| 16:20:52 | stephenfin | it's strange indeed. The fact that it's reproducible locally and popping up frequently means I can't just write it off as an intermittent flake. I guess that's a good thing in the long run, since we'll have to fix it, but not helpful right now 😅 | |
| 16:20:52 | stephenfin | it's strange indeed. The fact that it's reproducible locally and popping up frequently means I can't just write it off as an intermittent flake. I guess that's a good thing in the long run, since we'll have to fix it, but not helpful right now 😅 | |
| 16:21:09 | stephenfin | but yeah, just a devstack vm running in PSI internally | |
| 16:22:51 | dansmith | ack | |
| 21:33:24 | opendevreview | Danylo Vodopianov proposed openstack/nova master: Packed virtqueue support was added. https://review.opendev.org/c/openstack/nova/+/876075 | |
| #openstack-nova - 2023-08-03 | |||
| 00:33:30 | opendevreview | Ghanshyam proposed openstack/nova master: Add service role in nova policy https://review.opendev.org/c/openstack/nova/+/864594 | |
| 04:24:47 | opendevreview | Ghanshyam proposed openstack/nova master: api-ref update: Move the service APIs in a separate section https://review.opendev.org/c/openstack/nova/+/864655 | |
| 08:45:49 | auniyal | Hello @sean-k-mooney, regarding healthcheck patch | |
| 08:45:49 | auniyal | pre_start_hook here https://review.opendev.org/c/openstack/nova/+/827844/7/nova/compute/manager.py#1759 | |