Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2023-06-06
17:37:06 sean-k-mooney well again i dont care about the cinder case im trying to fix discard support for non-cinder storage
17:37:20 geguileo using the report_discard_supported backend option
17:37:39 geguileo sean-k-mooney: I was digging into the discard case for cinder lol
17:37:52 geguileo and forgot to look into the ephemeral case
17:37:52 sean-k-mooney yep i know :)
17:38:07 sean-k-mooney ephmeral means somethign esle in nova
17:38:16 geguileo sean-k-mooney: I'm doing a writeup on my findings, so I'll send you the link later so you can add yours as well
17:38:24 sean-k-mooney acl
17:38:27 sean-k-mooney *ack
17:41:09 geguileo sean-k-mooney: dansmith thank you both for your time :-)
17:41:23 dansmith same :)
18:08:01 carloss o/ bauzas - what are your thoughts on having a follow-up cross-project session between Nova and Manila in the PTG next week? we can use it to chat about gouthamr's specs
20:07:49 opendevreview Merged openstack/nova master: Add debug logging when Instance raises OrphanedObjectError https://review.opendev.org/c/openstack/nova/+/883325
#openstack-nova - 2023-06-07
06:08:18 opendevreview Amit Uniyal proposed openstack/nova master: Reproducer for dangling bdms https://review.opendev.org/c/openstack/nova/+/881457
06:08:18 opendevreview Amit Uniyal proposed openstack/nova master: Delete dangling bdms https://review.opendev.org/c/openstack/nova/+/882284
06:55:43 opendevreview Amit Uniyal proposed openstack/nova master: Delete dangling bdms https://review.opendev.org/c/openstack/nova/+/882284
08:07:14 gibi dansmith: re https://www.youtube.com/watch?v=dLjNzwEULG8 so I should tatoo some instance.update notification to my body :)
08:14:02 opendevreview Amit Uniyal proposed openstack/nova-specs master: Adds cleanup to remove dangling volumes https://review.opendev.org/c/openstack/nova-specs/+/878757
08:29:28 gibi id we changed cirros guest image recently on master? Yesterday and today
08:29:48 gibi I started to see guest block io failures
08:30:00 gibi see https://review.opendev.org/c/openstack/nova/+/873216/7#message-4584b616820a42414995f77c6e495aafd6499ebc
08:30:07 gibi and
08:30:07 gibi https://review.opendev.org/c/openstack/nova/+/873216/7#message-0306974232385dedf7a9553ad65459e4f8849e28
08:52:26 gibi and one more https://review.opendev.org/c/openstack/nova/+/885352/3#message-0ed9f92e5069e79cb7b60724c048ca038c7c094e
09:04:43 gibi bauzas: I have questions in https://review.opendev.org/c/openstack/nova/+/885352
09:05:30 bauzas gibi: will look in a sec once I eventaually send the email I have in my inbox for a while :D
09:11:41 bauzas there
09:14:16 bauzas gibi: ack, thanks for your points, have like 2-min for discussing them .
09:14:18 bauzas ?
09:14:33 gibi yepp I have
09:16:04 bauzas cool
09:16:34 bauzas so, I don't really want to avoid providing a FileNotFound exception if you want to set a governor
09:17:04 bauzas if so, operators would see that their OS platform is not supporting the governors
09:17:39 gibi OK. so it is intentional that the FileNotFound exception propagates
09:18:15 gibi does it make the nova-compute fail to start if governor is requested in the config but not available on the hypervisor?
09:18:43 gibi or only the intance operaton that calls set_governor will fail?
09:26:41 frickler gibi: iiuc the GPT messages are normal due to the way cirros works. the vdb issue would be an additional volume failing, not related to cirros?
09:27:37 frickler also no change on cirros image yet, I want to get the new version cached in infra images first
09:27:48 frickler https://review.opendev.org/c/openstack/project-config/+/885005
09:28:39 gibi frickler: thanks
09:28:57 gibi frickler: then I need to check deeper about the volume issue
09:30:52 bauzas gibi: sorry, was looking at something else
09:31:18 gibi bauzas: as far as I see if the configured governor is not available then the instance operation will fail
09:31:23 bauzas gibi: yeah, if the ops wants to set a governor strategy, then we'll try to set it at startup
09:31:33 bauzas gibi: so the service restart will fail
09:31:35 gibi bauzas: could you point to it?
09:32:11 bauzas gibi: https://review.opendev.org/c/openstack/nova/+/885352/3/nova/tests/functional/libvirt/test_power_manage.py#244
09:35:28 gibi looking
09:36:05 gibi ahh it goes through power_down_all_dedicated_cpus
09:36:10 gibi during init_host
09:36:11 bauzas yes
09:36:11 gibi cool then
09:36:24 bauzas and that's why it failed previously
09:36:45 bauzas well, not exactly
09:37:07 bauzas it failed in the validate_cpu() method because we were comparing the governors if you set cp_state strategy
09:37:08 gibi previously it is failed on the governor property
09:37:12 gibi yeah
09:37:24 gibi and there now we return None
09:37:36 bauzas that's a proposal I made
09:37:37 gibi so the len of the governors will be 1 in this case and that check passses
09:37:58 gibi then the power_down_all_dedicated_cpus will be called and fail
09:37:58 bauzas I'm open to other ideas like dansmith's one about the 'none' string
09:38:44 gibi I'm OK with None
09:38:46 bauzas gibi: depending on the strategy, yes it will fail if governor is set
09:39:28 gibi as we are only using that value to collect the different actual governors across the pcpus
09:39:51 bauzas an alternative would be to raise an InvalidConfiguration exception instead of a somehow meaningless FileNotFound
09:40:27 gibi if FileNotFound explains the missing file path then I think that is enough for the deployer to figure out what is the issue
09:40:33 bauzas we do return this InvalidConf exception if you want to change the governors but you have some CPUs offline
09:40:56 bauzas gibi: yeah I was torn
09:41:45 bauzas gibi: between raising the FileNotFound exception that would show the filename, or a better direct exception that would directly tell 'sorry, you want to change the governors but your OS doesn't support it"
09:43:57 gibi I'm OK as is
09:44:38 gibi summarized our discussion in the review now. Thanks for clearing this up for me
09:45:22 bauzas gibi: np and thanks for the review
09:55:08 opendevreview Sylvain Bauza proposed openstack/nova master: cpu: make governors to be optional https://review.opendev.org/c/openstack/nova/+/885352
10:56:25 sean-k-mooney bauzas: i have not read back fully but it should be a hard error if you have enabled the govenors
10:57:00 sean-k-mooney but if you have enabeld cpu state then the lack of the cpu frequency govoner should not break things
11:04:28 sean-k-mooney bauzas: gibi what os was this on by the way
11:05:43 sean-k-mooney you are right that not all plathform will have this but any majour linux disto on x86 should so im wondering what exotic config was being used to find this
11:07:51 sean-k-mooney hum q35 vms?
11:10:57 sean-k-mooney https://www.phoronix.com/news/KVM-CPUFreq-RFC-Patches that might changegoing forward
11:19:46 gibi sean-k-mooney: It was theorethical based on reading the code :)
11:19:57 gibi but bauzas helped me understand it.
11:20:03 sean-k-mooney ok well it wont work in vms currently
11:20:10 sean-k-mooney so that is the refernce plathform :)
11:20:12 gibi so a configured but missing governor will be a hard failure on nova-compute startup
11:20:30 sean-k-mooney well a configured but missing govoner should be a hard fail
11:20:44 gibi it is :) so everything is good
11:20:58 sean-k-mooney but what would not be ok is if the cpu state part didnt work
11:21:08 gibi eypp
11:21:10 gibi yepp
11:21:11 sean-k-mooney if you configure that just because the govoner is not supported
11:21:13 sean-k-mooney so thats the bug right
11:21:21 gibi yes, and it is being fixed ow
11:21:22 gibi now
11:21:33 sean-k-mooney ya i looked at the patch quickly
13:25:05 dansmith bauzas: replied
13:41:55 bauzas dansmith: ok, so you would prefer to have an empty string ?
13:42:01 bauzas instead of None
13:42:14 dansmith bauzas: I would, but don't hold this up on me.. None is fine.
13:42:40 dansmith seriously, three people are fine with None, it's fine

Earlier   Later