| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-06-07 | |||
| 09:43:57 | gibi | I'm OK as is | |
| 09:44:38 | gibi | summarized our discussion in the review now. Thanks for clearing this up for me | |
| 09:45:22 | bauzas | gibi: np and thanks for the review | |
| 09:55:08 | opendevreview | Sylvain Bauza proposed openstack/nova master: cpu: make governors to be optional https://review.opendev.org/c/openstack/nova/+/885352 | |
| 10:56:25 | sean-k-mooney | bauzas: i have not read back fully but it should be a hard error if you have enabled the govenors | |
| 10:57:00 | sean-k-mooney | but if you have enabeld cpu state then the lack of the cpu frequency govoner should not break things | |
| 11:04:28 | sean-k-mooney | bauzas: gibi what os was this on by the way | |
| 11:05:43 | sean-k-mooney | you are right that not all plathform will have this but any majour linux disto on x86 should so im wondering what exotic config was being used to find this | |
| 11:07:51 | sean-k-mooney | hum q35 vms? | |
| 11:10:57 | sean-k-mooney | https://www.phoronix.com/news/KVM-CPUFreq-RFC-Patches that might changegoing forward | |
| 11:19:46 | gibi | sean-k-mooney: It was theorethical based on reading the code :) | |
| 11:19:57 | gibi | but bauzas helped me understand it. | |
| 11:20:03 | sean-k-mooney | ok well it wont work in vms currently | |
| 11:20:10 | sean-k-mooney | so that is the refernce plathform :) | |
| 11:20:12 | gibi | so a configured but missing governor will be a hard failure on nova-compute startup | |
| 11:20:30 | sean-k-mooney | well a configured but missing govoner should be a hard fail | |
| 11:20:44 | gibi | it is :) so everything is good | |
| 11:20:58 | sean-k-mooney | but what would not be ok is if the cpu state part didnt work | |
| 11:21:08 | gibi | eypp | |
| 11:21:10 | gibi | yepp | |
| 11:21:11 | sean-k-mooney | if you configure that just because the govoner is not supported | |
| 11:21:13 | sean-k-mooney | so thats the bug right | |
| 11:21:21 | gibi | yes, and it is being fixed ow | |
| 11:21:22 | gibi | now | |
| 11:21:33 | sean-k-mooney | ya i looked at the patch quickly | |
| 13:25:05 | dansmith | bauzas: replied | |
| 13:41:55 | bauzas | dansmith: ok, so you would prefer to have an empty string ? | |
| 13:42:01 | bauzas | instead of None | |
| 13:42:14 | dansmith | bauzas: I would, but don't hold this up on me.. None is fine. | |
| 13:42:40 | dansmith | seriously, three people are fine with None, it's fine | |
| 13:42:54 | bauzas | okidoki | |
| 14:14:58 | dansmith | bauzas: sorry I thought there was still a style thing to fix, I +2d now | |
| 14:16:12 | opendevreview | Merged openstack/nova master: Process unlimited exceptions raised by unplug_vifs https://review.opendev.org/c/openstack/nova/+/879350 | |
| 14:35:53 | opendevreview | Merged openstack/nova master: Fix failed count for anti-affinity check https://review.opendev.org/c/openstack/nova/+/873216 | |
| 16:54:02 | opendevreview | Merged openstack/nova master: db: Don't rely on branched connections https://review.opendev.org/c/openstack/nova/+/880663 | |
| 16:54:10 | opendevreview | Merged openstack/nova master: db: Remove unnecessary 'insert()' argument https://review.opendev.org/c/openstack/nova/+/880664 | |
| 16:54:19 | opendevreview | Merged openstack/nova master: tests: Pass parameters to sqlalchemy.text() as bindparams https://review.opendev.org/c/openstack/nova/+/880665 | |
| 16:54:26 | opendevreview | Merged openstack/nova master: tests: Add missing args to sqlalchemy.Table https://review.opendev.org/c/openstack/nova/+/880667 | |
| 21:37:32 | opendevreview | Merged openstack/nova master: cpu: fix the privsep issue when offlining the cpu https://review.opendev.org/c/openstack/nova/+/885293 | |
| #openstack-nova - 2023-06-08 | |||
| 06:47:19 | mnederlof | Hi all, would someone be able to help me to review the change i made? (https://review.opendev.org/c/openstack/nova/+/884595) | |
| 06:50:52 | frickler | mnederlof: based on the bug you reference (which was marked as invalid for nova) maybe sean-k-mooney might want to have a look. but also next week the summit is happening so things might be slow until some time after that | |
| 06:58:11 | mnederlof | yeah it was marked invalid, because it needed to be a feature, so i created a bp for it as well. but i can imagine the summit takes some preparation time this week as well :) | |
| 08:18:22 | opendevreview | Merged openstack/nova-specs master: Re-propose using extend volume completion action for 2023.2 https://review.opendev.org/c/openstack/nova-specs/+/877233 | |
| 09:57:17 | sean-k-mooney | mnederlof: frickler due to budget and other considerations im actully not attendign this summit. i had planned to go to the last physical ptg but it was canceled | |
| 10:00:10 | sean-k-mooney | mnederlof: placign the config option in workarounds implies it will be deleted at some point. so it likely should be elsewhere | |
| 10:01:12 | sean-k-mooney | mnederlof: you can get the same effect already without modifying nova | |
| 10:01:23 | sean-k-mooney | well almost | |
| 10:01:45 | sean-k-mooney | if you disabel the access to the diretl storage url in glance and exposing multipel locations | |
| 10:02:08 | sean-k-mooney | then nova cant detect that its the same ceph cluseter and we will download the image via glance and flatten it | |
| 10:35:15 | mnederlof | sean-k-mooney: yeah you could do that with glance, but then you lose the speed improvement when using a clone/flatten by ceph directly (which is significant) | |
| 10:36:13 | mnederlof | and thanks for the review, i will continue to work on these other points you mentioned | |
| 10:37:16 | sean-k-mooney | you will need to attend the nova team meeting and ask for the specless bluepritn to be approves as a specless blueprint by the way. its possibel that you may be asked to provdie a spec for this | |
| 10:38:01 | sean-k-mooney | we have a deadline for approvals in each cycle and in this case its july 6th | |
| 10:38:36 | sean-k-mooney | the next team meeting will be canceled due to the ptg so the next operturntiy to do this will be tuesday the 20th | |
| 10:39:59 | sean-k-mooney | bauzas: without doing a full review (feel free to do one if you want) do you think https://review.opendev.org/c/openstack/nova/+/884595 would need a spec | |
| 10:41:10 | sean-k-mooney | there si no api change which means we have some flexiblity and given its config driven and only in the libvirt driver the question really is what is the upgrade impact | |
| 10:41:45 | sean-k-mooney | mnederlof: have you spent any time thinking about what happens if you cahnge this option after the cloud is deployed | |
| 10:42:21 | sean-k-mooney | i.e. you have many vms using not flattend storage possibley with existign snapshots. then you enable flattening | |
| 10:42:43 | sean-k-mooney | will you retoractivaly flatten all the existign snapshots or just the new one | |
| 11:29:05 | mnederlof | sean-k-mooney: only new ones will be flattened, as this happens during instance create procedure, so if you change it after deployment, a operator needs to do the flattening of the previously created instances manually, using `rbd flatten <nova-pool>/<instance uuid>_disk` | |
| 11:29:35 | mnederlof | which is something he is already doing sometimes, if he wants to delete a glance image which has children | |
| 11:48:04 | sean-k-mooney | "{{ hostvars[inventory_hostname]['ansible_facts']['default_ipv4']['address'] }}" | |
| 11:49:46 | sean-k-mooney | https://opendev.org/zuul/zuul-jobs/src/commit/839de7f8996838162ae0de6a9f6ba28f968381bc/roles/nimble/defaults/main.yaml#L4 | |
| 11:54:53 | opendevreview | Amit Uniyal proposed openstack/nova master: Reproducer for dangling bdms https://review.opendev.org/c/openstack/nova/+/881457 | |
| 11:54:54 | opendevreview | Amit Uniyal proposed openstack/nova master: Delete dangling bdms https://review.opendev.org/c/openstack/nova/+/882284 | |
| 13:24:25 | sean-k-mooney | anyone care to review this backport. i just realised its still open https://review.opendev.org/c/openstack/nova/+/829804 | |
| 13:49:32 | dansmith | sean-k-mooney: can you hit this? https://review.opendev.org/c/openstack/nova/+/885352 | |
| 13:50:57 | dansmith | sean-k-mooney: how is that backport not just a feature? it even says so in the reno | |
| 13:51:16 | dansmith | I know it has as bug and bug-like description in the commit message, but it seems like a feature | |
| 13:51:35 | dansmith | and it also went straight to wallaby? | |
| 13:52:03 | dansmith | I guess I missed the discussion, so I'll go look | |
| 13:54:06 | dansmith | hmm, I'm not finding it | |
| 13:56:16 | dansmith | oh, feb 2022, not 2023 so was this already in yoga? | |
| 14:03:11 | sean-k-mooney | dansmith: where was some patalogical behvior which affected amd host that this helped adress | |
| 14:03:27 | sean-k-mooney | i need to join a meeting be let me loop back with the context i dont have it to hand | |
| 14:03:35 | dansmith | ack | |
| 14:15:26 | opendevreview | Amit Uniyal proposed openstack/nova master: Reproducer for dangling bdms https://review.opendev.org/c/openstack/nova/+/881457 | |
| 14:15:27 | opendevreview | Amit Uniyal proposed openstack/nova master: Delete dangling bdms https://review.opendev.org/c/openstack/nova/+/882284 | |
| 14:16:35 | ykarel | sean-k-mooney, bauzas when you get chance please revisit https://review.opendev.org/c/openstack/nova/+/868419 | |
| 14:16:53 | bauzas | ykarel: ack | |
| 14:37:28 | sean-k-mooney | dansmith: so looping back https://bugs.launchpad.net/nova/+bug/1978372 was the amd bug where the balancing feature could be used to mitigate the impact. however while lookign at that i just rememebered that gibi aslo adress the issue directly by adding some caching https://review.opendev.org/c/openstack/nova/+/845896 so backporting htat would also adress the issue with a large | |
| 14:37:30 | sean-k-mooney | number of host numa nodes | |
| 14:38:03 | sean-k-mooney | it does not jsut affect amd by the way but they just have a higher propbaly of higher core/numa node counts | |
| 14:40:21 | sean-k-mooney | so https://bugs.launchpad.net/nova/+bug/1978372/comments/6 was the intiall workaround but if we backport gibis change insteads we dont need the balancing feature is bug | |
| 15:32:51 | dansmith | sean-k-mooney: yeah, seems a lot better to backport that fix from gibi | |
| 15:33:22 | sean-k-mooney | ack in that case care to leave that as a comment and we can backprot that instead | |
| 15:33:42 | dansmith | not only does it closes-bug instead of partial-bug, fixes instead of feature in reno, but it addresses the actual problem without adding new conf knobs and behaviors | |
| 15:34:01 | dansmith | sean-k-mooney: I've already commented and got an unhelpful response from the owner | |
| 15:34:09 | dansmith | but yeah I'll leave my -1 then | |
| 15:34:19 | sean-k-mooney | cool | |
| 15:52:52 | opendevreview | Vasyl Saienko proposed openstack/os-vif master: Don't break traffic if port already exists https://review.opendev.org/c/openstack/os-vif/+/885127 | |
| 19:01:14 | dansmith | bauzas: we could probably benefit from a similar strategy: https://review.opendev.org/c/openstack/os-brick/+/885558/1/README.rst | |
| #openstack-nova - 2023-06-09 | |||
| 05:28:31 | opendevreview | Kiran Pawar proposed openstack/nova-specs master: SR-IOV NIC device tracking in Placement https://review.opendev.org/c/openstack/nova-specs/+/884569 | |
| 08:54:26 | plibeau1 | hello guys, do you have sometime to review: https://review.opendev.org/c/openstack/nova/+/861172 | |
| 12:52:20 | sean-k-mooney | plibeau1: i dont see any of the previous feedback adressed | |
| 12:52:28 | sean-k-mooney | port creation should not be using the admin client | |
| 12:52:46 | sean-k-mooney | port binding should be using the admin client or service user | |
| 12:53:02 | opendevreview | ribaudr proposed openstack/nova master: Deletion of associated share mappings on instance deletion https://review.opendev.org/c/openstack/nova/+/881472 | |
| 12:53:04 | opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | |
| 12:53:04 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/854823 | |