| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-05-09 | |||
| 16:20:56 | sean-k-mooney | we have a stable one schduled soon right? | |
| 16:21:15 | gibi | sean-k-mooney: I'm not sure we have bug review day scheduled | |
| 16:21:24 | elodilles | actually if i'm not mistaken that day is today :) | |
| 16:21:29 | gibi | I think we only scheduled spec review day | |
| 16:21:47 | elodilles | https://releases.openstack.org/bobcat/schedule.html#b-nova-stable-review-day | |
| 16:21:57 | elodilles | today :) | |
| 16:21:57 | sean-k-mooney | https://releases.openstack.org/bobcat/schedule.html#b-nova-stable-review-day | |
| 16:22:16 | gibi | hupps, I totally missed that | |
| 16:22:17 | sean-k-mooney | i think that didnt happen | |
| 16:22:28 | sean-k-mooney | should we try again next week | |
| 16:22:34 | gibi | we should | |
| 16:22:35 | elodilles | i reviewed some stable backport o:) | |
| 16:22:41 | gibi | elodilles++ :) | |
| 16:22:42 | sean-k-mooney | elodilles++ | |
| 16:23:13 | elodilles | though i also had review duties with Bobcat-1 release patches :X | |
| 16:23:18 | gibi | bauzas: could you make sure that we try the stable review day next week same day? | |
| 16:23:35 | gibi | or elodilles ^^ | |
| 16:23:37 | sean-k-mooney | other things were on my mind so i forgot about this until now | |
| 16:23:55 | gibi | it was a total blackout from my side | |
| 16:23:59 | gibi | anyhow | |
| 16:24:00 | gibi | moving on | |
| 16:24:13 | elodilles | i can ping the team here next Tuesday if that is what you mean gibi | |
| 16:24:19 | elodilles | on IRC | |
| 16:24:26 | gibi | elodilles: that is exactly what I mean :) | |
| 16:24:29 | gibi | thanks | |
| 16:24:31 | elodilles | \o/ | |
| 16:24:33 | gibi | #topic Gate status | |
| 16:24:40 | gibi | #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs | |
| 16:25:13 | gibi | I'm not up to date with the gate status | |
| 16:25:21 | gibi | but I saw https://bugs.launchpad.net/nova/+bug/1946339 happening again on couple of my patches | |
| 16:25:38 | gibi | so I added fresh links there | |
| 16:25:45 | gibi | *fresh job links | |
| 16:25:55 | gibi | how others feel about the gate? | |
| 16:27:11 | gibi | then I guess everything is acceptable | |
| 16:27:12 | gibi | :) | |
| 16:27:26 | gibi | #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&pipeline=periodic-weekly Nova&Placement | |
| 16:27:45 | gibi | periodics are green | |
| 16:27:57 | gibi | #info Please look at the gate failures and file a bug report with the gate-failure tag. | |
| 16:28:01 | gibi | #info STOP DOING BLIND RECHECKS aka. 'recheck' https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures | |
| 16:28:07 | gibi | anything else about our gate? | |
| 16:29:16 | gibi | then moving on | |
| 16:29:17 | gibi | #topic Release Planning | |
| 16:29:21 | gibi | #link https://releases.openstack.org/bobcat/schedule.html | |
| 16:29:26 | gibi | #info Nova deadlines are set in the above schedule | |
| 16:29:30 | gibi | #info Bobcat-1 is today | |
| 16:29:48 | elodilles | (* this week, rather) | |
| 16:29:49 | gibi | elodilles: do you need any help from us to make B-1 happen? | |
| 16:29:57 | gibi | elodilles: thanks, correct | |
| 16:30:01 | elodilles | gibi: i haven't seen any nova related patch | |
| 16:30:15 | gibi | is it a good or a bad sign? :) | |
| 16:30:17 | elodilles | that means we don't have any merged (and unreleased) patches | |
| 16:30:34 | elodilles | in our libraries / clients | |
| 16:31:03 | gibi | sounds good to me | |
| 16:31:21 | gibi | #info Next Tuesday 16th is stable branches review day | |
| 16:31:24 | elodilles | if anyone aware of sg that needs to be released, then this is the time, though :) | |
| 16:31:43 | elodilles | gibi: thx! \o/ | |
| 16:31:46 | gibi | elodilles: thanks | |
| 16:31:54 | elodilles | ++ | |
| 16:32:19 | gibi | hm either somebody updated the agenda while we were talking about the stable review day or it was already delayed | |
| 16:32:24 | sean-k-mooney | elodilles: once the os-vif bug is fixed we will want to do a release pretty quickily i think but it does not need to be aligned to any milestone | |
| 16:32:43 | gibi | sean-k-mooney: good point | |
| 16:32:55 | elodilles | sean-k-mooney: ACK, thanks for the heads up! | |
| 16:33:07 | elodilles | ping me and i can review it | |
| 16:33:09 | sean-k-mooney | its release wiht intermedirary so ill just submit the patch after the issue is fixed | |
| 16:33:15 | sean-k-mooney | ack | |
| 16:34:07 | gibi | cool, any other topic about our releases? | |
| 16:34:53 | gibi | then | |
| 16:34:54 | gibi | #topic Review priorities | |
| 16:34:58 | gibi | #link https://review.opendev.org/q/status:open+(project:openstack/nova+OR+project:openstack/placement+OR+project:openstack/os-traits+OR+project:openstack/os-resource-classes+OR+project:openstack/os-vif+OR+project:openstack/python-novaclient+OR+project:openstack/osc-placement)+(label:Review-Priority%252B1+OR+label:Review-Priority%252B2) | |
| 16:35:04 | gibi | #info As a reminder, cores eager to review changes can +1 to indicate their interest, +2 for committing to the review | |
| 16:35:07 | gibi | just the usual :) | |
| 16:35:24 | gibi | any comments? | |
| 16:36:13 | gibi | then I'm passing the keyboard to elodilles | |
| 16:36:13 | gibi | #topic Stable Branches | |
| 16:36:27 | elodilles | nothing to report, really, | |
| 16:36:33 | elodilles | so the usual: | |
| 16:36:36 | elodilles | #info stable branch status / gate failures tracking etherpad: https://etherpad.opendev.org/p/nova-stable-branch-ci | |
| 16:37:01 | elodilles | and i'll ping the team next week for the stable review day :) | |
| 16:37:07 | gibi | awesome | |
| 16:37:09 | elodilles | that's all from me | |
| 16:37:13 | gibi | thank you | |
| 16:37:21 | elodilles | ++ | |
| 16:37:43 | gibi | #topic Open discussion | |
| 16:37:47 | gibi | nothing on the agenda | |
| 16:38:17 | gibi | does anybody has anything to talk about? | |
| 16:38:55 | auniyal_ | this patch https://review.opendev.org/c/openstack/nova/+/857339 | |
| 16:39:30 | auniyal_ | I was trying to replace hasattr with obj_attr_is_set as per comments but few existing test cases are failing | |
| 16:39:49 | auniyal_ | because instance.new_flavor is getting set as None | |
| 16:40:28 | auniyal_ | I have added a detailed comments in patch | |
| 16:41:38 | auniyal_ | sean-k-mooney, suggested earlier need to change in test cases, but I am not sure what | |
| 16:41:43 | gibi | you need to do if instance.new_flavor and instance.new_flavor.obj_attr_is_set | |
| 16:41:54 | gibi | so basically check if instance.new_falvor is not None | |
| 16:42:02 | gibi | before callin obj_attr_is_set on it | |
| 16:42:19 | gibi | >>> hasattr(None, "foo") | |
| 16:42:19 | gibi | False | |
| 16:42:24 | gibi | hashattr handles None internally | |
| 16:42:25 | auniyal_ | but then we won't be running these TC's, is it okay | |
| 16:42:57 | gibi | I only checked this from hashattr vs obj_attr_is_set perspective | |
| 16:44:35 | gibi | with hasattr you also skipped these test if new_flavor was None | |
| 16:44:49 | auniyal_ | yes | |