| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-05-09 | |||
| 16:41:38 | auniyal_ | sean-k-mooney, suggested earlier need to change in test cases, but I am not sure what | |
| 16:41:43 | gibi | you need to do if instance.new_flavor and instance.new_flavor.obj_attr_is_set | |
| 16:41:54 | gibi | so basically check if instance.new_falvor is not None | |
| 16:42:02 | gibi | before callin obj_attr_is_set on it | |
| 16:42:19 | gibi | >>> hasattr(None, "foo") | |
| 16:42:19 | gibi | False | |
| 16:42:24 | gibi | hashattr handles None internally | |
| 16:42:25 | auniyal_ | but then we won't be running these TC's, is it okay | |
| 16:42:57 | gibi | I only checked this from hashattr vs obj_attr_is_set perspective | |
| 16:44:35 | gibi | with hasattr you also skipped these test if new_flavor was None | |
| 16:44:49 | auniyal_ | yes | |
| 16:45:25 | gibi | based on the review many people has more context on this change than me so I will defer to them | |
| 16:45:55 | gibi | but they seems not to be present right now. So I suggest to ping them | |
| 16:46:05 | auniyal_ | actually later I understood that, when I removed the hasattr I was skipping these test | |
| 16:46:29 | auniyal_ | sean-k-mooney, :) | |
| 16:48:13 | gibi | OK. Anything else before we close the meeting? | |
| 16:48:43 | auniyal_ | no, nothing from side thanks gibi | |
| 16:49:12 | gibi | #endmeeting | |
| 16:49:40 | gibi | bauzas: we need you to end the meeting | |
| 16:49:47 | gibi | the bot refuse to listen to me | |
| 16:49:59 | bauzas | gibi: shit, forgot you to add as a chair | |
| 16:50:45 | bauzas | also, about the stable branch review day, yeah let's punt that to next week | |
| 16:50:53 | gibi | ack | |
| 16:50:54 | bauzas | anyway, thanks a lot gibi | |
| 16:50:59 | bauzas | thanks all | |
| 16:51:00 | gibi | bauzas: no worries | |
| 16:51:03 | bauzas | #endmeeting | |
| 16:51:03 | opendevmeet | Meeting ended Tue May 9 16:51:03 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 16:51:03 | opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2023/nova.2023-05-09-16.01.html | |
| 16:51:03 | opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2023/nova.2023-05-09-16.01.txt | |
| 16:51:03 | opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2023/nova.2023-05-09-16.01.log.html | |
| 16:51:07 | gibi | thanks folks | |
| 16:52:45 | elodilles | thanks o/ | |
| 18:32:46 | opendevreview | sean mooney proposed openstack/os-vif master: set default qos policy https://review.opendev.org/c/openstack/os-vif/+/881751 | |
| 18:55:22 | opendevreview | sean mooney proposed openstack/os-vif master: set default qos policy https://review.opendev.org/c/openstack/os-vif/+/881751 | |
| 19:02:59 | opendevreview | sean mooney proposed openstack/os-vif master: set default qos policy https://review.opendev.org/c/openstack/os-vif/+/881751 | |
| 19:49:13 | bauzas | dansmith: now that we merged a lot of volume-related ssh stuff, I guess I only need to recheck https://review.opendev.org/c/openstack/nova/+/882052 ? or shall I rebase it from master ? | |
| 19:49:46 | bauzas | after a week, we're still unable to land this critical bugfix | |
| 19:49:57 | dansmith | did that fail on volume things? | |
| 19:50:09 | bauzas | yes, https://878773ae5f0379c9d548-8605f807f0b1cdc197533279c15edd0d.ssl.cf1.rackcdn.com/882052/1/check/tempest-integrated-compute-enforce-scope-new-defaults/2d80ba4/testr_results.html | |
| 19:50:46 | bauzas | (at least one test, not the second one which is a panicking guest) | |
| 19:50:51 | dansmith | bauzas: that failed with a kernel panic | |
| 19:51:08 | dansmith | unrelated to the things I've been working on fixing, but related to the thing I asked kashyap to try to chase down | |
| 19:51:27 | dansmith | but cirros 0.5.2's kernel being unsupported now, we don't really have any recourse | |
| 19:51:49 | bauzas | dansmith: but the first test failed on teardown after a timeout | |
| 19:52:05 | dansmith | because the guest was totally hung | |
| 19:53:36 | bauzas | oh, shit | |
| 19:53:43 | dansmith | bauzas: only one test failed, the first row is the teardown for the test that failed | |
| 19:53:54 | bauzas | missed that the first test failing is actually a teardownclass | |
| 19:53:59 | bauzas | yeah that | |
| 19:54:17 | dansmith | yeah | |
| 19:54:57 | bauzas | roger and do we have the cirros bug report ? | |
| 19:56:06 | bauzas | nvm, found it https://bugs.launchpad.net/nova/+bug/1939108 | |
| 19:58:26 | dansmith | actually I have a newer one | |
| 19:58:48 | dansmith | although my kernel crash looks different than the one you have here | |
| 19:59:12 | dansmith | yours looks like that one in the above bug indeed | |
| 19:59:25 | bauzas | yup | |
| 19:59:26 | dansmith | mine is quite different, but we see it a fair bit too | |
| 19:59:45 | dansmith | https://bugs.launchpad.net/nova/+bug/2018612\ | |
| 19:59:47 | dansmith | https://bugs.launchpad.net/nova/+bug/2018612 | |
| 20:00:19 | bauzas | I see | |
| 20:00:23 | bauzas | different problem indeed | |
| 20:00:30 | bauzas | kernel taintaing | |
| 20:00:35 | bauzas | tainting* | |
| 20:00:38 | dansmith | yours looks like crash on startup, mine is on attach, I think | |
| 20:00:42 | bauzas | yes | |
| 20:00:47 | bauzas | the acpi boot fails | |
| 20:01:12 | bauzas | we also have a problem with udhcpd leases, related to cirros too | |
| 20:01:30 | dansmith | yeaj | |
| 20:41:58 | opendevreview | sean mooney proposed openstack/os-vif master: remove focal based jobs https://review.opendev.org/c/openstack/os-vif/+/882755 | |
| 23:54:06 | opendevreview | Merged openstack/nova master: Revert "Debug Nova APIs call failures" https://review.opendev.org/c/openstack/nova/+/882052 | |
| 23:54:22 | dansmith | last time's a charm ^ | |
| 23:56:03 | melwitt | lol finally | |
| #openstack-nova - 2023-05-10 | |||
| 05:54:27 | opendevreview | Amit Uniyal proposed openstack/nova master: Allow swap resize from non-zero to zero https://review.opendev.org/c/openstack/nova/+/857339 | |
| 07:38:50 | opendevreview | Amit Uniyal proposed openstack/nova master: WIP: Reproducer for dangling volumes https://review.opendev.org/c/openstack/nova/+/881457 | |
| 07:38:50 | opendevreview | Amit Uniyal proposed openstack/nova master: WIP: Delete dangling bdms https://review.opendev.org/c/openstack/nova/+/882284 | |
| 08:54:39 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: [wip]network: convert usage of neutronclient to openstacksdk https://review.opendev.org/c/openstack/nova/+/882714 | |
| 11:10:58 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: [wip]network: convert usage of neutronclient to openstacksdk https://review.opendev.org/c/openstack/nova/+/882714 | |
| 13:20:19 | sean-k-mooney | sahid: when you have time can you take a look at https://review.opendev.org/c/openstack/os-vif/+/881751 and https://review.opendev.org/c/openstack/os-vif/+/882755 | |
| 14:19:05 | sahid | sean-k-mooney: sure, sorry I just have noticed your message | |
| 14:23:21 | sean-k-mooney | sahid: no rush | |
| 14:40:26 | opendevreview | Dan Smith proposed openstack/nova master: Use force=True for os-brick disconnect during delete https://review.opendev.org/c/openstack/nova/+/882847 | |
| 14:53:25 | opendevreview | melanie witt proposed openstack/nova master: Enable use of service user token with admin context https://review.opendev.org/c/openstack/nova/+/882852 | |
| 14:57:43 | opendevreview | melanie witt proposed openstack/nova stable/2023.1: Use force=True for os-brick disconnect during delete https://review.opendev.org/c/openstack/nova/+/882858 | |
| 14:57:44 | opendevreview | melanie witt proposed openstack/nova stable/2023.1: Enable use of service user token with admin context https://review.opendev.org/c/openstack/nova/+/882859 | |
| 14:59:46 | opendevreview | melanie witt proposed openstack/nova stable/zed: Use force=True for os-brick disconnect during delete https://review.opendev.org/c/openstack/nova/+/882860 | |
| 14:59:47 | opendevreview | melanie witt proposed openstack/nova stable/zed: Enable use of service user token with admin context https://review.opendev.org/c/openstack/nova/+/882861 | |
| 15:00:51 | opendevreview | melanie witt proposed openstack/nova stable/yoga: Use force=True for os-brick disconnect during delete https://review.opendev.org/c/openstack/nova/+/882863 | |
| 15:00:52 | opendevreview | melanie witt proposed openstack/nova stable/yoga: Enable use of service user token with admin context https://review.opendev.org/c/openstack/nova/+/882864 | |
| 15:03:26 | opendevreview | melanie witt proposed openstack/nova stable/xena: Use force=True for os-brick disconnect during delete https://review.opendev.org/c/openstack/nova/+/882867 | |
| 15:03:27 | opendevreview | melanie witt proposed openstack/nova stable/xena: Enable use of service user token with admin context https://review.opendev.org/c/openstack/nova/+/882868 | |
| 15:05:58 | opendevreview | melanie witt proposed openstack/nova stable/wallaby: Use force=True for os-brick disconnect during delete https://review.opendev.org/c/openstack/nova/+/882869 | |
| 15:05:59 | opendevreview | melanie witt proposed openstack/nova stable/wallaby: Enable use of service user token with admin context https://review.opendev.org/c/openstack/nova/+/882870 | |
| 17:01:57 | dansmith | need another quick +W on this to avoid a regression introduced in the CVE fix: https://review.opendev.org/c/openstack/nova/+/882852/1 | |
| 17:01:59 | dansmith | sean-k-mooney: ^ | |
| 17:02:07 | dansmith | gmann: ^ | |
| 17:05:18 | gmann | dansmith: sure, checking | |
| 17:23:21 | gmann | dansmith: so this is not that CVE fix regression but before also this exist right? I mean admin token was not made as service token ? | |
| 17:23:34 | gmann | or cinder had put the check about service token instead of just admin | |
| 17:24:10 | dansmith | gmann: we didn't need service token for these admins contexts before.. there was literally no reason, | |