| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-02-10 | |||
| 09:11:40 | bauzas | gibi: sean-k-mooney is on PTO today until wed, we need a second core | |
| 09:12:00 | gibi | hm mh | |
| 09:12:13 | sean-k-mooney[m] | i am but im reviewing your pm series | |
| 09:12:18 | sean-k-mooney[m] | right now | |
| 09:12:34 | sean-k-mooney[m] | so if you want me to look at something quickly i can | |
| 09:12:58 | bauzas | sean-k-mooney: oh, as you can | |
| 09:13:00 | gibi | sean-k-mooney[m]: just blindly merge https://review.opendev.org/c/openstack/nova/+/872975 please :D this is still trying to catch the functional tc | |
| 09:13:19 | gibi | that cause the libvirt import error in a later test | |
| 09:13:36 | bauzas | sean-k-mooney: for the PM series, I'll update the 3rd patch and work on a FUP given the method rename discussing in patch #2 | |
| 09:13:48 | gibi | after couple of days of constant rechecks we did not get a hit | |
| 09:14:00 | gibi | so we think if we merge the extra log it will fix the gate (kidding) | |
| 09:15:48 | gibi | bauzas: one thing hit me during the night and now I remember it. If we do the rename of the get_online_cpus and return the offlined ones as well then I think cpu_shared_set will allow listing offline CPUs without nova rejecting it. While in the past such config was rejected | |
| 09:16:04 | sean-k-mooney[m] | hehe a the famous add a debug line to fix the race technique | |
| 09:16:14 | sean-k-mooney[m] | there are man | |
| 09:16:19 | bauzas | technically this is a warning line :D | |
| 09:16:41 | bauzas | gibi: I need to look at that code, tbh | |
| 09:16:45 | sean-k-mooney[m] | *many c programs that are fixt with strategicly placed printfs | |
| 09:17:19 | gibi | sean-k-mooney[m]: it is a heisenbug so we merge the observer into the system and hope that it won't get entangled with it | |
| 09:17:42 | bauzas | lol | |
| 09:17:46 | gibi | but I know my fate | |
| 09:17:46 | bauzas | we need a cat | |
| 09:18:22 | bauzas | I'd rather say that the race condition is actually low | |
| 09:18:37 | bauzas | and we were blinded by the false positives | |
| 09:18:40 | gibi | maybe the race condition is affraid of cats ... | |
| 09:18:56 | bauzas | (just a theory) | |
| 09:19:05 | bauzas | cats don't like races | |
| 09:19:14 | bauzas | they prefer to sit down and lick their bottoms | |
| 09:19:43 | sean-k-mooney[m] | wont that break tempest | |
| 09:20:04 | bauzas | tempest is already broken :) | |
| 09:20:09 | gibi | sean-k-mooney[m]: in which way? | |
| 09:20:15 | bauzas | that's another fun story | |
| 09:20:40 | sean-k-mooney[m] | https://review.opendev.org/c/openstack/nova/+/872975/7/nova/virt/libvirt/driver.py | |
| 09:20:42 | sean-k-mooney[m] | if we ever do an abort in tempest | |
| 09:21:09 | sean-k-mooney[m] | then wont that either crash on parent being none or keep looping | |
| 09:21:52 | bauzas | you mean for the real tempest checks ? | |
| 09:22:37 | sean-k-mooney[m] | ya if we test live migration abort | |
| 09:23:04 | sean-k-mooney[m] | like we never set testcase_id in reall code in the eventlet | |
| 09:23:13 | bauzas | that's a good point | |
| 09:23:23 | bauzas | gibi: ^ | |
| 09:23:46 | bauzas | formerly, I restricted zuul to only run the functests | |
| 09:24:02 | bauzas | but if we merge this, it will be run for *all* tests | |
| 09:25:35 | sean-k-mooney[m] | its a simple fix commeted inline | |
| 09:25:47 | sean-k-mooney[m] | we just need to check that current is not None | |
| 09:25:56 | sean-k-mooney[m] | and only log if its not None | |
| 09:26:30 | sean-k-mooney[m] | so too None check in the while and around the log and it will work without breaking abort | |
| 09:27:39 | gibi | good point | |
| 09:27:42 | gibi | fixing it up... | |
| 09:51:51 | bauzas | gibi: working on the alternative for the PM series patch #2 | |
| 09:51:55 | bauzas | it won't be a fup | |
| 09:52:38 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add logging to find test cases leaking libvirt threads https://review.opendev.org/c/openstack/nova/+/872975 | |
| 09:52:43 | gibi | bauzas: sean-k-mooney[m]: ^^ | |
| 09:52:45 | gibi | bauzas: ack | |
| 09:53:57 | bauzas | gibi: +2d | |
| 09:54:38 | sean-k-mooney[m] | +2w | |
| 09:54:56 | sean-k-mooney[m] | also sylvain i completed a pass on the pm seriese | |
| 09:55:12 | sean-k-mooney[m] | nothing major but if your reworking it anyway please take a look | |
| 09:55:25 | sean-k-mooney[m] | i dont have any comments really worth holding the seriese over | |
| 09:55:42 | sean-k-mooney[m] | but perhaps things to think about in followups | |
| 09:57:14 | sean-k-mooney[m] | ok im going to have a coffee. check on freya then play some factorio. my ipad will be near by so if there is anything else just ping but im mostly done for the day now | |
| 09:57:17 | bauzas | sean-k-mooney: ack, very much appreciated | |
| 09:58:47 | sean-k-mooney[m] | ill laugh if after all that this fails to merge in the gate because the func test fails | |
| 10:00:38 | bauzas | our gate is in the weeds either way due to https://review.opendev.org/c/openstack/tempest/+/873300 still not merged | |
| 10:04:05 | gibi | factorio++ :) | |
| 10:04:23 | gibi | sean-k-mooney[m]: yeah, that has a chance :) | |
| 10:12:19 | opendevreview | Sofia Enriquez proposed openstack/nova master: Implement encryption on backingStore https://review.opendev.org/c/openstack/nova/+/870012 | |
| 10:17:14 | bauzas | TIL about factorio | |
| 10:24:52 | gibi | bauzas: be careful with factorio, it can feel like work :D | |
| 10:25:03 | gibi | sweet sweet productive work :D | |
| 10:25:17 | bauzas | I won't install it now, that's too risky | |
| 10:25:40 | bauzas | but I used to love playing RTS | |
| 10:28:28 | elodilles | bauzas: SC1 or SC2? :D | |
| 10:28:59 | bauzas | elodilles: dude, I'm 42, what do you expect ? | |
| 10:29:57 | elodilles | bauzas: 'same applies here' ;) | |
| 10:30:07 | gibi | SC1 2vs2 battle net was nice | |
| 10:30:36 | gibi | we tried SC2 2vs2 but it does not felt the same. (we probably got old) | |
| 10:30:37 | sean-k-mooney | its much simpler to get into a productive flow with factorio | |
| 10:31:06 | sean-k-mooney | that said did you know there are prometious exporters for factorio s you can visualise your factory in graphana | |
| 10:31:12 | bauzas | and when I say C&C, I really mean C&C 1 | |
| 10:31:16 | bauzas | and Red Alert | |
| 10:31:22 | bauzas | (mostly Red Alert actually) | |
| 10:31:29 | elodilles | :) | |
| 10:31:57 | bauzas | gibi: LAN parties with Starcraft 2x2 were gorgeous indeed | |
| 10:32:29 | elodilles | I'm so old that i time to time play WarCraft1 campaign just for "fun" >:D | |
| 10:32:32 | sean-k-mooney | peopel have litrally confiruted really monitoring systems to monitor there virtual factory and raise alerts when you run out of ore.... that is more investment then i can put into any game | |
| 10:32:57 | bauzas | sean-k-mooney: oh man, that's way too much addictive | |
| 10:33:38 | sean-k-mooney | bauzas: you should play it its fun | |
| 10:34:03 | sean-k-mooney | just make sure you have good posture when you do because you might blink and realise its been 3 hours without moving | |
| 10:38:18 | gibi | sean-k-mooney: if we loose bauzas on factortio then you need to be the next nova PTL as a punishment :) | |
| 10:38:36 | sean-k-mooney | lol | |
| 10:39:01 | sean-k-mooney | surpisingly that does not narrow it down much | |
| 10:40:50 | bauzas | Ogame, got it | |
| 10:41:14 | bauzas | that one stole too much of my free time | |
| 10:49:25 | bauzas | gibi: about https://review.opendev.org/c/openstack/nova/+/821228/6/nova/virt/libvirt/host.py#745 I wonder whether we really need to call *again* getCPUMap() | |
| 10:49:43 | bauzas | gibi: the existing logic just considers to return the cpu blindless | |
| 10:49:48 | bauzas | blindly | |
| 10:50:27 | bauzas | but I see your point | |
| 10:50:32 | bauzas | nevermind | |
| 10:51:24 | gibi | bauzas: you probably still need to differentiate between non existent cpu ids in the dedicated_set and existing but offined cpus | |
| 10:52:00 | bauzas | yeah, I'm about adding a get_available_cpus() which will return all CPUs for the map | |
| 10:53:23 | gibi | yeah that will work | |