| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-02-10 | |||
| 09:20:09 | gibi | sean-k-mooney[m]: in which way? | |
| 09:20:15 | bauzas | that's another fun story | |
| 09:20:40 | sean-k-mooney[m] | https://review.opendev.org/c/openstack/nova/+/872975/7/nova/virt/libvirt/driver.py | |
| 09:20:42 | sean-k-mooney[m] | if we ever do an abort in tempest | |
| 09:21:09 | sean-k-mooney[m] | then wont that either crash on parent being none or keep looping | |
| 09:21:52 | bauzas | you mean for the real tempest checks ? | |
| 09:22:37 | sean-k-mooney[m] | ya if we test live migration abort | |
| 09:23:04 | sean-k-mooney[m] | like we never set testcase_id in reall code in the eventlet | |
| 09:23:13 | bauzas | that's a good point | |
| 09:23:23 | bauzas | gibi: ^ | |
| 09:23:46 | bauzas | formerly, I restricted zuul to only run the functests | |
| 09:24:02 | bauzas | but if we merge this, it will be run for *all* tests | |
| 09:25:35 | sean-k-mooney[m] | its a simple fix commeted inline | |
| 09:25:47 | sean-k-mooney[m] | we just need to check that current is not None | |
| 09:25:56 | sean-k-mooney[m] | and only log if its not None | |
| 09:26:30 | sean-k-mooney[m] | so too None check in the while and around the log and it will work without breaking abort | |
| 09:27:39 | gibi | good point | |
| 09:27:42 | gibi | fixing it up... | |
| 09:51:51 | bauzas | gibi: working on the alternative for the PM series patch #2 | |
| 09:51:55 | bauzas | it won't be a fup | |
| 09:52:38 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add logging to find test cases leaking libvirt threads https://review.opendev.org/c/openstack/nova/+/872975 | |
| 09:52:43 | gibi | bauzas: sean-k-mooney[m]: ^^ | |
| 09:52:45 | gibi | bauzas: ack | |
| 09:53:57 | bauzas | gibi: +2d | |
| 09:54:38 | sean-k-mooney[m] | +2w | |
| 09:54:56 | sean-k-mooney[m] | also sylvain i completed a pass on the pm seriese | |
| 09:55:12 | sean-k-mooney[m] | nothing major but if your reworking it anyway please take a look | |
| 09:55:25 | sean-k-mooney[m] | i dont have any comments really worth holding the seriese over | |
| 09:55:42 | sean-k-mooney[m] | but perhaps things to think about in followups | |
| 09:57:14 | sean-k-mooney[m] | ok im going to have a coffee. check on freya then play some factorio. my ipad will be near by so if there is anything else just ping but im mostly done for the day now | |
| 09:57:17 | bauzas | sean-k-mooney: ack, very much appreciated | |
| 09:58:47 | sean-k-mooney[m] | ill laugh if after all that this fails to merge in the gate because the func test fails | |
| 10:00:38 | bauzas | our gate is in the weeds either way due to https://review.opendev.org/c/openstack/tempest/+/873300 still not merged | |
| 10:04:05 | gibi | factorio++ :) | |
| 10:04:23 | gibi | sean-k-mooney[m]: yeah, that has a chance :) | |
| 10:12:19 | opendevreview | Sofia Enriquez proposed openstack/nova master: Implement encryption on backingStore https://review.opendev.org/c/openstack/nova/+/870012 | |
| 10:17:14 | bauzas | TIL about factorio | |
| 10:24:52 | gibi | bauzas: be careful with factorio, it can feel like work :D | |
| 10:25:03 | gibi | sweet sweet productive work :D | |
| 10:25:17 | bauzas | I won't install it now, that's too risky | |
| 10:25:40 | bauzas | but I used to love playing RTS | |
| 10:28:28 | elodilles | bauzas: SC1 or SC2? :D | |
| 10:28:59 | bauzas | elodilles: dude, I'm 42, what do you expect ? | |
| 10:29:57 | elodilles | bauzas: 'same applies here' ;) | |
| 10:30:07 | gibi | SC1 2vs2 battle net was nice | |
| 10:30:36 | gibi | we tried SC2 2vs2 but it does not felt the same. (we probably got old) | |
| 10:30:37 | sean-k-mooney | its much simpler to get into a productive flow with factorio | |
| 10:31:06 | sean-k-mooney | that said did you know there are prometious exporters for factorio s you can visualise your factory in graphana | |
| 10:31:12 | bauzas | and when I say C&C, I really mean C&C 1 | |
| 10:31:16 | bauzas | and Red Alert | |
| 10:31:22 | bauzas | (mostly Red Alert actually) | |
| 10:31:29 | elodilles | :) | |
| 10:31:57 | bauzas | gibi: LAN parties with Starcraft 2x2 were gorgeous indeed | |
| 10:32:29 | elodilles | I'm so old that i time to time play WarCraft1 campaign just for "fun" >:D | |
| 10:32:32 | sean-k-mooney | peopel have litrally confiruted really monitoring systems to monitor there virtual factory and raise alerts when you run out of ore.... that is more investment then i can put into any game | |
| 10:32:57 | bauzas | sean-k-mooney: oh man, that's way too much addictive | |
| 10:33:38 | sean-k-mooney | bauzas: you should play it its fun | |
| 10:34:03 | sean-k-mooney | just make sure you have good posture when you do because you might blink and realise its been 3 hours without moving | |
| 10:38:18 | gibi | sean-k-mooney: if we loose bauzas on factortio then you need to be the next nova PTL as a punishment :) | |
| 10:38:36 | sean-k-mooney | lol | |
| 10:39:01 | sean-k-mooney | surpisingly that does not narrow it down much | |
| 10:40:50 | bauzas | Ogame, got it | |
| 10:41:14 | bauzas | that one stole too much of my free time | |
| 10:49:25 | bauzas | gibi: about https://review.opendev.org/c/openstack/nova/+/821228/6/nova/virt/libvirt/host.py#745 I wonder whether we really need to call *again* getCPUMap() | |
| 10:49:43 | bauzas | gibi: the existing logic just considers to return the cpu blindless | |
| 10:49:48 | bauzas | blindly | |
| 10:50:27 | bauzas | but I see your point | |
| 10:50:32 | bauzas | nevermind | |
| 10:51:24 | gibi | bauzas: you probably still need to differentiate between non existent cpu ids in the dedicated_set and existing but offined cpus | |
| 10:52:00 | bauzas | yeah, I'm about adding a get_available_cpus() which will return all CPUs for the map | |
| 10:53:23 | gibi | yeah that will work | |
| 10:59:45 | kashyap | bauzas: What exactly does getCPUMap() fetch? The docs only say "Get node CPU information" | |
| 11:00:12 | kashyap | Ah, it maps to `virsh cpu-stats` | |
| 11:00:57 | bauzas | yup | |
| 11:01:01 | kashyap | Oh, interesting. When I run `virsh cpu-stats` on my Fedora 36 VM for a guest, it gives me: | |
| 11:01:05 | bauzas | https://libvirt.org/html/libvirt-libvirt-host.html#virNodeGetCPUMap | |
| 11:01:12 | kashyap | $> sudo virsh cpu-stats 1 | |
| 11:01:13 | kashyap | error: Failed to retrieve CPU statistics for domain 'el8-vm1' | |
| 11:01:13 | kashyap | error: Operation not supported: operation 'getCpuacctPercpuUsage' not supported for backend 'cgroup V2' | |
| 11:01:25 | bauzas | [sbauza@sbauza temp]$ python | |
| 11:01:26 | bauzas | Python 3.11.1 (main, Jan 6 2023, 00:00:00) [GCC 12.2.1 20221121 (Red Hat 12.2.1-4)] on linux | |
| 11:01:26 | bauzas | Type "help", "copyright", "credits" or "license" for more information. | |
| 11:01:26 | bauzas | >>> import libvirt | |
| 11:01:26 | bauzas | >>> conn = libvirt.open('qemu:///system') | |
| 11:01:26 | kashyap | bauzas: Yeah, was reading. It looks like there's some accounting to be done w.r.t CGroups version | |
| 11:01:27 | bauzas | >>> conn.getCPUMap() | |
| 11:01:29 | bauzas | (8, [True, True, True, True, True, True, True, True], 8) | |
| 11:01:55 | kashyap | Yep | |
| 11:10:42 | sean-k-mooney | you can also just get the online cores form sysfs | |
| 11:11:18 | sean-k-mooney | if this is an issue but im fine with using libvirt's api for this | |
| 11:16:12 | bauzas | I'm done with the new rev, just updating the upper patch now | |
| 11:24:22 | sean-k-mooney | my steamdeck is charging so im currently still at my work laptop.(playing factorio) so gibi if your happy to review bauzas serise and it looks good to you ping me when your done and i can then do a final pass over it quickly and we can likely merge that today. with that said i have a doctors apointmen in a littel over 3 hours so ill be away after that. | |
| 11:24:38 | bauzas | that's a love | |
| 11:24:52 | auniyal | O/ | |
| 11:24:57 | gibi | sean-k-mooney: ack | |
| 11:25:04 | auniyal | in devstack is there a way to see nova-manage logs | |
| 11:25:20 | bauzas | I'm honestly torn, I don't know whether we should really pay attention to ignoring errors | |
| 11:25:36 | bauzas | and whether we should be cautious | |
| 11:25:55 | bauzas | honestly, we create a temp dir, so I don't except problems besides the full disk problem | |
| 11:26:11 | sean-k-mooney | you should not get any now with the way the fixture works | |