| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-02-08 | |||
| 09:48:46 | opendevreview | Sylvain Bauza proposed openstack/nova master: DNM: Add logging for leaking out the non-poisoned libvirt testcase https://review.opendev.org/c/openstack/nova/+/872975 | |
| 09:49:05 | bauzas | gibi: ^ | |
| 10:10:47 | gibi | bauzas: thanks | |
| 10:17:43 | bauzas | folks, on os-traits, given we only merged https://opendev.org/openstack/os-traits/commit/feb3e28a00eeab0d4dbf097dd801aff3adeb10d6 we don't need a release | |
| 10:18:21 | bauzas | that being said, there are 2 open changes that are related to some accepted nova blueprint https://review.opendev.org/q/status:open+project:openstack/os-traits | |
| 10:18:57 | bauzas | elodilles: I just approved https://review.opendev.org/c/openstack/os-traits/+/871226 on os-traits | |
| 10:19:06 | bauzas | elodilles: we'll need a release | |
| 10:21:10 | bauzas | cores, need a second +2/+W on https://review.opendev.org/c/openstack/os-traits/+/872185 to let Uggla not blocked by this os-trait change | |
| 10:21:37 | bauzas | even if there are very little chances to have virtiofs-scaphandre series to be mergeable in Antelope | |
| 10:25:19 | opendevreview | Merged openstack/os-traits master: Add new 'COMPUTE_ADDRESS_SPACE_*' traits https://review.opendev.org/c/openstack/os-traits/+/871226 | |
| 10:30:06 | gibi | bauzas: it is in merge conflict now so I will rebase it and approve it | |
| 10:31:49 | opendevreview | Merged openstack/os-resource-classes master: Change minversion of tox to 3.18.0 https://review.opendev.org/c/openstack/os-resource-classes/+/791974 | |
| 10:33:03 | opendevreview | Balazs Gibizer proposed openstack/os-traits master: Add 'COMPUTE_SHARE_LOCAL_FS' https://review.opendev.org/c/openstack/os-traits/+/872185 | |
| 10:34:18 | gibi | bauzas: done ^^ | |
| 10:34:41 | gibi | bauzas: we need to bump the os-traits min version in placement once there is an os-traits release for A | |
| 10:42:01 | elodilles | bauzas: ack, let me know when os-traits can be released | |
| 10:43:34 | gibi | elodilles: I think we only waiting for https://review.opendev.org/c/openstack/os-traits/+/872185 to land then we are good to go | |
| 10:43:57 | gibi | the rest of the open os-traits reviews seems to be not related to the a release | |
| 10:44:05 | gibi | s/a release/A release/ | |
| 10:46:47 | elodilles | gibi: ack, thanks | |
| 10:48:13 | elodilles | as I see that patch will land within 2-3 minutes if everything goes well | |
| 11:02:50 | opendevreview | Merged openstack/os-traits master: Add 'COMPUTE_SHARE_LOCAL_FS' https://review.opendev.org/c/openstack/os-traits/+/872185 | |
| 11:11:53 | elodilles | and merged ^^^, do you want me to create the release patch? | |
| 11:14:30 | gibi | elodilles: if it means you cannot +2 it then I will create the release patch :) | |
| 11:22:30 | elodilles | gibi: then please do o:) | |
| 11:25:03 | gibi | on it | |
| 11:27:33 | opendevreview | John Garbutt proposed openstack/nova stable/victoria: Revert "Revert resize: wait for events according to hybrid plug" https://review.opendev.org/c/openstack/nova/+/857423 | |
| 11:30:58 | gibi | elodilles, bauzas https://review.opendev.org/c/openstack/releases/+/873106 | |
| 11:34:30 | elodilles | thanks! will review when the release jobs have finished | |
| 11:37:58 | gibi | elodilles: cool, and bauzas will be back soon I guess to review it too | |
| 11:38:28 | bauzas | just done | |
| 11:42:18 | elodilles | +2'd! | |
| 11:42:45 | elodilles | bauzas: Bon Appétit! | |
| 11:42:45 | elodilles | bauzas: Bon Appétit! | |
| 11:45:18 | gibi | bauzas: enjoy | |
| 12:28:54 | gibi | bauzas: I just realized that we don't have debug log enabled in the functional test by default so I will going to change https://review.opendev.org/c/openstack/nova/+/872975 to log a warning instead | |
| 12:29:16 | bauzas | ack, ok | |
| 12:30:01 | sean-k-mooney | zigo: the best you can do is disable the format in glance including disbaling the image conversion. there is no way to fully block it in nova and even then im not sure idsablity in glace will prevnet all ways it could be used. | |
| 12:30:06 | bauzas | or pass OS_DEBUG=1 in tox.ini? | |
| 12:30:27 | sean-k-mooney | OS_DEBUG=1 can be set on the comand line | |
| 12:30:33 | sean-k-mooney | no need to modify tox.ini | |
| 12:30:45 | sean-k-mooney | oh you mean for ci | |
| 12:30:56 | sean-k-mooney | ya you could in the DNM change | |
| 12:31:12 | sean-k-mooney | but its very verbose on failure i think the pass logs are not too bad | |
| 12:31:17 | bauzas | yeah I mean in the specific change | |
| 12:31:33 | bauzas | but ok, will change the level | |
| 12:31:53 | sean-k-mooney | well it might be useful to use debug | |
| 12:31:55 | opendevreview | Balazs Gibizer proposed openstack/nova master: DNM: Add logging for leaking out the non-poisoned libvirt testcase https://review.opendev.org/c/openstack/nova/+/872975 | |
| 12:32:27 | bauzas | haha, gibi just did it :) | |
| 12:35:13 | gibi | we can switch to DEBUG all over for this patch if we want but that will mean a lot bigger subunit file to deal with :) | |
| 12:55:36 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (db) https://review.opendev.org/c/openstack/nova/+/831193 | |
| 12:55:36 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (objects) https://review.opendev.org/c/openstack/nova/+/839401 | |
| 12:55:37 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | |
| 12:55:37 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 12:55:38 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (api) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 12:55:38 | opendevreview | ribaudr proposed openstack/nova master: Check shares support https://review.opendev.org/c/openstack/nova/+/850499 | |
| 12:55:39 | opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | |
| 12:55:39 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| 12:55:40 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | |
| 12:55:41 | opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | |
| 12:55:41 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/852085 | |
| 12:55:43 | opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | |
| 12:55:43 | opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | |
| 12:55:45 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/854823 | |
| 12:55:45 | opendevreview | ribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/854824 | |
| 12:55:47 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach_error notification https://review.opendev.org/c/openstack/nova/+/860282 | |
| 12:55:47 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach_error notification https://review.opendev.org/c/openstack/nova/+/860283 | |
| 12:55:49 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to resume method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/860284 | |
| 12:55:49 | opendevreview | ribaudr proposed openstack/nova master: Support resuming an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/860285 | |
| 12:55:51 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to rescue/unrescue shares https://review.opendev.org/c/openstack/nova/+/860286 | |
| 12:55:51 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (driver part) https://review.opendev.org/c/openstack/nova/+/860287 | |
| 12:55:53 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/860288 | |
| 12:55:53 | opendevreview | ribaudr proposed openstack/nova master: Documentation https://review.opendev.org/c/openstack/nova/+/871642 | |
| 14:11:15 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (api) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 14:11:16 | opendevreview | ribaudr proposed openstack/nova master: Check shares support https://review.opendev.org/c/openstack/nova/+/850499 | |
| 14:11:16 | opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | |
| 14:11:17 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| 14:11:17 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | |
| 14:11:18 | opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | |
| 14:11:18 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/852085 | |
| 14:11:19 | opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | |
| 14:11:19 | opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | |
| 14:11:21 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/854823 | |
| 14:11:21 | opendevreview | ribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/854824 | |
| 14:11:23 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach_error notification https://review.opendev.org/c/openstack/nova/+/860282 | |
| 14:11:23 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach_error notification https://review.opendev.org/c/openstack/nova/+/860283 | |
| 14:11:25 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to resume method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/860284 | |
| 14:11:25 | opendevreview | ribaudr proposed openstack/nova master: Support resuming an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/860285 | |
| 14:11:27 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to rescue/unrescue shares https://review.opendev.org/c/openstack/nova/+/860286 | |
| 14:11:27 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (driver part) https://review.opendev.org/c/openstack/nova/+/860287 | |
| 14:11:29 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/860288 | |
| 14:11:29 | opendevreview | ribaudr proposed openstack/nova master: Documentation https://review.opendev.org/c/openstack/nova/+/871642 | |
| 14:11:57 | bauzas | Uggla: your're next in my review list, can I do it ? ^ | |
| 14:12:17 | Uggla | bauzas, sure | |
| 14:13:36 | bauzas | ack, grabbing a coffee first | |
| 14:33:26 | opendevreview | Elod Illes proposed openstack/nova stable/train: DNM: CI test https://review.opendev.org/c/openstack/nova/+/873116 | |
| 14:50:07 | gibi | bauzas: we are really unlucky with the DNM patch, it is still passing and not even producing the half false positives | |
| 14:50:15 | gibi | anyhow I rechecked again | |
| 14:50:20 | bauzas | yup, I've seen it | |
| 14:50:38 | bauzas | maybe we would need to merge it for like 2 or 3 days and revert it after | |