| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-02-08 | |||
| 12:29:16 | bauzas | ack, ok | |
| 12:30:01 | sean-k-mooney | zigo: the best you can do is disable the format in glance including disbaling the image conversion. there is no way to fully block it in nova and even then im not sure idsablity in glace will prevnet all ways it could be used. | |
| 12:30:06 | bauzas | or pass OS_DEBUG=1 in tox.ini? | |
| 12:30:27 | sean-k-mooney | OS_DEBUG=1 can be set on the comand line | |
| 12:30:33 | sean-k-mooney | no need to modify tox.ini | |
| 12:30:45 | sean-k-mooney | oh you mean for ci | |
| 12:30:56 | sean-k-mooney | ya you could in the DNM change | |
| 12:31:12 | sean-k-mooney | but its very verbose on failure i think the pass logs are not too bad | |
| 12:31:17 | bauzas | yeah I mean in the specific change | |
| 12:31:33 | bauzas | but ok, will change the level | |
| 12:31:53 | sean-k-mooney | well it might be useful to use debug | |
| 12:31:55 | opendevreview | Balazs Gibizer proposed openstack/nova master: DNM: Add logging for leaking out the non-poisoned libvirt testcase https://review.opendev.org/c/openstack/nova/+/872975 | |
| 12:32:27 | bauzas | haha, gibi just did it :) | |
| 12:35:13 | gibi | we can switch to DEBUG all over for this patch if we want but that will mean a lot bigger subunit file to deal with :) | |
| 12:55:36 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (db) https://review.opendev.org/c/openstack/nova/+/831193 | |
| 12:55:36 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (objects) https://review.opendev.org/c/openstack/nova/+/839401 | |
| 12:55:37 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | |
| 12:55:37 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 12:55:38 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (api) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 12:55:38 | opendevreview | ribaudr proposed openstack/nova master: Check shares support https://review.opendev.org/c/openstack/nova/+/850499 | |
| 12:55:39 | opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | |
| 12:55:39 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| 12:55:40 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | |
| 12:55:41 | opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | |
| 12:55:41 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/852085 | |
| 12:55:43 | opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | |
| 12:55:43 | opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | |
| 12:55:45 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/854823 | |
| 12:55:45 | opendevreview | ribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/854824 | |
| 12:55:47 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach_error notification https://review.opendev.org/c/openstack/nova/+/860282 | |
| 12:55:47 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach_error notification https://review.opendev.org/c/openstack/nova/+/860283 | |
| 12:55:49 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to resume method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/860284 | |
| 12:55:49 | opendevreview | ribaudr proposed openstack/nova master: Support resuming an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/860285 | |
| 12:55:51 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to rescue/unrescue shares https://review.opendev.org/c/openstack/nova/+/860286 | |
| 12:55:51 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (driver part) https://review.opendev.org/c/openstack/nova/+/860287 | |
| 12:55:53 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/860288 | |
| 12:55:53 | opendevreview | ribaudr proposed openstack/nova master: Documentation https://review.opendev.org/c/openstack/nova/+/871642 | |
| 14:11:15 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (api) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 14:11:16 | opendevreview | ribaudr proposed openstack/nova master: Check shares support https://review.opendev.org/c/openstack/nova/+/850499 | |
| 14:11:16 | opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | |
| 14:11:17 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| 14:11:17 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | |
| 14:11:18 | opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | |
| 14:11:18 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/852085 | |
| 14:11:19 | opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | |
| 14:11:19 | opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | |
| 14:11:21 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/854823 | |
| 14:11:21 | opendevreview | ribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/854824 | |
| 14:11:23 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach_error notification https://review.opendev.org/c/openstack/nova/+/860282 | |
| 14:11:23 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach_error notification https://review.opendev.org/c/openstack/nova/+/860283 | |
| 14:11:25 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to resume method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/860284 | |
| 14:11:25 | opendevreview | ribaudr proposed openstack/nova master: Support resuming an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/860285 | |
| 14:11:27 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to rescue/unrescue shares https://review.opendev.org/c/openstack/nova/+/860286 | |
| 14:11:27 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (driver part) https://review.opendev.org/c/openstack/nova/+/860287 | |
| 14:11:29 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (compute and API part) https://review.opendev.org/c/openstack/nova/+/860288 | |
| 14:11:29 | opendevreview | ribaudr proposed openstack/nova master: Documentation https://review.opendev.org/c/openstack/nova/+/871642 | |
| 14:11:57 | bauzas | Uggla: your're next in my review list, can I do it ? ^ | |
| 14:12:17 | Uggla | bauzas, sure | |
| 14:13:36 | bauzas | ack, grabbing a coffee first | |
| 14:33:26 | opendevreview | Elod Illes proposed openstack/nova stable/train: DNM: CI test https://review.opendev.org/c/openstack/nova/+/873116 | |
| 14:50:07 | gibi | bauzas: we are really unlucky with the DNM patch, it is still passing and not even producing the half false positives | |
| 14:50:15 | gibi | anyhow I rechecked again | |
| 14:50:20 | bauzas | yup, I've seen it | |
| 14:50:38 | bauzas | maybe we would need to merge it for like 2 or 3 days and revert it after | |
| 14:50:53 | bauzas | so more than one change would use it | |
| 15:40:30 | bauzas | if, while I'm reviewing some series, someone wants to jab my own power management series, it would be loved <3 https://review.opendev.org/q/topic:bp%252Flibvirt-cpu-state-mgmt | |
| 15:40:43 | bauzas | I can hit the bullet. | |
| 15:40:57 | gibi | bauzas: on my list to go back to it | |
| 15:41:07 | bauzas | thanks | |
| 15:41:22 | bauzas | I'm on the manila shares one, but a single coffee shot isn't enough | |
| 15:50:17 | opendevreview | Jorge San Emeterio proposed openstack/nova master: WIP: Look for cpu controller on cgroups v2 https://review.opendev.org/c/openstack/nova/+/873127 | |
| 16:57:49 | gmann | gibi: did you get chance to look into the placement RBAC change, updated as per your comment https://review.opendev.org/c/openstack/placement/+/865618 | |
| 17:00:30 | gibi | gmann: good point. I'm fast tracking your patch now | |
| 17:02:18 | gibi | gmann: +2 +A thanks | |
| 17:03:39 | gibi | the check queue getting long in zuul (>2h to get an executor). It almost feels like FF week :) | |
| 17:10:17 | gmann | gibi: thanks | |
| 17:10:34 | gmann | yeah, gate is in bad situation | |
| 17:36:35 | opendevreview | Dan Smith proposed openstack/nova master: Add docs for stable-compute-uuid behaviors https://review.opendev.org/c/openstack/nova/+/872977 | |
| 18:18:57 | gibi | bauzas: you might not like it but I reviewed the power managemenet series | |
| 18:19:08 | gibi | bauzas: I'm close to -2 on the tar.gz part ;) | |
| 18:19:32 | sean-k-mooney | gibi: that is proably resolveable | |
| 18:19:45 | bauzas | gibi: thanks for the fish | |
| 18:19:53 | bauzas | gibi: do you have time for discussing about it ? | |
| 18:19:53 | sean-k-mooney | we started with a large copy of the syfs filesystem but the funcitonl test can be writeen a differnt way | |
| 18:20:02 | gibi | bauzas: I have a bit of time yes | |
| 18:20:18 | sean-k-mooney | the current approch was taken when thsi started as arbiterd | |
| 18:20:30 | sean-k-mooney | it had a much larger scope | |
| 18:20:33 | gibi | my main concern with the tar.gz is that I cannot review it or diff it in a normal way | |
| 18:20:40 | gibi | so it is hidden information | |
| 18:20:41 | bauzas | gibi: I do understand your point | |
| 18:20:42 | sean-k-mooney | for the limite scope in nova i htink we can create a fixture another way | |
| 18:20:57 | gibi | I would do couple of helper function that generates the fs on the fly | |
| 18:21:09 | bauzas | gibi: the problem is, as said by sean-k-mooney, is that the large number of files was creating a problem | |
| 18:21:11 | sean-k-mooney | gibi: ya that was the alternitive | |
| 18:21:23 | sean-k-mooney | bauzas: we dont need a large number of files | |
| 18:21:29 | gibi | bauzas: I assume we have two type of files | |
| 18:21:29 | bauzas | ok, I can try to generate those arbitrary files then | |
| 18:21:33 | sean-k-mooney | we actully only need a small subset | |
| 18:21:39 | bauzas | we only need a subset of the sysfs | |
| 18:21:47 | bauzas | yep, ok | |