| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-01-17 | |||
| 16:45:44 | bauzas | that sounds doable to me | |
| 16:45:45 | gmann | for local run I think both way ok either make sure we have tox<4 in our env or pin it in tox.ini | |
| 16:46:04 | sean-k-mooney | i replciated the pin in ci downstream | |
| 16:46:32 | gmann | we did for python-novaclient https://review.opendev.org/c/openstack/python-novaclient/+/869598/2/tox.ini#4 | |
| 16:46:35 | gmann | #link https://review.opendev.org/c/openstack/python-novaclient/+/869598/2/tox.ini#4 | |
| 16:47:27 | sean-k-mooney | yes | |
| 16:47:38 | sean-k-mooney | so do we want to do it for all the other nova delivberable | |
| 16:47:46 | elodilles | then i'm OK to do the same and release after that merged | |
| 16:47:50 | sean-k-mooney | if so we should do it before the em tansition | |
| 16:48:35 | elodilles | yes, I'm OK with that, I don't see now any reason not to do it before the transition | |
| 16:49:56 | elodilles | (the generated xena release patches don't have deadlines, but best not to postpone them for weeks) | |
| 16:50:28 | bauzas | ok, sounds an agreement, we just need an owner | |
| 16:50:53 | sean-k-mooney | i can do it for os-vif maybe some of the others | |
| 16:51:00 | bauzas | ack | |
| 16:51:02 | sean-k-mooney | its really just one line and ensuring it works loocally | |
| 16:51:10 | bauzas | I know | |
| 16:51:12 | elodilles | sean-k-mooney: ping me if i forgot the reviews o:) | |
| 16:51:52 | bauzas | anyway I guess we're done with this topic and we have a specless blueprint ask in a sec | |
| 16:51:59 | bauzas | so, moving on | |
| 16:52:17 | bauzas | #topic Open discussion | |
| 16:52:30 | bauzas | (sean-k-mooney) https://blueprints.launchpad.net/nova/+spec/default-ephemeral-format-unformated | |
| 16:53:03 | sean-k-mooney | ya so tl;dr is currently we use libguestfs in two places in nova | |
| 16:53:12 | sean-k-mooney | file injection which is deprecated for a long time | |
| 16:53:25 | sean-k-mooney | and formating the filesystem of the addtional ephmeral disks | |
| 16:53:41 | bauzas | true | |
| 16:53:45 | sean-k-mooney | i would like to have a way to allwo tthe ephmeral disk to be unformated | |
| 16:53:53 | sean-k-mooney | making libguestfs optional | |
| 16:54:14 | sean-k-mooney | to the proposal is either add unformated to https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.default_ephemeral_format | |
| 16:54:28 | sean-k-mooney | or sligly cleaner add a bool opt to trun off the formating | |
| 16:54:35 | bauzas | what does the default value which is None ? | |
| 16:54:55 | sean-k-mooney | and i want to kwno if there is a prefernce and if we think this could be a spec or specless | |
| 16:55:02 | dansmith | either is okay with me, I guess format=unformatted seems better to me because it's just another option for an existing knob | |
| 16:55:31 | sean-k-mooney | i need to check the default of none but i belive it makes it os dependednt | |
| 16:55:36 | bauzas | sean-k-mooney: I see None as the default value, what's then the behaviour ? | |
| 16:55:38 | bauzas | ok | |
| 16:55:43 | sean-k-mooney | i need to dig into this a little more | |
| 16:56:04 | sean-k-mooney | but basically i wanted ot know if peopel think this is ok to do this cycle | |
| 16:56:13 | sean-k-mooney | or shoudl we discuss in the ptg and do it next cycle | |
| 16:56:14 | bauzas | I think this is a very small feature | |
| 16:56:19 | bauzas | self-containede | |
| 16:56:26 | dansmith | yeah no need for lots of discussion, IMHO | |
| 16:56:30 | bauzas | particularly if we go with adding a new value | |
| 16:56:56 | sean-k-mooney | ok so 1 i need to document what none does. 2 determin if it can disable the formating today alredy | |
| 16:57:02 | bauzas | true | |
| 16:57:10 | sean-k-mooney | and 3 if not add unformated as an option to expcitly do that | |
| 16:57:20 | bauzas | sounds a simple plan to me | |
| 16:57:34 | sean-k-mooney | so at a minium ill add a docs change to say what none does | |
| 16:57:45 | sean-k-mooney | and we can then evaluate in the gerrit review if we need unformated | |
| 16:58:02 | gibi | sounds good to me | |
| 16:58:06 | bauzas | anyone objecting about this smallish effort for this cycle ? | |
| 16:58:29 | sean-k-mooney | if this ends up not being small i will punt to next cycle | |
| 16:58:45 | bauzas | I don't expect any behavioural change | |
| 16:59:03 | bauzas | so I'm fine with approving it as a specless blueprint based on such assumption | |
| 16:59:35 | bauzas | and you're free to close this one as deferred if we consider this is only a doc patch | |
| 16:59:44 | sean-k-mooney | correct the default would be what we have today and the unformated behavior woudl be opt in | |
| 16:59:45 | bauzas | any objections ? | |
| 16:59:51 | dansmith | no objection from me | |
| 16:59:55 | bauzas | cool | |
| 17:00:11 | bauzas | #agreed https://blueprints.launchpad.net/nova/+spec/default-ephemeral-format-unformated accepted as specless blueprint for the 2023.1 cycle | |
| 17:00:17 | bauzas | that's it for me | |
| 17:00:21 | bauzas | nothing else on the agenda | |
| 17:00:23 | bauzas | thanks all | |
| 17:00:26 | bauzas | #endmeeting | |
| 17:00:26 | opendevmeet | Meeting ended Tue Jan 17 17:00:26 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 17:00:26 | opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2023/nova.2023-01-17-16.00.html | |
| 17:00:26 | opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2023/nova.2023-01-17-16.00.txt | |
| 17:00:26 | opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2023/nova.2023-01-17-16.00.log.html | |
| 17:01:09 | elodilles | thanks o/ | |
| 17:01:12 | gibi | o/ | |
| 17:03:17 | bauzas | sean-k-mooney: https://github.com/openstack/nova/blob/9e2ca01988b8889738eba3c9af336ad82d214e1b/nova/virt/libvirt/utils.py#L226 | |
| 17:05:50 | sean-k-mooney | so none is virt driver dpendent and for libvirt its ext4 | |
| 17:06:06 | sean-k-mooney | if the glance image does not have an OS | |
| 17:06:16 | sean-k-mooney | *os_type set | |
| 17:06:47 | sean-k-mooney | also why are we importing the constant form the privsep module nova.privsep.fs.FS_FORMAT_EXT4 | |
| 17:06:52 | sean-k-mooney | that just feel lazy | |
| 17:07:09 | sean-k-mooney | bauzas: actully thats in create_ploop_image | |
| 17:07:10 | bauzas | correct | |
| 17:07:19 | sean-k-mooney | so that is only used for openvz | |
| 17:07:43 | sean-k-mooney | that not what we do for qemu/kvm | |
| 17:08:21 | bauzas | indeed | |
| 17:08:22 | bauzas | https://github.com/openstack/nova/blob/b8a5961161da4a33c4d9c80e3025d9ff6eaf5326/nova/privsep/fs.py#L299-L302 | |
| 17:08:40 | sean-k-mooney | https://github.com/openstack/nova/blob/9e2ca01988b8889738eba3c9af336ad82d214e1b/nova/privsep/fs.py#L257-L259 | |
| 17:08:59 | bauzas | yup | |
| 17:09:10 | sean-k-mooney | so for qemu/kvm we default to vfat | |
| 17:09:11 | bauzas | anyway, the behaviour of None seems consistent | |
| 17:09:29 | sean-k-mooney | its virt driver and virt_type dependent | |
| 17:09:36 | sean-k-mooney | so ya a new option is what we want | |
| 17:09:41 | sean-k-mooney | well value | |
| 17:09:44 | bauzas | this is just saying "let the virt driver decide for me or the os type" | |
| 17:09:44 | sean-k-mooney | of unformatted | |
| 17:09:53 | sean-k-mooney | yep | |
| 17:10:04 | sean-k-mooney | ok will ill update the docs text to call that out | |
| 17:10:07 | bauzas | correct, we need an extra explicit value | |
| 17:10:32 | bauzas | if we just want an unformatted partition | |
| 17:10:33 | sean-k-mooney | i breifly looked at this this morning but didnt have time to fully get to the bottom of it | |
| 17:10:54 | sean-k-mooney | not even a partion a blank file | |
| 17:11:17 | sean-k-mooney | so if we set unformatted we will jsut get the empty disk | |
| 17:11:26 | sean-k-mooney | and its up to the user to partion and format it as they see fit | |
| 17:11:31 | sean-k-mooney | just like a blank cinder volume | |
| 17:11:42 | bauzas | I see | |