Earlier  
Posted Nick Remark
#openstack-nova - 2023-01-17
16:57:20 bauzas sounds a simple plan to me
16:57:34 sean-k-mooney so at a minium ill add a docs change to say what none does
16:57:45 sean-k-mooney and we can then evaluate in the gerrit review if we need unformated
16:58:02 gibi sounds good to me
16:58:06 bauzas anyone objecting about this smallish effort for this cycle ?
16:58:29 sean-k-mooney if this ends up not being small i will punt to next cycle
16:58:45 bauzas I don't expect any behavioural change
16:59:03 bauzas so I'm fine with approving it as a specless blueprint based on such assumption
16:59:35 bauzas and you're free to close this one as deferred if we consider this is only a doc patch
16:59:44 sean-k-mooney correct the default would be what we have today and the unformated behavior woudl be opt in
16:59:45 bauzas any objections ?
16:59:51 dansmith no objection from me
16:59:55 bauzas cool
17:00:11 bauzas #agreed https://blueprints.launchpad.net/nova/+spec/default-ephemeral-format-unformated accepted as specless blueprint for the 2023.1 cycle
17:00:17 bauzas that's it for me
17:00:21 bauzas nothing else on the agenda
17:00:23 bauzas thanks all
17:00:26 bauzas #endmeeting
17:00:26 opendevmeet Meeting ended Tue Jan 17 17:00:26 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
17:00:26 opendevmeet Minutes: https://meetings.opendev.org/meetings/nova/2023/nova.2023-01-17-16.00.html
17:00:26 opendevmeet Minutes (text): https://meetings.opendev.org/meetings/nova/2023/nova.2023-01-17-16.00.txt
17:00:26 opendevmeet Log: https://meetings.opendev.org/meetings/nova/2023/nova.2023-01-17-16.00.log.html
17:01:09 elodilles thanks o/
17:01:12 gibi o/
17:03:17 bauzas sean-k-mooney: https://github.com/openstack/nova/blob/9e2ca01988b8889738eba3c9af336ad82d214e1b/nova/virt/libvirt/utils.py#L226
17:05:50 sean-k-mooney so none is virt driver dpendent and for libvirt its ext4
17:06:06 sean-k-mooney if the glance image does not have an OS
17:06:16 sean-k-mooney *os_type set
17:06:47 sean-k-mooney also why are we importing the constant form the privsep module nova.privsep.fs.FS_FORMAT_EXT4
17:06:52 sean-k-mooney that just feel lazy
17:07:09 sean-k-mooney bauzas: actully thats in create_ploop_image
17:07:10 bauzas correct
17:07:19 sean-k-mooney so that is only used for openvz
17:07:43 sean-k-mooney that not what we do for qemu/kvm
17:08:21 bauzas indeed
17:08:22 bauzas https://github.com/openstack/nova/blob/b8a5961161da4a33c4d9c80e3025d9ff6eaf5326/nova/privsep/fs.py#L299-L302
17:08:40 sean-k-mooney https://github.com/openstack/nova/blob/9e2ca01988b8889738eba3c9af336ad82d214e1b/nova/privsep/fs.py#L257-L259
17:08:59 bauzas yup
17:09:10 sean-k-mooney so for qemu/kvm we default to vfat
17:09:11 bauzas anyway, the behaviour of None seems consistent
17:09:29 sean-k-mooney its virt driver and virt_type dependent
17:09:36 sean-k-mooney so ya a new option is what we want
17:09:41 sean-k-mooney well value
17:09:44 bauzas this is just saying "let the virt driver decide for me or the os type"
17:09:44 sean-k-mooney of unformatted
17:09:53 sean-k-mooney yep
17:10:04 sean-k-mooney ok will ill update the docs text to call that out
17:10:07 bauzas correct, we need an extra explicit value
17:10:32 bauzas if we just want an unformatted partition
17:10:33 sean-k-mooney i breifly looked at this this morning but didnt have time to fully get to the bottom of it
17:10:54 sean-k-mooney not even a partion a blank file
17:11:17 sean-k-mooney so if we set unformatted we will jsut get the empty disk
17:11:26 sean-k-mooney and its up to the user to partion and format it as they see fit
17:11:31 sean-k-mooney just like a blank cinder volume
17:11:42 bauzas I see
17:50:26 opendevreview Merged openstack/osc-placement master: Use pypi released version of placement in functional tests https://review.opendev.org/c/openstack/osc-placement/+/869755
17:53:55 sean-k-mooney sigh... https://review.opendev.org/c/openstack/nova/+/869900 will never merge
18:14:14 sean-k-mooney bauzas: summerised usecase here https://blueprints.launchpad.net/nova/+spec/default-ephemeral-format-unformated
18:14:21 sean-k-mooney in the whiteboard
18:14:27 bauzas sean-k-mooney: all good thanks
18:43:02 dansmith yeah looking at the latest ceph-multistore oom, one of tempest's workers is using >900MiB of ram, where the others are <10
18:43:09 dansmith so something is clearly going haywire
18:43:33 dansmith gmann: you're aware of this right?
18:43:52 dansmith I assume if you knew of any recent tempest changes that could be responsible, you'd have spoken up by now :)
18:57:01 gmann dansmith: no, I cannot recall any relevant change happened in tempest
18:57:15 dansmith yeah I looked too, and nothing much lately
18:59:49 gmann and no stestr version change recently
19:01:33 dansmith I'm trying to stack for the first time this year so I can repro and I'm getting this failure to install pbr.build when it tries to install os-testr
19:01:38 dansmith ModuleNotFoundError: No module named 'pbr.build'
19:01:45 dansmith is this known?
19:01:52 dansmith gmann: ^
19:03:33 gmann no, i did not see this before
19:04:01 sean-k-mooney stephenfin: fixed a pbr issues recently not sure if its releaed
19:05:22 sean-k-mooney this https://review.opendev.org/q/topic:pep-517 but that looks more tox 4 related
19:06:46 dansmith blargh
19:06:56 dansmith I can install os-testr without constraints, but it fails like this otherwise
19:07:08 sean-k-mooney wait os-testr
19:07:11 gmann yeah I think those were tox4 related
19:07:13 sean-k-mooney what is using that
19:07:22 dansmith sean-k-mooney: +./stack.sh:main:803 pip_install -U os-testr
19:07:24 sean-k-mooney we shoud not be using os-testr anywhere anymore
19:07:35 sean-k-mooney everthing should be using stestr
19:07:41 gmann that is installed successfully in gate I think that is using constraint?
19:07:59 gmann https://zuul.opendev.org/t/openstack/build/0fc9dc8ecbe748498c941c6f21cbf057/log/job-output.txt#4367
19:08:23 dansmith yeah I dunno why I can't install it
19:08:31 sean-k-mooney its in uc ya https://opendev.org/openstack/requirements/src/branch/master/openstack_requirements/tests/files/upper-constraints.txt#L359
19:08:37 dansmith unless it's a mirror sync thing?
19:08:57 sean-k-mooney https://opendev.org/openstack/devstack/src/branch/master/stack.sh#L803
19:09:04 sean-k-mooney comment ou tthat line
19:09:26 gmann not this week but last week i stack successfully
19:09:53 clarkb note contraints don't pick what is installed. Only what version to install if something is to be installed
19:09:56 dansmith sean-k-mooney: heh, yeah, I could but..
19:10:27 sean-k-mooney clarkb: yep i know just pointing out that it would be constrained if it was installed for other projects
19:10:39 dansmith I purged pbr and os-testr locally, which might have gotten past it
19:10:59 sean-k-mooney pip_install -U os-testr
19:11:04 sean-k-mooney so that is unconstiaed in devstack
19:11:18 sean-k-mooney unless pip_install in devstack add uc by default
19:12:23 gmann https://zuul.opendev.org/t/openstack/build/0fc9dc8ecbe748498c941c6f21cbf057/log/job-output.txt#4367
19:12:37 dansmith sean-k-mooney: it does
19:12:47 dansmith I could install it myself without uc

Earlier   Later