Earlier  
Posted Nick Remark
#openstack-nova - 2022-10-27
02:26:00 opendevreview melanie witt proposed openstack/nova master: Add mock to avoid loading guestfs in unit test https://review.opendev.org/c/openstack/nova/+/862769
08:12:49 opendevreview Sahid Orentino Ferdjaoui proposed openstack/nova master: compute: enhance compute evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858383
08:12:49 opendevreview Sahid Orentino Ferdjaoui proposed openstack/nova master: api: extend evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858384
08:19:40 opendevreview Sahid Orentino Ferdjaoui proposed openstack/nova-specs master: spec: allowing target state for evacuate https://review.opendev.org/c/openstack/nova-specs/+/857838
08:56:51 opendevreview Balazs Gibizer proposed openstack/nova master: Reproduce PCI pool filtering bug https://review.opendev.org/c/openstack/nova/+/855649
08:56:52 opendevreview Balazs Gibizer proposed openstack/nova master: Strictly follow placement allocation during PCI claim https://review.opendev.org/c/openstack/nova/+/855650
08:56:52 opendevreview Balazs Gibizer proposed openstack/nova master: Show candidate combinatorial explosion by dev number https://review.opendev.org/c/openstack/nova/+/855885
09:01:52 gibi bauzas: a procedural question. We have the RFE bug filed for the port route metric support https://bugs.launchpad.net/nova/+bug/1994137 it is a whislist so that part is OK. Should I simply set it to Triaged or we want to discuss it in the next meeting before I set Triaged?
09:02:18 bauzas gibi: no, we agreed on it so Triage it directly ;)
09:02:25 gibi OK.
09:04:58 auniyal_ Hi bauzas, gibi, sean-k-mooney
09:05:23 auniyal_ can you please review theses - these are backports
09:05:24 auniyal_ https://review.opendev.org/c/openstack/nova/+/861856
09:05:24 auniyal_ https://review.opendev.org/c/openstack/nova/+/861857
09:05:24 auniyal_
09:05:24 auniyal_ https://review.opendev.org/c/openstack/nova/+/861871
09:05:26 auniyal_ https://review.opendev.org/c/openstack/nova/+/861872
09:05:28 auniyal_
09:05:30 auniyal_ https://review.opendev.org/c/openstack/nova/+/862604
09:05:32 auniyal_ https://review.opendev.org/c/openstack/nova/+/862603
09:05:34 auniyal_
09:05:36 auniyal_ mostly clean cherry-pick
09:35:45 amorin hello nova team, when using ovs backend, nova plugs interface in ovs using vif_plug_ovs python module
09:36:02 amorin I was expecting to find the vif_plug_ovs option available in the config reference:
09:36:04 amorin https://docs.openstack.org/nova/latest/configuration/config.html
09:36:08 amorin but it's not
09:36:57 amorin https://github.com/openstack/os-vif/blob/master/vif_plug_ovs/ovs.py#L54
09:37:57 amorin is that normal?
09:45:09 sean-k-mooney its a know issue
09:45:19 sean-k-mooney so technically os-vif is not part of nova
09:45:26 sean-k-mooney to have it incldued in novas docs
09:45:27 bauzas I was about to say it :)
09:45:35 sean-k-mooney we need to list it in the generation command
09:45:43 bauzas this is not a middleware we import
09:45:44 sean-k-mooney someone was goign to fix it a while ago
09:45:49 sean-k-mooney feel free to if you want
09:45:59 sean-k-mooney bauzas: actully it is
09:46:06 sean-k-mooney but not in the docs
09:46:14 bauzas sean-k-mooney: this is a lazy import ?
09:46:31 sean-k-mooney vif_plug_ovs is import when we init os-vif
09:46:40 bauzas correct, so a lazy import
09:46:43 sean-k-mooney its the in tree ovs plugin
09:47:01 bauzas hence me wondering how we could generate the config without importing it directly
09:47:02 sean-k-mooney ya but when we generate the config refence we need to list the namespaces to generate
09:47:05 sean-k-mooney and we dont
09:47:06 bauzas without not*
09:48:27 gibi auniyal_: left +2s on the first and left some feedback in https://review.opendev.org/c/openstack/nova/+/862603
09:49:34 sean-k-mooney amorin: anyway back to yoru question its just a case of we never got aroudn to it
09:50:04 sean-k-mooney so patches are welcome i was just loking for where to chagne it but i dont rememebr off the top of my head
09:50:28 sean-k-mooney i think you need to add it here https://github.com/openstack/nova/blob/master/etc/nova/nova-config-generator.conf#L18
09:50:30 bauzas https://github.com/openstack/nova/blob/master/etc/nova/nova-config-generator.conf
09:50:36 sean-k-mooney ya
09:50:37 amorin ack, perfect
09:50:37 bauzas damn, again, beated
09:50:47 amorin I will try to propose a change then
09:51:01 bauzas amorin: test it locally
09:51:11 bauzas amorin: you have a tox target
09:51:13 sean-k-mooney can you add all the in tree plugsin so also linux bridge
09:51:17 bauzas tox -egenconfig
09:51:33 amorin ok
09:51:45 sean-k-mooney the noop pluging does not have config so you can ignore it
09:53:06 amorin so it's os-vif + linux-bridge
09:53:18 amorin is the list somewhere?
09:53:53 sean-k-mooney https://github.com/openstack/os-vif
09:54:04 sean-k-mooney there are 3 plugins the vif_plug diretories
09:54:14 sean-k-mooney and the ovs and linux bridge ones have config options
09:55:51 sean-k-mooney amorin: this is how the cofnig is regestered https://github.com/openstack/os-vif/blob/master/os_vif/plugin.py#L71-L89
09:57:28 sean-k-mooney the linux bridge name is https://github.com/openstack/os-vif/blob/b0298b5350f21f858f2bf72c5d18e3019a696514/vif_plug_linux_bridge/constants.py#L13
09:57:46 sean-k-mooney os os_vif_linux_bridge
09:58:24 sean-k-mooney that i think will be the namespace you need to list but i have not tried that to see if that is correct or if the namespace shoudl just be os_vif or something like that
10:09:27 darkhorse sean-k-mooney: thank you for responding to the issue that I have reported to launchpad. https://bugs.launchpad.net/nova/+bug/1993736
10:10:27 darkhorse I think I did not make clear description there. I have updated the description and put a link to a patchset that I have published.
10:11:03 darkhorse Will you take a look at it when you find a moment?
10:12:39 amorin ack, thanks sean-k-mooney
10:12:44 amorin and bauzas
10:51:10 auniyal_ thanks gibi
11:28:50 opendevreview Sahid Orentino Ferdjaoui proposed openstack/nova-specs master: spec: allowing target state for evacuate https://review.opendev.org/c/openstack/nova-specs/+/857838
11:44:19 opendevreview Sahid Orentino Ferdjaoui proposed openstack/nova-specs master: spec: allowing target state for evacuate https://review.opendev.org/c/openstack/nova-specs/+/857838
11:51:20 songwenping_ sean-k-mooney: hi, in our Rocky version env, placement integrate with nova, placement-api service comes across this error https://bugs.launchpad.net/nova/+bug/1314554/, and return 500 when call its api. do you have any idea?
11:53:12 sean-k-mooney i dont think we support nosetests in rocky by the way but that not really the issue
11:55:39 sean-k-mooney well it might be related
11:56:25 sean-k-mooney songwenping_: do you get the same issue if you use stestr or tox to run the tests
12:02:29 songwenping_ our tests cannot run, we have give up the test in our product env.
12:03:29 sean-k-mooney we will be end of lifing the rocky branch shortly with no other release planned
12:03:57 sean-k-mooney if this is broken its likely not a recent breakage
12:04:24 sean-k-mooney the last commit to stable rocky was the 22nd of april this year
12:04:37 sean-k-mooney so your product tests have been broken since then or longer
12:06:39 songwenping_ yes we have broken for long time
12:06:42 sean-k-mooney im running the test locally now to confirm but this could be due to a downstream change you have in your product
12:14:06 sean-k-mooney songwenping_: so the test pass correctly with tox using stestr
12:14:31 sean-k-mooney nosetest was never supported in the rocky release so this might be just down to using the incorrect test runner
12:14:59 sean-k-mooney so this sound like its either a downstream bug or a bug in how you are runnign the tests
12:21:55 sean-k-mooney sahid: comments left on https://review.opendev.org/c/openstack/nova-specs/+/857838
12:23:24 songwenping_ sean-k-mooney: i'm finding the lastest changid for our code.
12:32:39 darkhorse Hi team Can I get someone's attention on https://bugs.launchpad.net/nova/+bug/1993736?
12:39:10 sean-k-mooney darkhorse: ah you got the test passign
12:39:19 darkhorse yes
12:39:49 darkhorse sean-k-mooney: yes
12:41:15 sean-k-mooney so just lookign at it quickly
12:41:21 sean-k-mooney it woudl be nice to add a functional test

Earlier   Later