| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-10-27 | |||
| 12:14:06 | sean-k-mooney | songwenping_: so the test pass correctly with tox using stestr | |
| 12:14:31 | sean-k-mooney | nosetest was never supported in the rocky release so this might be just down to using the incorrect test runner | |
| 12:14:59 | sean-k-mooney | so this sound like its either a downstream bug or a bug in how you are runnign the tests | |
| 12:21:55 | sean-k-mooney | sahid: comments left on https://review.opendev.org/c/openstack/nova-specs/+/857838 | |
| 12:23:24 | songwenping_ | sean-k-mooney: i'm finding the lastest changid for our code. | |
| 12:32:39 | darkhorse | Hi team Can I get someone's attention on https://bugs.launchpad.net/nova/+bug/1993736? | |
| 12:39:10 | sean-k-mooney | darkhorse: ah you got the test passign | |
| 12:39:19 | darkhorse | yes | |
| 12:39:49 | darkhorse | sean-k-mooney: yes | |
| 12:41:15 | sean-k-mooney | so just lookign at it quickly | |
| 12:41:21 | sean-k-mooney | it woudl be nice to add a functional test | |
| 12:41:32 | sean-k-mooney | and assert teh instance action log now has the deelted action | |
| 12:41:46 | sean-k-mooney | you just fixed the existing test but did not add any to test the change you made | |
| 12:42:15 | sean-k-mooney | as in there is no test to actully ensure the instnace action log now has the deleted actions | |
| 12:47:03 | darkhorse | sean-k-mooney: will you give me some more details/examples? i think there are already functional tests for deleting shelve offloaded instances. | |
| 12:48:09 | darkhorse | excuse me this is my first time committing to upstream | |
| 13:06:43 | sean-k-mooney | darkhorse: yes there shoudl be an existing one that you can just add a rest call to get the list of instance action events and check that the deleted on is in the list | |
| 13:06:50 | sean-k-mooney | ill see if i can fidn one quickly | |
| 13:07:40 | darkhorse | sean-k-mooney: thank you! | |
| 13:08:26 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/tests/functional/test_servers.py#L2578-L2598 | |
| 13:08:40 | sean-k-mooney | thats a simple shelve unshleve test with delete at teh end | |
| 13:09:15 | sean-k-mooney | so you can copy that skip the unshelve step and then add a call to the event list api | |
| 13:09:21 | sean-k-mooney | and assert delete is there | |
| 13:09:57 | sean-k-mooney | let me see if there is an existing server event list test you could copy form | |
| 13:12:12 | sean-k-mooney | darkhorse: yes ok so there are example here https://github.com/openstack/nova/blob/master/nova/tests/functional/test_instance_actions.py | |
| 13:13:05 | sean-k-mooney | so you coudl add a new test case by modifying https://github.com/openstack/nova/blob/master/nova/tests/functional/test_instance_actions.py#L96 | |
| 13:14:20 | darkhorse | sean-k-mooney: thank you! I will take a look and add functional test for shelved instance deletion. | |
| 13:14:22 | sean-k-mooney | so you really just need this https://github.com/openstack/nova/blob/master/nova/tests/functional/test_instance_actions.py#L229-L234 | |
| 13:14:50 | sahid | sean-k-mooney: ack thank you | |
| 13:15:27 | sean-k-mooney | darkhorse: i would put this test in the other file test_servers | |
| 13:15:48 | sean-k-mooney | and just copy the shelve_unshelve test as i said and add in this check | |
| 13:15:53 | sean-k-mooney | then it would be good | |
| 13:16:46 | darkhorse | sean-k-mooney: ok thank you | |
| 13:21:32 | opendevreview | Elod Illes proposed openstack/nova stable/wallaby: Retry image download if it's corrupted https://review.opendev.org/c/openstack/nova/+/819180 | |
| 13:23:12 | opendevreview | Elod Illes proposed openstack/nova stable/victoria: Retry image download if it's corrupted https://review.opendev.org/c/openstack/nova/+/819181 | |
| 15:59:12 | melwitt | sean-k-mooney[m]: this is what I came up with for that unit test loading guestfs issue, also put some repro steps in the referenced lp bug if you want to see https://review.opendev.org/c/openstack/nova/+/862769 | |
| 16:00:31 | sean-k-mooney[m] | cool ill take a look in a while | |
| 16:03:45 | sean-k-mooney[m] | ok ya that looks interesting | |
| 16:04:16 | sean-k-mooney[m] | i set rp+1 on it so ill come back to it in a bit. deliveray arriving shortly | |
| 16:04:34 | sean-k-mooney[m] | so need to step away for a few minutes | |
| 16:06:52 | melwitt | k. no rush of course, just wanted to show you it | |
| 16:07:43 | sean-k-mooney[m] | so its a slightly difffernt approch then our other poison fixtures but its also a slight different usecase | |
| 16:08:13 | melwitt | if you have suggestions lmk. that's just the best I could think of at the time :P | |
| 16:09:50 | sean-k-mooney[m] | the only thing i was thinking about really is this only works if we use the oslo import utils funciton | |
| 16:09:56 | sean-k-mooney[m] | and not a import statement | |
| 16:10:20 | melwitt | yes. I tried to make __import__ work but failed. if you know how, lmk | |
| 16:11:28 | melwitt | I didn't find a way to monkey patch it. I also haven't really monkey patched built ins before that I can remember | |
| 16:11:49 | sean-k-mooney[m] | i feel like i have look it up before but i dont rememebr how to do it currelty | |
| 16:12:44 | sean-k-mooney[m] | we can always make it more robost later so we can likely start with this | |
| 16:14:18 | sean-k-mooney[m] | https://stackoverflow.com/a/63320902 | |
| 16:16:16 | sean-k-mooney[m] | we could try doing that ^ | |
| 16:16:38 | melwitt | thanks! that looks promising | |
| 16:16:44 | sean-k-mooney[m] | not sure if that will have the opisite probalem and only work for import but i think it should work for both | |
| 16:16:49 | melwitt | I'll try it | |
| 16:25:54 | gibi | we could poison VFSGuestFS.__init__ | |
| 16:26:28 | gibi | but that is more specific to the current code than the import poison | |
| 16:26:32 | gibi | so I'm fine with both | |
| 18:01:04 | opendevreview | Amit Uniyal proposed openstack/nova master: DOC update remote console access https://review.opendev.org/c/openstack/nova/+/860687 | |
| 18:07:33 | opendevreview | John Garbutt proposed openstack/nova-specs master: WIP: Ironic shards to replace peer_list https://review.opendev.org/c/openstack/nova-specs/+/862833 | |
| 18:08:39 | opendevreview | John Garbutt proposed openstack/nova-specs master: WIP: Ironic shards to replace peer_list https://review.opendev.org/c/openstack/nova-specs/+/862833 | |
| 18:10:51 | opendevreview | John Garbutt proposed openstack/nova-specs master: WIP: Ironic shards to replace peer_list https://review.opendev.org/c/openstack/nova-specs/+/862833 | |
| 19:00:05 | opendevreview | melanie witt proposed openstack/nova master: Add mock to avoid loading guestfs in unit test https://review.opendev.org/c/openstack/nova/+/862769 | |
| #openstack-nova - 2022-10-28 | |||
| 08:10:30 | opendevreview | Pavlo Shchelokovskyy proposed openstack/nova master: Do not store InstanceInvalidState as instance_fault https://review.opendev.org/c/openstack/nova/+/860702 | |
| 09:51:24 | gibi | stephenfin: do you have a hint why nova gets | |
| 09:51:24 | gibi | /home/fedora/rtox/nova/functional-py310/.tox/functional-py310/lib/python3.10/site-packages/oslo_db/sqlalchemy/enginefacade.py:537: DeprecationWarning: Using the 'mysql_enable_ndb' argument is deprecated in version '12.1.0': Support for the MySQL NDB Cluster storage engine has been deprecated and will be removed in a future release. | |
| 09:51:36 | gibi | I see the deprecation decorator in oslo_db | |
| 09:51:49 | gibi | but I grepped for that param in nova and I don't see any usage of it | |
| 09:52:42 | opendevreview | Balazs Gibizer proposed openstack/nova master: FUP for the scheduler part of PCI in placement https://review.opendev.org/c/openstack/nova/+/862876 | |
| 10:02:48 | gibi | sean-k-mooney[m]: thanks for the reviews on the PCI series I opened a FUP ^^ to collect the minor things | |
| 10:05:53 | sean-k-mooney[m] | ill make my way true the rest on tuesday | |
| 10:06:16 | gibi | OK, thanks | |
| 10:06:43 | gibi | I've fixed the test instability in the last patch too | |
| 10:07:47 | opendevreview | Balazs Gibizer proposed openstack/nova master: Strictly follow placement allocation during PCI claim https://review.opendev.org/c/openstack/nova/+/855650 | |
| 10:07:48 | opendevreview | Balazs Gibizer proposed openstack/nova master: FUP for the scheduler part of PCI in placement https://review.opendev.org/c/openstack/nova/+/862876 | |
| 10:12:19 | gibi | bauzas: if you are around today, this is a simple spec repropose for A https://review.opendev.org/c/openstack/nova-specs/+/855661 | |
| 10:19:24 | bauzas | gibi: was on meeting but will look | |
| 10:20:20 | gibi | thanks | |
| 10:20:47 | bauzas | gibi: sent to the gate, bravo for the first approved spec afaik | |
| 10:21:41 | gibi | thanks. I was well prepared since Zed FF to land the re-propose early along with the code | |
| 10:32:52 | opendevreview | Merged openstack/nova-specs master: Re-propose PCI Device Tracking In Placement for A https://review.opendev.org/c/openstack/nova-specs/+/855661 | |
| 16:06:34 | darkhorse | hi team - how can i run functional test only for one function that i have added? tox command runs too many tests and takes too long. | |
| 16:08:54 | clarkb | darkhorse: generally projects respect some form of `tox -epy310 -- test_name_here` to filter tests by that name | |
| 16:09:07 | clarkb | you can look at the tox.ini to see how posargs are handled to confirm this | |
| 16:10:50 | darkhorse | clarkb: thank you for answering my question quickly. can you give me an example of running functional tests only (skipping all other tests like pep8)? | |
| 16:13:28 | gibi | darkhorse: this will run all functional tests with python 3.10: tox -e functional-py310 | |
| 16:13:41 | clarkb | darkhorse: if you look in the tox.ini file it lists the various targets. You specify a target using `tox -e` so in this case `tox -e functional-py310` Then if you want to filter for lists you'll see the functional targets pass in posargs to the stestr command which allows you to do something like `tox -e functional-py310 -- your_test_name_here` | |
| 16:13:56 | gibi | darkhorse: this will only run test from the SimpleRCAndTraitBasedPCIAliasTests class: tox -e functional-py310 SimpleRCAndTraitBasedPCIAliasTests | |
| 16:13:58 | clarkb | *filter for specific tests | |
| 16:15:08 | darkhorse | that makes sense. thank you all! | |
| 17:17:40 | opendevreview | Alex Chan proposed openstack/nova master: record action log when deleting shelved instance https://review.opendev.org/c/openstack/nova/+/862404 | |
| 18:09:29 | eandersson | What is the solution for race conditions in the scheduler with high density VCPU servers with core pinning enabled? cstone mentioned that setting max_concurrent_builds to 1 fixes it | |
| 18:14:12 | eandersson | > Failed to build and run instance: nova.exception.CPUPinningInvalid: CPU set to pin [81, 17] must be a subset of free CPU set [4, ....., 127] | |
| 18:22:56 | opendevreview | melanie witt proposed openstack/nova master: Add mock to avoid loading guestfs in unit test https://review.opendev.org/c/openstack/nova/+/862769 | |
| 21:55:43 | opendevreview | Patrick Hampson proposed openstack/nova master: Doc: Fix list servers detailed response param https://review.opendev.org/c/openstack/nova/+/862963 | |
| 22:10:27 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Save cell socket correctly when updating host NUMA topology https://review.opendev.org/c/openstack/nova/+/862964 | |
| 22:11:58 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Save cell socket correctly when updating host NUMA topology https://review.opendev.org/c/openstack/nova/+/862964 | |
| #openstack-nova - 2022-10-29 | |||
| 00:06:37 | opendevreview | Artom Lifshitz proposed openstack/nova master: Save cell socket correctly when updating host NUMA topology https://review.opendev.org/c/openstack/nova/+/862964 | |
| 00:06:37 | opendevreview | Artom Lifshitz proposed openstack/nova master: Reproduce bug 1995153 https://review.opendev.org/c/openstack/nova/+/862967 | |
| 02:01:03 | opendevreview | Artom Lifshitz proposed openstack/nova master: Reproduce bug 1995153 https://review.opendev.org/c/openstack/nova/+/862967 | |
| 02:01:04 | opendevreview | Artom Lifshitz proposed openstack/nova master: Save cell socket correctly when updating host NUMA topology https://review.opendev.org/c/openstack/nova/+/862964 | |