| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-10-26 | |||
| 14:30:18 | bauzas | well, actually, you're right, and this would confuse people | |
| 14:30:25 | bauzas | we agreed at the PTG to have this libvirt-specifc | |
| 14:30:29 | bauzas | then, nevermind | |
| 14:30:38 | bauzas | I'll just create a package under libvirt | |
| 14:30:41 | bauzas | libvirt.cpu | |
| 14:30:51 | sean-k-mooney | ack | |
| 14:31:00 | sean-k-mooney | that or put the function into host.py | |
| 14:31:08 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/host.py | |
| 14:31:15 | sean-k-mooney | but its own thing proably is simpler | |
| 14:31:20 | sean-k-mooney | well cleaner | |
| 14:31:34 | bauzas | well, the host module is mostly for talking to the host libvirt API right? | |
| 14:31:43 | sean-k-mooney | mostly but not entirly | |
| 14:31:46 | bauzas | true | |
| 14:32:00 | bauzas | I just want to have some interface | |
| 14:32:11 | sean-k-mooney | we lookup the firmware files for uefi there and i think some vtpm stuff | |
| 14:32:13 | bauzas | but I need to think it more | |
| 14:32:26 | sean-k-mooney | honestly poc it however you feel is best | |
| 14:32:45 | sean-k-mooney | we can debttate it later but i think under the libvirt driver somewhere is the right approch | |
| 14:32:52 | bauzas | tru | |
| 14:32:54 | bauzas | true* | |
| 14:33:03 | sean-k-mooney | beyond that as long as you dont just put it in driver.py im more or less ok with it | |
| 14:33:09 | sean-k-mooney | driver.py is already too big | |
| 14:33:25 | bauzas | :) | |
| 14:34:04 | sean-k-mooney | i know we will never get around to doing this but some day i would like to split up driver.py | |
| 14:34:28 | sean-k-mooney | 10k loc is excessive | |
| 14:37:09 | bauzas | don't (git) blame me :) | |
| 14:54:12 | Uggla | agree driver.py is a bit long. ;) | |
| #openstack-nova - 2022-10-27 | |||
| 02:26:00 | opendevreview | melanie witt proposed openstack/nova master: Add mock to avoid loading guestfs in unit test https://review.opendev.org/c/openstack/nova/+/862769 | |
| 08:12:49 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: compute: enhance compute evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858383 | |
| 08:12:49 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: api: extend evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858384 | |
| 08:19:40 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova-specs master: spec: allowing target state for evacuate https://review.opendev.org/c/openstack/nova-specs/+/857838 | |
| 08:56:51 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reproduce PCI pool filtering bug https://review.opendev.org/c/openstack/nova/+/855649 | |
| 08:56:52 | opendevreview | Balazs Gibizer proposed openstack/nova master: Strictly follow placement allocation during PCI claim https://review.opendev.org/c/openstack/nova/+/855650 | |
| 08:56:52 | opendevreview | Balazs Gibizer proposed openstack/nova master: Show candidate combinatorial explosion by dev number https://review.opendev.org/c/openstack/nova/+/855885 | |
| 09:01:52 | gibi | bauzas: a procedural question. We have the RFE bug filed for the port route metric support https://bugs.launchpad.net/nova/+bug/1994137 it is a whislist so that part is OK. Should I simply set it to Triaged or we want to discuss it in the next meeting before I set Triaged? | |
| 09:02:18 | bauzas | gibi: no, we agreed on it so Triage it directly ;) | |
| 09:02:25 | gibi | OK. | |
| 09:04:58 | auniyal_ | Hi bauzas, gibi, sean-k-mooney | |
| 09:05:23 | auniyal_ | can you please review theses - these are backports | |
| 09:05:24 | auniyal_ | https://review.opendev.org/c/openstack/nova/+/861856 | |
| 09:05:24 | auniyal_ | https://review.opendev.org/c/openstack/nova/+/861857 | |
| 09:05:24 | auniyal_ | ||
| 09:05:24 | auniyal_ | https://review.opendev.org/c/openstack/nova/+/861871 | |
| 09:05:26 | auniyal_ | https://review.opendev.org/c/openstack/nova/+/861872 | |
| 09:05:28 | auniyal_ | ||
| 09:05:30 | auniyal_ | https://review.opendev.org/c/openstack/nova/+/862604 | |
| 09:05:32 | auniyal_ | https://review.opendev.org/c/openstack/nova/+/862603 | |
| 09:05:34 | auniyal_ | ||
| 09:05:36 | auniyal_ | mostly clean cherry-pick | |
| 09:35:45 | amorin | hello nova team, when using ovs backend, nova plugs interface in ovs using vif_plug_ovs python module | |
| 09:36:02 | amorin | I was expecting to find the vif_plug_ovs option available in the config reference: | |
| 09:36:04 | amorin | https://docs.openstack.org/nova/latest/configuration/config.html | |
| 09:36:08 | amorin | but it's not | |
| 09:36:57 | amorin | https://github.com/openstack/os-vif/blob/master/vif_plug_ovs/ovs.py#L54 | |
| 09:37:57 | amorin | is that normal? | |
| 09:45:09 | sean-k-mooney | its a know issue | |
| 09:45:19 | sean-k-mooney | so technically os-vif is not part of nova | |
| 09:45:26 | sean-k-mooney | to have it incldued in novas docs | |
| 09:45:27 | bauzas | I was about to say it :) | |
| 09:45:35 | sean-k-mooney | we need to list it in the generation command | |
| 09:45:43 | bauzas | this is not a middleware we import | |
| 09:45:44 | sean-k-mooney | someone was goign to fix it a while ago | |
| 09:45:49 | sean-k-mooney | feel free to if you want | |
| 09:45:59 | sean-k-mooney | bauzas: actully it is | |
| 09:46:06 | sean-k-mooney | but not in the docs | |
| 09:46:14 | bauzas | sean-k-mooney: this is a lazy import ? | |
| 09:46:31 | sean-k-mooney | vif_plug_ovs is import when we init os-vif | |
| 09:46:40 | bauzas | correct, so a lazy import | |
| 09:46:43 | sean-k-mooney | its the in tree ovs plugin | |
| 09:47:01 | bauzas | hence me wondering how we could generate the config without importing it directly | |
| 09:47:02 | sean-k-mooney | ya but when we generate the config refence we need to list the namespaces to generate | |
| 09:47:05 | sean-k-mooney | and we dont | |
| 09:47:06 | bauzas | without not* | |
| 09:48:27 | gibi | auniyal_: left +2s on the first and left some feedback in https://review.opendev.org/c/openstack/nova/+/862603 | |
| 09:49:34 | sean-k-mooney | amorin: anyway back to yoru question its just a case of we never got aroudn to it | |
| 09:50:04 | sean-k-mooney | so patches are welcome i was just loking for where to chagne it but i dont rememebr off the top of my head | |
| 09:50:28 | sean-k-mooney | i think you need to add it here https://github.com/openstack/nova/blob/master/etc/nova/nova-config-generator.conf#L18 | |
| 09:50:30 | bauzas | https://github.com/openstack/nova/blob/master/etc/nova/nova-config-generator.conf | |
| 09:50:36 | sean-k-mooney | ya | |
| 09:50:37 | amorin | ack, perfect | |
| 09:50:37 | bauzas | damn, again, beated | |
| 09:50:47 | amorin | I will try to propose a change then | |
| 09:51:01 | bauzas | amorin: test it locally | |
| 09:51:11 | bauzas | amorin: you have a tox target | |
| 09:51:13 | sean-k-mooney | can you add all the in tree plugsin so also linux bridge | |
| 09:51:17 | bauzas | tox -egenconfig | |
| 09:51:33 | amorin | ok | |
| 09:51:45 | sean-k-mooney | the noop pluging does not have config so you can ignore it | |
| 09:53:06 | amorin | so it's os-vif + linux-bridge | |
| 09:53:18 | amorin | is the list somewhere? | |
| 09:53:53 | sean-k-mooney | https://github.com/openstack/os-vif | |
| 09:54:04 | sean-k-mooney | there are 3 plugins the vif_plug diretories | |
| 09:54:14 | sean-k-mooney | and the ovs and linux bridge ones have config options | |
| 09:55:51 | sean-k-mooney | amorin: this is how the cofnig is regestered https://github.com/openstack/os-vif/blob/master/os_vif/plugin.py#L71-L89 | |
| 09:57:28 | sean-k-mooney | the linux bridge name is https://github.com/openstack/os-vif/blob/b0298b5350f21f858f2bf72c5d18e3019a696514/vif_plug_linux_bridge/constants.py#L13 | |
| 09:57:46 | sean-k-mooney | os os_vif_linux_bridge | |
| 09:58:24 | sean-k-mooney | that i think will be the namespace you need to list but i have not tried that to see if that is correct or if the namespace shoudl just be os_vif or something like that | |
| 10:09:27 | darkhorse | sean-k-mooney: thank you for responding to the issue that I have reported to launchpad. https://bugs.launchpad.net/nova/+bug/1993736 | |
| 10:10:27 | darkhorse | I think I did not make clear description there. I have updated the description and put a link to a patchset that I have published. | |
| 10:11:03 | darkhorse | Will you take a look at it when you find a moment? | |