| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-10-05 | |||
| 15:34:01 | stephenfin | Yeah, I think I +2d it | |
| 15:34:10 | Uggla | \o/ | |
| 15:40:44 | opendevreview | Stephen Finucane proposed openstack/nova master: objects: Add NovaSoftDeleteObject mixin https://review.opendev.org/c/openstack/nova/+/854355 | |
| 15:40:50 | stephenfin | Uggla: lmk what you think ^ | |
| 15:46:14 | Uggla | stephenfin, i'll have a look after our meeting. | |
| 15:47:23 | opendevreview | Stephen Finucane proposed openstack/nova master: rpc: Mark attributes as private https://review.opendev.org/c/openstack/nova/+/792803 | |
| 15:55:59 | melwitt | kashyap: the "abort live migration if monitoring fails" patch was to fail in a proper way when the error is encountered, there is another patch that needs review that will do the actual ignoring of the particular error https://review.opendev.org/c/openstack/nova/+/852002 | |
| 15:59:50 | melwitt | kashyap: there was an issue with the patch I had proposed to workaround it, so I abandoned it. ^ is the new one from another contributor | |
| 16:02:04 | Uggla | stephenfin, what you did in https://review.opendev.org/c/openstack/nova/+/854355/4..5, sounds good to me. Thank you. Now let's check if gibi, dansmith, bauzas agree. | |
| 16:03:11 | bauzas | I thought we said we haven't wanted to have API tables to be soft-deletable | |
| 16:03:36 | bauzas | but, we haven't said "yeah, we should deprecate the other tables" | |
| 16:05:16 | dansmith | yeah | |
| 16:05:28 | dansmith | I don't agree with the use of "deprecated" here | |
| 16:05:42 | dansmith | "not recommended for everything by default" makes sense | |
| 16:07:01 | bauzas | at least I'm afraid of saying "we deprecate instance record soft-deletion" | |
| 16:07:17 | dansmith | was there some decision to deprecate and actually remove this stuff? because I think I disagree with that | |
| 16:07:23 | dansmith | and if not, we should change the wording in the patch I think | |
| 16:11:34 | bauzas | Uggla: I looked at your patch | |
| 16:11:51 | kashyap | melwitt: Thanks for jogging my memory! I now recall | |
| 16:12:01 | bauzas | sounds quite good to me if you say 'we need to formally name which tables do softdelete" | |
| 16:12:16 | bauzas | which is what you code | |
| 16:12:19 | kashyap | melwitt: I thought this one from Brett has already merged...but apparently not yet. Is it waiting on something still? | |
| 16:12:43 | melwitt | kashyap: just needs a second reviewer | |
| 16:13:00 | kashyap | Ah, nod. I thought something else besides it. | |
| 16:13:02 | melwitt | I already +2ed it | |
| 16:13:09 | melwitt | nah | |
| 16:14:01 | kashyap | gibi: or any other core who's not Mel, can you please put this through? - https://review.opendev.org/c/openstack/nova/+/852002 | |
| 16:14:48 | kashyap | melwitt: Also thank you for - https://review.opendev.org/c/openstack/nova/+/859358/1 | |
| 16:15:44 | melwitt | :) | |
| 16:15:52 | kashyap | Often these unit tests take a ton of time (at least for me), and I keep duking around them | |
| 16:15:57 | gibi | kashyap: I added to my queue but no promises when I get to it | |
| 16:16:59 | kashyap | gibi: What? I thought you'd attach a promiese-to-be-executed-on-this-date to all your reviews! | |
| 16:17:20 | melwitt | kashyap: they take a ton of time for me, pretty much never goes smoothly 😆 | |
| 16:18:06 | kashyap | melwitt: Good to know; I feel particularly low when a unit test that I'm struggling with takes so long that a hen will develop teeth, but the test won't come out right. | |
| 16:19:59 | melwitt | kashyap: "hen develop teeth" haha I've never heard that before | |
| 16:21:00 | kashyap | I recently learnt the expression, "as rare as hen's teeth" -- https://en.wiktionary.org/wiki/rare_as_hen%27s_teeth :P | |
| 16:22:54 | melwitt | it's funny :) | |
| 16:24:25 | kashyap | On that note, /me goes to make "non-hen" dinner | |
| 16:25:01 | melwitt | o/ | |
| 16:33:46 | gibi | kashyap: :) | |
| 16:36:49 | opendevreview | Stephen Finucane proposed openstack/nova master: objects: Remove unnecessary type aliases, exceptions https://review.opendev.org/c/openstack/nova/+/738240 | |
| 16:36:49 | opendevreview | Stephen Finucane proposed openstack/nova master: objects: Use imports instead of type aliases https://review.opendev.org/c/openstack/nova/+/738018 | |
| 16:36:50 | opendevreview | Stephen Finucane proposed openstack/nova master: objects: Remove wrappers around ovo mixins https://review.opendev.org/c/openstack/nova/+/738019 | |
| 16:36:50 | opendevreview | Stephen Finucane proposed openstack/nova master: objects: Remove 'NovaObjectDictCompat' from 'Service' https://review.opendev.org/c/openstack/nova/+/835595 | |
| 16:36:51 | opendevreview | Stephen Finucane proposed openstack/nova master: WIP: add ovo-mypy-plugin to type hinting o.vos https://review.opendev.org/c/openstack/nova/+/758851 | |
| 17:29:41 | opendevreview | Stephen Finucane proposed openstack/nova master: objects: Add NovaSoftDeleteObject mixin https://review.opendev.org/c/openstack/nova/+/854355 | |
| 17:30:54 | sean-k-mooney | stephenfin: to be clear the goal of ^ shoudl be the minimal possible change to allow Uggla to create teh manilla share object models without delete/deleted at in the db or ovo | |
| 17:33:42 | stephenfin | Yup, I think that's doing that? I suspect dansmith and bauzas had missed part of the commit message that explained that | |
| 17:34:06 | stephenfin | "Currently, the NovaPersistentObject mixin includes fields required by the soft delete feature - deleted and deleted_at - even if the backing SQLAlchemy model isn't using soft delete." | |
| 17:34:20 | stephenfin | 👆 that bit | |
| 17:35:03 | sean-k-mooney | right but other way to do that is for the manilla object to inherit form the timestamed one | |
| 17:35:08 | sean-k-mooney | and make no change to anything else | |
| 17:36:05 | sean-k-mooney | so instead of inheriting form NovaPersistentObject the manila share ones could inherit form ovoo_base.TimestampedObject which is also called NovaTimestampObject | |
| 17:36:23 | sean-k-mooney | we dont need to add the mixin for the orgianl usecse | |
| 17:36:49 | stephenfin | Same thing, different approach. If I was Uggla, I'd probably do that to avoid this blocking things | |
| 17:36:58 | sean-k-mooney | gibi: Uggla did i miss why we are not just doing that | |
| 17:37:35 | sean-k-mooney | stephenfin: thats basically what i suggested a month ago https://review.opendev.org/c/openstack/nova/+/854355/5#message-839b7637eabf1d6dcf4e95050e9244c954dc1056 | |
| 17:37:55 | sean-k-mooney | at that time i did not see that we had NovaTimestampObject | |
| 17:38:03 | sean-k-mooney | and did not need ot intoduce a new class at all | |
| 17:38:43 | stephenfin | That change does still make sense though. As unlikely as it is that anyone will bump those major versions, it is confusing and the TODOs are helpful to highlight that | |
| 17:39:15 | sean-k-mooney | i dont dissagree that we might also want to do this | |
| 17:39:24 | sean-k-mooney | but i dont think we want to do this in the manilla share seriese | |
| 17:39:30 | stephenfin | agreed | |
| 17:39:39 | sean-k-mooney | which si why i ask Uggla to not do this when i first reviewed | |
| 17:40:34 | gibi | I cannot recall the reason we went that way | |
| 17:40:47 | gibi | probably to fix the other ovos where we can fix | |
| 17:41:01 | sean-k-mooney | gibi: Uggla orgingial patch alredy had updated all the other objects | |
| 17:41:02 | Uggla | sean-k-mooney, stephenfin I tried to make objects without soft delete the default behavior to avoid future misused. I also started with a less intrusive patch, but gibi wanted to extend it. | |
| 17:41:39 | sean-k-mooney | Uggla: ya but if we did that it shoudl be a sperate blueprint/spec not mixed into your share work | |
| 17:43:37 | sean-k-mooney | bauzas: melwitt when i mentioned stpehens change in the bug call by the way i ment https://review.opendev.org/c/openstack/nova/+/860401 | |
| 17:43:52 | sean-k-mooney | not https://review.opendev.org/c/openstack/nova/+/854355 | |
| 17:44:07 | sean-k-mooney | i just saw that stephen updated that also | |
| 17:44:45 | melwitt | sean-k-mooney: thanks | |
| 17:51:10 | Uggla | sean-k-mooney, ok if it is needed. | |
| 22:17:19 | atmark | I messed up nova cells and now computes states are down. I corrected the cells but they still show as down. How can I reregister the computes? | |
| 22:17:46 | atmark | This is a new deployment | |
| 22:18:44 | atmark | `openstack compute service delete id` won't let me delete | |
| #openstack-nova - 2022-10-06 | |||
| 05:41:25 | opendevreview | Amit Uniyal proposed openstack/nova master: Adds a repoducer for post live migration fail https://review.opendev.org/c/openstack/nova/+/854499 | |
| 05:41:25 | opendevreview | Amit Uniyal proposed openstack/nova master: [compute] always set instance.host in post_livemigration https://review.opendev.org/c/openstack/nova/+/791135 | |
| 07:09:38 | gokhanisi | Hello folks, after deleting vm glance image, we can not reboot vm, because it can't find _base image and after that nova destroyed my vm automatically. this the expected state or is there any mechanism to prevent automatic deletion? | |
| 09:46:56 | sean-k-mooney[m] | gokhanisi: there is no code in nova to do that automatic deletion | |
| 09:47:17 | sean-k-mooney[m] | gokhanisi: so it sounds like you have somethign else in your cloud that is doing that | |
| 09:47:51 | sean-k-mooney[m] | deleting the glance image will have no effect on running vms | |
| 09:49:00 | sean-k-mooney[m] | evacuate may fail if the image is deleted and the vm is not on shared sotrage as it wont be able to download the image but reboots and normal move operations like cold/live migrate will work | |
| 10:56:55 | auniyal_ | Hello #openstack-nova | |
| 10:57:00 | auniyal_ | please review these: | |
| 10:57:02 | auniyal_ | https://review.opendev.org/c/openstack/nova/+/854979 | |
| 10:57:07 | auniyal_ | https://review.opendev.org/c/openstack/nova/+/854980 | |
| 10:57:34 | auniyal_ | https://review.opendev.org/c/openstack/nova/+/858673 | |
| 11:43:26 | sean-k-mooney | bauzas: care to be the second reviewer on https://review.opendev.org/c/openstack/nova/+/827467 | |
| 11:51:06 | opendevreview | sean mooney proposed openstack/nova master: update default overcommit https://review.opendev.org/c/openstack/nova/+/830829 | |
| 11:52:20 | sean-k-mooney | gibi: stephenfin johnthetubaguy ^ care to take a look at that. im hoping we can merge that sooner rather then later | |
| 11:55:11 | opendevreview | Kirill proposed openstack/nova stable/wallaby: GCLOUD2-6989:vnc workable varsion https://review.opendev.org/c/openstack/nova/+/860555 | |
| 11:55:53 | opendevreview | Stephen Finucane proposed openstack/nova master: objects: Add NovaSoftDeleteObject mixin https://review.opendev.org/c/openstack/nova/+/854355 | |
| 11:55:53 | opendevreview | Stephen Finucane proposed openstack/nova master: objects: Validate object-DB model field parity https://review.opendev.org/c/openstack/nova/+/860556 | |
| 12:00:17 | opendevreview | Kirill proposed openstack/nova stable/wallaby: add support of vnc console for ironic https://review.opendev.org/c/openstack/nova/+/860557 | |
| 12:09:53 | opendevreview | Merged openstack/nova master: Fix typos in nova docs https://review.opendev.org/c/openstack/nova/+/858673 | |
| 12:14:37 | gibi | sean-k-mooney: I'm +2 | |
| 12:19:56 | stephenfin | Me too. Low risk since as you note, these are the _initial_ ratios and therefore only affect new resources | |
| 12:21:39 | bauzas | sean-k-mooney: I can look at https://review.opendev.org/c/openstack/nova/+/827467 | |