| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-09-02 | |||
| 12:05:02 | sean-k-mooney | ah | |
| 12:05:10 | sean-k-mooney | master is clampped already to 3.3.3 | |
| 12:05:18 | sean-k-mooney | 3.3.0 | |
| 12:05:24 | sean-k-mooney | https://github.com/openstack/requirements/blob/master/upper-constraints.txt#L141 | |
| 12:06:35 | sean-k-mooney | frickler: we are not clamping it on master today https://github.com/openstack/requirements/blob/5b346cf74df6bbfc67f794c053d3c4210da4bacb/global-requirements.txt#L197 | |
| 12:06:48 | sean-k-mooney | we just have not merged the update to move it forward form 3.3.0 | |
| 12:06:54 | sean-k-mooney | but we have done that on yoga | |
| 12:07:07 | sean-k-mooney | presumable this can break all branches | |
| 12:07:31 | sean-k-mooney | so we shoudl definlaly also clamp it on master to prevent breaking the gat during FF | |
| 12:08:24 | sean-k-mooney | elodilles: gibi ^ | |
| 12:09:10 | gibi | sean-k-mooney: it is known and intentionally not updated on master by https://review.opendev.org/c/openstack/requirements/+/854862/2..3/upper-constraints.txt | |
| 12:09:33 | gibi | sean-k-mooney: we are pinned to 3.3.0 on master at the moment | |
| 12:09:46 | sean-k-mooney | where | |
| 12:10:09 | sean-k-mooney | that goign to get overrided when the bot runs | |
| 12:10:15 | gibi | https://github.com/openstack/requirements/blob/master/upper-constraints.txt#L141 | |
| 12:11:02 | gibi | sean-k-mooney: this all happend already. the bot ran and update the constraint, the nova job failed on the requirements patch, and then frickler removed the bump from the patch | |
| 12:11:28 | sean-k-mooney | hum ok | |
| 12:11:40 | gibi | frickler even pinged us during the weekend about it :) | |
| 12:11:44 | sean-k-mooney | so instead of pinning it in global-requireemnts where the both will not try to bump it | |
| 12:11:53 | sean-k-mooney | we are pinnign it in the generate file | |
| 12:11:58 | sean-k-mooney | and relaying on the failure | |
| 12:12:13 | gibi | I think it is OK while we wait for the devs to decide if this is a bug or not | |
| 12:12:20 | sean-k-mooney | ok | |
| 12:13:53 | sean-k-mooney | gibi: if they decied its not a bug and dont fix ti we will likely need to disable those tests | |
| 12:14:12 | sean-k-mooney | or rewirte them to not use pretty table | |
| 12:14:18 | sean-k-mooney | unless the assert fails | |
| 12:14:54 | gibi | sure we need to do something with it, but I haven't looked at the tests so I don't know which direction we should go | |
| 12:15:23 | sean-k-mooney | we cant just update the string to the new format as it would fail with older version of pretty table | |
| 12:15:34 | sean-k-mooney | and we cant raise the test requirement on stable | |
| 12:15:49 | sean-k-mooney | so it will need a differnt solution that works with both formats | |
| 12:15:49 | gibi | I do believe we will kep this pinned on stable | |
| 12:15:59 | gibi | keep | |
| 12:16:17 | sean-k-mooney | we could unpin in master and use the new format | |
| 12:16:32 | sean-k-mooney | that would mean that would effectivly be our min version for zed | |
| 12:16:36 | sean-k-mooney | for testing at least | |
| 12:16:48 | sean-k-mooney | i think this is not a runtime requirement | |
| 12:16:49 | gibi | I would not change this for Zed either so close to RC1 | |
| 12:17:05 | gibi | as we dont need anything from 3.4.0 | |
| 12:17:22 | sean-k-mooney | so pin for both | |
| 12:17:27 | sean-k-mooney | zed and yoga | |
| 12:17:37 | sean-k-mooney | i guess we could do that | |
| 12:17:38 | gibi | probably yes | |
| 12:17:52 | gibi | and understandt the test code then fix it on master | |
| 12:19:03 | sean-k-mooney | this is the current test https://github.com/openstack/nova/blob/master/nova/tests/unit/cmd/test_manage.py#L48-L67 | |
| 12:19:37 | sean-k-mooney | so the alieng ment i think changed form left aligned to centered | |
| 12:20:45 | sean-k-mooney | In 3.3.0, the data and header were left-aligned. | |
| 12:20:47 | sean-k-mooney | In 3.4.0, only the data was left-aligned, the header was centre-aligned. | |
| 12:21:29 | frickler | FYI all these blockers are tracked in https://etherpad.opendev.org/p/requirements-blockers (at least that's the idea). help to unblock things is always welcome | |
| 12:21:32 | sean-k-mooney | we set the alignment here https://github.com/openstack/nova/blob/90e2a5e50fbf08e62a1aedd5e176845ee22d96c9/nova/cmd/manage.py#L124 | |
| 12:21:59 | sean-k-mooney | so we might jsut be able to set pt.header_align='l' | |
| 12:23:00 | sean-k-mooney | ill try that quickly and see if it does anything | |
| 12:24:26 | gibi | ack | |
| 12:24:46 | opendevreview | Balazs Gibizer proposed openstack/nova master: Follow up for the PCI in placement series https://review.opendev.org/c/openstack/nova/+/855185 | |
| 12:24:46 | opendevreview | Balazs Gibizer proposed openstack/nova master: Doc follow up for PCI in placement https://review.opendev.org/c/openstack/nova/+/855186 | |
| 12:24:47 | opendevreview | Balazs Gibizer proposed openstack/nova master: Create RequestGroups from InstancePCIRequests https://review.opendev.org/c/openstack/nova/+/852771 | |
| 12:24:47 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support resource_class and traits in PCI alias https://review.opendev.org/c/openstack/nova/+/853316 | |
| 12:24:48 | opendevreview | Balazs Gibizer proposed openstack/nova master: Split PCI pools per PF https://review.opendev.org/c/openstack/nova/+/854440 | |
| 12:24:48 | opendevreview | Balazs Gibizer proposed openstack/nova master: Map PCI pools to RP UUIDs https://review.opendev.org/c/openstack/nova/+/854118 | |
| 12:24:49 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make allocation candidates available for scheduler filters https://review.opendev.org/c/openstack/nova/+/854119 | |
| 12:24:50 | opendevreview | Balazs Gibizer proposed openstack/nova master: Filter PCI pools based on Placement allocation https://review.opendev.org/c/openstack/nova/+/854120 | |
| 12:24:50 | opendevreview | Balazs Gibizer proposed openstack/nova master: Factor out base class for candidate aware filters https://review.opendev.org/c/openstack/nova/+/854929 | |
| 12:24:52 | opendevreview | Balazs Gibizer proposed openstack/nova master: Store allocated RP in InstancePCIRequest https://review.opendev.org/c/openstack/nova/+/854121 | |
| 12:24:52 | opendevreview | Balazs Gibizer proposed openstack/nova master: Func test for PCI in placement scheduling https://review.opendev.org/c/openstack/nova/+/854122 | |
| 12:24:54 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support cold migrate and resize with PCI tracking in placement https://review.opendev.org/c/openstack/nova/+/854247 | |
| 12:24:54 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support evacuate with PCI in placement https://review.opendev.org/c/openstack/nova/+/854615 | |
| 12:24:56 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support unshelve with PCI in placement https://review.opendev.org/c/openstack/nova/+/854616 | |
| 12:24:56 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support same host resize with PCI in placement https://review.opendev.org/c/openstack/nova/+/854441 | |
| 12:24:58 | opendevreview | Balazs Gibizer proposed openstack/nova master: Test reschedule with PCI in placement https://review.opendev.org/c/openstack/nova/+/854626 | |
| 12:24:58 | opendevreview | Balazs Gibizer proposed openstack/nova master: Test multi create with PCI in placement https://review.opendev.org/c/openstack/nova/+/854663 | |
| 12:25:00 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI scheduling in Placement https://review.opendev.org/c/openstack/nova/+/854924 | |
| 12:25:00 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename _to_device_spec_conf to _to_list_of_json_str https://review.opendev.org/c/openstack/nova/+/855648 | |
| 12:25:02 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reproduce PCI pool filtering bug https://review.opendev.org/c/openstack/nova/+/855649 | |
| 12:25:02 | opendevreview | Balazs Gibizer proposed openstack/nova master: Strictly follow placement allocation during PCI claim https://review.opendev.org/c/openstack/nova/+/855650 | |
| 12:25:04 | opendevreview | Balazs Gibizer proposed openstack/nova master: Follow up for the PCI in placement series https://review.opendev.org/c/openstack/nova/+/855654 | |
| 12:25:09 | bauzas | sorry folks, I was taxiing again kids and all the likes | |
| 12:25:23 | bauzas | sean-k-mooney: what was your question for me ? | |
| 12:25:51 | sean-k-mooney | its not imporant | |
| 12:26:06 | sean-k-mooney | we had a minor bugfix for palcment and wanted to know if i can merge it | |
| 12:26:16 | sean-k-mooney | after talkign to gibi i +w'd it | |
| 12:26:40 | gibi | stephenfin, sean-k-mooney: I have two FUPs for the merged part of the PCI series. One for the code https://review.opendev.org/c/openstack/nova/+/855185 and one for the doc https://review.opendev.org/c/openstack/nova/+/855186 | |
| 12:27:04 | sean-k-mooney | gibi: ack ill take a look | |
| 12:27:05 | gibi | now they are up to date and on the proper base | |
| 12:27:09 | gibi | sean-k-mooney: thanks | |
| 12:27:10 | sean-k-mooney | on master | |
| 12:27:26 | sean-k-mooney | or on the last patch that is pending in the gate | |
| 12:27:40 | gibi | on top of https://review.opendev.org/c/openstack/nova/+/853835 which is being merged | |
| 12:27:48 | sean-k-mooney | ack | |
| 12:40:59 | sean-k-mooney | gibi: frickler ok that works ill push a patch shortly | |
| 12:42:34 | frickler | sean-k-mooney: great, did you confirm with older prettytable, too? | |
| 12:42:44 | sean-k-mooney | yep | |
| 12:42:57 | sean-k-mooney | i have not run all tests to see if it fixes all of them yet | |
| 12:43:02 | sean-k-mooney | but that one test now passes | |
| 12:43:14 | sean-k-mooney | so just adding the header alignemnt seames to work | |
| 12:43:35 | frickler | o.k., nice | |
| 12:45:57 | gibi | sean-k-mooney: sounds good | |
| 12:46:07 | opendevreview | sean mooney proposed openstack/nova master: add header alingment for PrettyTable 3.4.0 https://review.opendev.org/c/openstack/nova/+/855658 | |
| 12:46:16 | sean-k-mooney | ill run the full test now locally | |
| 12:46:30 | opendevreview | Balazs Gibizer proposed openstack/nova-specs master: Update the PCI in placement spec https://review.opendev.org/c/openstack/nova-specs/+/855218 | |
| 12:47:01 | gibi | sean-k-mooney, stephenfin: ^^ and this is the update of the Zed spec that sync the spec with the implementation | |
| 12:53:50 | sean-k-mooney | ok that passed unit test localy so it should be good | |