| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-09-02 | |||
| 12:17:05 | gibi | as we dont need anything from 3.4.0 | |
| 12:17:22 | sean-k-mooney | so pin for both | |
| 12:17:27 | sean-k-mooney | zed and yoga | |
| 12:17:37 | sean-k-mooney | i guess we could do that | |
| 12:17:38 | gibi | probably yes | |
| 12:17:52 | gibi | and understandt the test code then fix it on master | |
| 12:19:03 | sean-k-mooney | this is the current test https://github.com/openstack/nova/blob/master/nova/tests/unit/cmd/test_manage.py#L48-L67 | |
| 12:19:37 | sean-k-mooney | so the alieng ment i think changed form left aligned to centered | |
| 12:20:45 | sean-k-mooney | In 3.3.0, the data and header were left-aligned. | |
| 12:20:47 | sean-k-mooney | In 3.4.0, only the data was left-aligned, the header was centre-aligned. | |
| 12:21:29 | frickler | FYI all these blockers are tracked in https://etherpad.opendev.org/p/requirements-blockers (at least that's the idea). help to unblock things is always welcome | |
| 12:21:32 | sean-k-mooney | we set the alignment here https://github.com/openstack/nova/blob/90e2a5e50fbf08e62a1aedd5e176845ee22d96c9/nova/cmd/manage.py#L124 | |
| 12:21:59 | sean-k-mooney | so we might jsut be able to set pt.header_align='l' | |
| 12:23:00 | sean-k-mooney | ill try that quickly and see if it does anything | |
| 12:24:26 | gibi | ack | |
| 12:24:46 | opendevreview | Balazs Gibizer proposed openstack/nova master: Follow up for the PCI in placement series https://review.opendev.org/c/openstack/nova/+/855185 | |
| 12:24:46 | opendevreview | Balazs Gibizer proposed openstack/nova master: Doc follow up for PCI in placement https://review.opendev.org/c/openstack/nova/+/855186 | |
| 12:24:47 | opendevreview | Balazs Gibizer proposed openstack/nova master: Create RequestGroups from InstancePCIRequests https://review.opendev.org/c/openstack/nova/+/852771 | |
| 12:24:47 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support resource_class and traits in PCI alias https://review.opendev.org/c/openstack/nova/+/853316 | |
| 12:24:48 | opendevreview | Balazs Gibizer proposed openstack/nova master: Split PCI pools per PF https://review.opendev.org/c/openstack/nova/+/854440 | |
| 12:24:48 | opendevreview | Balazs Gibizer proposed openstack/nova master: Map PCI pools to RP UUIDs https://review.opendev.org/c/openstack/nova/+/854118 | |
| 12:24:49 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make allocation candidates available for scheduler filters https://review.opendev.org/c/openstack/nova/+/854119 | |
| 12:24:50 | opendevreview | Balazs Gibizer proposed openstack/nova master: Filter PCI pools based on Placement allocation https://review.opendev.org/c/openstack/nova/+/854120 | |
| 12:24:50 | opendevreview | Balazs Gibizer proposed openstack/nova master: Factor out base class for candidate aware filters https://review.opendev.org/c/openstack/nova/+/854929 | |
| 12:24:52 | opendevreview | Balazs Gibizer proposed openstack/nova master: Store allocated RP in InstancePCIRequest https://review.opendev.org/c/openstack/nova/+/854121 | |
| 12:24:52 | opendevreview | Balazs Gibizer proposed openstack/nova master: Func test for PCI in placement scheduling https://review.opendev.org/c/openstack/nova/+/854122 | |
| 12:24:54 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support cold migrate and resize with PCI tracking in placement https://review.opendev.org/c/openstack/nova/+/854247 | |
| 12:24:54 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support evacuate with PCI in placement https://review.opendev.org/c/openstack/nova/+/854615 | |
| 12:24:56 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support unshelve with PCI in placement https://review.opendev.org/c/openstack/nova/+/854616 | |
| 12:24:56 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support same host resize with PCI in placement https://review.opendev.org/c/openstack/nova/+/854441 | |
| 12:24:58 | opendevreview | Balazs Gibizer proposed openstack/nova master: Test reschedule with PCI in placement https://review.opendev.org/c/openstack/nova/+/854626 | |
| 12:24:58 | opendevreview | Balazs Gibizer proposed openstack/nova master: Test multi create with PCI in placement https://review.opendev.org/c/openstack/nova/+/854663 | |
| 12:25:00 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI scheduling in Placement https://review.opendev.org/c/openstack/nova/+/854924 | |
| 12:25:00 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename _to_device_spec_conf to _to_list_of_json_str https://review.opendev.org/c/openstack/nova/+/855648 | |
| 12:25:02 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reproduce PCI pool filtering bug https://review.opendev.org/c/openstack/nova/+/855649 | |
| 12:25:02 | opendevreview | Balazs Gibizer proposed openstack/nova master: Strictly follow placement allocation during PCI claim https://review.opendev.org/c/openstack/nova/+/855650 | |
| 12:25:04 | opendevreview | Balazs Gibizer proposed openstack/nova master: Follow up for the PCI in placement series https://review.opendev.org/c/openstack/nova/+/855654 | |
| 12:25:09 | bauzas | sorry folks, I was taxiing again kids and all the likes | |
| 12:25:23 | bauzas | sean-k-mooney: what was your question for me ? | |
| 12:25:51 | sean-k-mooney | its not imporant | |
| 12:26:06 | sean-k-mooney | we had a minor bugfix for palcment and wanted to know if i can merge it | |
| 12:26:16 | sean-k-mooney | after talkign to gibi i +w'd it | |
| 12:26:40 | gibi | stephenfin, sean-k-mooney: I have two FUPs for the merged part of the PCI series. One for the code https://review.opendev.org/c/openstack/nova/+/855185 and one for the doc https://review.opendev.org/c/openstack/nova/+/855186 | |
| 12:27:04 | sean-k-mooney | gibi: ack ill take a look | |
| 12:27:05 | gibi | now they are up to date and on the proper base | |
| 12:27:09 | gibi | sean-k-mooney: thanks | |
| 12:27:10 | sean-k-mooney | on master | |
| 12:27:26 | sean-k-mooney | or on the last patch that is pending in the gate | |
| 12:27:40 | gibi | on top of https://review.opendev.org/c/openstack/nova/+/853835 which is being merged | |
| 12:27:48 | sean-k-mooney | ack | |
| 12:40:59 | sean-k-mooney | gibi: frickler ok that works ill push a patch shortly | |
| 12:42:34 | frickler | sean-k-mooney: great, did you confirm with older prettytable, too? | |
| 12:42:44 | sean-k-mooney | yep | |
| 12:42:57 | sean-k-mooney | i have not run all tests to see if it fixes all of them yet | |
| 12:43:02 | sean-k-mooney | but that one test now passes | |
| 12:43:14 | sean-k-mooney | so just adding the header alignemnt seames to work | |
| 12:43:35 | frickler | o.k., nice | |
| 12:45:57 | gibi | sean-k-mooney: sounds good | |
| 12:46:07 | opendevreview | sean mooney proposed openstack/nova master: add header alingment for PrettyTable 3.4.0 https://review.opendev.org/c/openstack/nova/+/855658 | |
| 12:46:16 | sean-k-mooney | ill run the full test now locally | |
| 12:46:30 | opendevreview | Balazs Gibizer proposed openstack/nova-specs master: Update the PCI in placement spec https://review.opendev.org/c/openstack/nova-specs/+/855218 | |
| 12:47:01 | gibi | sean-k-mooney, stephenfin: ^^ and this is the update of the Zed spec that sync the spec with the implementation | |
| 12:53:50 | sean-k-mooney | ok that passed unit test localy so it should be good | |
| 12:54:08 | sean-k-mooney | gibi: any prefernce on what i review first | |
| 12:54:19 | sean-k-mooney | gibi: i was goign to look at the code tehn the spec | |
| 12:54:29 | gibi | sean-k-mooney: any order is OK | |
| 13:06:00 | sean-k-mooney | stephenfin: one question i gues for you in https://review.opendev.org/c/openstack/nova/+/855186 or gibi | |
| 13:06:18 | sean-k-mooney | gibi: but the two followup look ok to me | |
| 13:06:24 | gibi | heh, that is a nice question | |
| 13:06:39 | gibi | I tried many ways to combine them and get a good looking result in the html | |
| 13:06:51 | sean-k-mooney | oh i guess i should look at that | |
| 13:06:59 | gibi | the current source produces the best html result for me | |
| 13:07:19 | gibi | but I'm curious if stephenfin has a better one | |
| 13:07:42 | gibi | for me reSt can be mistery sometimes | |
| 13:09:39 | opendevreview | Balazs Gibizer proposed openstack/nova-specs master: Re-propose PCI Device Tracking In Placement for A https://review.opendev.org/c/openstack/nova-specs/+/855661 | |
| 13:09:46 | sean-k-mooney | it looks alreight i guess https://717a5ffd6a01c6a737e0-3e7434681f5fe092d7172e763d28f5ee.ssl.cf5.rackcdn.com/855186/3/check/openstack-tox-docs/1737365/docs/admin/pci-passthrough.html | |
| 13:10:56 | sean-k-mooney | gibi: im going to delegate ot stepehn on this | |
| 13:11:02 | gibi | sure | |
| 13:11:36 | gibi | if there is a better way then I will change | |
| 13:12:02 | sean-k-mooney | i actully tough thte render was goign to be more dramatic then it is | |
| 13:12:08 | sean-k-mooney | like a note or imporant | |
| 13:12:15 | sean-k-mooney | this is pretty subtle | |
| 13:12:19 | bauzas | gibi: sorry if you felt abandoned for your PCI series | |
| 13:12:23 | sean-k-mooney | so i dont mind the duplicates as much | |
| 13:12:30 | bauzas | I didn't had time to look at all the merged changes | |
| 13:12:58 | opendevreview | Merged openstack/nova master: Generate request_id for Flavor based InstancePCIRequest https://review.opendev.org/c/openstack/nova/+/853835 | |
| 13:13:06 | sean-k-mooney | bauzas: you can make it up to gibi by looking at the unmerged once after RC1 :P | |
| 13:13:11 | gibi | bauzas: no worries, sean-k-mooney and stephenfin did an superb job providing feedback and reviews | |
| 13:16:16 | gibi | this was a lot of code (the whole series is over 8KLOC) and we merged a substantial and meaningful part of it | |
| 13:16:36 | sean-k-mooney | and fixed some latent bugs | |
| 13:16:44 | sean-k-mooney | hard to find ones at that | |
| 13:17:00 | sean-k-mooney | specificaly that decorator eating the excption | |
| 13:17:02 | gibi | yes, I was able to pull out some bugs in the process too. that was nice | |
| 13:17:51 | gibi | so while I'm sad that we could not land the whole thing in Zed, I think we made a good progress on something that was on our plate at least since 2019 | |
| 13:18:08 | sean-k-mooney | only 2019 | |
| 13:18:22 | sean-k-mooney | pci in placment is more or less why we started nested resouce providers | |
| 13:18:23 | gibi | I remember we whiteboarded it in China | |
| 13:18:34 | gibi | the rest is fading in my memory | |
| 13:18:52 | gibi | but sure there is a lot of history | |
| 13:19:03 | sean-k-mooney | yep | |