| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-08-22 | |||
| 14:06:40 | sean-k-mooney | but if the requester id was the flavor uuid in that case we could | |
| 14:07:26 | gibi | yes, it sounds useful | |
| 14:07:28 | gibi | I keep it in mind | |
| 14:07:58 | sean-k-mooney | ack im trying not to over complicate the requirement for your mvp | |
| 14:08:04 | opendevreview | Balazs Gibizer proposed openstack/nova master: Generate request_id for Flavor based InstancePCIRequest https://review.opendev.org/c/openstack/nova/+/853835 | |
| 14:08:15 | gibi | sean-k-mooney: no worries :) | |
| 14:08:49 | sean-k-mooney | stephenfin: gibi when you have time the vdpa seriese i belive is not ready for review | |
| 14:08:59 | stephenfin | now? | |
| 14:09:02 | sean-k-mooney | im going to switch to some down stream stuff for a bit | |
| 14:09:05 | stephenfin | (or not) | |
| 14:09:07 | sean-k-mooney | stephenfin: yes just pushed it | |
| 14:09:18 | sean-k-mooney | sorry now | |
| 14:09:26 | sean-k-mooney | :) | |
| 14:09:32 | gibi | I will review it right now, to fit it before the downstream call | |
| 14:28:20 | gibi | sean-k-mooney: there are some service version mistmatches in the last vdpa patch, I left a -1 there | |
| 14:28:37 | sean-k-mooney | ya also i just ran those tests localy and 2 of them fail | |
| 14:28:43 | sean-k-mooney | i tought i did that but i guess not | |
| 14:29:08 | sean-k-mooney | ill fix the issues today but likely after our downstream meetings | |
| 14:29:23 | sean-k-mooney | thanks for taking a look | |
| 14:30:19 | gibi | ack | |
| 15:02:54 | JayF | Hey all again, still looking for reviews on this improvement to CI for Ironic-related patches https://review.opendev.org/c/openstack/nova/+/853529 | |
| 15:03:26 | JayF | and a couple of stable patches I'm trying to get through the gate; one is at victoria right now ( https://review.opendev.org/c/openstack/nova/+/821350 ) and the other is at ussuri ( https://review.opendev.org/c/openstack/nova/+/853540 ) | |
| 15:03:44 | JayF | Also if there's anything I can do to more properly integrate my requests for reviews into whatever process you all use, I'm happy to take feedback. | |
| 16:05:02 | opendevreview | Sofia Enriquez proposed openstack/nova master: WIP: Check NFS protocol https://review.opendev.org/c/openstack/nova/+/854030 | |
| 16:37:41 | opendevreview | Jean-Sébastien Bevilacqua proposed openstack/nova master: Add Lustre support to nova https://review.opendev.org/c/openstack/nova/+/853786 | |
| 16:49:04 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix rescue volume-based instance https://review.opendev.org/c/openstack/nova/+/852737 | |
| 16:57:42 | opendevreview | sean mooney proposed openstack/nova master: Add VDPA support for suspend and livemigrate https://review.opendev.org/c/openstack/nova/+/853704 | |
| 17:15:28 | opendevreview | Elod Illes proposed openstack/nova stable/victoria: Ignore plug_vifs on the ironic driver https://review.opendev.org/c/openstack/nova/+/821350 | |
| 17:16:49 | stephenfin | sean-k-mooney: question on the last vDPA patch but good on the other two https://review.opendev.org/c/openstack/nova/+/853704 | |
| 17:17:43 | sean-k-mooney | gibi: stephenfin what is the lifetime of this fixture https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_pci_sriov_servers.py#L83 | |
| 17:18:08 | sean-k-mooney | when i inhirt form this class instead it not actully in applied in my live migration test | |
| 17:18:15 | sean-k-mooney | do i need to assgin that to a varible | |
| 17:18:23 | gibi | a single test case | |
| 17:18:27 | sean-k-mooney | to extend it to the full test | |
| 17:18:51 | gibi | do you call super() from your class setUp? | |
| 17:19:03 | sean-k-mooney | yep | |
| 17:19:14 | sean-k-mooney | if i do | |
| 17:19:17 | sean-k-mooney | from nova.tests.fixtures.libvirt import Domain as Dom | |
| 17:19:19 | sean-k-mooney | self.assertEqual(self._migrate_stub, Dom.migrateToURI3) | |
| 17:19:23 | sean-k-mooney | they are not the same | |
| 17:19:54 | sean-k-mooney | stephenfin: looking now | |
| 17:20:30 | gibi | strange. I would say push the patch and I will look at it but I will only do that tomorrow. I' mostly off for today | |
| 17:21:01 | sean-k-mooney | gibi: the current one has the issue | |
| 17:21:08 | sean-k-mooney | and no worries | |
| 17:21:19 | sean-k-mooney | i might assign it to a var and see if that helps | |
| 17:21:49 | gibi | should not make a difference but worth trying as it maybe tease out something else | |
| 17:22:04 | sean-k-mooney | gibi: by the way stephenfin question is basicaly somethign i need you to answer https://review.opendev.org/c/openstack/nova/+/853704/5/nova/objects/service.py#236 | |
| 17:22:53 | sean-k-mooney | gibi: it can wait till tomorrw but my current answer is becasue gibi said so | |
| 17:23:43 | gibi | stephenfin, sean-k-mooney: about the N-1 version list in service.py. I think the easiest way out is not to change that in this patch series | |
| 17:23:52 | gibi | we change that at every start of a cycle | |
| 17:24:09 | sean-k-mooney | ack i can drop it | |
| 17:24:21 | stephenfin | wfm | |
| 17:24:32 | gibi | but to answer the question. When I introduced that logic I made it generic to support the case when somebody upgrade nova to beta version (or to m2 version) | |
| 17:24:58 | gibi | so the recorded service version for a given release is the first version appeared in that release | |
| 17:25:29 | gibi | so when we say Yoga supports Xena computes it means Yoga supports even the first (not just the last) service version of the Xena computes | |
| 17:25:35 | sean-k-mooney | hum ok i tought this was ment to be the latest version | |
| 17:26:01 | sean-k-mooney | im not sure we make that guarentee | |
| 17:26:09 | gibi | I think talked about later that it does not really need to support m2 upgrades | |
| 17:26:20 | gibi | so my genericness is not strictly needed | |
| 17:26:25 | gibi | but it is not wrong per se | |
| 17:26:34 | sean-k-mooney | it does not need to be in this patch anyway | |
| 17:26:48 | gibi | but if we change to latest, then I suggest to change it with some extra comments that describes that past values are not latest per release | |
| 17:26:57 | gibi | sean-k-mooney: yes, it is not needed in this patch | |
| 17:27:16 | sean-k-mooney | cool enjoy your eventing | |
| 17:27:23 | gibi | btw, I don't see any obvious problem with your live migration test, but I will look more tomorrow | |
| 17:27:28 | sean-k-mooney | im going to finsih soon too as i have a headache | |
| 17:27:39 | sean-k-mooney | ya its weired | |
| 17:27:47 | sean-k-mooney | im going to try one or two thing and call it aday | |
| 17:29:52 | sean-k-mooney | im wondering is this a sideefect fo fixtures._fixtures.monkeypatch.MonkeyPatch vs fixtures._fixtures.mock | |
| 19:07:04 | opendevreview | Merged openstack/nova master: Fix a deprecation warning about threading.Thread https://review.opendev.org/c/openstack/nova/+/853869 | |
| 20:35:26 | opendevreview | Rico Lin proposed openstack/nova master: Add locked_memory extra spec and image property https://review.opendev.org/c/openstack/nova/+/778347 | |
| 20:35:26 | opendevreview | Rico Lin proposed openstack/nova master: libvirt: Add vIOMMU device to guest https://review.opendev.org/c/openstack/nova/+/830646 | |
| 20:35:27 | opendevreview | Rico Lin proposed openstack/nova master: Add traits for viommu model https://review.opendev.org/c/openstack/nova/+/844507 | |
| 23:02:24 | opendevreview | Brett Milford proposed openstack/nova master: Handle "no RAM info was set" migration case https://review.opendev.org/c/openstack/nova/+/852002 | |
| #openstack-nova - 2022-08-23 | |||
| 04:37:07 | auniyal | Hi | |
| 04:37:14 | auniyal | please review these - | |
| 04:37:35 | auniyal | https://review.opendev.org/c/openstack/nova/+/853811 | |
| 04:37:35 | auniyal | https://review.opendev.org/c/openstack/nova/+/853812 | |
| 07:43:25 | sean-k-mooney[m] | gibi: i have mostly figured out the issue with my test. its not the migration stub im calling _detach_passthough_vifs in this code path and that was not being mocked by the fixture | |
| 07:43:40 | gibi | ahh, OK | |
| 07:43:40 | sean-k-mooney[m] | if i mock that the migration succeed although my post condtions fail | |
| 07:43:48 | sean-k-mooney[m] | so i need to mock it better | |
| 07:44:00 | sean-k-mooney[m] | or perhaps just the detach call | |
| 07:44:43 | sean-k-mooney[m] | im still not sure why this fails in my case and not the sriov case | |
| 07:44:55 | sean-k-mooney[m] | or in my detach test | |
| 07:45:04 | sean-k-mooney[m] | but thats the issue | |
| 08:10:17 | opendevreview | sean mooney proposed openstack/nova master: Add VDPA support for suspend and livemigrate https://review.opendev.org/c/openstack/nova/+/853704 | |
| 08:12:09 | sean-k-mooney[m] | im just running ^ now locally | |
| 08:12:42 | sean-k-mooney[m] | that should resolve the issue with the tests and i have dropped the service version release mapping | |
| 08:13:31 | gibi | sean-k-mooney[m]: I'm +2 and fingers crossed for the test | |
| 08:14:23 | sean-k-mooney[m] | the issue once i mocked it was the _live_migrate helper did not return the server object | |
| 08:14:47 | sean-k-mooney[m] | so i fixed that and then the assert worked | |
| 08:16:36 | sean-k-mooney[m] | hum that apprently broke one functional test im going to leave the unit test finish then ill check that again | |
| 08:16:54 | sean-k-mooney[m] | im not sure why wapping the order of the waits would have that effect | |
| 08:17:52 | sean-k-mooney[m] | i can restore the order of the waits and store teh server responce in a local var | |
| 08:18:32 | gibi | or return the server from the _live_migrate helper | |
| 08:19:01 | sean-k-mooney[m] | well i am returning it from _live_migrate | |
| 08:19:25 | gibi | ahh yes | |
| 08:19:44 | sean-k-mooney[m] | https://review.opendev.org/c/openstack/nova/+/853704/6/nova/tests/functional/integrated_helpers.py | |
| 08:19:52 | gibi | would be nice to check the code which state transtion happens last, the migration or the server | |