| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-08-22 | |||
| 17:24:58 | gibi | so the recorded service version for a given release is the first version appeared in that release | |
| 17:25:29 | gibi | so when we say Yoga supports Xena computes it means Yoga supports even the first (not just the last) service version of the Xena computes | |
| 17:25:35 | sean-k-mooney | hum ok i tought this was ment to be the latest version | |
| 17:26:01 | sean-k-mooney | im not sure we make that guarentee | |
| 17:26:09 | gibi | I think talked about later that it does not really need to support m2 upgrades | |
| 17:26:20 | gibi | so my genericness is not strictly needed | |
| 17:26:25 | gibi | but it is not wrong per se | |
| 17:26:34 | sean-k-mooney | it does not need to be in this patch anyway | |
| 17:26:48 | gibi | but if we change to latest, then I suggest to change it with some extra comments that describes that past values are not latest per release | |
| 17:26:57 | gibi | sean-k-mooney: yes, it is not needed in this patch | |
| 17:27:16 | sean-k-mooney | cool enjoy your eventing | |
| 17:27:23 | gibi | btw, I don't see any obvious problem with your live migration test, but I will look more tomorrow | |
| 17:27:28 | sean-k-mooney | im going to finsih soon too as i have a headache | |
| 17:27:39 | sean-k-mooney | ya its weired | |
| 17:27:47 | sean-k-mooney | im going to try one or two thing and call it aday | |
| 17:29:52 | sean-k-mooney | im wondering is this a sideefect fo fixtures._fixtures.monkeypatch.MonkeyPatch vs fixtures._fixtures.mock | |
| 19:07:04 | opendevreview | Merged openstack/nova master: Fix a deprecation warning about threading.Thread https://review.opendev.org/c/openstack/nova/+/853869 | |
| 20:35:26 | opendevreview | Rico Lin proposed openstack/nova master: Add locked_memory extra spec and image property https://review.opendev.org/c/openstack/nova/+/778347 | |
| 20:35:26 | opendevreview | Rico Lin proposed openstack/nova master: libvirt: Add vIOMMU device to guest https://review.opendev.org/c/openstack/nova/+/830646 | |
| 20:35:27 | opendevreview | Rico Lin proposed openstack/nova master: Add traits for viommu model https://review.opendev.org/c/openstack/nova/+/844507 | |
| 23:02:24 | opendevreview | Brett Milford proposed openstack/nova master: Handle "no RAM info was set" migration case https://review.opendev.org/c/openstack/nova/+/852002 | |
| #openstack-nova - 2022-08-23 | |||
| 04:37:07 | auniyal | Hi | |
| 04:37:14 | auniyal | please review these - | |
| 04:37:35 | auniyal | https://review.opendev.org/c/openstack/nova/+/853811 | |
| 04:37:35 | auniyal | https://review.opendev.org/c/openstack/nova/+/853812 | |
| 07:43:25 | sean-k-mooney[m] | gibi: i have mostly figured out the issue with my test. its not the migration stub im calling _detach_passthough_vifs in this code path and that was not being mocked by the fixture | |
| 07:43:40 | gibi | ahh, OK | |
| 07:43:40 | sean-k-mooney[m] | if i mock that the migration succeed although my post condtions fail | |
| 07:43:48 | sean-k-mooney[m] | so i need to mock it better | |
| 07:44:00 | sean-k-mooney[m] | or perhaps just the detach call | |
| 07:44:43 | sean-k-mooney[m] | im still not sure why this fails in my case and not the sriov case | |
| 07:44:55 | sean-k-mooney[m] | or in my detach test | |
| 07:45:04 | sean-k-mooney[m] | but thats the issue | |
| 08:10:17 | opendevreview | sean mooney proposed openstack/nova master: Add VDPA support for suspend and livemigrate https://review.opendev.org/c/openstack/nova/+/853704 | |
| 08:12:09 | sean-k-mooney[m] | im just running ^ now locally | |
| 08:12:42 | sean-k-mooney[m] | that should resolve the issue with the tests and i have dropped the service version release mapping | |
| 08:13:31 | gibi | sean-k-mooney[m]: I'm +2 and fingers crossed for the test | |
| 08:14:23 | sean-k-mooney[m] | the issue once i mocked it was the _live_migrate helper did not return the server object | |
| 08:14:47 | sean-k-mooney[m] | so i fixed that and then the assert worked | |
| 08:16:36 | sean-k-mooney[m] | hum that apprently broke one functional test im going to leave the unit test finish then ill check that again | |
| 08:16:54 | sean-k-mooney[m] | im not sure why wapping the order of the waits would have that effect | |
| 08:17:52 | sean-k-mooney[m] | i can restore the order of the waits and store teh server responce in a local var | |
| 08:18:32 | gibi | or return the server from the _live_migrate helper | |
| 08:19:01 | sean-k-mooney[m] | well i am returning it from _live_migrate | |
| 08:19:25 | gibi | ahh yes | |
| 08:19:44 | sean-k-mooney[m] | https://review.opendev.org/c/openstack/nova/+/853704/6/nova/tests/functional/integrated_helpers.py | |
| 08:19:52 | gibi | would be nice to check the code which state transtion happens last, the migration or the server | |
| 08:20:07 | gibi | and encode that order in the helper | |
| 08:20:17 | sean-k-mooney[m] | the order should not break other test right? | |
| 08:20:19 | gibi | if that make a test case fail then we probably have a bug somwhere | |
| 08:20:29 | gibi | yes, it should not | |
| 08:20:38 | gibi | except if the returned server is asserted | |
| 08:20:47 | gibi | but it is not yet in the expected strate | |
| 08:20:48 | gibi | state | |
| 08:20:54 | gibi | or vice versa | |
| 08:21:12 | gibi | hm | |
| 08:21:19 | gibi | actually what you do is the correct one I think | |
| 08:21:29 | gibi | as you return the server after the server state is changed | |
| 08:21:38 | gibi | so I guess the bug is in that other func test case | |
| 08:21:41 | sean-k-mooney[m] | ya that is why i reordered it | |
| 08:22:20 | sean-k-mooney[m] | i think so ya just getting its name | |
| 08:22:45 | sean-k-mooney[m] | i think its an ovs hardware offload test | |
| 08:23:28 | sean-k-mooney[m] | ya test_rollback_pre_live_migration | |
| 08:29:08 | sean-k-mooney[m] | ya its a regression but its expected the server state to be migrating and migration state to be failed | |
| 08:29:26 | sean-k-mooney[m] | but the server state is actully now active | |
| 08:29:57 | sean-k-mooney[m] | because i am now waitign until after the migation has failed and we have rolled back | |
| 08:30:40 | sean-k-mooney[m] | so if you are doing fault injection the order actully can matter but this is the only test out of all the unit and fuctional tests that fail | |
| 08:30:46 | sean-k-mooney[m] | so im just going to update it | |
| 08:32:17 | opendevreview | sean mooney proposed openstack/nova master: Add VDPA support for suspend and livemigrate https://review.opendev.org/c/openstack/nova/+/853704 | |
| 08:34:01 | sean-k-mooney[m] | ok i have been looking at that since 6 am and i have not had coffee this morning so im going to go correct that | |
| 08:34:04 | sean-k-mooney[m] | brb | |
| 08:41:40 | gibi | yeah, that is a valid fix for the test case | |
| 08:44:12 | Uggla | Hi gibi , do we have the nova meeting this evening ? | |
| 08:44:38 | gibi | Uggla: it is tuesday so yes | |
| 08:44:42 | gibi | I will chair it | |
| 08:44:46 | gibi | as the last two | |
| 08:44:56 | Uggla | ok cool | |
| 08:47:23 | sean-k-mooney[m] | still embing caffine but assuming im done with vdpa for today. what seriese should i review first | |
| 09:06:44 | opendevreview | Balazs Gibizer proposed openstack/nova master: Basics for PCI Placement reporting https://review.opendev.org/c/openstack/nova/+/846187 | |
| 09:06:44 | opendevreview | Balazs Gibizer proposed openstack/nova master: Extend device_spec with resource_class and traits https://review.opendev.org/c/openstack/nova/+/846218 | |
| 09:06:45 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject PCI dependent device config https://review.opendev.org/c/openstack/nova/+/846435 | |
| 09:06:45 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject mixed VF rc and trait config https://review.opendev.org/c/openstack/nova/+/846436 | |
| 09:06:46 | opendevreview | Balazs Gibizer proposed openstack/nova master: Ignore PCI devs with physical_network tag https://review.opendev.org/c/openstack/nova/+/846219 | |
| 09:06:46 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject devname based device_spec config https://review.opendev.org/c/openstack/nova/+/846466 | |
| 09:06:47 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support [pci]device_spec reconfiguration https://review.opendev.org/c/openstack/nova/+/846470 | |
| 09:06:47 | opendevreview | Balazs Gibizer proposed openstack/nova master: Stop if tracking is disable after it was enabled before https://review.opendev.org/c/openstack/nova/+/847009 | |
| 09:06:48 | opendevreview | Balazs Gibizer proposed openstack/nova master: Move provider_tree RP creation to PciResourceProvider https://review.opendev.org/c/openstack/nova/+/850546 | |
| 09:06:49 | opendevreview | Balazs Gibizer proposed openstack/nova master: Retry /reshape at provider generation conflict https://review.opendev.org/c/openstack/nova/+/851358 | |
| 09:06:49 | opendevreview | Balazs Gibizer proposed openstack/nova master: Heal missing simple PCI allocation in the resource tracker https://review.opendev.org/c/openstack/nova/+/851359 | |
| 09:06:51 | opendevreview | Balazs Gibizer proposed openstack/nova master: Heal PCI allocation during resize https://review.opendev.org/c/openstack/nova/+/852396 | |
| 09:06:51 | opendevreview | Balazs Gibizer proposed openstack/nova master: Handle PCI dev reconf with allocations https://review.opendev.org/c/openstack/nova/+/852397 | |
| 09:06:53 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI tracking in Placement https://review.opendev.org/c/openstack/nova/+/850468 | |
| 09:06:53 | opendevreview | Balazs Gibizer proposed openstack/nova master: Generate request_id for Flavor based InstancePCIRequest https://review.opendev.org/c/openstack/nova/+/853835 | |
| 09:06:55 | opendevreview | Balazs Gibizer proposed openstack/nova master: Request filter for PCI in placement https://review.opendev.org/c/openstack/nova/+/852771 | |
| 09:06:55 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support resource_class and traits in PCI alias https://review.opendev.org/c/openstack/nova/+/853316 | |
| 09:06:57 | opendevreview | Balazs Gibizer proposed openstack/nova master: Map PCI pools to RP UUIDs https://review.opendev.org/c/openstack/nova/+/854118 | |
| 09:06:57 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make allocation candidates available for scheduler filters https://review.opendev.org/c/openstack/nova/+/854119 | |
| 09:06:59 | opendevreview | Balazs Gibizer proposed openstack/nova master: Filter PCI pools based on Placement allocation https://review.opendev.org/c/openstack/nova/+/854120 | |
| 09:06:59 | opendevreview | Balazs Gibizer proposed openstack/nova master: Store allocated RP in InstancePCIRequest https://review.opendev.org/c/openstack/nova/+/854121 | |
| 09:07:01 | opendevreview | Balazs Gibizer proposed openstack/nova master: Func test for PCI in placement scheduling https://review.opendev.org/c/openstack/nova/+/854122 | |