| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-08-09 | |||
| 16:37:04 | gibi | is there anything else today/ | |
| 16:37:05 | gibi | ? | |
| 16:38:32 | gibi | then I will give you back 22 minutes | |
| 16:38:35 | gibi | #endmeeting | |
| 16:38:35 | opendevmeet | Meeting ended Tue Aug 9 16:38:35 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 16:38:35 | opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2022/nova.2022-08-09-16.02.html | |
| 16:38:35 | opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2022/nova.2022-08-09-16.02.txt | |
| 16:38:35 | opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2022/nova.2022-08-09-16.02.log.html | |
| 16:47:18 | opendevreview | Merged openstack/nova master: Update libvirt enlightenments for Windows https://review.opendev.org/c/openstack/nova/+/847641 | |
| 19:37:17 | melwitt | stephenfin: thanks for bringing up the ephemeral encryption stuff. I was wary to bother people about it, there's been so much else going on. we'll need bauzas_away to remove his -2 on the bottom patch. IIRC he should be back Aug 30 (2 days before FF), so hopefully he can remove it then cc sean-k-mooney[m] | |
| 19:47:16 | melwitt | sean-k-mooney[m], stephenfin: wrt the naming, I wanted to give everyone a break before bringing it up again 😬 but ... I had thought more about it and thinking about it in the context of the other extra spec/image prop names, I thought "hw_disk_encryption" does seemingly fit better https://github.com/openstack/nova/blob/1220d53c2fd6231bb569a54f004a0e858536e970/nova/objects/image_meta.py#L347-L351 but as you pointed out, there's a | |
| 19:47:17 | melwitt | chance that users might anyway think it could be referring to cinder volumes as well (?). none of the names are a slam dunk really :( | |
| #openstack-nova - 2022-08-10 | |||
| 03:57:16 | opendevreview | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/851337 | |
| 05:47:56 | opendevreview | chenwei proposed openstack/nova master: Remove unicode literal from code https://review.opendev.org/c/openstack/nova/+/852538 | |
| 06:33:54 | gokhanis | hi folks, because of lack disk space, my instances are paused. after increaing disk space, how can I start these instances? now vm state is active but power state is paused. | |
| 07:23:44 | gibi | melwitt: we can alway ask the infra folks to remove a -2 | |
| 10:09:46 | sean-k-mooney[m] | gibi can you rebase https://review.opendev.org/c/openstack/nova/+/852295/1 and i guess the rest of the pci series on the patch to make py310 voting and also fix the mocking issues in that patch | |
| 10:10:12 | gibi | I will do that as soon as the py310 voting patch lands | |
| 10:10:15 | sean-k-mooney[m] | gokhanisi: hard reboot is the simplest way | |
| 10:12:00 | sean-k-mooney[m] | gokhanisi: you might be able to call the pause and unpause api to do it too but really if you run out of disk you cant really resume form the api without somethign like a hard reboot or stop | |
| 11:52:36 | kashyap | Can anyone put this stable/wallaby backport through? - https://review.opendev.org/c/openstack/nova/+/849610 ([nova/libvirt] Support for checking and enabling SMM when needed | |
| 11:52:40 | kashyap | ) | |
| 12:06:26 | sean-k-mooney[m] | nope its still blocked by the xena backport | |
| 12:06:33 | sean-k-mooney[m] | https://review.opendev.org/c/openstack/nova/+/849676 | |
| 12:07:21 | sean-k-mooney[m] | elodilles: ^ if you have time to review or gibi perhaps | |
| 12:10:29 | gibi | done | |
| 12:20:25 | elodilles | as i see you already managed it :) | |
| 12:58:45 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix rescue volume-based instance https://review.opendev.org/c/openstack/nova/+/852737 | |
| 13:37:04 | opendevreview | Merged openstack/nova master: Remove double mocking... again https://review.opendev.org/c/openstack/nova/+/852464 | |
| 13:40:49 | opendevreview | Merged openstack/nova stable/xena: [nova/libvirt] Support for checking and enabling SMM when needed https://review.opendev.org/c/openstack/nova/+/849676 | |
| 14:23:12 | sean-k-mooney[m] | i might as well say this here too. just an fyi ill be on PTO returning tuseday once i sign off this evening | |
| 14:23:52 | sean-k-mooney[m] | gibi: melwitt_ i reviewed as much of the pci and encypted disk features as i have brain power for this morning | |
| 14:24:11 | sean-k-mooney[m] | both look mostly good but ill take a look at them again when im back | |
| 14:24:43 | gibi | sean-k-mooney[m]: thank you. I really appreciate the effort | |
| 14:28:00 | gibi | I worked on the basics of the scheduling part of the feature today. the pre_filter part was pretty simple, but I still have to do the allocation_candidte filtering in hardware.py and the allocation correlation in the claim code | |
| 14:31:52 | sean-k-mooney[m] | ack on pre_filter they normally are. the filtering in hardware.py hopefully wont be too hard the correcation might be a little more complicated | |
| 14:32:03 | sean-k-mooney[m] | did we merge your chaching change yet by the way | |
| 14:32:25 | gibi | which change you are referring to? | |
| 14:32:53 | sean-k-mooney[m] | the perfromace imporement for the hardware module by caching which nodes we had already checked | |
| 14:33:15 | gibi | hm | |
| 14:33:17 | gibi | I have to look | |
| 14:33:38 | gibi | nope | |
| 14:33:41 | gibi | it is still open https://review.opendev.org/c/openstack/nova/+/845896 | |
| 14:34:18 | sean-k-mooney[m] | ok it would likely be good to land that before you have to refactor that | |
| 14:34:26 | sean-k-mooney[m] | stephenfin: ^ | |
| 14:34:38 | sean-k-mooney[m] | its pretty simple if you have the time | |
| 14:35:10 | sean-k-mooney[m] | i also need to adress your feedback on https://review.opendev.org/c/openstack/nova/+/846169 | |
| 14:35:33 | sean-k-mooney[m] | i was going to work on the vdpa patch before i went on pto but this is smaller and more doable today so ill do that now | |
| 14:35:50 | gibi | ack, ping me and I can re-review | |
| 14:36:07 | gibi | and good point about the cache, I already forgot it | |
| 14:41:52 | gibi | hm, the py310 voting patch merged so I will also do the rebase of the series | |
| 14:42:04 | gibi | then we can land at least the bugfix in front of it | |
| 14:45:23 | opendevreview | sean mooney proposed openstack/nova master: update default numa allocation strategy https://review.opendev.org/c/openstack/nova/+/846169 | |
| 14:45:37 | sean-k-mooney[m] | yep | |
| 14:49:00 | opendevreview | Merged openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/851337 | |
| 14:54:11 | melwitt | gibi: oh true, I forgot about that | |
| 14:54:38 | melwitt | sean-k-mooney[m]: thank you, appreciated | |
| 14:57:55 | sean-k-mooney[m] | melwitt: since your about care to look at https://review.opendev.org/q/topic:bug%252F1978372 | |
| 14:58:28 | melwitt | sean-k-mooney[m]: sure, will look after the bug call | |
| 14:58:46 | sean-k-mooney[m] | oh ya i proably shoud get something to drink before that | |
| 14:59:00 | sean-k-mooney[m] | you know water totally just water | |
| 15:00:01 | opendevreview | Balazs Gibizer proposed openstack/nova master: Request filter for PCI in placement https://review.opendev.org/c/openstack/nova/+/852771 | |
| 15:00:15 | melwitt | sean-k-mooney[m]: :D | |
| 15:23:41 | opendevreview | Merged openstack/nova stable/wallaby: [nova/libvirt] Support for checking and enabling SMM when needed https://review.opendev.org/c/openstack/nova/+/849610 | |
| 16:22:23 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reproducer for bug 1983753 https://review.opendev.org/c/openstack/nova/+/852295 | |
| 16:22:23 | opendevreview | Balazs Gibizer proposed openstack/nova master: Update RequestSpec.pci_request for resize https://review.opendev.org/c/openstack/nova/+/852296 | |
| 16:22:24 | opendevreview | Balazs Gibizer proposed openstack/nova master: Poison /sys access via various calls in test https://review.opendev.org/c/openstack/nova/+/844627 | |
| 16:22:24 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add compute restart capability for libvirt func tests https://review.opendev.org/c/openstack/nova/+/850510 | |
| 16:22:25 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename [pci]passthrough_whitelist to device_spec https://review.opendev.org/c/openstack/nova/+/843834 | |
| 16:22:25 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename exception.PciConfigInvalidWhitelist to PciConfigInvalidSpec https://review.opendev.org/c/openstack/nova/+/843861 | |
| 16:22:26 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename whitelist in tests https://review.opendev.org/c/openstack/nova/+/843862 | |
| 16:22:26 | opendevreview | Balazs Gibizer proposed openstack/nova master: Basics for PCI Placement reporting https://review.opendev.org/c/openstack/nova/+/846187 | |
| 16:22:27 | opendevreview | Balazs Gibizer proposed openstack/nova master: Extend device_spec with resource_class and traits https://review.opendev.org/c/openstack/nova/+/846218 | |
| 16:22:28 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject PCI dependent device config https://review.opendev.org/c/openstack/nova/+/846435 | |
| 16:22:28 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject mixed VF rc and trait config https://review.opendev.org/c/openstack/nova/+/846436 | |
| 16:22:30 | opendevreview | Balazs Gibizer proposed openstack/nova master: Ignore PCI devs with physical_network tag https://review.opendev.org/c/openstack/nova/+/846219 | |
| 16:22:30 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject devname based device_spec config https://review.opendev.org/c/openstack/nova/+/846466 | |
| 16:22:32 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support [pci]device_spec reconfiguration https://review.opendev.org/c/openstack/nova/+/846470 | |
| 16:22:32 | opendevreview | Balazs Gibizer proposed openstack/nova master: Stop if tracking is disable after it was enabled before https://review.opendev.org/c/openstack/nova/+/847009 | |
| 16:22:34 | opendevreview | Balazs Gibizer proposed openstack/nova master: Move provider_tree RP creation to PciResourceProvider https://review.opendev.org/c/openstack/nova/+/850546 | |
| 16:22:34 | opendevreview | Balazs Gibizer proposed openstack/nova master: Retry /reshape at provider generation conflict https://review.opendev.org/c/openstack/nova/+/851358 | |
| 16:22:36 | opendevreview | Balazs Gibizer proposed openstack/nova master: Heal missing simple PCI allocation in the resource tracker https://review.opendev.org/c/openstack/nova/+/851359 | |
| 16:22:36 | opendevreview | Balazs Gibizer proposed openstack/nova master: Heal PCI allocation during resize https://review.opendev.org/c/openstack/nova/+/852396 | |
| 16:22:38 | opendevreview | Balazs Gibizer proposed openstack/nova master: Handle PCI dev reconf with allocations https://review.opendev.org/c/openstack/nova/+/852397 | |
| 16:22:38 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI tracking in Placement https://review.opendev.org/c/openstack/nova/+/850468 | |
| 16:22:40 | opendevreview | Balazs Gibizer proposed openstack/nova master: Request filter for PCI in placement https://review.opendev.org/c/openstack/nova/+/852771 | |
| 16:22:55 | sean-k-mooney[m] | just one or two patches :) | |
| 16:23:05 | gibi | yeah just 22 :) | |
| 16:23:10 | gibi | in the main series | |
| 16:23:21 | gibi | but now it is rebased as the double mock fix landed | |
| 16:23:23 | sean-k-mooney[m] | it does make it more digestable | |
| 16:23:31 | sean-k-mooney[m] | cool | |
| 16:23:40 | sean-k-mooney[m] | i think the first few are ready to merge | |
| 16:23:40 | gibi | I checked locally I don't have double mock in the first two patches (the bugfix) | |
| 16:23:57 | sean-k-mooney[m] | ack | |
| 16:24:05 | gibi | I will check the rest locally too, but I have to log off in 10 minutes | |
| 16:33:31 | gibi | OK it seems to be the series is clean from double mocks (at least running it locally) | |
| 17:21:49 | gibi | sean-k-mooney[m]: https://review.opendev.org/c/openstack/nova/+/852295/2 is green now. so if you still around that could unblock some of the patches in the pci seriea | |
| 17:31:22 | sean-k-mooney[m] | yep still here | |
| 17:32:06 | sean-k-mooney[m] | done | |