| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-08-10 | |||
| 14:31:52 | sean-k-mooney[m] | ack on pre_filter they normally are. the filtering in hardware.py hopefully wont be too hard the correcation might be a little more complicated | |
| 14:32:03 | sean-k-mooney[m] | did we merge your chaching change yet by the way | |
| 14:32:25 | gibi | which change you are referring to? | |
| 14:32:53 | sean-k-mooney[m] | the perfromace imporement for the hardware module by caching which nodes we had already checked | |
| 14:33:15 | gibi | hm | |
| 14:33:17 | gibi | I have to look | |
| 14:33:38 | gibi | nope | |
| 14:33:41 | gibi | it is still open https://review.opendev.org/c/openstack/nova/+/845896 | |
| 14:34:18 | sean-k-mooney[m] | ok it would likely be good to land that before you have to refactor that | |
| 14:34:26 | sean-k-mooney[m] | stephenfin: ^ | |
| 14:34:38 | sean-k-mooney[m] | its pretty simple if you have the time | |
| 14:35:10 | sean-k-mooney[m] | i also need to adress your feedback on https://review.opendev.org/c/openstack/nova/+/846169 | |
| 14:35:33 | sean-k-mooney[m] | i was going to work on the vdpa patch before i went on pto but this is smaller and more doable today so ill do that now | |
| 14:35:50 | gibi | ack, ping me and I can re-review | |
| 14:36:07 | gibi | and good point about the cache, I already forgot it | |
| 14:41:52 | gibi | hm, the py310 voting patch merged so I will also do the rebase of the series | |
| 14:42:04 | gibi | then we can land at least the bugfix in front of it | |
| 14:45:23 | opendevreview | sean mooney proposed openstack/nova master: update default numa allocation strategy https://review.opendev.org/c/openstack/nova/+/846169 | |
| 14:45:37 | sean-k-mooney[m] | yep | |
| 14:49:00 | opendevreview | Merged openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/851337 | |
| 14:54:11 | melwitt | gibi: oh true, I forgot about that | |
| 14:54:38 | melwitt | sean-k-mooney[m]: thank you, appreciated | |
| 14:57:55 | sean-k-mooney[m] | melwitt: since your about care to look at https://review.opendev.org/q/topic:bug%252F1978372 | |
| 14:58:28 | melwitt | sean-k-mooney[m]: sure, will look after the bug call | |
| 14:58:46 | sean-k-mooney[m] | oh ya i proably shoud get something to drink before that | |
| 14:59:00 | sean-k-mooney[m] | you know water totally just water | |
| 15:00:01 | opendevreview | Balazs Gibizer proposed openstack/nova master: Request filter for PCI in placement https://review.opendev.org/c/openstack/nova/+/852771 | |
| 15:00:15 | melwitt | sean-k-mooney[m]: :D | |
| 15:23:41 | opendevreview | Merged openstack/nova stable/wallaby: [nova/libvirt] Support for checking and enabling SMM when needed https://review.opendev.org/c/openstack/nova/+/849610 | |
| 16:22:23 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reproducer for bug 1983753 https://review.opendev.org/c/openstack/nova/+/852295 | |
| 16:22:23 | opendevreview | Balazs Gibizer proposed openstack/nova master: Update RequestSpec.pci_request for resize https://review.opendev.org/c/openstack/nova/+/852296 | |
| 16:22:24 | opendevreview | Balazs Gibizer proposed openstack/nova master: Poison /sys access via various calls in test https://review.opendev.org/c/openstack/nova/+/844627 | |
| 16:22:24 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add compute restart capability for libvirt func tests https://review.opendev.org/c/openstack/nova/+/850510 | |
| 16:22:25 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename [pci]passthrough_whitelist to device_spec https://review.opendev.org/c/openstack/nova/+/843834 | |
| 16:22:25 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename exception.PciConfigInvalidWhitelist to PciConfigInvalidSpec https://review.opendev.org/c/openstack/nova/+/843861 | |
| 16:22:26 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename whitelist in tests https://review.opendev.org/c/openstack/nova/+/843862 | |
| 16:22:26 | opendevreview | Balazs Gibizer proposed openstack/nova master: Basics for PCI Placement reporting https://review.opendev.org/c/openstack/nova/+/846187 | |
| 16:22:27 | opendevreview | Balazs Gibizer proposed openstack/nova master: Extend device_spec with resource_class and traits https://review.opendev.org/c/openstack/nova/+/846218 | |
| 16:22:28 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject PCI dependent device config https://review.opendev.org/c/openstack/nova/+/846435 | |
| 16:22:28 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject mixed VF rc and trait config https://review.opendev.org/c/openstack/nova/+/846436 | |
| 16:22:30 | opendevreview | Balazs Gibizer proposed openstack/nova master: Ignore PCI devs with physical_network tag https://review.opendev.org/c/openstack/nova/+/846219 | |
| 16:22:30 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject devname based device_spec config https://review.opendev.org/c/openstack/nova/+/846466 | |
| 16:22:32 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support [pci]device_spec reconfiguration https://review.opendev.org/c/openstack/nova/+/846470 | |
| 16:22:32 | opendevreview | Balazs Gibizer proposed openstack/nova master: Stop if tracking is disable after it was enabled before https://review.opendev.org/c/openstack/nova/+/847009 | |
| 16:22:34 | opendevreview | Balazs Gibizer proposed openstack/nova master: Move provider_tree RP creation to PciResourceProvider https://review.opendev.org/c/openstack/nova/+/850546 | |
| 16:22:34 | opendevreview | Balazs Gibizer proposed openstack/nova master: Retry /reshape at provider generation conflict https://review.opendev.org/c/openstack/nova/+/851358 | |
| 16:22:36 | opendevreview | Balazs Gibizer proposed openstack/nova master: Heal missing simple PCI allocation in the resource tracker https://review.opendev.org/c/openstack/nova/+/851359 | |
| 16:22:36 | opendevreview | Balazs Gibizer proposed openstack/nova master: Heal PCI allocation during resize https://review.opendev.org/c/openstack/nova/+/852396 | |
| 16:22:38 | opendevreview | Balazs Gibizer proposed openstack/nova master: Handle PCI dev reconf with allocations https://review.opendev.org/c/openstack/nova/+/852397 | |
| 16:22:38 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI tracking in Placement https://review.opendev.org/c/openstack/nova/+/850468 | |
| 16:22:40 | opendevreview | Balazs Gibizer proposed openstack/nova master: Request filter for PCI in placement https://review.opendev.org/c/openstack/nova/+/852771 | |
| 16:22:55 | sean-k-mooney[m] | just one or two patches :) | |
| 16:23:05 | gibi | yeah just 22 :) | |
| 16:23:10 | gibi | in the main series | |
| 16:23:21 | gibi | but now it is rebased as the double mock fix landed | |
| 16:23:23 | sean-k-mooney[m] | it does make it more digestable | |
| 16:23:31 | sean-k-mooney[m] | cool | |
| 16:23:40 | sean-k-mooney[m] | i think the first few are ready to merge | |
| 16:23:40 | gibi | I checked locally I don't have double mock in the first two patches (the bugfix) | |
| 16:23:57 | sean-k-mooney[m] | ack | |
| 16:24:05 | gibi | I will check the rest locally too, but I have to log off in 10 minutes | |
| 16:33:31 | gibi | OK it seems to be the series is clean from double mocks (at least running it locally) | |
| 17:21:49 | gibi | sean-k-mooney[m]: https://review.opendev.org/c/openstack/nova/+/852295/2 is green now. so if you still around that could unblock some of the patches in the pci seriea | |
| 17:31:22 | sean-k-mooney[m] | yep still here | |
| 17:32:06 | sean-k-mooney[m] | done | |
| 17:32:25 | sean-k-mooney[m] | ill +w some of the later ones shortly | |
| 17:41:58 | sean-k-mooney[m] | for a second there i tought something was broken with how few jobs those are running | |
| 17:42:12 | sean-k-mooney[m] | then i realsed the patch im looking at is test only | |
| 17:42:29 | sean-k-mooney[m] | so it only runs the unit and functional tests not all of tempest | |
| 17:42:40 | sean-k-mooney[m] | well and pep8 and docs | |
| 17:45:27 | sean-k-mooney[m] | gibi: everything before https://review.opendev.org/c/openstack/nova/+/846187/18 should be now making its way through the gate | |
| 17:45:55 | sean-k-mooney[m] | so thats the pci whitelist rename part | |
| 17:46:01 | sean-k-mooney[m] | and the bug fix at the start | |
| 17:47:18 | sean-k-mooney[m] | o/ | |
| 18:06:59 | opendevreview | Merged openstack/nova master: Reproducer for bug 1983753 https://review.opendev.org/c/openstack/nova/+/852295 | |
| 18:25:27 | gibi | sean-k-mooney[m]: thank you | |
| 19:47:07 | opendevreview | Merged openstack/nova master: Update RequestSpec.pci_request for resize https://review.opendev.org/c/openstack/nova/+/852296 | |
| 19:47:14 | opendevreview | Merged openstack/nova master: Poison /sys access via various calls in test https://review.opendev.org/c/openstack/nova/+/844627 | |
| 19:47:21 | opendevreview | Merged openstack/nova master: Add compute restart capability for libvirt func tests https://review.opendev.org/c/openstack/nova/+/850510 | |
| 20:13:43 | opendevreview | Merged openstack/nova master: Rename [pci]passthrough_whitelist to device_spec https://review.opendev.org/c/openstack/nova/+/843834 | |
| 20:13:49 | opendevreview | Merged openstack/nova master: Rename exception.PciConfigInvalidWhitelist to PciConfigInvalidSpec https://review.opendev.org/c/openstack/nova/+/843861 | |
| 20:13:56 | opendevreview | Merged openstack/nova master: Rename whitelist in tests https://review.opendev.org/c/openstack/nova/+/843862 | |
| 21:21:25 | opendevreview | Merged openstack/nova master: update default numa allocation strategy https://review.opendev.org/c/openstack/nova/+/846169 | |
| 23:30:07 | opendevreview | melanie witt proposed openstack/nova master: Fix exception catch when volume mount fails https://review.opendev.org/c/openstack/nova/+/852795 | |
| #openstack-nova - 2022-08-11 | |||
| 01:53:00 | opendevreview | Merged openstack/nova master: Optimize numa_fit_instance_to_host https://review.opendev.org/c/openstack/nova/+/845896 | |
| 01:53:07 | opendevreview | Merged openstack/nova master: Remove workaround for SQLAlchemy < 1.4 https://review.opendev.org/c/openstack/nova/+/852255 | |
| 03:36:13 | opendevreview | Merged openstack/nova master: manager: Reduce unnecessary calls https://review.opendev.org/c/openstack/nova/+/795027 | |
| 03:36:21 | opendevreview | Merged openstack/nova master: objects: Don't use generic 'Field' container https://review.opendev.org/c/openstack/nova/+/738239 | |
| 04:24:53 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix rescue volume-based instance https://review.opendev.org/c/openstack/nova/+/852737 | |
| 08:34:40 | opendevreview | Bence Romsics proposed openstack/nova master: Add limitation to docs about bug 1983570 https://review.opendev.org/c/openstack/nova/+/852168 | |
| 11:20:33 | opendevreview | Merged openstack/nova stable/wallaby: Adapt to SQLAlchemy 1.4 https://review.opendev.org/c/openstack/nova/+/852099 | |
| 17:05:44 | dansmith | melwitt: do we really have no test class for ConductorTaskManager ? | |
| 17:05:58 | dansmith | I see various mocks of it, but... | |
| 17:07:16 | dansmith | sorry, conductor.ComputeTaskManager I mean | |
| 17:16:50 | melwitt | uh dunno. I will look | |
| 17:19:06 | melwitt | this says it's for ComputeTaskManager https://github.com/openstack/nova/blob/master/nova/tests/unit/conductor/test_conductor.py#L2238 | |
| 17:20:06 | melwitt | dansmith: ^ | |
| 17:23:07 | dansmith | ah, yeah, okay, I found that in the greps but it seemed like that was more for tasks/* but yeah I guess maybe that's it | |
| 17:35:21 | opendevreview | Dan Smith proposed openstack/nova master: Unify placement client singleton implementations https://review.opendev.org/c/openstack/nova/+/852900 | |
| 17:35:22 | opendevreview | Dan Smith proposed openstack/nova master: Avoid startup failure for keystone failures https://review.opendev.org/c/openstack/nova/+/852901 | |