| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-08-03 | |||
| 09:45:46 | sean-k-mooney[m] | during shelve offload | |
| 09:45:54 | amorin | yes, everything is actually fine on the compute | |
| 09:46:01 | sean-k-mooney[m] | incidentally shelve offload is where it should be unbound | |
| 09:46:05 | sean-k-mooney[m] | not shelve itslef | |
| 09:46:11 | amorin | it's just that the database (ml2_port_binding) does not reflect what is on the compute | |
| 09:46:24 | amorin | yes | |
| 09:46:30 | sean-k-mooney[m] | by defualt we automaticaly shelve offload with a time out of 0 seconds | |
| 09:46:44 | sean-k-mooney[m] | yep that makes sense | |
| 09:46:49 | amorin | true, we kept this parameter to 0 here | |
| 09:47:34 | sean-k-mooney[m] | personally i would prefer to eventurlaly remove the config option and always just offload but that proably wont happen | |
| 09:48:00 | amorin | what's the purpose of delaying the offload? | |
| 09:48:55 | sean-k-mooney[m] | in rare cases if you unshleve quickly enough it can sometimes be useful to delay. the use case was for bustable instances | |
| 09:49:14 | sean-k-mooney[m] | basically in some cases where shelve/unshele is used to scale in/out | |
| 09:49:28 | sean-k-mooney[m] | its nice to have say a 15min delay incase the load spike | |
| 09:49:42 | sean-k-mooney[m] | as its faster to unshleve if the vms is still in place | |
| 09:50:08 | sean-k-mooney[m] | in partice that was only ever useful for vms without ceph or boot form volume | |
| 09:50:08 | amorin | ok, that's sound like a weird usecase to me | |
| 09:50:19 | amorin | shelve / unshelve is not suppose to happen a quick way | |
| 09:50:31 | sean-k-mooney[m] | well that depends | |
| 09:50:36 | sean-k-mooney[m] | shelve should be very very quick | |
| 09:50:45 | sean-k-mooney[m] | if you are using rbd or boot form volume | |
| 09:50:55 | sean-k-mooney[m] | sicne there is no data to copy | |
| 09:51:18 | sean-k-mooney[m] | but ya it was a pretty niche usecase which is why i would prefer to simplify the code | |
| 09:51:29 | amorin | ack | |
| 09:51:36 | sean-k-mooney[m] | that or remove the config option but make it an api parmater | |
| 09:51:54 | sean-k-mooney[m] | so the user can say delay for up to x time | |
| 09:52:18 | sean-k-mooney[m] | i do not like config driven api behavior shich this currently is | |
| 10:47:27 | opendevreview | Merged openstack/nova master: Remove the PowerVM driver https://review.opendev.org/c/openstack/nova/+/850346 | |
| 11:23:09 | sean-k-mooney[m] | stephenfin: your lines of code stats will never not be negitive ^ | |
| 11:23:57 | gibi | don't encourage him, he will find a way to replace the content of the nova repo with a simple readme file :D | |
| 11:23:58 | sean-k-mooney[m] | cells v1, nova networks xen and power vm. | |
| 11:24:06 | sean-k-mooney[m] | whats next on the list :) | |
| 11:24:44 | sean-k-mooney[m] | oh i for got the docs project :) | |
| 11:25:04 | sean-k-mooney[m] | @gibi: that would be one way to close out all the bugs | |
| 11:25:57 | gibi | what an elegant way :) | |
| 11:25:58 | sean-k-mooney[m] | @gibi speaking of which i marked the custom device_owner bug as invalid | |
| 11:26:17 | gibi | heh, I guessed you would | |
| 11:26:26 | gibi | and I agree | |
| 11:28:58 | gibi | their use case can be solved without the requested change | |
| 11:30:14 | sean-k-mooney[m] | if we wanted to support it we should do it properly as a minor feature with the filtering of events on the neutron side and filtering of port on the nova side so taht they are never stored in our netrowk info cache ectra | |
| 11:30:48 | opendevreview | Merged openstack/nova master: [trivial] Simplify dict get call by removing unused default https://review.opendev.org/c/openstack/nova/+/850450 | |
| 11:37:40 | gibi | sean-k-mooney[m]: I agree | |
| 12:12:33 | gibi | during live migration what triggers the creation of the domain on the dest host? Is it the call to migrateToURI3 from the source host? or nova somehow pre-create a domain on the dest host? | |
| 12:12:46 | sean-k-mooney[m] | yes | |
| 12:13:06 | sean-k-mooney[m] | its created by libvirt as a result of our call to libvirt on the source node | |
| 12:13:11 | gibi | thanks | |
| 12:13:16 | sean-k-mooney[m] | via the migrateToURI3 function | |
| 12:13:39 | gibi | so even though our func test env simulate libvirt it does not simulate that 14:12 < gibi> during live migration what triggers the creation of the domain on the dest host? Is it the call to migrateToURI3 from the source host? or nova somehow pre-create a domain on the dest host? | |
| 12:13:44 | gibi | 14:12 < sean-k-mooney[m]> yes | |
| 12:13:45 | gibi | again | |
| 12:13:47 | gibi | sorry | |
| 12:13:53 | sean-k-mooney[m] | correct | |
| 12:14:04 | sean-k-mooney[m] | we just mock out that call | |
| 12:14:07 | gibi | so even though our func test env simulate libvirt it does not simulate that migrateToURI3 triggers the domain creation on the dest | |
| 12:14:15 | gibi | ack | |
| 12:14:43 | gibi | that explains some func test failures I see with https://review.opendev.org/c/openstack/nova/+/851832/3 | |
| 12:14:47 | sean-k-mooney[m] | we dont really simulate the domins in general in the libvirt fixture | |
| 12:14:58 | sean-k-mooney[m] | at least not for the move ops like that | |
| 12:15:18 | sean-k-mooney[m] | we proably could mock it differntly adn have it do that to be fair | |
| 12:15:38 | gibi | three is some vm tracking in the fixture but yes, that seems to be incomplete | |
| 13:13:54 | opendevreview | Balazs Gibizer proposed openstack/nova master: Do not mutate migration context for rollback_live_migration_at_destination https://review.opendev.org/c/openstack/nova/+/851832 | |
| 13:13:54 | opendevreview | Balazs Gibizer proposed openstack/nova master: Prevent instance.save() under mutated migration context https://review.opendev.org/c/openstack/nova/+/850746 | |
| 13:22:06 | opendevreview | Balazs Gibizer proposed openstack/placement master: Clarify trait filtering in the API doc https://review.opendev.org/c/openstack/placement/+/825501 | |
| 13:25:10 | opendevreview | Balazs Gibizer proposed openstack/nova stable/ussuri: Reproduce bug 1944759 https://review.opendev.org/c/openstack/nova/+/836733 | |
| 13:25:11 | opendevreview | Balazs Gibizer proposed openstack/nova stable/ussuri: Store old_flavor already on source host during resize https://review.opendev.org/c/openstack/nova/+/836734 | |
| 13:31:13 | opendevreview | Balazs Gibizer proposed openstack/nova master: Poison /sys access via various calls in test https://review.opendev.org/c/openstack/nova/+/844627 | |
| 13:31:14 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add compute restart capability for libvirt func tests https://review.opendev.org/c/openstack/nova/+/850510 | |
| 13:31:14 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename [pci]passthrough_whitelist to device_spec https://review.opendev.org/c/openstack/nova/+/843834 | |
| 13:31:15 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename exception.PciConfigInvalidWhitelist to PciConfigInvalidSpec https://review.opendev.org/c/openstack/nova/+/843861 | |
| 13:31:15 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename whitelist in tests https://review.opendev.org/c/openstack/nova/+/843862 | |
| 13:31:16 | opendevreview | Balazs Gibizer proposed openstack/nova master: Basics for PCI Placement reporting https://review.opendev.org/c/openstack/nova/+/846187 | |
| 13:31:16 | opendevreview | Balazs Gibizer proposed openstack/nova master: Extend device_spec with resource_class and traits https://review.opendev.org/c/openstack/nova/+/846218 | |
| 13:31:17 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject PCI dependent device config https://review.opendev.org/c/openstack/nova/+/846435 | |
| 13:31:18 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject mixed VF rc and trait config https://review.opendev.org/c/openstack/nova/+/846436 | |
| 13:31:18 | opendevreview | Balazs Gibizer proposed openstack/nova master: Ignore PCI devs with physical_network tag https://review.opendev.org/c/openstack/nova/+/846219 | |
| 13:31:20 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject devname based device_spec config https://review.opendev.org/c/openstack/nova/+/846466 | |
| 13:31:20 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support [pci]device_spec reconfiguration https://review.opendev.org/c/openstack/nova/+/846470 | |
| 13:31:22 | opendevreview | Balazs Gibizer proposed openstack/nova master: Stop if tracking is disable after it was enabled before https://review.opendev.org/c/openstack/nova/+/847009 | |
| 13:31:22 | opendevreview | Balazs Gibizer proposed openstack/nova master: Move provider_tree RP creation to PciResourceProvider https://review.opendev.org/c/openstack/nova/+/850546 | |
| 13:31:24 | opendevreview | Balazs Gibizer proposed openstack/nova master: Retry /reshape at provider generation conflict https://review.opendev.org/c/openstack/nova/+/851358 | |
| 13:31:24 | opendevreview | Balazs Gibizer proposed openstack/nova master: Heal missing PCI allocation in the resource tracker https://review.opendev.org/c/openstack/nova/+/851359 | |
| 13:31:26 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI tracking in Placement https://review.opendev.org/c/openstack/nova/+/850468 | |
| 13:38:29 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add more test coverage for devname base dev spec https://review.opendev.org/c/openstack/nova/+/844625 | |
| 13:38:29 | opendevreview | Balazs Gibizer proposed openstack/nova master: Extra tests for remote managed dev spec https://review.opendev.org/c/openstack/nova/+/844626 | |
| 13:38:30 | opendevreview | Balazs Gibizer proposed openstack/nova master: Unparent PciDeviceSpec from PciAddressSpec https://review.opendev.org/c/openstack/nova/+/844491 | |
| 13:38:30 | opendevreview | Balazs Gibizer proposed openstack/nova master: Fix PciAddressSpec descendants to call super.__init__ https://review.opendev.org/c/openstack/nova/+/844565 | |
| 13:38:31 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove dead code from PhysicalPciAddress https://review.opendev.org/c/openstack/nova/+/844628 | |
| 13:38:31 | opendevreview | Balazs Gibizer proposed openstack/nova master: Clean up mapping input to address spec types https://review.opendev.org/c/openstack/nova/+/845765 | |
| 13:38:32 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove unused PF checking from get_function_by_ifname https://review.opendev.org/c/openstack/nova/+/845775 | |
| 13:38:32 | opendevreview | Balazs Gibizer proposed openstack/nova master: Fix type annotation of pci.Whitelist class https://review.opendev.org/c/openstack/nova/+/845780 | |
| 13:38:33 | opendevreview | Balazs Gibizer proposed openstack/nova master: Move __str__ to the PciAddressSpec base class https://review.opendev.org/c/openstack/nova/+/845781 | |
| 13:39:39 | gibi | pheww rebased out the pci serieses from the merge conflict | |
| 14:41:25 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reproducer for bug 1982497 https://review.opendev.org/c/openstack/nova/+/850672 | |
| 14:41:25 | opendevreview | Balazs Gibizer proposed openstack/nova master: Do not mutate migration context for rollback_live_migration_at_destination https://review.opendev.org/c/openstack/nova/+/851832 | |
| 14:41:26 | opendevreview | Balazs Gibizer proposed openstack/nova master: Prevent instance.save() under mutated migration context https://review.opendev.org/c/openstack/nova/+/850746 | |
| 15:29:32 | melwitt | gibi: ack, will look | |
| 15:31:13 | gibi | thanks | |
| 15:51:19 | sean-k-mooney[m] | gibi are you going with dans suggetion to just remove all the save or proceeding with the decorator for now | |
| 15:51:31 | sean-k-mooney[m] | or both | |
| 15:51:50 | sean-k-mooney[m] | backport decorator adn then remove saves on master only? | |