| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-08-03 | |||
| 12:13:45 | gibi | again | |
| 12:13:47 | gibi | sorry | |
| 12:13:53 | sean-k-mooney[m] | correct | |
| 12:14:04 | sean-k-mooney[m] | we just mock out that call | |
| 12:14:07 | gibi | so even though our func test env simulate libvirt it does not simulate that migrateToURI3 triggers the domain creation on the dest | |
| 12:14:15 | gibi | ack | |
| 12:14:43 | gibi | that explains some func test failures I see with https://review.opendev.org/c/openstack/nova/+/851832/3 | |
| 12:14:47 | sean-k-mooney[m] | we dont really simulate the domins in general in the libvirt fixture | |
| 12:14:58 | sean-k-mooney[m] | at least not for the move ops like that | |
| 12:15:18 | sean-k-mooney[m] | we proably could mock it differntly adn have it do that to be fair | |
| 12:15:38 | gibi | three is some vm tracking in the fixture but yes, that seems to be incomplete | |
| 13:13:54 | opendevreview | Balazs Gibizer proposed openstack/nova master: Do not mutate migration context for rollback_live_migration_at_destination https://review.opendev.org/c/openstack/nova/+/851832 | |
| 13:13:54 | opendevreview | Balazs Gibizer proposed openstack/nova master: Prevent instance.save() under mutated migration context https://review.opendev.org/c/openstack/nova/+/850746 | |
| 13:22:06 | opendevreview | Balazs Gibizer proposed openstack/placement master: Clarify trait filtering in the API doc https://review.opendev.org/c/openstack/placement/+/825501 | |
| 13:25:10 | opendevreview | Balazs Gibizer proposed openstack/nova stable/ussuri: Reproduce bug 1944759 https://review.opendev.org/c/openstack/nova/+/836733 | |
| 13:25:11 | opendevreview | Balazs Gibizer proposed openstack/nova stable/ussuri: Store old_flavor already on source host during resize https://review.opendev.org/c/openstack/nova/+/836734 | |
| 13:31:13 | opendevreview | Balazs Gibizer proposed openstack/nova master: Poison /sys access via various calls in test https://review.opendev.org/c/openstack/nova/+/844627 | |
| 13:31:14 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add compute restart capability for libvirt func tests https://review.opendev.org/c/openstack/nova/+/850510 | |
| 13:31:14 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename [pci]passthrough_whitelist to device_spec https://review.opendev.org/c/openstack/nova/+/843834 | |
| 13:31:15 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename exception.PciConfigInvalidWhitelist to PciConfigInvalidSpec https://review.opendev.org/c/openstack/nova/+/843861 | |
| 13:31:15 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename whitelist in tests https://review.opendev.org/c/openstack/nova/+/843862 | |
| 13:31:16 | opendevreview | Balazs Gibizer proposed openstack/nova master: Basics for PCI Placement reporting https://review.opendev.org/c/openstack/nova/+/846187 | |
| 13:31:16 | opendevreview | Balazs Gibizer proposed openstack/nova master: Extend device_spec with resource_class and traits https://review.opendev.org/c/openstack/nova/+/846218 | |
| 13:31:17 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject PCI dependent device config https://review.opendev.org/c/openstack/nova/+/846435 | |
| 13:31:18 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject mixed VF rc and trait config https://review.opendev.org/c/openstack/nova/+/846436 | |
| 13:31:18 | opendevreview | Balazs Gibizer proposed openstack/nova master: Ignore PCI devs with physical_network tag https://review.opendev.org/c/openstack/nova/+/846219 | |
| 13:31:20 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject devname based device_spec config https://review.opendev.org/c/openstack/nova/+/846466 | |
| 13:31:20 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support [pci]device_spec reconfiguration https://review.opendev.org/c/openstack/nova/+/846470 | |
| 13:31:22 | opendevreview | Balazs Gibizer proposed openstack/nova master: Stop if tracking is disable after it was enabled before https://review.opendev.org/c/openstack/nova/+/847009 | |
| 13:31:22 | opendevreview | Balazs Gibizer proposed openstack/nova master: Move provider_tree RP creation to PciResourceProvider https://review.opendev.org/c/openstack/nova/+/850546 | |
| 13:31:24 | opendevreview | Balazs Gibizer proposed openstack/nova master: Retry /reshape at provider generation conflict https://review.opendev.org/c/openstack/nova/+/851358 | |
| 13:31:24 | opendevreview | Balazs Gibizer proposed openstack/nova master: Heal missing PCI allocation in the resource tracker https://review.opendev.org/c/openstack/nova/+/851359 | |
| 13:31:26 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI tracking in Placement https://review.opendev.org/c/openstack/nova/+/850468 | |
| 13:38:29 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add more test coverage for devname base dev spec https://review.opendev.org/c/openstack/nova/+/844625 | |
| 13:38:29 | opendevreview | Balazs Gibizer proposed openstack/nova master: Extra tests for remote managed dev spec https://review.opendev.org/c/openstack/nova/+/844626 | |
| 13:38:30 | opendevreview | Balazs Gibizer proposed openstack/nova master: Unparent PciDeviceSpec from PciAddressSpec https://review.opendev.org/c/openstack/nova/+/844491 | |
| 13:38:30 | opendevreview | Balazs Gibizer proposed openstack/nova master: Fix PciAddressSpec descendants to call super.__init__ https://review.opendev.org/c/openstack/nova/+/844565 | |
| 13:38:31 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove dead code from PhysicalPciAddress https://review.opendev.org/c/openstack/nova/+/844628 | |
| 13:38:31 | opendevreview | Balazs Gibizer proposed openstack/nova master: Clean up mapping input to address spec types https://review.opendev.org/c/openstack/nova/+/845765 | |
| 13:38:32 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove unused PF checking from get_function_by_ifname https://review.opendev.org/c/openstack/nova/+/845775 | |
| 13:38:32 | opendevreview | Balazs Gibizer proposed openstack/nova master: Fix type annotation of pci.Whitelist class https://review.opendev.org/c/openstack/nova/+/845780 | |
| 13:38:33 | opendevreview | Balazs Gibizer proposed openstack/nova master: Move __str__ to the PciAddressSpec base class https://review.opendev.org/c/openstack/nova/+/845781 | |
| 13:39:39 | gibi | pheww rebased out the pci serieses from the merge conflict | |
| 14:41:25 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reproducer for bug 1982497 https://review.opendev.org/c/openstack/nova/+/850672 | |
| 14:41:25 | opendevreview | Balazs Gibizer proposed openstack/nova master: Do not mutate migration context for rollback_live_migration_at_destination https://review.opendev.org/c/openstack/nova/+/851832 | |
| 14:41:26 | opendevreview | Balazs Gibizer proposed openstack/nova master: Prevent instance.save() under mutated migration context https://review.opendev.org/c/openstack/nova/+/850746 | |
| 15:29:32 | melwitt | gibi: ack, will look | |
| 15:31:13 | gibi | thanks | |
| 15:51:19 | sean-k-mooney[m] | gibi are you going with dans suggetion to just remove all the save or proceeding with the decorator for now | |
| 15:51:31 | sean-k-mooney[m] | or both | |
| 15:51:50 | sean-k-mooney[m] | backport decorator adn then remove saves on master only? | |
| 15:51:53 | gibi | sean-k-mooney[m]: I proposed a decorator now and fixed the rebuild case by hand with apply and revert | |
| 15:52:22 | sean-k-mooney[m] | ok | |
| 15:52:34 | gibi | I feel that changing the contract between the compute manager and the virt drivers is a bit much for me for now | |
| 15:52:49 | sean-k-mooney[m] | ack | |
| 15:52:52 | gibi | the decorator will catch all the problematic cases | |
| 15:53:16 | gibi | and we have two of those one that is fixed by the bugfix and the other was as simple one with rebuild | |
| 15:53:20 | sean-k-mooney[m] | ill review tomorrow but i assume you are just logging the issue for now and not saving | |
| 15:53:29 | gibi | wait | |
| 15:53:38 | gibi | so for the rollback live migration | |
| 15:53:49 | gibi | I was able to remove the mutated migration context and keep the save | |
| 15:54:05 | sean-k-mooney[m] | ok | |
| 15:54:15 | gibi | the vpmem cleanup that needed the mutation contex can be done based on the domain and not based on the instance.resources storage | |
| 15:54:30 | gibi | this solves our current bug I believe | |
| 15:54:51 | gibi | the decorator is added in a followup to catch new cases by raising at save() if it is called under a mutated context | |
| 15:55:10 | gibi | and that revealed a second place where we do this, at rebuild | |
| 15:55:17 | gibi | but that was fairly simple to fix | |
| 15:56:49 | sean-k-mooney[m] | oh ok so you have resolved the current incorrect uses | |
| 15:56:55 | sean-k-mooney[m] | and new incorrect uses will raise | |
| 15:56:55 | gibi | yes | |
| 15:56:57 | gibi | yes | |
| 15:57:01 | sean-k-mooney[m] | so we wont merge it | |
| 15:57:03 | sean-k-mooney[m] | ok | |
| 15:57:19 | sean-k-mooney[m] | that a liit more context then im prepared to digest to review today | |
| 15:57:27 | sean-k-mooney[m] | but ill look back on this tomorrow | |
| 15:58:07 | gibi | ack | |
| 15:58:37 | gibi | artom and dansmith are also on it to keep me honest :) | |
| 15:58:49 | dansmith | yeah will try to look a bit later | |
| 15:59:46 | sean-k-mooney[m] | ok if dansmith and melwitt are able to review it i would prefer not to add another context switch to my current list | |
| 16:00:01 | sean-k-mooney[m] | but if this is urgent i can | |
| 16:01:55 | melwitt | sean-k-mooney[m]: sure, I can look | |
| 16:01:55 | gibi | I don't think that it is super urgent | |
| 16:03:14 | gibi | thank you all | |
| 16:37:54 | frickler | dansmith: melwitt: could you also have a look at https://review.opendev.org/c/openstack/nova/+/851909 pls? would be good to be able to have wider testing of latest sdk, currently this is blocking getting it into u-c | |
| 16:39:38 | dansmith | hmm, I guess that's needed because of when we talk to placement | |
| 16:42:15 | dansmith | frickler: +W | |
| 16:50:50 | frickler | thx | |
| 17:26:45 | opendevreview | Jan Hartkopf proposed openstack/nova master: add support for updating server's user_data https://review.opendev.org/c/openstack/nova/+/816157 | |
| 17:44:34 | opendevreview | Merged openstack/placement master: Func test for os-traits and os-resource-classes lib sync https://review.opendev.org/c/openstack/placement/+/851966 | |
| 17:44:38 | opendevreview | Merged openstack/nova master: Fix mocking SafeConnectedTestCase https://review.opendev.org/c/openstack/nova/+/851909 | |
| 17:49:01 | stephenfin | gibi: Is that PCI series ready for review? | |
| 18:59:30 | spatel | does nova support sound adaptor ? | |
| 19:19:55 | wolsen[m] | gibi: bauzas: sorry I've been slow to respond on that patch set (the mdev devices libvirt 7.x one - https://review.opendev.org/c/openstack/nova/+/838976) - I 'm reading the backscroll now and see you commented that you need something for me. I'm jugging various things at the moment but will review feedback shortly | |
| 19:21:21 | wolsen[m] | looks like an update around the FUP patch that bauzas had posted | |
| #openstack-nova - 2022-08-04 | |||
| 03:12:23 | opendevreview | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/851337 | |
| 06:56:21 | opendevreview | Brett Milford proposed openstack/nova master: Handle "no RAM info was set" migration case https://review.opendev.org/c/openstack/nova/+/852002 | |
| 07:15:14 | gibi | stephenfin: re PCI series: I still had issues after the unittest.mock and double mocking change. But the content is ready up until https://review.opendev.org/c/openstack/nova/+/850546 . The rest top of that has TODOs in the commit message | |
| 07:15:57 | gibi | wolsen[m]: yes, I think only the FUP patch needs update the rest is OK to land | |
| 07:16:50 | gibi | stephenfin: I probably need to change the first patch in the series https://review.opendev.org/c/openstack/nova/+/844627 due to the double mocking stuff | |
| 07:26:39 | ignazio | Hello, I have very slow performances in live migration when instances using memory heavily (for example java application servers). I used converce mode in nova.conf and it does not seem to solve. If I migrate an instance with 8GB ram it takes more than 20 minutes. If I migrate again it takes few seconds. Do you think it is related to memory access ? | |