| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-07-20 | |||
| 09:29:06 | gibi | I haven't checked the secondary thread there might be others there too | |
| 09:29:08 | sean-k-mooney | ya that is the one | |
| 09:29:17 | sean-k-mooney | i just think that woudl be nice ot merge ahead of the rest | |
| 09:29:26 | gibi | let me quckly resping the series to remove "q" :D | |
| 09:29:40 | sean-k-mooney | oh its novs git log | |
| 09:29:53 | sean-k-mooney | fun that is nice an recursvice | |
| 09:30:15 | sean-k-mooney | i never do | |
| 09:30:31 | sean-k-mooney | fable has it that back in the dark dark days of nova | |
| 09:31:07 | sean-k-mooney | someone added the entire ddwrt image or souce to novas git repo | |
| 09:31:11 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename [pci]passthrough_whitelist to device_spec https://review.opendev.org/c/openstack/nova/+/843834 | |
| 09:31:12 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename exception.PciConfigInvalidWhitelist to PciConfigInvalidSpec https://review.opendev.org/c/openstack/nova/+/843861 | |
| 09:31:12 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename whitelist in tests https://review.opendev.org/c/openstack/nova/+/843862 | |
| 09:31:13 | opendevreview | Balazs Gibizer proposed openstack/nova master: Basics for PCI Placement reporting https://review.opendev.org/c/openstack/nova/+/846187 | |
| 09:31:13 | opendevreview | Balazs Gibizer proposed openstack/nova master: Extend device_spec with resource_class and traits https://review.opendev.org/c/openstack/nova/+/846218 | |
| 09:31:14 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject mixed VF rc and trait config https://review.opendev.org/c/openstack/nova/+/846436 | |
| 09:31:14 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject PCI dependent device config https://review.opendev.org/c/openstack/nova/+/846435 | |
| 09:31:15 | opendevreview | Balazs Gibizer proposed openstack/nova master: Ignore PCI devs with physical_network tag https://review.opendev.org/c/openstack/nova/+/846219 | |
| 09:31:16 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject devname based device_spec config https://review.opendev.org/c/openstack/nova/+/846466 | |
| 09:31:16 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support [pci]device_spec reconfiguration https://review.opendev.org/c/openstack/nova/+/846470 | |
| 09:31:18 | opendevreview | Balazs Gibizer proposed openstack/nova master: Stop if tracking is disable after it was enabled before https://review.opendev.org/c/openstack/nova/+/847009 | |
| 09:31:18 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI tracking in Placement https://review.opendev.org/c/openstack/nova/+/850468 | |
| 09:31:28 | gibi | jeah I heard that story :) | |
| 09:31:52 | sean-k-mooney | jay should me the commit at one point | |
| 09:32:10 | sean-k-mooney | i think it has been purged form the amin repo but still exists in gerrits copy | |
| 09:32:19 | sean-k-mooney | or did at one point | |
| 09:32:41 | gibi | "q" is removed. hope he will not be mad about it :) | |
| 09:33:04 | sean-k-mooney | but where will we get all the fancy toys now | |
| 09:33:19 | gibi | we need to wait and evolve... | |
| 09:38:46 | sean-k-mooney | im going to read your comment in email and respond to them then ill go back and do a review form the start | |
| 09:40:29 | gibi | thanks | |
| 10:07:35 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Attach Manila shares via virtiofs (objects) https://review.opendev.org/c/openstack/nova/+/839401 | |
| 10:07:35 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Attach Manila shares via virtiofs (db) https://review.opendev.org/c/openstack/nova/+/831193 | |
| 10:07:36 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | |
| 10:07:36 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Attach Manila shares via virtiofs (drivers) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 10:07:37 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Attach Manila shares via virtiofs (api) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 10:07:37 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Bump compute version and check shares support https://review.opendev.org/c/openstack/nova/+/850499 | |
| 10:07:38 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | |
| 10:07:38 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| 10:29:39 | opendevreview | Stephen Finucane proposed openstack/placement master: docs: Unset 'language' https://review.opendev.org/c/openstack/placement/+/850505 | |
| 10:52:23 | bauzas | Uggla: made a few comment nits on your unshelve patch | |
| 10:52:44 | bauzas | if you have time to write UTs, would be appreciated before you respin https://review.opendev.org/c/openstack/nova/+/831507/17 | |
| 10:53:12 | bauzas | but if you prefer, I can accept as-it-is and just update https://review.opendev.org/c/openstack/nova/+/845897 | |
| 10:53:31 | bauzas | you could update the compute part UTs in a FUP | |
| 10:53:37 | bauzas | (follow-up patch) | |
| 11:22:05 | sean-k-mooney | gibi: ok ill loop back to review them properly later but responed to the remaining open comments i reluctanlty agree whith why you did not put the fucntion in the pcidevice object | |
| 11:22:38 | gibi | sean-k-mooney: I will do a quick spike on the refactor of PciDeviceSpec to PciDevice but I'm affraid it will be a can of worms | |
| 11:23:17 | sean-k-mooney | leave it for now | |
| 11:23:27 | sean-k-mooney | we can reevaluate in A | |
| 11:24:09 | sean-k-mooney | it would requrie converting the dicts we get rom the hypervior into the pci objects | |
| 11:24:26 | sean-k-mooney | and having the tracker add the tag info ectra to them | |
| 11:24:37 | sean-k-mooney | based on the pci entry they matched | |
| 11:24:43 | sean-k-mooney | so let not go there for now | |
| 11:27:26 | sean-k-mooney | stephenfin: care to re review https://review.opendev.org/c/openstack/nova-specs/+/849488/5 | |
| 11:28:31 | stephenfin | Sure | |
| 11:30:00 | gibi | sean-k-mooney: ack | |
| 11:43:04 | gibi | incoming... | |
| 11:43:09 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename [pci]passthrough_whitelist to device_spec https://review.opendev.org/c/openstack/nova/+/843834 | |
| 11:43:10 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename exception.PciConfigInvalidWhitelist to PciConfigInvalidSpec https://review.opendev.org/c/openstack/nova/+/843861 | |
| 11:43:10 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename whitelist in tests https://review.opendev.org/c/openstack/nova/+/843862 | |
| 11:43:11 | opendevreview | Balazs Gibizer proposed openstack/nova master: Basics for PCI Placement reporting https://review.opendev.org/c/openstack/nova/+/846187 | |
| 11:43:11 | opendevreview | Balazs Gibizer proposed openstack/nova master: Extend device_spec with resource_class and traits https://review.opendev.org/c/openstack/nova/+/846218 | |
| 11:43:12 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject PCI dependent device config https://review.opendev.org/c/openstack/nova/+/846435 | |
| 11:43:12 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject mixed VF rc and trait config https://review.opendev.org/c/openstack/nova/+/846436 | |
| 11:43:13 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject devname based device_spec config https://review.opendev.org/c/openstack/nova/+/846466 | |
| 11:43:13 | opendevreview | Balazs Gibizer proposed openstack/nova master: Ignore PCI devs with physical_network tag https://review.opendev.org/c/openstack/nova/+/846219 | |
| 11:43:14 | opendevreview | Balazs Gibizer proposed openstack/nova master: Stop if tracking is disable after it was enabled before https://review.opendev.org/c/openstack/nova/+/847009 | |
| 11:43:14 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support [pci]device_spec reconfiguration https://review.opendev.org/c/openstack/nova/+/846470 | |
| 11:43:16 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI tracking in Placement https://review.opendev.org/c/openstack/nova/+/850468 | |
| 11:43:16 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add compute restart capability for libvirt func tests https://review.opendev.org/c/openstack/nova/+/850510 | |
| 11:44:06 | gibi | sean-k-mooney: I moved the libvirt func test compute restart change to the beggining | |
| 11:44:45 | gibi | it become a bit bigger as I found some existing tests using various local methods to implement the restart | |
| 11:44:50 | gibi | so I had to move them to the new function | |
| 11:54:24 | Uggla | bauzas, could we have a really quick chat beginning of the afternoon, just to be clear about what you expect. | |
| 11:55:32 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support [pci]device_spec reconfiguration https://review.opendev.org/c/openstack/nova/+/846470 | |
| 11:55:33 | opendevreview | Balazs Gibizer proposed openstack/nova master: Stop if tracking is disable after it was enabled before https://review.opendev.org/c/openstack/nova/+/847009 | |
| 11:55:33 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI tracking in Placement https://review.opendev.org/c/openstack/nova/+/850468 | |
| 11:57:01 | sean-k-mooney | gibi: thats why i wanted it to be a sperate change form the serise i had obseved some old and new tests that did it | |
| 11:57:15 | sean-k-mooney | and having one implemenation is good | |
| 11:57:18 | gibi | yepp | |
| 11:57:22 | gibi | good suggestion | |
| 11:58:13 | sean-k-mooney | ok i have a downstream call in a minute and have not had coffee thismoring eventhough fyera work me up 2 hours before i normally do | |
| 11:58:35 | sean-k-mooney | so coffee -> meetting -> then code review :) | |
| 11:58:44 | gibi | sean-k-mooney: no worries, I have things to do :) | |
| 12:02:48 | bauzas | Uggla: in 10 mins if you can | |
| 12:03:51 | Uggla | bauzas, no pb, just ping me when you can. | |
| 12:20:04 | bauzas | Uggla: ack, doing something first | |
| 12:30:01 | bauzas | Uggla : https://meet.google.com/dji-oznv-cfz | |
| 12:30:08 | bauzas | (people can join if they wish) | |
| 12:30:17 | Uggla | bauzas, ok joining | |
| 13:42:21 | ricolin | sean-k-mooney: regarding https://review.opendev.org/c/openstack/nova/+/830646/12/nova/tests/unit/virt/libvirt/test_driver.py#8651 | |
| 13:42:40 | ricolin | you mean only q35 and AArch64 are acceptable, and we will raise errors when providing iommu with all other arch? | |
| 13:43:24 | sean-k-mooney | yes | |
| 13:43:36 | sean-k-mooney | we cannot ignore a request for a feature | |
| 13:43:52 | sean-k-mooney | if the arch does not supprot it we must reject teh boot request | |
| 13:44:20 | sean-k-mooney | ricolin: this should not actully get that far really | |
| 13:44:31 | sean-k-mooney | the reason is that on those plathform we will not be reporting the traits | |
| 13:44:42 | sean-k-mooney | so we shoudl not get as far as generating the xml | |
| 13:45:21 | sean-k-mooney | but the current logic is incorrect we shoudl be raising an error if for some reason we are on a ppc64 host and we manage to get to this point in the virt driver | |
| 13:48:08 | sean-k-mooney | ricolin: the contract that nova provides is if you ask for a feature we will either fail to find a host that can provide that and set the instnace to error or we will boot a vm with that feature enabled | |
| 13:48:24 | sean-k-mooney | ricolin: so for this feature you need to provide that same guarentee | |