| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-07-19 | |||
| 19:50:04 | sean-k-mooney | im also kind of burnt out on this but i can prepare a draft or at least link to this in the spec | |
| #openstack-nova - 2022-07-20 | |||
| 02:14:28 | opendevreview | melanie witt proposed openstack/nova master: imagebackend: default by_name image_type to config correctly https://review.opendev.org/c/openstack/nova/+/826526 | |
| 02:14:29 | opendevreview | melanie witt proposed openstack/nova master: image_meta: Add ephemeral encryption properties https://review.opendev.org/c/openstack/nova/+/760454 | |
| 02:14:29 | opendevreview | melanie witt proposed openstack/nova master: BlockDeviceMapping: Add encryption fields https://review.opendev.org/c/openstack/nova/+/760453 | |
| 02:14:30 | opendevreview | melanie witt proposed openstack/nova master: compute: Update bdms with ephemeral encryption details when requested https://review.opendev.org/c/openstack/nova/+/764486 | |
| 02:14:30 | opendevreview | melanie witt proposed openstack/nova master: BlockDeviceMapping: Add is_local property https://review.opendev.org/c/openstack/nova/+/764485 | |
| 02:14:31 | opendevreview | melanie witt proposed openstack/nova master: virt: Add ephemeral encryption flag https://review.opendev.org/c/openstack/nova/+/760455 | |
| 02:14:31 | opendevreview | melanie witt proposed openstack/nova master: scheduler: Add an ephemeral encryption pre filter https://review.opendev.org/c/openstack/nova/+/760456 | |
| 02:14:32 | opendevreview | melanie witt proposed openstack/nova master: block_device: Add DriverImageBlockDevice to block_device_info https://review.opendev.org/c/openstack/nova/+/826527 | |
| 02:14:32 | opendevreview | melanie witt proposed openstack/nova master: block_device: Add encryption attributes to image and ephemeral disks https://review.opendev.org/c/openstack/nova/+/826528 | |
| 02:14:34 | opendevreview | melanie witt proposed openstack/nova master: virt: Add block_device_info helper to find encrypted disks https://review.opendev.org/c/openstack/nova/+/826529 | |
| 02:14:34 | opendevreview | melanie witt proposed openstack/nova master: blockinfo: Add encryption details to the disk_info mappings when provided https://review.opendev.org/c/openstack/nova/+/772272 | |
| 02:14:36 | opendevreview | melanie witt proposed openstack/nova master: imagebackend: Add disk_info_mapping as an optional attribute of Image https://review.opendev.org/c/openstack/nova/+/826530 | |
| 02:14:36 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Consolidate create_cow_image and create_image https://review.opendev.org/c/openstack/nova/+/846246 | |
| 02:14:38 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Add encryption support to qemu-img create command https://review.opendev.org/c/openstack/nova/+/826752 | |
| 02:14:38 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Report ephemeral encryption traits based on imagebackend https://review.opendev.org/c/openstack/nova/+/826753 | |
| 02:14:40 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Configure and teardown ephemeral encryption secrets https://review.opendev.org/c/openstack/nova/+/826754 | |
| 03:49:20 | opendevreview | melanie witt proposed openstack/nova master: Workaround qemu query-migrate issue during live migration https://review.opendev.org/c/openstack/nova/+/842687 | |
| 05:10:45 | opendevreview | liuhuajie proposed openstack/nova master: Remove None for get method, the default value is None https://review.opendev.org/c/openstack/nova/+/850450 | |
| 07:09:28 | opendevreview | Manuel Bentele proposed openstack/nova-specs master: Add configuration options to set SPICE compression settings https://review.opendev.org/c/openstack/nova-specs/+/849488 | |
| 07:27:50 | opendevreview | Manuel Bentele proposed openstack/nova master: libvirt: Add configuration options to set SPICE compression settings https://review.opendev.org/c/openstack/nova/+/828675 | |
| 08:06:05 | gibi | o/ | |
| 08:18:22 | bauzas | \o | |
| 08:19:40 | Uggla | o/ | |
| 08:28:50 | kashyap | A patch on SPICE, interesting ... upstream SPICE seems almost inactive | |
| 08:30:31 | kashyap | s/almost inactive/dead/ | |
| 08:36:39 | gibi | sean-k-mooney: you probably saw last evening I pushed an update to the pci tracking series. I fixed most of your comments but some is left open with an answer from me, like the owner trait, or the PciDeviceSpec move to PciDevice. I put my oppinonon about those into the reviews | |
| 08:37:14 | sean-k-mooney | ack i did not but ill try to take a look at them today | |
| 08:37:14 | gibi | I promised couple of refactors on top. I will do those now | |
| 08:37:25 | sean-k-mooney | cool | |
| 08:37:54 | gibi | and I noticed a strange functional failure I have to track down (probably a leaked global state somewhere) | |
| 09:26:21 | sean-k-mooney | gibi: is https://review.opendev.org/c/openstack/nova/+/843834 the first patch in the serise | |
| 09:26:32 | sean-k-mooney | i think so but i know that it splits latter | |
| 09:27:07 | gibi | yes, that is the start | |
| 09:27:22 | gibi | I did not update the secondary thread of patches | |
| 09:27:25 | gibi | just the main one | |
| 09:27:35 | sean-k-mooney | cool ill grab coffee and make my way throuhg it | |
| 09:27:53 | gibi | ohh shit, I have an extra file added to that patch :D | |
| 09:27:55 | sean-k-mooney | in the secondary traead there was one change i suggested pulling out an merging first | |
| 09:28:32 | sean-k-mooney | ah q | |
| 09:28:38 | sean-k-mooney | a very good file in deed | |
| 09:28:53 | gibi | there was the restart compute func test enhancement that you asked to split out I will do that todayt | |
| 09:29:06 | gibi | I haven't checked the secondary thread there might be others there too | |
| 09:29:08 | sean-k-mooney | ya that is the one | |
| 09:29:17 | sean-k-mooney | i just think that woudl be nice ot merge ahead of the rest | |
| 09:29:26 | gibi | let me quckly resping the series to remove "q" :D | |
| 09:29:40 | sean-k-mooney | oh its novs git log | |
| 09:29:53 | sean-k-mooney | fun that is nice an recursvice | |
| 09:30:15 | sean-k-mooney | i never do | |
| 09:30:31 | sean-k-mooney | fable has it that back in the dark dark days of nova | |
| 09:31:07 | sean-k-mooney | someone added the entire ddwrt image or souce to novas git repo | |
| 09:31:11 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename [pci]passthrough_whitelist to device_spec https://review.opendev.org/c/openstack/nova/+/843834 | |
| 09:31:12 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename exception.PciConfigInvalidWhitelist to PciConfigInvalidSpec https://review.opendev.org/c/openstack/nova/+/843861 | |
| 09:31:12 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename whitelist in tests https://review.opendev.org/c/openstack/nova/+/843862 | |
| 09:31:13 | opendevreview | Balazs Gibizer proposed openstack/nova master: Basics for PCI Placement reporting https://review.opendev.org/c/openstack/nova/+/846187 | |
| 09:31:13 | opendevreview | Balazs Gibizer proposed openstack/nova master: Extend device_spec with resource_class and traits https://review.opendev.org/c/openstack/nova/+/846218 | |
| 09:31:14 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject mixed VF rc and trait config https://review.opendev.org/c/openstack/nova/+/846436 | |
| 09:31:14 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject PCI dependent device config https://review.opendev.org/c/openstack/nova/+/846435 | |
| 09:31:15 | opendevreview | Balazs Gibizer proposed openstack/nova master: Ignore PCI devs with physical_network tag https://review.opendev.org/c/openstack/nova/+/846219 | |
| 09:31:16 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reject devname based device_spec config https://review.opendev.org/c/openstack/nova/+/846466 | |
| 09:31:16 | opendevreview | Balazs Gibizer proposed openstack/nova master: Support [pci]device_spec reconfiguration https://review.opendev.org/c/openstack/nova/+/846470 | |
| 09:31:18 | opendevreview | Balazs Gibizer proposed openstack/nova master: Stop if tracking is disable after it was enabled before https://review.opendev.org/c/openstack/nova/+/847009 | |
| 09:31:18 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow enabling PCI tracking in Placement https://review.opendev.org/c/openstack/nova/+/850468 | |
| 09:31:28 | gibi | jeah I heard that story :) | |
| 09:31:52 | sean-k-mooney | jay should me the commit at one point | |
| 09:32:10 | sean-k-mooney | i think it has been purged form the amin repo but still exists in gerrits copy | |
| 09:32:19 | sean-k-mooney | or did at one point | |
| 09:32:41 | gibi | "q" is removed. hope he will not be mad about it :) | |
| 09:33:04 | sean-k-mooney | but where will we get all the fancy toys now | |
| 09:33:19 | gibi | we need to wait and evolve... | |
| 09:38:46 | sean-k-mooney | im going to read your comment in email and respond to them then ill go back and do a review form the start | |
| 09:40:29 | gibi | thanks | |
| 10:07:35 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Attach Manila shares via virtiofs (objects) https://review.opendev.org/c/openstack/nova/+/839401 | |
| 10:07:35 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Attach Manila shares via virtiofs (db) https://review.opendev.org/c/openstack/nova/+/831193 | |
| 10:07:36 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | |
| 10:07:36 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Attach Manila shares via virtiofs (drivers) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 10:07:37 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Attach Manila shares via virtiofs (api) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 10:07:37 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Bump compute version and check shares support https://review.opendev.org/c/openstack/nova/+/850499 | |
| 10:07:38 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | |
| 10:07:38 | opendevreview | ribaudr proposed openstack/nova master: [WIP] Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| 10:29:39 | opendevreview | Stephen Finucane proposed openstack/placement master: docs: Unset 'language' https://review.opendev.org/c/openstack/placement/+/850505 | |
| 10:52:23 | bauzas | Uggla: made a few comment nits on your unshelve patch | |
| 10:52:44 | bauzas | if you have time to write UTs, would be appreciated before you respin https://review.opendev.org/c/openstack/nova/+/831507/17 | |
| 10:53:12 | bauzas | but if you prefer, I can accept as-it-is and just update https://review.opendev.org/c/openstack/nova/+/845897 | |
| 10:53:31 | bauzas | you could update the compute part UTs in a FUP | |
| 10:53:37 | bauzas | (follow-up patch) | |
| 11:22:05 | sean-k-mooney | gibi: ok ill loop back to review them properly later but responed to the remaining open comments i reluctanlty agree whith why you did not put the fucntion in the pcidevice object | |
| 11:22:38 | gibi | sean-k-mooney: I will do a quick spike on the refactor of PciDeviceSpec to PciDevice but I'm affraid it will be a can of worms | |
| 11:23:17 | sean-k-mooney | leave it for now | |
| 11:23:27 | sean-k-mooney | we can reevaluate in A | |
| 11:24:09 | sean-k-mooney | it would requrie converting the dicts we get rom the hypervior into the pci objects | |
| 11:24:26 | sean-k-mooney | and having the tracker add the tag info ectra to them | |
| 11:24:37 | sean-k-mooney | based on the pci entry they matched | |
| 11:24:43 | sean-k-mooney | so let not go there for now | |
| 11:27:26 | sean-k-mooney | stephenfin: care to re review https://review.opendev.org/c/openstack/nova-specs/+/849488/5 | |
| 11:28:31 | stephenfin | Sure | |
| 11:30:00 | gibi | sean-k-mooney: ack | |
| 11:43:04 | gibi | incoming... | |
| 11:43:09 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename [pci]passthrough_whitelist to device_spec https://review.opendev.org/c/openstack/nova/+/843834 | |
| 11:43:10 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename exception.PciConfigInvalidWhitelist to PciConfigInvalidSpec https://review.opendev.org/c/openstack/nova/+/843861 | |