Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2022-03-23
13:39:13 gibi kashyap: no worries, then something was mixed in that env
13:39:46 Uggla zuul*
14:13:41 sean-k-mooney Uggla: reverify in the long ago before times used to be use to tirgger just the gate pipeline rather then both gate and check. we removed it whith the green check policy dission about 8 years ago but downstream we trigger off both recheck and reverify for legacy reasons but ya as artom said recheck is what is used upstream when reqruied
14:41:56 Uggla sean-k-mooney, thx for the info.
14:44:52 sean-k-mooney gmann: bauzas since ye have already +2'd the followup care to review https://review.opendev.org/c/openstack/nova/+/828598/1 so that the docs pathes can proceed
14:45:32 bauzas sean-k-mooney: shit I missed the fact it was depending on this
14:46:02 gmann I had in list then missed somehow. thanks
14:46:03 sean-k-mooney no worreis this has been on my review list for a while
14:56:42 sean-k-mooney gibi: just looking at https://review.opendev.org/q/topic:any-traits-support the remaining patches are just using any traits right e.g. client supprot nova testing ectra. the feature is "complete" from the placmenet side in yoga?
14:57:49 sean-k-mooney just going through my review backlog but i had mentally check that off as complete
14:58:50 gibi sean-k-mooney: yes the feature is complete from placement perspective
14:59:17 gibi I have the placement client patch open, but that is not super important
14:59:29 gibi and I have the todo to check the sql performance and improve if needed
15:00:58 opendevreview Merged openstack/nova master: doc: Split up notifications document https://review.opendev.org/c/openstack/nova/+/828598
15:01:19 gibi hm I missed that review ^^ but quickly checked and looks good to me too
15:13:34 opendevreview Merged openstack/nova master: doc: Remove useless contributor/api-2 doc https://review.opendev.org/c/openstack/nova/+/828599
15:15:43 opendevreview Stephen Finucane proposed openstack/nova master: objects: Remove 'NovaObjectDictCompat' from 'Migration' https://review.opendev.org/c/openstack/nova/+/723572
15:16:03 opendevreview Stephen Finucane proposed openstack/nova master: objects: Remove 'NovaObjectDictCompat' from 'InstancePCIRequest' https://review.opendev.org/c/openstack/nova/+/723573
15:45:47 outbrito Morning folks! I'm trying to run tox @ master locally on my work laptop (ubuntu 20.04) and I'm getting a weird error: oslo_config.cfg.RequiredOptError: value required for option lock_path in group [DEFAULT]
15:45:54 outbrito Is that a known issue?
15:47:26 sean-k-mooney am i have seen that locally too
15:47:32 sean-k-mooney but not sure if we have a tacker for it
15:47:34 dansmith rebuild your venv?
15:47:38 dansmith tox -r
15:47:57 outbrito It was a brand new clone, but I'll try anyway
15:49:13 dansmith ack, usually random oslo things for me are due to a stale venv when reqs had changed, so that's the first thing I try
15:49:57 sean-k-mooney outbrito: is this actully causing test failures for you or just an warning/error message
15:50:07 outbrito 5 test failing
15:50:13 outbrito tests*
15:50:49 sean-k-mooney ok that actully the same as i saw on my mac book air tests yesterday also on a clean clone
15:51:11 sean-k-mooney let me see if i can repoduce on my normal system
15:53:41 sean-k-mooney i updated my ubuntu 20.04 server to 21.10 at the weekend but its running them now
15:54:17 sean-k-mooney so it wont be idential hum so i did get 1 failure with master
15:54:22 sean-k-mooney ill try in a clean clone
15:54:58 sean-k-mooney outbrito: what version of python did you run them under
15:55:09 sean-k-mooney 3.8 i assume?
15:55:14 sean-k-mooney just in case that matters
15:57:13 opendevreview Merged openstack/placement master: tests: Silence noisy tests https://review.opendev.org/c/openstack/placement/+/801101
15:58:34 outbrito 3.9
16:00:26 outbrito The only differences I see on requirements is Yappi vs. yappi and PyNaCl vs. pynacl
16:01:53 gibi hm with 20.04 + py38 + fresh master I could not reproduce the lock_path issue
16:03:54 outbrito The tests failing are these btw:
16:04:02 outbrito nova.tests.unit.compute.test_compute_mgr.ComputeManagerUnitTestCase.test_detach_volume_evacuate_mismatch
16:04:02 outbrito nova.tests.unit.compute.test_compute_mgr.ComputeManagerUnitTestCase.test_detach_volume_evacuate_legacy
16:04:02 outbrito nova.tests.unit.compute.test_compute_mgr.ComputeManagerUnitTestCase.test_detach_volume_evacuate
16:04:02 outbrito nova.tests.unit.virt.test_block_device.TestDriverBlockDeviceNewFlow.test_volume_attach_with_shared_targets
16:04:04 outbrito nova.tests.unit.virt.test_block_device.TestDriverBlockDevice.test_volume_attach_with_shared_targets
16:04:57 outbrito All related to volumes for that matter
16:04:58 opendevreview Merged openstack/placement master: tox: Remove psycopg2 warning filter https://review.opendev.org/c/openstack/placement/+/800911
16:08:48 sean-k-mooney on a clean clone on 21.10 i did not have any failure under python 39
16:10:37 outbrito py38 also broken for me
16:11:24 outbrito just to be sure, last commit is d2b2516 right?
16:11:39 gibi yepp
16:11:45 gibi I see that as head too
16:11:51 gibi but no luck reproducing the issue
16:12:07 gibi does it happen the same way for you each time you rerun these tests?
16:12:15 gibi or is it unstable?
16:13:47 outbrito consistent
16:15:30 gibi outbrito: do you also get a stack trace? If yes could you past it via https://paste.opendev.org/ (or similar)
16:17:04 opendevreview Merged openstack/placement master: setup: Replace dashes with underscores https://review.opendev.org/c/openstack/placement/+/801102
16:17:34 outbrito https://paste.opendev.org/show/bZm6XstZ4MTPM7SPVuCR/
16:21:38 gibi thanks
16:25:06 gibi outbrito: what is the os-brick version in your virtualenv?
16:40:24 mfo sean-k-mooney, hey o/ getting back to you exactly 1 month later :) sorry. i'd appreciate your comments/review when you have a chance (but it's not urgent, as you can see).
16:40:35 mfo we chatted [0] about an issue [1] that the libvirt driver in uefi mode ended up with the ovmf _secboot_ image, which doesn't boot on the pc machine type (required q35); so i proposed to skip the secboot image if on pc. [2,3]
16:40:45 mfo [0] https://pastebin.ubuntu.com/p/jVxcXvDW6h/
16:40:45 mfo [1] https://bugs.launchpad.net/nova/+bug/1960758
16:40:45 mfo [2] https://review.opendev.org/c/openstack/nova/+/828980
16:40:46 mfo [3] https://review.opendev.org/c/openstack/nova/+/828979
16:40:53 mfo essentially, i would get back to you with:
16:40:53 mfo 1) explain why the secboot image didn't "just work", 2) add unit tests, 3) ensure we only skip secboot image if there's another image to use.
16:40:53 mfo i've explained 1) with technical details/research in the bug's comments, and addressed 2) and 3) in the patches.
16:40:55 mfo thanks!
16:41:53 sean-k-mooney mfo: ack, in a downstream call currently so will review it after
16:42:19 sean-k-mooney mfo: in your opipion are the parces ready for review if so ill try and add them to my backlog for this week
16:42:46 mfo sean-k-mooney, yup, i think it's ready for review.
16:43:49 gibi outbrito: sorry I don't see what is happening on your side with those test and I will soon and my day.
16:59:33 outbrito no worries, i'll keep investigating. Thanks for looking into it
17:00:38 outbrito gibi, os-brick is at 5.2.0 btw
18:44:31 melwitt dansmith: I have a patch proposed to address a func test gate bug I see semi frequently and the patch is based on a NOTE by you in the CellDatabases func test fixture. if you might be interested in reviewing: https://review.opendev.org/c/openstack/nova/+/831084
18:53:26 dansmith melwitt: yeah I remember that, looking
19:02:48 opendevreview Artom Lifshitz proposed openstack/nova master: Add whitebox-devstack-multinode job to periodic https://review.opendev.org/c/openstack/nova/+/833453
19:04:49 dansmith melwitt: commented, see what you think
19:05:11 melwitt cool thanks. looking
19:09:22 opendevreview Artom Lifshitz proposed openstack/nova master: Add whitebox-devstack-multinode job to periodic https://review.opendev.org/c/openstack/nova/+/833453
19:16:27 opendevreview Artom Lifshitz proposed openstack/nova master: Add whitebox-devstack-multinode job to periodic https://review.opendev.org/c/openstack/nova/+/833453
19:37:30 opendevreview Artom Lifshitz proposed openstack/nova master: Add whitebox-devstack-multinode job to periodic https://review.opendev.org/c/openstack/nova/+/833453
19:58:31 artom "deprecated_since=versionutils.deprecated.WALLABY"
19:58:43 artom ... in a placement installed in a ussuri tox functional venv
19:58:48 artom *sigh*
20:00:43 sean-k-mooney that is likely down to how we install placment for the placment fixture in the tox env
20:01:15 sean-k-mooney if that is happenign in a clean checkout with new venv
20:01:28 sean-k-mooney https://github.com/openstack/nova/blob/master/tox.ini#L119
20:01:53 sean-k-mooney that should still be limited by upper constratis for the branch https://github.com/openstack/nova/blob/master/tox.ini#L29
20:02:22 sean-k-mooney ah hehe
20:02:26 sean-k-mooney https://opendev.org/openstack/requirements/raw/branch/stable/ussuri/upper-constraints.txt
20:02:39 sean-k-mooney placement is not in upperconstrait for stable/ussuri
20:02:53 sean-k-mooney artom: so you will get whatever is on pypi
20:03:14 sean-k-mooney for the most part that should be ok as we are just using it for the fixture in this case
20:03:35 artom Unless it explicitly uses variables named after major releases :P

Earlier   Later