| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-03-23 | |||
| 20:03:14 | sean-k-mooney | for the most part that should be ok as we are just using it for the fixture in this case | |
| 20:03:35 | artom | Unless it explicitly uses variables named after major releases :P | |
| 20:03:35 | sean-k-mooney | but that is why that happens its installing the latest pypi release of placement | |
| 20:03:56 | artom | Presumably this would fail in the upstream gate as well | |
| 20:04:15 | sean-k-mooney | proably we likely should cap it to the feature level | |
| 20:04:26 | sean-k-mooney | * minor release | |
| 20:04:47 | sean-k-mooney | actully placement is not release independ ot its the major verion | |
| 20:05:13 | sean-k-mooney | that woudl be pretty trival to do just update https://github.com/openstack/nova/blob/stable/ussuri/tox.ini#L91 | |
| 20:05:28 | sean-k-mooney | but we woudl need to do that with a stable only patch for each release | |
| 20:06:19 | sean-k-mooney | so ussuri is 3.0.0 so you need to set it to <4.0.0 | |
| 20:06:58 | sean-k-mooney | so """openstack-placement>=1.0.0,<4.0.0""" i think although im not sure if the , is needed | |
| 20:07:02 | sean-k-mooney | that shoudl fix it | |
| 20:07:34 | sean-k-mooney | or you coudl be explcit and say openstack-placement==3 | |
| 20:08:22 | sean-k-mooney | that will give you any 3.x.y but not 2.* or 4.* | |
| 20:08:47 | sean-k-mooney | artom: hopefully that makes sense | |
| 20:09:03 | sean-k-mooney | im goign to call it a day so chat to you tomorrow o/ | |
| 20:09:32 | artom | sean-k-mooney, yep, many thanks, very useful | |
| 20:10:00 | artom | Will also need to do it for victoria as well, since it doesn't understand WALLABY either | |
| 20:15:02 | clarkb | note I think ==3 means 3.0.0 not 3.x.y | |
| 20:16:14 | sean-k-mooney | im not sure about that but either way we can use min/max version or just pin to the majory with ==3 depending on the semantics of the syntax | |
| 20:16:30 | sean-k-mooney | i tought it woudl select the new 3.x.y | |
| 20:16:36 | sean-k-mooney | but im not sure | |
| 20:19:25 | clarkb | the ~= operator is for that or using * in the versions. missing identifiers seem to expand to .0 | |
| 20:19:59 | sean-k-mooney | ack | |
| 20:20:08 | sean-k-mooney | is ~= supprot new | |
| 20:20:33 | sean-k-mooney | im familar with it in other context but i did nto think it was supproted in the requirements specificaitons | |
| 20:21:59 | clarkb | it was defined in pep 440 somewhat new | |
| 20:28:27 | opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: [stable-only] Cap placement version in tox functional venv https://review.opendev.org/c/openstack/nova/+/834970 | |
| 23:37:15 | opendevreview | melanie witt proposed openstack/nova master: image_meta: Add ephemeral encryption properties https://review.opendev.org/c/openstack/nova/+/760454 | |
| 23:37:16 | opendevreview | melanie witt proposed openstack/nova master: BlockDeviceMapping: Add encryption fields https://review.opendev.org/c/openstack/nova/+/760453 | |
| 23:37:16 | opendevreview | melanie witt proposed openstack/nova master: BlockDeviceMapping: Add is_local property https://review.opendev.org/c/openstack/nova/+/764485 | |
| 23:37:17 | opendevreview | melanie witt proposed openstack/nova master: compute: Update bdms with ephemeral encryption details when requested https://review.opendev.org/c/openstack/nova/+/764486 | |
| 23:37:17 | opendevreview | melanie witt proposed openstack/nova master: virt: Add ephemeral encryption flag https://review.opendev.org/c/openstack/nova/+/760455 | |
| #openstack-nova - 2022-03-24 | |||
| 04:54:01 | opendevreview | melanie witt proposed openstack/nova master: BlockDeviceMapping: Add encryption fields https://review.opendev.org/c/openstack/nova/+/760453 | |
| 04:54:02 | opendevreview | melanie witt proposed openstack/nova master: BlockDeviceMapping: Add is_local property https://review.opendev.org/c/openstack/nova/+/764485 | |
| 04:54:02 | opendevreview | melanie witt proposed openstack/nova master: compute: Update bdms with ephemeral encryption details when requested https://review.opendev.org/c/openstack/nova/+/764486 | |
| 04:54:03 | opendevreview | melanie witt proposed openstack/nova master: virt: Add ephemeral encryption flag https://review.opendev.org/c/openstack/nova/+/760455 | |
| 15:54:57 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Replace implicit conversion of SELECT into FROM https://review.opendev.org/c/openstack/placement/+/800910 | |
| 15:54:58 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Replace 'as_scalar()' with 'scalar_subquery()' https://review.opendev.org/c/openstack/placement/+/801100 | |
| 15:54:58 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Update 'select()' calls https://review.opendev.org/c/openstack/placement/+/801103 | |
| 15:54:59 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Remove use of non-integer/slice indices https://review.opendev.org/c/openstack/placement/+/801104 | |
| 15:54:59 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Replace deprecated 'FromClause.select().whereclause' parameter https://review.opendev.org/c/openstack/placement/+/801105 | |
| 15:55:00 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Use explicit transactions https://review.opendev.org/c/openstack/placement/+/801106 | |
| 15:55:00 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Remove unnecessary use of '_mapping' https://review.opendev.org/c/openstack/placement/+/801107 | |
| 15:55:01 | opendevreview | Stephen Finucane proposed openstack/placement master: tests: Restore - don't reset - warning filters https://review.opendev.org/c/openstack/placement/+/828119 | |
| 15:55:01 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Use Row, not LegacyRow https://review.opendev.org/c/openstack/placement/+/828305 | |
| 15:55:03 | opendevreview | Stephen Finucane proposed openstack/placement master: tox: Enable SQLAlchemy 2.0 warnings https://review.opendev.org/c/openstack/placement/+/801108 | |
| 18:46:07 | opendevreview | melanie witt proposed openstack/nova master: Retry in CellDatabases fixture when global DB state changes https://review.opendev.org/c/openstack/nova/+/831084 | |
| 19:33:08 | outbrito | gibi, g'day! Just FTR, I found out that just doing this I would get these tests running: https://paste.opendev.org/show/b7EqvAMhZE6fJe2bYNSI/ | |
| 19:33:29 | outbrito | Still investigating what could be different on my env | |
| 19:46:16 | outbrito | I'm almost sure this is because I'm running ubuntu desktop and I don't have iscsiadm on it | |
| 19:46:16 | outbrito | https://github.com/openstack/os-brick/blob/master/os_brick/initiator/utils.py#L40 | |
| 20:09:47 | outbrito | Yeah, if I install open-iscsi the error ceases. Should that be on bindep then? | |
| 20:14:16 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Update 'select()' calls https://review.opendev.org/c/openstack/placement/+/801103 | |
| 20:14:16 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Remove use of non-integer/slice indices https://review.opendev.org/c/openstack/placement/+/801104 | |
| 20:14:17 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Replace deprecated 'FromClause.select().whereclause' parameter https://review.opendev.org/c/openstack/placement/+/801105 | |
| 20:14:17 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Use explicit transactions https://review.opendev.org/c/openstack/placement/+/801106 | |
| 20:14:18 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Remove unnecessary use of '_mapping' https://review.opendev.org/c/openstack/placement/+/801107 | |
| 20:14:18 | opendevreview | Stephen Finucane proposed openstack/placement master: tests: Restore - don't reset - warning filters https://review.opendev.org/c/openstack/placement/+/828119 | |
| 20:14:19 | opendevreview | Stephen Finucane proposed openstack/placement master: db: Use Row, not LegacyRow https://review.opendev.org/c/openstack/placement/+/828305 | |
| 20:14:19 | opendevreview | Stephen Finucane proposed openstack/placement master: tox: Enable SQLAlchemy 2.0 warnings https://review.opendev.org/c/openstack/placement/+/801108 | |
| 21:50:55 | mloza | Hi, I know it isn't possible to attach a server group to existing VMs that don't have it so I'm asking if it's possible to modify the instance details in the database to add it ? | |
| 23:32:04 | mnaser | mloza: possible? yes -- should you? probably not :) | |
| 23:50:02 | mloza | mnaser: what's the impact ? Another solution besides rebuilding the VMs | |
| 23:50:24 | mnaser | mloza: since you're doing something that is not supported, no one knows what the impact is unfortunately | |
| 23:50:34 | mnaser | you can try it, but if it all breaks, i doubt you'll be able to get much help unfortunately | |
| 23:54:51 | mloza | I know `instance_group_member` table in nova_api db needs to be modified. Is there any other table I'm missing ? | |
| #openstack-nova - 2022-03-25 | |||
| 00:16:52 | opendevreview | Merged openstack/nova master: objects: Remove 'NovaObjectDictCompat' from 'Migration' https://review.opendev.org/c/openstack/nova/+/723572 | |
| 00:17:00 | opendevreview | Merged openstack/nova master: objects: Remove 'NovaObjectDictCompat' from 'InstancePCIRequest' https://review.opendev.org/c/openstack/nova/+/723573 | |
| 06:21:19 | opendevreview | Merged openstack/nova master: Update contributor guide for Zed https://review.opendev.org/c/openstack/nova/+/833441 | |
| 06:21:24 | opendevreview | Merged openstack/placement master: Add zed spec directory https://review.opendev.org/c/openstack/placement/+/829532 | |
| 13:01:58 | noonedeadpunk | hey there! Any considerations if to use `resources:PCPU` or `hw:cpu_policy='dedicated'` for cpu-pinning? | |
| 13:02:10 | noonedeadpunk | As I just realized they result in quite different xmls | |
| 13:03:04 | noonedeadpunk | In first case through "static" vcpu placement, in second through reall mapping of vCPUs to CPUs... | |
| 13:03:26 | sean-k-mooney | they shoudl result in the same | |
| 13:03:37 | noonedeadpunk | huh | |
| 13:03:50 | sean-k-mooney | both should do a one to one vcpu pinning with the vcpupin element | |
| 13:04:32 | noonedeadpunk | For resources:PCPU I got just <vcpu placement='static'>4</vcpu> | |
| 13:04:40 | sean-k-mooney | ya that is not correct | |
| 13:04:40 | noonedeadpunk | and no vcpupin | |
| 13:04:50 | sean-k-mooney | what release are you on | |
| 13:04:54 | noonedeadpunk | Xena | |
| 13:05:11 | sean-k-mooney | i wonder if the mixed cpu support regressed that | |
| 13:06:07 | noonedeadpunk | maybe I have some mistake in flavor, let me double-check | |
| 13:06:56 | sean-k-mooney | if you have resouces:PCPU it shoudl be all you need although i dont recommend that people use the resouces: syntax in general | |
| 13:07:07 | sean-k-mooney | https://github.com/openstack/nova-specs/blob/master/specs/victoria/implemented/use-pcpu-vcpu-in-one-instance.rst was implemented in victoria | |
| 13:07:20 | sean-k-mooney | its possibe that intoduced a regression but we shoudl have functional test for this | |
| 13:07:48 | noonedeadpunk | Yah I read https://docs.openstack.org/nova/latest/admin/cpu-topologies.html quite carefully :) | |
| 13:08:00 | noonedeadpunk | I just didn't find any difference in there | |
| 13:08:21 | noonedeadpunk | but `hw:cpu_policy='dedicated'` doing correct thing | |
| 13:09:13 | noonedeadpunk | Another question - I do remember some changelog, that suport of live migration for pinned instances was added - was I dreaming or it's a thing? | |
| 13:09:40 | sean-k-mooney | its a thing i know its in wallaby for sure but i think it was before that even | |
| 13:09:45 | sean-k-mooney | so xena has it | |
| 13:10:24 | sean-k-mooney | our functional test are not actully asserting things about the xml at first glace | |
| 13:12:29 | noonedeadpunk | Should we submit bug then? | |
| 13:13:44 | sean-k-mooney | for the pinnign yes please do | |
| 13:13:59 | sean-k-mooney | i was just looking at some other integration tests we have | |
| 13:14:34 | sean-k-mooney | whitebox has test to assert the xml generateion https://opendev.org/openstack/whitebox-tempest-plugin/src/branch/master/whitebox_tempest_plugin/api/compute/test_cpu_pinning.py#L94-L110 | |
| 13:14:51 | sean-k-mooney | but i think that is only testing the dedicated case not pcpus | |
| 13:15:52 | sean-k-mooney | thats actully just the helper function | |