| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-02-24 | |||
| 16:19:11 | gibi | bauzas: ack | |
| 16:19:14 | gibi | no worries | |
| 16:19:25 | bauzas | gmann: gibi: I was asking for it as I knew it would mean two microversions for the same project_id change | |
| 16:19:37 | yuval | gibi thanks for the fast response, chateaulav sorry about that | |
| 16:19:58 | chateaulav | your good. just a sec of panic on my side | |
| 16:19:59 | bauzas | gmann: gibi: but I was wondering about merging a few things for Yoga as we don't have any new microversions and just telling within the microversion what APIs were touched | |
| 16:20:15 | bauzas | gmann: gibi: but if you guys prefer to merge it at once, fine by me | |
| 16:20:25 | gibi | bauzas: we can technically split to two microversions it is a bit of a meh UX but yeah | |
| 16:20:41 | bauzas | this is just unrealistic to merge the whole branch before today EOB | |
| 16:20:46 | gibi | ack | |
| 16:21:11 | bauzas | my only concern is that brinzhang isn't around as we speak | |
| 16:21:20 | gibi | it is pretty late for him | |
| 16:21:30 | bauzas | so we can't really ask him to change the microversion change for saying which APIs are modified | |
| 16:21:41 | bauzas | this would mean some kind of exception | |
| 16:21:48 | bauzas | so maybe not a priority | |
| 16:21:58 | bauzas | as you can see, I'm not opinionated | |
| 16:21:59 | gmann | yeah, I also prefer to merge it together | |
| 16:22:25 | bauzas | OK, if there is no huge interesting in merging by pieces, let's then punt | |
| 16:22:42 | gmann | as it is cleanup, I think we can move it to next cycle and make it priority in Zed since starting.? | |
| 16:22:43 | gibi | my only fear that we never merge it ever and brinzhang gets mad and drops it | |
| 16:23:06 | gmann | gibi: yeah, it has been going in many cycle. | |
| 16:23:23 | gibi | yeah we somehow need tof force ourselve to look at that series early in the cycle | |
| 16:23:32 | gibi | but we failed on it this time | |
| 16:23:38 | gibi | or at least I failed | |
| 16:24:00 | gmann | I too failed, but I will commit on this for Zed for sure. | |
| 16:24:29 | gmann | there are few last patches not ready at least server tenant usage url one | |
| 16:24:45 | gmann | which brin asked me to look and I did not get chance | |
| 16:26:23 | melwitt | apologies for the upcoming spam | |
| 16:26:41 | opendevreview | melanie witt proposed openstack/nova master: Move keypair quota error message into exception https://review.opendev.org/c/openstack/nova/+/828186 | |
| 16:26:42 | opendevreview | melanie witt proposed openstack/nova master: Add stub unified limits driver https://review.opendev.org/c/openstack/nova/+/712137 | |
| 16:26:42 | opendevreview | melanie witt proposed openstack/nova master: Assert quota related API behavior when noop https://review.opendev.org/c/openstack/nova/+/712140 | |
| 16:26:43 | opendevreview | melanie witt proposed openstack/nova master: Make unified limits APIs return reserved of 0 https://review.opendev.org/c/openstack/nova/+/712141 | |
| 16:26:43 | opendevreview | melanie witt proposed openstack/nova master: Add logic to enforce local api and db limits https://review.opendev.org/c/openstack/nova/+/712139 | |
| 16:26:44 | opendevreview | melanie witt proposed openstack/nova master: Enforce api and db limits https://review.opendev.org/c/openstack/nova/+/712142 | |
| 16:26:44 | opendevreview | melanie witt proposed openstack/nova master: Update quota_class APIs for db and api limits https://review.opendev.org/c/openstack/nova/+/712143 | |
| 16:26:45 | opendevreview | melanie witt proposed openstack/nova master: Update limit APIs https://review.opendev.org/c/openstack/nova/+/712707 | |
| 16:26:46 | opendevreview | melanie witt proposed openstack/nova master: Update quota sets APIs https://review.opendev.org/c/openstack/nova/+/712749 | |
| 16:26:46 | opendevreview | melanie witt proposed openstack/nova master: Tell oslo.limit how to count nova resources https://review.opendev.org/c/openstack/nova/+/713301 | |
| 16:26:48 | opendevreview | melanie witt proposed openstack/nova master: Enforce resource limits using oslo.limit https://review.opendev.org/c/openstack/nova/+/615180 | |
| 16:26:48 | opendevreview | melanie witt proposed openstack/nova master: Add legacy limits and usage to placement unified limits https://review.opendev.org/c/openstack/nova/+/713498 | |
| 16:26:50 | opendevreview | melanie witt proposed openstack/nova master: Update quota apis with keystone limits and usage https://review.opendev.org/c/openstack/nova/+/713499 | |
| 16:26:50 | opendevreview | melanie witt proposed openstack/nova master: Add reno for unified limits https://review.opendev.org/c/openstack/nova/+/715271 | |
| 16:26:52 | opendevreview | melanie witt proposed openstack/nova master: Enable unified limits in the nova-next job https://review.opendev.org/c/openstack/nova/+/789963 | |
| 16:28:20 | melwitt | gibi, bauzas: merge conflict was super easy, was due to requirements bump so only requirements.txt and test-requirements.txt | |
| 16:28:36 | bauzas | ++ | |
| 16:29:08 | gibi | OK, On it | |
| 16:32:21 | opendevreview | Ghanshyam proposed openstack/nova master: Modify remaining APIs as per RBAC new guidelines https://review.opendev.org/c/openstack/nova/+/828994 | |
| 16:32:34 | dansmith | bauzas: did you see my reply comment here about splitting? https://review.opendev.org/c/openstack/nova/+/820368 | |
| 16:33:00 | gmann | gibi: bauzas fixed the assisted volume snapshot one https://review.opendev.org/c/openstack/nova/+/828994 | |
| 16:33:03 | dansmith | bauzas: I think that's what you intended and I was picking the wrong seam, but just want clarification before I go trying to help split that as described in my most recent one | |
| 16:33:28 | opendevreview | Ghanshyam proposed openstack/nova master: Separate flavor extra specs policy for server APIs https://review.opendev.org/c/openstack/nova/+/829626 | |
| 16:33:35 | opendevreview | Ghanshyam proposed openstack/nova master: Complete phase-1 of RBAC community-wide goal https://review.opendev.org/c/openstack/nova/+/829866 | |
| 16:35:58 | gibi | melwitt: rebase looks good, I did the paperwork to send the series to the gate | |
| 16:36:14 | melwitt | thank you gibi! | |
| 16:36:24 | gibi | gmann: you are next :) | |
| 16:36:36 | gmann | gibi: thanks :) | |
| 16:36:53 | gibi | I have to stop in about an hour | |
| 16:54:26 | gibi | gmann: thanks for the fix | |
| 16:55:14 | gibi | bauzas: this morning I re-read the policy series and I find no problems (except the assisted snapshot that is fixed now) so I upgraded my vote now to +2 on the policy series | |
| 16:55:25 | gibi | bauzas: we still need you to check back to https://review.opendev.org/c/openstack/nova/+/828994/8 as that was updated recently | |
| 16:55:38 | bauzas | gibi: ok | |
| 16:55:42 | gibi | but otherwise the policy series is also going to the gate | |
| 16:56:22 | bauzas | done | |
| 16:56:33 | gibi | now zuul has things to do :D | |
| 16:58:17 | bauzas | dansmith: sorry in an internal meeting but looking | |
| 17:01:36 | bauzas | dansmith: so, | |
| 17:01:43 | bauzas | we have two different things | |
| 17:01:57 | bauzas | one is the REST API modification adding a new microversion | |
| 17:02:26 | bauzas | the other is the new instance external event type we add in the related ovo | |
| 17:02:52 | dansmith | well, the microversion for the event is specifically for the event api, not the ovo directly, but yeah | |
| 17:03:18 | bauzas | agreed, it's in the event itself | |
| 17:03:55 | bauzas | I'm speaking of https://review.opendev.org/c/openstack/nova/+/820368/9/nova/objects/external_event.py | |
| 17:04:16 | bauzas | vs. https://review.opendev.org/c/openstack/nova/+/820368/9/nova/api/openstack/compute/rest_api_version_history.rst | |
| 17:04:26 | dansmith | yah | |
| 17:05:11 | bauzas | we were about discussing 5 mins ago about merging one microversion for tenant_id | |
| 17:05:15 | bauzas | which could be 2.91 | |
| 17:05:22 | bauzas | fortunately, this won't happen | |
| 17:05:33 | bauzas | so, technically, the 2.91 slot is free to anyone | |
| 17:05:57 | gmann | bauzas: gibi thanks for review. | |
| 17:06:39 | bauzas | dansmith: just take note of https://review.opendev.org/c/openstack/nova/+/764292/34/nova/api/openstack/compute/rest_api_version_history.rst | |
| 17:06:52 | bauzas | but we agreed 5 mins ago with gmann to not merge it | |
| 17:07:25 | bauzas | that said, I'll have to leave in 10 mins | |
| 17:07:28 | dansmith | bauzas: yeah, I really wish we shouldn't do those sorts of things | |
| 17:07:30 | dansmith | but regardles | |
| 17:07:54 | dansmith | all I'm trying to figure out is whether you actually wanted *two* microversions, one for the event and one for the rebuild change | |
| 17:08:10 | bauzas | two REST microversions ? | |
| 17:08:14 | dansmith | or if you meant to split the plumbing underneath (i.e. the actual event, the rebuild code) from the api changes | |
| 17:08:24 | bauzas | no, I didn't ask for it | |
| 17:08:36 | bauzas | I asked for splitting the plumbing as you speak | |
| 17:08:40 | dansmith | I forgot that we started microversions for the events (which I'm not sure why we started doing that), but.. | |
| 17:08:41 | dansmith | right okay | |
| 17:08:59 | bauzas | let's call it event versioning, if you prefer :) | |
| 17:09:02 | dansmith | cool cool, my mistake for forgetting that initially so I was on a slightly wrong track | |
| 17:09:19 | bauzas | but gibi knows more than me on it | |
| 17:09:46 | bauzas | dansmith: again, that said, I won't be able to review it honestly today | |
| 17:09:52 | dansmith | bauzas: that's fine | |
| 17:09:57 | bauzas | as I have an hard stop in 5 mins | |
| 17:09:58 | dansmith | whoami-rajat: are you cool with me trying to split your patch accordingly or do you want to do it? | |
| 17:11:31 | gibi | bauzas: I think you are conflating versioning notifications emitted by nova and microversion bump for the external_events REST API. | |
| 17:11:49 | whoami-rajat | dansmith, either way is fine with me, maybe better if you do it because I still don't have full idea of the ask here or if guided i can | |