| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-02-24 | |||
| 16:36:36 | gmann | gibi: thanks :) | |
| 16:36:53 | gibi | I have to stop in about an hour | |
| 16:54:26 | gibi | gmann: thanks for the fix | |
| 16:55:14 | gibi | bauzas: this morning I re-read the policy series and I find no problems (except the assisted snapshot that is fixed now) so I upgraded my vote now to +2 on the policy series | |
| 16:55:25 | gibi | bauzas: we still need you to check back to https://review.opendev.org/c/openstack/nova/+/828994/8 as that was updated recently | |
| 16:55:38 | bauzas | gibi: ok | |
| 16:55:42 | gibi | but otherwise the policy series is also going to the gate | |
| 16:56:22 | bauzas | done | |
| 16:56:33 | gibi | now zuul has things to do :D | |
| 16:58:17 | bauzas | dansmith: sorry in an internal meeting but looking | |
| 17:01:36 | bauzas | dansmith: so, | |
| 17:01:43 | bauzas | we have two different things | |
| 17:01:57 | bauzas | one is the REST API modification adding a new microversion | |
| 17:02:26 | bauzas | the other is the new instance external event type we add in the related ovo | |
| 17:02:52 | dansmith | well, the microversion for the event is specifically for the event api, not the ovo directly, but yeah | |
| 17:03:18 | bauzas | agreed, it's in the event itself | |
| 17:03:55 | bauzas | I'm speaking of https://review.opendev.org/c/openstack/nova/+/820368/9/nova/objects/external_event.py | |
| 17:04:16 | bauzas | vs. https://review.opendev.org/c/openstack/nova/+/820368/9/nova/api/openstack/compute/rest_api_version_history.rst | |
| 17:04:26 | dansmith | yah | |
| 17:05:11 | bauzas | we were about discussing 5 mins ago about merging one microversion for tenant_id | |
| 17:05:15 | bauzas | which could be 2.91 | |
| 17:05:22 | bauzas | fortunately, this won't happen | |
| 17:05:33 | bauzas | so, technically, the 2.91 slot is free to anyone | |
| 17:05:57 | gmann | bauzas: gibi thanks for review. | |
| 17:06:39 | bauzas | dansmith: just take note of https://review.opendev.org/c/openstack/nova/+/764292/34/nova/api/openstack/compute/rest_api_version_history.rst | |
| 17:06:52 | bauzas | but we agreed 5 mins ago with gmann to not merge it | |
| 17:07:25 | bauzas | that said, I'll have to leave in 10 mins | |
| 17:07:28 | dansmith | bauzas: yeah, I really wish we shouldn't do those sorts of things | |
| 17:07:30 | dansmith | but regardles | |
| 17:07:54 | dansmith | all I'm trying to figure out is whether you actually wanted *two* microversions, one for the event and one for the rebuild change | |
| 17:08:10 | bauzas | two REST microversions ? | |
| 17:08:14 | dansmith | or if you meant to split the plumbing underneath (i.e. the actual event, the rebuild code) from the api changes | |
| 17:08:24 | bauzas | no, I didn't ask for it | |
| 17:08:36 | bauzas | I asked for splitting the plumbing as you speak | |
| 17:08:40 | dansmith | I forgot that we started microversions for the events (which I'm not sure why we started doing that), but.. | |
| 17:08:41 | dansmith | right okay | |
| 17:08:59 | bauzas | let's call it event versioning, if you prefer :) | |
| 17:09:02 | dansmith | cool cool, my mistake for forgetting that initially so I was on a slightly wrong track | |
| 17:09:19 | bauzas | but gibi knows more than me on it | |
| 17:09:46 | bauzas | dansmith: again, that said, I won't be able to review it honestly today | |
| 17:09:52 | dansmith | bauzas: that's fine | |
| 17:09:57 | bauzas | as I have an hard stop in 5 mins | |
| 17:09:58 | dansmith | whoami-rajat: are you cool with me trying to split your patch accordingly or do you want to do it? | |
| 17:11:31 | gibi | bauzas: I think you are conflating versioning notifications emitted by nova and microversion bump for the external_events REST API. | |
| 17:11:49 | whoami-rajat | dansmith, either way is fine with me, maybe better if you do it because I still don't have full idea of the ask here or if guided i can | |
| 17:12:07 | dansmith | whoami-rajat: ack, partially my fault anyway :D | |
| 17:13:00 | whoami-rajat | dansmith, i think it's because the codebase is fairly new to me :) | |
| 17:13:20 | dansmith | whoami-rajat: you should seize the opportunity to blame me ;P | |
| 17:13:32 | bauzas | gibi: I'm not conflating, but I wrote a comment which was unclear :) | |
| 17:13:53 | gibi | OK. I don't have the full context sorry :) | |
| 17:14:03 | bauzas | https://review.opendev.org/c/openstack/nova/+/820368/9#message-f4b92b3310dee2af9598f108dc761f7fabafd34a | |
| 17:14:21 | whoami-rajat | :D | |
| 17:14:27 | bauzas | "event one" was unclear | |
| 17:14:34 | bauzas | I was referring to the patch | |
| 17:14:34 | gibi | OK. | |
| 17:14:39 | gibi | I see now | |
| 17:14:48 | bauzas | not to any other microversion | |
| 17:17:23 | bauzas | other cores, I trust you | |
| 17:17:33 | bauzas | if you wanna continue to review, fine by me | |
| 17:19:17 | ralonsoh | gibi, https://review.opendev.org/c/openstack/neutron/+/829247 just a heads-up, if you didn't see my reply | |
| 17:22:34 | gibi | ralonsoh: thank, I haven't seen it yet. I will check tomorrow or next week, as we are in feature freeze crazy :) | |
| 17:22:43 | ralonsoh | sure, no rush | |
| 17:22:50 | ralonsoh | ping me whenever you can | |
| 17:28:27 | opendevreview | Jonathan Race proposed openstack/nova master: object/notification for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828369 | |
| 17:28:28 | opendevreview | Jonathan Race proposed openstack/nova master: driver/secheduler/docs for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053 | |
| 17:28:28 | opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | |
| 17:29:04 | gibi | ralonsoh: thanks | |
| 17:29:43 | chateaulav | sean-k-mooney: that should do, sorry it took a litle bit the rebase got wonked so started fresh. | |
| 17:29:48 | chateaulav | gibi: thanks as well | |
| 17:30:23 | gibi | chateaulav: rebaswe looks clear | |
| 17:30:35 | gibi | so I'm +2 | |
| 17:30:41 | gibi | but now I have to stop for today | |
| 17:30:47 | gibi | see you all tomorrow o/ | |
| 17:31:02 | chateaulav | thanks | |
| 17:41:34 | opendevreview | Merged openstack/nova master: Allow per-context rule in error messages https://review.opendev.org/c/openstack/nova/+/816865 | |
| 17:45:32 | dansmith | whoami-rajat: so, functional tests fail without the api change in place, which I think means that we're not properly honoring the old microversion behavior | |
| 17:45:36 | dansmith | which is a good reason for this split | |
| 17:53:03 | whoami-rajat | dansmith, ack | |
| 17:59:35 | opendevreview | Dan Smith proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/820368 | |
| 17:59:36 | opendevreview | Dan Smith proposed openstack/nova master: Add volume-rebuild support to cinder module https://review.opendev.org/c/openstack/nova/+/830882 | |
| 17:59:36 | opendevreview | Dan Smith proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | |
| 17:59:48 | dansmith | whoami-rajat: ^ | |
| 18:00:04 | dansmith | whoami-rajat: assuming that first mini patch is good, we should be able to get that merged ASAP and cut down what remains | |
| 18:00:47 | dansmith | hmm, did I lose the reno? | |
| 18:01:22 | opendevreview | Dan Smith proposed openstack/nova master: Add API support for rebuilding BFV instances https://review.opendev.org/c/openstack/nova/+/830883 | |
| 18:01:28 | dansmith | there we go | |
| 18:01:51 | whoami-rajat | ack, thanks for splitting it up | |
| 18:02:05 | dansmith | whoami-rajat: so I think we need to get the rebuild flag down to the compute manager so it knows whether or not to trigger the new behavior | |
| 18:05:13 | whoami-rajat | dansmith, i agree with the usage of an old version of API but if they don't pass the flag, it will never reach the compute manager and should fail at API level | |
| 18:05:32 | whoami-rajat | but we need to still consider the old API new compute case | |
| 18:05:34 | dansmith | whoami-rajat: see the test failure in that middle patch :) | |
| 18:05:43 | whoami-rajat | will look into that | |
| 18:05:45 | dansmith | whoami-rajat: if the image ref does not change, we should rebuild the instance but not the volume, | |
| 18:05:56 | dansmith | but your code makes it still call rebuild, which will erase the root volume | |
| 18:06:48 | whoami-rajat | Ah ok, we support rebuilding volume backed instances having same image as the provided one | |
| 18:07:18 | whoami-rajat | so reimage_boot_volume should be checked in the manager, got it | |
| 18:07:18 | dansmith | right, the image can't change, but we do that because we don't destroy the root disk, so we require the image to be the same | |
| 18:07:32 | dansmith | yep | |
| 18:07:41 | whoami-rajat | ack, will work on that | |
| 18:07:42 | dansmith | also, | |