| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-02-23 | |||
| 11:38:13 | sean-k-mooney | 2919c3f393bb2e897cead2e62c598acadeae3b8bd1603ef8e171e4274ff1b2e0-primary.xml.gz is missing form the mirrors | |
| 11:38:39 | sean-k-mooney | so proably a sync issue | |
| 11:38:56 | sean-k-mooney | lyarwood: how is life in openshift land | |
| 11:39:33 | lyarwood | Yeah good, I've somehow ended up helping with the introduction of flavors into KubeVirt ^_^ | |
| 11:40:12 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/820368 | |
| 11:40:42 | sean-k-mooney | ok so pod spec templates or something like that ya | |
| 11:43:21 | sean-k-mooney | the idea of flavors in a k8s env would be somewhat differnt then ours i expect since the intent with k8s is to be much more dynmic in terms of each pod spec is used for that one set of pods but not reused across unrelated pods | |
| 11:44:03 | sean-k-mooney | so unlike openstack if you udated the kubevirt flavor i would expect that to propagate to everything that used it | |
| 11:59:52 | gibi | kashyap: https://bugs.launchpad.net/tripleo/+bug/1959014/comments/15 tldr; I don't think the original problem was reproduced in later runs linked in the bug | |
| 12:00:34 | sean-k-mooney | stephenfin: by the way nova is nolonger installable with -e because pbr cannot figure out the version | |
| 12:00:49 | gibi | sean-k-mooney: thanks for pushing the any-traits through. I will get back to the series to do the small nit followup and the perf measurements / tuning | |
| 12:01:16 | sean-k-mooney | stephenfin: i know there is a bug with the current pbr due to metadata or somehting like that but do you know if the impact on nova is expected | |
| 12:01:30 | sean-k-mooney | gibi: ack | |
| 12:02:34 | stephenfin | sean-k-mooney: There is? I wasn't aware of anything | |
| 12:02:48 | sean-k-mooney | if you install with devstack | |
| 12:02:58 | sean-k-mooney | then clone nova and pip install -e the clone | |
| 12:03:08 | sean-k-mooney | then when you restart the nova compute agent | |
| 12:03:10 | sean-k-mooney | or any of the rest | |
| 12:03:13 | sean-k-mooney | it will fail to run | |
| 12:03:32 | sean-k-mooney | because pbr will not be able to figure out the version | |
| 12:03:47 | sean-k-mooney | so you ahve to do a non -e install currently | |
| 12:04:02 | sean-k-mooney | which is annoying since you have to redo it every time you make a change | |
| 12:06:59 | gibi | hm, I haven't hit that issue yet ^^ | |
| 12:07:10 | gibi | probably my pbr is older | |
| 12:09:29 | sean-k-mooney | https://paste.opendev.org/show/812529/ | |
| 12:09:56 | sean-k-mooney | stephenfin: gibi that is what it looks liek in the journal | |
| 12:10:40 | stephenfin | That's weird. I haven't seen that eithe | |
| 12:10:41 | stephenfin | *either | |
| 12:10:53 | sean-k-mooney | have you done sudo pip install -e | |
| 12:11:05 | sean-k-mooney | of the repo or a differnt copy of the repo | |
| 12:11:14 | stephenfin | I didn't need to. It does an editable install by default | |
| 12:11:19 | stephenfin | DevStack that is | |
| 12:11:27 | gibi | yeah I have the editable nova in devstack too | |
| 12:11:36 | gibi | so then that is the difference | |
| 12:11:55 | sean-k-mooney | so ye dont use a second repo for dev | |
| 12:12:06 | sean-k-mooney | with devstafck using reclone=ture i guess | |
| 12:12:21 | gibi | I tend to pull from my dev repo to the devstack nova repo with git | |
| 12:12:38 | stephenfin | Yeah, me too | |
| 12:12:47 | sean-k-mooney | ok you do it that way instead of installign the dev one after the fact | |
| 12:12:49 | stephenfin | Or I push from the local to devstack | |
| 12:13:04 | stephenfin | (that's slower because you've to change branches) | |
| 12:13:08 | sean-k-mooney | i dont like having to commit for it to take effect most of the time | |
| 12:13:27 | sean-k-mooney | and since i have reclone true set its not safe to do dev in the devstack managed one | |
| 12:13:33 | stephenfin | git commit -asm TODO | |
| 12:13:39 | stephenfin | easy as pie | |
| 12:14:15 | sean-k-mooney | ya but that vs save and restart | |
| 12:14:36 | sean-k-mooney | anyway i think this is caused by the other pbr bug | |
| 12:14:51 | sean-k-mooney | but i think that has been fixed recently | |
| 12:15:58 | sean-k-mooney | https://review.opendev.org/c/openstack/pbr/+/662035 i think is realted to it | |
| 12:17:08 | stephenfin | so using pbr 5.8.1, I can use an editable install and still get a valid version for another pbr-based project I have | |
| 12:17:16 | stephenfin | so maybe it's the sudo part of things that's the issue | |
| 12:18:29 | sean-k-mooney | https://review.opendev.org/c/openstack/pbr/+/827977/1/releasenotes/notes/fix-pep517-metadata-regression-bc287e60e45b2732.yaml | |
| 12:20:25 | chateaulav | so i have the `tools/hooks/post_test_hook.sh` file that was an accidental change, but i cant seem to remove that change from the patchset. i have tried reset to its original commit but it doesnt like that and i cant seem to simply discard it. any ideas | |
| 12:21:00 | gibi | have you tried git rm tools/hooks/post_test_hook.sh ? | |
| 12:21:50 | chateaulav | yeah but then that deletes the file itself, and i dont want to commit it as deleted, that is no different then the typechange it is recognizing | |
| 12:23:07 | gibi | ahh so it is a link on mater | |
| 12:23:08 | gibi | master | |
| 12:23:10 | chateaulav | https://usercontent.irccloud-cdn.com/file/zqzGCZdB/image.png | |
| 12:23:25 | chateaulav | added 5 years ago | |
| 12:24:01 | chateaulav | when i try to reset it it does a weird staged and ustaged change at the same time, which wont allow me to commit | |
| 12:24:08 | sean-k-mooney | you can do git checkout -- <file> | |
| 12:24:18 | sean-k-mooney | to rest the file to what was in the parent commit | |
| 12:24:18 | chateaulav | ok, ill try that | |
| 12:24:41 | sean-k-mooney | or do git checkout <branch or commit> -- <file> | |
| 12:24:50 | sean-k-mooney | if you want to restrore it to a specific version | |
| 12:25:32 | gibi | $ git checkout HEAD^ -- tools/hooks/post_test_hook.sh | |
| 12:25:32 | gibi | gibizer@riverbed:~/upstream/git/nova D[eaf971cfda driver/secheduler/docs for Adds Pick guest CPU architecture based on host arch in libvirt driver support] [000] [13:25:23] | |
| 12:25:36 | gibi | $ git status | |
| 12:25:39 | gibi | HEAD detached at FETCH_HEAD | |
| 12:25:41 | gibi | Changes to be committed: | |
| 12:25:44 | gibi | (use "git restore --staged <file>..." to unstage) | |
| 12:25:46 | gibi | ahh sean-k-mooney was faster | |
| 12:25:48 | gibi | typechange: tools/hooks/post_test_hook.sh | |
| 12:26:01 | chateaulav | k | |
| 12:31:11 | opendevreview | Jonathan Race proposed openstack/nova master: driver/secheduler/docs for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053 | |
| 12:31:11 | opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | |
| 12:31:38 | chateaulav | perfect, appreciate the tip! | |
| 12:33:37 | sean-k-mooney | git restore i think can do somethign similar but its a much more recent tool in the git suite so not really famialr with how it works | |
| 12:34:46 | chateaulav | yeah, i can definitely say this whole process has thouroughly expanded my understanding of git | |
| 12:40:15 | gibi | git is nice but it has a learning curve | |
| 12:45:52 | sean-k-mooney | having used svn and perforce(breifly) i will take the learning curve over checking out indivugual files anyday | |
| 12:46:26 | sean-k-mooney | i know other tools like mercuiral exist that work in a similar way | |
| 12:46:43 | sean-k-mooney | but with out a distibuted version contol system like git we could not work the way we do today | |
| 12:47:10 | chateaulav | definitely | |
| 12:47:24 | sean-k-mooney | even the kernels email based approch depend on it to generate the patch files that are submitted | |
| 12:48:06 | gibi | agree | |
| 12:48:20 | gibi | I use clearcase and svn before git. git is superior | |
| 12:48:23 | gibi | *used | |
| 12:49:27 | sean-k-mooney | the centralised tools work fine if you can push to master | |
| 12:49:52 | sean-k-mooney | but unless everyone can commit directly they dont scale | |
| 12:50:39 | opendevreview | Merged openstack/nova master: VMware: Support volumes backed by VStorageObject https://review.opendev.org/c/openstack/nova/+/808791 | |
| 12:53:52 | yuval | Hey guys | |
| 12:53:58 | yuval | after elod upload | |
| 12:53:59 | yuval | https://review.opendev.org/c/openstack/nova/+/821606 | |
| 12:54:04 | yuval | I think this is ready | |
| 12:54:05 | gibi | bauzas, sean-k-mooney, chateaulav: I'm satisfied with the series https://review.opendev.org/q/topic:bp%252Fpick-guest-arch-based-on-host-arch-in-libvirt-driver the last patch adding the tempest test seem to work (nova can boot VMs) but still has some failing test cases. I think we can accept the implementation without the gate job as we know chateaulav is working on it | |
| 12:54:36 | gibi | yuval: you are next :) | |
| 12:54:41 | kashyap | gibi: Ah-ha! Reading. Thanks for the thorough response | |
| 12:54:55 | yuval | gibi: thanks | |
| 12:55:16 | chateaulav | gibi: thanks for the reviews and help! | |