| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2022-02-23 | |||
| 12:21:00 | gibi | have you tried git rm tools/hooks/post_test_hook.sh ? | |
| 12:21:50 | chateaulav | yeah but then that deletes the file itself, and i dont want to commit it as deleted, that is no different then the typechange it is recognizing | |
| 12:23:07 | gibi | ahh so it is a link on mater | |
| 12:23:08 | gibi | master | |
| 12:23:10 | chateaulav | https://usercontent.irccloud-cdn.com/file/zqzGCZdB/image.png | |
| 12:23:25 | chateaulav | added 5 years ago | |
| 12:24:01 | chateaulav | when i try to reset it it does a weird staged and ustaged change at the same time, which wont allow me to commit | |
| 12:24:08 | sean-k-mooney | you can do git checkout -- <file> | |
| 12:24:18 | sean-k-mooney | to rest the file to what was in the parent commit | |
| 12:24:18 | chateaulav | ok, ill try that | |
| 12:24:41 | sean-k-mooney | or do git checkout <branch or commit> -- <file> | |
| 12:24:50 | sean-k-mooney | if you want to restrore it to a specific version | |
| 12:25:32 | gibi | $ git checkout HEAD^ -- tools/hooks/post_test_hook.sh | |
| 12:25:32 | gibi | gibizer@riverbed:~/upstream/git/nova D[eaf971cfda driver/secheduler/docs for Adds Pick guest CPU architecture based on host arch in libvirt driver support] [000] [13:25:23] | |
| 12:25:36 | gibi | $ git status | |
| 12:25:39 | gibi | HEAD detached at FETCH_HEAD | |
| 12:25:41 | gibi | Changes to be committed: | |
| 12:25:44 | gibi | (use "git restore --staged <file>..." to unstage) | |
| 12:25:46 | gibi | ahh sean-k-mooney was faster | |
| 12:25:48 | gibi | typechange: tools/hooks/post_test_hook.sh | |
| 12:26:01 | chateaulav | k | |
| 12:31:11 | opendevreview | Jonathan Race proposed openstack/nova master: driver/secheduler/docs for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053 | |
| 12:31:11 | opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | |
| 12:31:38 | chateaulav | perfect, appreciate the tip! | |
| 12:33:37 | sean-k-mooney | git restore i think can do somethign similar but its a much more recent tool in the git suite so not really famialr with how it works | |
| 12:34:46 | chateaulav | yeah, i can definitely say this whole process has thouroughly expanded my understanding of git | |
| 12:40:15 | gibi | git is nice but it has a learning curve | |
| 12:45:52 | sean-k-mooney | having used svn and perforce(breifly) i will take the learning curve over checking out indivugual files anyday | |
| 12:46:26 | sean-k-mooney | i know other tools like mercuiral exist that work in a similar way | |
| 12:46:43 | sean-k-mooney | but with out a distibuted version contol system like git we could not work the way we do today | |
| 12:47:10 | chateaulav | definitely | |
| 12:47:24 | sean-k-mooney | even the kernels email based approch depend on it to generate the patch files that are submitted | |
| 12:48:06 | gibi | agree | |
| 12:48:20 | gibi | I use clearcase and svn before git. git is superior | |
| 12:48:23 | gibi | *used | |
| 12:49:27 | sean-k-mooney | the centralised tools work fine if you can push to master | |
| 12:49:52 | sean-k-mooney | but unless everyone can commit directly they dont scale | |
| 12:50:39 | opendevreview | Merged openstack/nova master: VMware: Support volumes backed by VStorageObject https://review.opendev.org/c/openstack/nova/+/808791 | |
| 12:53:52 | yuval | Hey guys | |
| 12:53:58 | yuval | after elod upload | |
| 12:53:59 | yuval | https://review.opendev.org/c/openstack/nova/+/821606 | |
| 12:54:04 | yuval | I think this is ready | |
| 12:54:05 | gibi | bauzas, sean-k-mooney, chateaulav: I'm satisfied with the series https://review.opendev.org/q/topic:bp%252Fpick-guest-arch-based-on-host-arch-in-libvirt-driver the last patch adding the tempest test seem to work (nova can boot VMs) but still has some failing test cases. I think we can accept the implementation without the gate job as we know chateaulav is working on it | |
| 12:54:36 | gibi | yuval: you are next :) | |
| 12:54:41 | kashyap | gibi: Ah-ha! Reading. Thanks for the thorough response | |
| 12:54:55 | yuval | gibi: thanks | |
| 12:55:16 | chateaulav | gibi: thanks for the reviews and help! | |
| 12:55:39 | gibi | chateaulav: no problem. thanks for working on this feature | |
| 13:04:21 | opendevreview | Felix Huettner proposed openstack/nova stable/queens: Gracefull recovery when attaching volume fails https://review.opendev.org/c/openstack/nova/+/830602 | |
| 13:05:43 | gibi | yuval: I'm +2 | |
| 13:10:43 | gibi | sean-k-mooney: I think pedro answered your question here https://review.opendev.org/c/openstack/nova/+/828387 | |
| 13:26:18 | sean-k-mooney | they responded but didnt really adress my concern | |
| 13:27:47 | sean-k-mooney | gibi: we could proceed with this update but i think this has the inverse problem | |
| 13:28:17 | sean-k-mooney | the old doc described live_migration_downtime as the maxium but failed to capture it was best effort | |
| 13:28:37 | sean-k-mooney | the new docs to me at least imples that live_migration_downtime is the minium downtime and it can be larger | |
| 13:29:52 | sean-k-mooney | to me live_migration_downtime is the maxium downtime we have asked libvirt to not exceed but its best effort | |
| 13:30:08 | sean-k-mooney | so it shoudl be less then that but in some case may be larger | |
| 13:30:51 | gibi | I see | |
| 13:31:10 | gibi | you are right | |
| 13:49:01 | sean-k-mooney | gibi: so i doen know if we want to merge the update as is or rephrase | |
| 13:49:16 | kashyap | gibi: Very clear analysis in the bug; nice work! To tie up the loose end, they're temporarily going to skip it - https://review.opendev.org/c/openstack/openstack-tempest-skiplist/+/828243 | |
| 14:00:10 | opendevreview | Merged openstack/nova master: VmWare: Remove unused legacy_nodename regex https://review.opendev.org/c/openstack/nova/+/806336 | |
| 14:04:16 | opendevreview | Rajat Dhasmana proposed openstack/nova master: Add support for volume backed server rebuild https://review.opendev.org/c/openstack/nova/+/820368 | |
| 14:12:49 | pmonteir | pedro ans | |
| 14:13:07 | pmonteir | ops, sry | |
| 14:27:17 | opendevreview | Pedro Monteiro Azevedo de Moura Almeida proposed openstack/nova master: Update live_migration_downtime definition https://review.opendev.org/c/openstack/nova/+/828387 | |
| 14:33:17 | pmonteir | sean-k-mooney: hey, saw u and gibi were talking about the change above today and I agree with the comment u left there, I didn't understand what u meant in the first comment, but got it now! If u can take a look when u have some time, pls do :D | |
| 14:35:28 | gibi | pmonteir: sure, I will check | |
| 14:51:01 | pmonteir | thank you! :) | |
| 14:55:29 | sean-k-mooney | pmonteir: thanks im fine with the new wording so +2 | |
| 15:01:21 | gibi | pmonteir: then it is approved :) | |
| 15:04:15 | mfo | hey folks! i'm looking for patch reviewers/feedback for bug 1960758, if you have a chance :) thanks in advance! | |
| 15:04:22 | mfo | https://bugs.launchpad.net/nova/+bug/1960758 | |
| 15:04:35 | mfo | (UEFI libvirt servers can't boot on Ubuntu 20.04 hypervisors with Ussuri/Victoria) | |
| 15:08:00 | pmonteir | thanks for the answering so quickly, guys! :) | |
| 15:09:52 | opendevreview | Felix Huettner proposed openstack/nova stable/queens: Gracefull recovery when attaching volume fails https://review.opendev.org/c/openstack/nova/+/829861 | |
| 15:10:44 | dansmith | bauzas: do you have opinions on my comment about splitting this up? https://review.opendev.org/c/openstack/nova/+/820368/8 | |
| 15:10:57 | dansmith | bauzas: it's huge right now, in terms of what all it touches | |
| 15:11:02 | bauzas | dansmith: looking | |
| 15:11:14 | dansmith | I can help him split it if you think it's important, but if I'm the only one I'll shut up | |
| 15:12:08 | bauzas | dansmith: nah, I agree with you | |
| 15:12:10 | sean-k-mooney | mfo:i think we alredy fixed this | |
| 15:12:29 | bauzas | adding a microversion plus a new event by the same change is large | |
| 15:12:53 | dansmith | bauzas: okay, can you slap a quick comment on there? I'll work with him to split after the next rev | |
| 15:13:06 | dansmith | bauzas: I assume this is still on the slate for merging yeah? | |
| 15:13:12 | bauzas | dansmith: doing it nbow | |
| 15:13:20 | dansmith | bauzas: <3 | |
| 15:13:27 | sean-k-mooney | mfo: teh secvure boot firemware shoudl not require secure boot to function it just supports it | |
| 15:13:56 | sean-k-mooney | mfo: so nova should not need to have any logic to select the non secure boot version | |
| 15:14:37 | sean-k-mooney | mfo: i aslo done se any fix againt master | |
| 15:14:51 | bauzas | dansmith: done | |
| 15:14:59 | dansmith | thanks | |
| 15:15:01 | bauzas | I explained why it's important to split | |
| 15:15:03 | sean-k-mooney | you seam to have started with a sable only patch https://review.opendev.org/c/openstack/nova/+/828980 | |
| 15:15:20 | sean-k-mooney | which i dont think is correct | |
| 15:18:40 | mfo | sean-k-mooney, thanks for looking. i'll follow up on the sec boot firmware (no) needs that you mentioned. and this is "fixed" on wallaby and later/master w/ the implementation of secboot spec/support, due a refactor (this a bit buried in the commit msg, but the research has been done to go w/ stable-only. :) | |
| 15:19:22 | mfo | and, seconding pmonteir above, thx for answering so quickly! | |
| 15:19:28 | sean-k-mooney | mfo: the secure booth ovmf image shoudl work without secure boot enabled howevdr | |
| 15:19:59 | sean-k-mooney | we should not need to filter like this form my understandig | |
| 15:20:06 | sean-k-mooney | do you know why this is requried | |