| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-10-21 | |||
| 16:00:36 | stephenfin | I think ironicclient was done a few cycles ago | |
| 16:00:41 | sean-k-mooney | gibi: you are assuming neutron care about heat | |
| 16:01:04 | sean-k-mooney | they proably do but maybe not | |
| 16:01:10 | stephenfin | wait, no, there's still ironicclient. It's just not a mandatory import | |
| 16:01:13 | stephenfin | *requirements | |
| 16:01:28 | artom | stephenfin, yeah... | |
| 16:01:55 | artom | Like, I'm taking part in this debat, but who am I kidding, I won't be the one doing the work - I tried to start, then just ran out of steam | |
| 16:02:29 | gibi | stephenfin: ouch, you are right :) | |
| 16:02:47 | artom | OTOH, what's kind of annoying is that the problem that I'm fixing in https://review.opendev.org/c/openstack/openstacksdk/+/741688 is still a problem. | |
| 16:02:57 | artom | image is *still* optional, when it isn't in the PAI | |
| 16:02:59 | artom | *API | |
| 16:03:50 | artom | And it's *still* missing the kwargs things for all the other params that are in the API | |
| 16:04:02 | stephenfin | artom: I should have looked at that. My bad :( If you got time to rebase it onto the feature/r1 branch (which will be merged into master soon enough) I'll review it in the AM | |
| 16:04:19 | artom | stephenfin, I need to fix the unit test below it and rebase | |
| 16:04:31 | artom | stephenfin, it's just such a slog, and I'm lazy and easily distracted | |
| 16:04:42 | stephenfin | you should try cocaine | |
| 16:04:50 | artom | Speaking from experience? | |
| 16:04:58 | stephenfin | all the bankers I know swear by it | |
| 16:05:29 | artom | Explains the state of the financial system | |
| 16:07:53 | gibi | happy hours already? | |
| 16:31:24 | sean-k-mooney | am are we goint to call it a day or do we want to do the pain points discussion | |
| 16:31:29 | sean-k-mooney | since we got time back | |
| 16:31:54 | sean-k-mooney | bauzas: ^ | |
| 16:31:56 | bauzas | sean-k-mooney: I prefer to leave early | |
| 16:32:18 | sean-k-mooney | ok | |
| 16:32:38 | bauzas | sean-k-mooney: I feel we can make all the agenda by tomorrow | |
| 16:33:04 | bauzas | we have 7 topics left | |
| 16:33:11 | sean-k-mooney | well we might but there is also tc sesssions tomorow | |
| 16:33:25 | sean-k-mooney | so we might not have quorm for the full day | |
| 16:33:39 | sean-k-mooney | but yes we likely can finish tomorow | |
| 16:34:11 | bauzas | sean-k-mooney: you're right, we're constrainted by the big TC RBAC thing | |
| 16:34:43 | bauzas | sean-k-mooney: but I feel we can postpone a few topics if we really need | |
| 16:35:10 | sean-k-mooney | as a last resort yes but in general we shoudl try to avoid that | |
| 16:35:40 | bauzas | agreed | |
| 16:35:47 | bauzas | I'll do a timekeeping thing | |
| 16:36:36 | bauzas | and try to not exceed 30 mins per topic | |
| 16:37:17 | sean-k-mooney | ok im going to step away for a few minutes. i was still using my wired headset today since i did not find my wireless one this morning so i have slight headach anyway. | |
| 16:38:01 | sean-k-mooney | it went away after 20 mins of not wareing it yesterday so hopefully the same will hapen today. | |
| 16:38:21 | bauzas | sean-k-mooney: yeah that's also why I wanted to stop earlier | |
| 16:38:26 | bauzas | we were not in the room | |
| 16:38:33 | bauzas | asking people to rejoin was an effort | |
| 16:38:50 | bauzas | so it would have meant 1 topic to discuss | |
| 16:39:16 | sean-k-mooney | yep getting momentum back is hard | |
| 16:41:01 | bauzas | sean-k-mooney: I see the TC discussion around RBAC occuring at 1:30pm until 3pm | |
| 16:41:48 | bauzas | sean-k-mooney: I accordingly flipped topics in the agenda | |
| 16:42:12 | sean-k-mooney | ack | |
| 17:09:42 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add a WA flag waiting for vif-plugged event during reboot https://review.opendev.org/c/openstack/nova/+/813419 | |
| 17:15:14 | gibi | artom: I've fixed up your comments ^^ | |
| 17:17:20 | artom | gibi, *looks* you have some more asserts in the test that are... unrelated? Like I don't know how anal we want to be about this, but it's really only the last one we care about | |
| 17:19:08 | gibi | artom: I can drop the other asserts | |
| 17:19:26 | gibi | I'm also not sure about our strategy in these tests | |
| 17:19:45 | gibi | I admit I copied a previous test and modified that hence the bigs cope | |
| 17:19:48 | artom | Our unit tests are overly tied to the implementation and confusing? Say it ain't so ;) | |
| 17:20:35 | gibi | I don't like our unit tests either :) | |
| 17:20:36 | artom | gibi, yeah, I figured that was the case :) I think in this situation, with the code being what it is, what you have is OK | |
| 17:20:53 | artom | Well, minus the extraneous asserts | |
| 17:29:47 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add a WA flag waiting for vif-plugged event during reboot https://review.opendev.org/c/openstack/nova/+/813419 | |
| 17:30:40 | gibi | artom: ^^ | |
| 17:32:04 | artom | gibi, cool, thanks for your patience :) | |
| 17:32:28 | gibi | artom: no worries. I do want to have nice unit tests so at least lets have the new ones nicer | |
| 17:35:33 | sean-k-mooney | i think the unit tests we write as small local tests are nice | |
| 17:36:10 | sean-k-mooney | but some of them are close to funcitonal test then unit | |
| 17:36:55 | sean-k-mooney | in that they test the behavior of things that are down several calls. | |
| 17:37:40 | gibi | yeah | |
| 17:37:55 | gibi | I finished for today. See you tomorrow | |
| 17:37:57 | gibi | o/ | |
| 17:38:53 | sean-k-mooney | o/ | |
| 23:50:19 | rm_work | hey, was there a specific reason that properties/metadata isn't something you can filter by in a server list? | |
| 23:54:26 | rm_work | or, would that be a patch you might accept? | |
| #openstack-nova - 2021-10-22 | |||
| 00:29:10 | brinzhang | bauzas: I agree with gibi and sean-k-mooney, I have no difficulty discussing it, thanks | |
| 07:25:58 | gibi | morning | |
| 08:00:45 | bauzas | good morning | |
| 08:09:22 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add a WA flag waiting for vif-plugged event during reboot https://review.opendev.org/c/openstack/nova/+/813419 | |
| 08:13:32 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add a WA flag waiting for vif-plugged event during reboot https://review.opendev.org/c/openstack/nova/+/813419 | |
| 08:27:42 | opendevreview | Balazs Gibizer proposed openstack/nova stable/pike: Add a WA flag waiting for vif-plugged event during reboot https://review.opendev.org/c/openstack/nova/+/813437 | |
| 08:56:27 | stephenfin | bauzas: Morning o/ Care to look at https://review.opendev.org/c/openstack/nova/+/814547 | |
| 08:56:59 | bauzas | stephenfin: ok thanks for finding it ! | |
| 08:58:59 | bauzas | stephenfin: just a thought, you're not explaining in https://review.opendev.org/c/openstack/nova/+/814547/1//COMMIT_MSG why we now have a regression | |
| 08:59:27 | stephenfin | oh, sorry, the regression is because I removed I6ce930fa86c82da1008089791942b1fff7d04c18 | |
| 08:59:42 | stephenfin | I mention that at the end of the commit message. It's kind of implicit though, admittedly | |
| 09:00:09 | stephenfin | I thought I'd fixed the issue that made I6ce930fa86c82da1008089791942b1fff7d04c18 necessary. Evidently not :( | |
| 09:00:52 | opendevreview | Rajat Dhasmana proposed openstack/nova-specs master: Add spec for volume backed server rebuild https://review.opendev.org/c/openstack/nova-specs/+/809621 | |
| 09:10:48 | bauzas | stephenfin: ok, then I'll leave a comment telling it and then I'll approve | |
| 09:12:48 | bauzas | done. | |
| 09:36:44 | stephenfin | ty | |
| 09:40:59 | opendevreview | Merged openstack/nova master: db: Increase timeout for migration tests https://review.opendev.org/c/openstack/nova/+/814547 | |
| 10:04:26 | opendevreview | Wenping Song proposed openstack/nova master: Support concurrently add hosts to aggregates https://review.opendev.org/c/openstack/nova/+/815105 | |
| 10:16:06 | gibi | sean-k-mooney[m]: do I understand correctly that neutron's sriov-nic-agent only sends plugtime plug/unplug events for vnic_type=direct ports but not for vnic_type=direct-physical ports | |
| 10:16:12 | gibi | ? | |
| 10:18:33 | gibi | sean-k-mooney[m]: https://github.com/openstack/neutron/blob/6d8e830859cd4ac9708701b8e344fdc68cbcaebb/neutron/plugins/ml2/drivers/mech_sriov/mech_driver/mech_driver.py#L135-L137 | |
| 10:20:44 | sean-k-mooney[m] | hum that is a good question. i guess that woud be the case yes since for PFs the agent does not configure anything since anything it did would be undone whne we detach the device from the host kernel and attach it to the guest | |
| 10:21:55 | sean-k-mooney[m] | i have never actully check its behavior in that regard | |
| 10:22:28 | gibi | in my local env I see plug/unplug event during nova hard reboot for VF ports but not for PF ports so probably this is the case | |
| 10:23:06 | sean-k-mooney[m] | yes so you might need to make an excption in your workaround patch | |
| 10:23:40 | sean-k-mooney[m] | perhaps change it form a boolean to a list of vnic_types | |
| 10:24:10 | sean-k-mooney[m] | odl only support vnic_type normal and vhost_user | |
| 10:24:20 | sean-k-mooney[m] | well vhost-user | |
| 10:24:52 | gibi | I think the doc in the patch still correct when we say set the flag only for ml2/ovs or networking-odl | |
| 10:25:19 | gibi | I might extend that with mech_sriov + vnic_type direct | |
| 10:25:31 | sean-k-mooney[m] | right but if you filter by vnic type you can use it when you have odl and sriov on the same host | |