| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-10-21 | |||
| 16:39:16 | sean-k-mooney | yep getting momentum back is hard | |
| 16:41:01 | bauzas | sean-k-mooney: I see the TC discussion around RBAC occuring at 1:30pm until 3pm | |
| 16:41:48 | bauzas | sean-k-mooney: I accordingly flipped topics in the agenda | |
| 16:42:12 | sean-k-mooney | ack | |
| 17:09:42 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add a WA flag waiting for vif-plugged event during reboot https://review.opendev.org/c/openstack/nova/+/813419 | |
| 17:15:14 | gibi | artom: I've fixed up your comments ^^ | |
| 17:17:20 | artom | gibi, *looks* you have some more asserts in the test that are... unrelated? Like I don't know how anal we want to be about this, but it's really only the last one we care about | |
| 17:19:08 | gibi | artom: I can drop the other asserts | |
| 17:19:26 | gibi | I'm also not sure about our strategy in these tests | |
| 17:19:45 | gibi | I admit I copied a previous test and modified that hence the bigs cope | |
| 17:19:48 | artom | Our unit tests are overly tied to the implementation and confusing? Say it ain't so ;) | |
| 17:20:35 | gibi | I don't like our unit tests either :) | |
| 17:20:36 | artom | gibi, yeah, I figured that was the case :) I think in this situation, with the code being what it is, what you have is OK | |
| 17:20:53 | artom | Well, minus the extraneous asserts | |
| 17:29:47 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add a WA flag waiting for vif-plugged event during reboot https://review.opendev.org/c/openstack/nova/+/813419 | |
| 17:30:40 | gibi | artom: ^^ | |
| 17:32:04 | artom | gibi, cool, thanks for your patience :) | |
| 17:32:28 | gibi | artom: no worries. I do want to have nice unit tests so at least lets have the new ones nicer | |
| 17:35:33 | sean-k-mooney | i think the unit tests we write as small local tests are nice | |
| 17:36:10 | sean-k-mooney | but some of them are close to funcitonal test then unit | |
| 17:36:55 | sean-k-mooney | in that they test the behavior of things that are down several calls. | |
| 17:37:40 | gibi | yeah | |
| 17:37:55 | gibi | I finished for today. See you tomorrow | |
| 17:37:57 | gibi | o/ | |
| 17:38:53 | sean-k-mooney | o/ | |
| 23:50:19 | rm_work | hey, was there a specific reason that properties/metadata isn't something you can filter by in a server list? | |
| 23:54:26 | rm_work | or, would that be a patch you might accept? | |
| #openstack-nova - 2021-10-22 | |||
| 00:29:10 | brinzhang | bauzas: I agree with gibi and sean-k-mooney, I have no difficulty discussing it, thanks | |
| 07:25:58 | gibi | morning | |
| 08:00:45 | bauzas | good morning | |
| 08:09:22 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add a WA flag waiting for vif-plugged event during reboot https://review.opendev.org/c/openstack/nova/+/813419 | |
| 08:13:32 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add a WA flag waiting for vif-plugged event during reboot https://review.opendev.org/c/openstack/nova/+/813419 | |
| 08:27:42 | opendevreview | Balazs Gibizer proposed openstack/nova stable/pike: Add a WA flag waiting for vif-plugged event during reboot https://review.opendev.org/c/openstack/nova/+/813437 | |
| 08:56:27 | stephenfin | bauzas: Morning o/ Care to look at https://review.opendev.org/c/openstack/nova/+/814547 | |
| 08:56:59 | bauzas | stephenfin: ok thanks for finding it ! | |
| 08:58:59 | bauzas | stephenfin: just a thought, you're not explaining in https://review.opendev.org/c/openstack/nova/+/814547/1//COMMIT_MSG why we now have a regression | |
| 08:59:27 | stephenfin | oh, sorry, the regression is because I removed I6ce930fa86c82da1008089791942b1fff7d04c18 | |
| 08:59:42 | stephenfin | I mention that at the end of the commit message. It's kind of implicit though, admittedly | |
| 09:00:09 | stephenfin | I thought I'd fixed the issue that made I6ce930fa86c82da1008089791942b1fff7d04c18 necessary. Evidently not :( | |
| 09:00:52 | opendevreview | Rajat Dhasmana proposed openstack/nova-specs master: Add spec for volume backed server rebuild https://review.opendev.org/c/openstack/nova-specs/+/809621 | |
| 09:10:48 | bauzas | stephenfin: ok, then I'll leave a comment telling it and then I'll approve | |
| 09:12:48 | bauzas | done. | |
| 09:36:44 | stephenfin | ty | |
| 09:40:59 | opendevreview | Merged openstack/nova master: db: Increase timeout for migration tests https://review.opendev.org/c/openstack/nova/+/814547 | |
| 10:04:26 | opendevreview | Wenping Song proposed openstack/nova master: Support concurrently add hosts to aggregates https://review.opendev.org/c/openstack/nova/+/815105 | |
| 10:16:06 | gibi | sean-k-mooney[m]: do I understand correctly that neutron's sriov-nic-agent only sends plugtime plug/unplug events for vnic_type=direct ports but not for vnic_type=direct-physical ports | |
| 10:16:12 | gibi | ? | |
| 10:18:33 | gibi | sean-k-mooney[m]: https://github.com/openstack/neutron/blob/6d8e830859cd4ac9708701b8e344fdc68cbcaebb/neutron/plugins/ml2/drivers/mech_sriov/mech_driver/mech_driver.py#L135-L137 | |
| 10:20:44 | sean-k-mooney[m] | hum that is a good question. i guess that woud be the case yes since for PFs the agent does not configure anything since anything it did would be undone whne we detach the device from the host kernel and attach it to the guest | |
| 10:21:55 | sean-k-mooney[m] | i have never actully check its behavior in that regard | |
| 10:22:28 | gibi | in my local env I see plug/unplug event during nova hard reboot for VF ports but not for PF ports so probably this is the case | |
| 10:23:06 | sean-k-mooney[m] | yes so you might need to make an excption in your workaround patch | |
| 10:23:40 | sean-k-mooney[m] | perhaps change it form a boolean to a list of vnic_types | |
| 10:24:10 | sean-k-mooney[m] | odl only support vnic_type normal and vhost_user | |
| 10:24:20 | sean-k-mooney[m] | well vhost-user | |
| 10:24:52 | gibi | I think the doc in the patch still correct when we say set the flag only for ml2/ovs or networking-odl | |
| 10:25:19 | gibi | I might extend that with mech_sriov + vnic_type direct | |
| 10:25:31 | sean-k-mooney[m] | right but if you filter by vnic type you can use it when you have odl and sriov on the same host | |
| 10:26:05 | gibi | yeah, I can ignore direct-physical ports when waiting for plug | |
| 10:26:23 | sean-k-mooney[m] | ya i guess that also works | |
| 10:26:49 | gibi | sean-k-mooney[m]: what would be your way to filter? | |
| 10:28:37 | sean-k-mooney[m] | if we make the config option a list of vnic_types to wait for on hard reboot we just do | |
| 10:28:59 | sean-k-mooney[m] | if vif.vnic_type in CONF.wait_on_reboot: … | |
| 10:29:42 | gibi | hm yeah that is also a way | |
| 10:29:59 | sean-k-mooney[m] | im not sure if we need to have different behavor for other vnic types like the cyborg ones | |
| 10:30:24 | sean-k-mooney[m] | or baremetal though thtat is used only by ironic | |
| 10:31:41 | sean-k-mooney[m] | i wouold have to look at the spec again but when we are using cyborg provided smart nics neutron still sends the events right? | |
| 10:35:06 | gibi | hm neutron seems to support accelerator-direct with mech_sriov, and direct means a VF so I assume there is plug time events | |
| 10:35:51 | sean-k-mooney[m] | i would assume so too but its not actully mentioned in https://specs.openstack.org/openstack/nova-specs/specs/xena/implemented/sriov-smartnic-support.html | |
| 10:38:00 | sean-k-mooney[m] | gibi so you could either limit this to the case we know work (normal,direct,vhost-user) or you could filet out the case we know wont work (direct-physical,acclerator-direct-physical) | |
| 10:38:36 | gibi | yeah | |
| 10:38:45 | gibi | as the config today needs to be opt-in | |
| 10:38:55 | gibi | I guess opting in to supported vnic types are better | |
| 10:39:20 | gibi | when you say vhost-user why is not enough to simply filter for vnic_type direct? | |
| 10:40:03 | sean-k-mooney[m] | in that case the list would be normal,direct,macvtap,acclerator-direct,vhost-user | |
| 10:40:16 | sean-k-mooney[m] | well direct shoud work right | |
| 10:40:47 | sean-k-mooney[m] | hardware offloaded ovs with ml2/ovs support direct and will send plug time events and the sriov nic agent should also | |
| 10:41:10 | sean-k-mooney[m] | and vhost-user should also work with ml2/ovs and ml2/odl | |
| 10:41:35 | sean-k-mooney[m] | the sriov nica agent should support macvtap plug time events | |
| 10:42:16 | sean-k-mooney[m] | ml2/ovs should also send them for vdpa | |
| 10:42:17 | gibi | for the deployer probably it is easier to just list vnic_types and not go into details like vhost-user | |
| 10:42:30 | sean-k-mooney[m] | vhost-user is a vnic type | |
| 10:42:40 | gibi | sean-k-mooney[m]: is it? | |
| 10:42:43 | sean-k-mooney[m] | yes | |
| 10:42:48 | sean-k-mooney[m] | its not a vif_type | |
| 10:43:22 | gibi | blob/6d8e830859cd4ac9708701b8e344fdc68cbcaebb/neutron/plugins/ml2/drivers/mech_sriov/mech_driver/mech_driver.py#L164 | |
| 10:43:28 | gibi | sorry | |
| 10:43:30 | gibi | wrong buffe4r | |
| 10:43:34 | gibi | https://github.com/openstack/neutron-lib/blob/f01b2e9025d33aeff3bf22ea2568bda036878819/neutron_lib/api/definitions/portbindings.py#L131 | |
| 10:43:38 | sean-k-mooney[m] | so i think if you want to hard code it just filter out direct-physical,baremetal and acclerator-direct-physical | |
| 10:43:39 | gibi | se here are the vnic_types | |
| 10:44:26 | gibi | I don't see vhost-user as vnic type in that list | |
| 10:45:17 | sean-k-mooney[m] | oh sorry maybe your right i have not looked at dpdk in 2 years or more | |
| 10:45:53 | sean-k-mooney[m] | i might be miss rememebvring let me check the ml2/driver but i guess its vnic_normal | |
| 10:46:04 | gibi | I thin it is mapped to normal yes | |
| 10:46:22 | gibi | anyhow I think we are in agreement to have this filtering based on vnic_type | |
| 10:46:33 | gibi | I think I will amend the current patch with that | |
| 10:46:47 | sean-k-mooney[m] | ya you are right it is | |
| 10:47:42 | sean-k-mooney[m] | so we should just skip waiting then for *-physical and baremetal | |
| 10:48:38 | sean-k-mooney[m] | looking at the other vnic_types i dont think vnic_type smartnic is used with ovs or odl | |