Posted	Nick	Remark
#openstack-nova - 2021-09-21
15:45:03	lyarwood	well that's on the stable team who want the second bot surely?
15:45:11	lyarwood	I don't get the argument here tbh
15:45:31	lyarwood	we want the cherry-pick job and are happy with the overhead
15:45:37	lyarwood	surely that's enough?
15:45:47	clarkb	I've got two main concerns. The first is that after many yaers we still act like proposing a non backport change to stable branches is immediately wrong. This is frustraing for people like me who basically only do that when touching stable branches
15:46:09	clarkb	the second issue is that any linter applied to commit messages is problematic because you don't typically run linting post commit
15:46:10	sean-k-mooney	im more or less of the opipion that we keep the cherry pick lines and enforce them in a job or we done enforce them in a job and dont require them any more
15:46:55	sean-k-mooney	clarkb: well actully having the bot tell you its wrong to propose directly to stable was one of the goals of the script
15:47:12	sean-k-mooney	clarkb: its not that uncommon to have one off patches propsoed directly to stable
15:48:07	sean-k-mooney	i have -1'd patches a cople of time for that and explained that the issue need to be resolved in master first
15:48:39	elodilles	clarkb: just for the record, this cherry-pick-check is only in nova repository (well, and afaik cyborg adopted it as well), all the other repositories are not having it
15:53:36	lyarwood	clarkb: sorry back, I appreciate that the initial -1 is slightly off putting but again if the stable team looking after the repo are happy to do the work to fix this while they approve then I can't see an issue here.
15:53:47	opendevreview	Stephen Finucane proposed openstack/nova master: tools: Ignore bot-generated branch creation patches https://review.opendev.org/c/openstack/nova/+/810285
15:54:04	stephenfin	lyarwood, sean-k-mooney, elodilles: eh? ^
15:54:25	gibi	stephenfin: thanks!
15:54:28	stephenfin	no need to backport that, obv. It'll just avoid this discussion come stable/yoga creation
15:54:28	dansmith	stephenfin: can we not just agree on some flag for bot-generated things?
15:54:34	lyarwood	ha hackaroundFinucane has entered the chat
15:54:54	stephenfin	dansmith: Sure. I just don't want to fix the bot :)
15:55:02	dansmith	checking for those strings seems fragile, but I'll also say I agree with lyarwood and do not understand why humans can't just handle this
15:56:08	dansmith	are the bots always the same userid?
15:56:26	dansmith	i.e. checking for owner might just be easier
15:56:44	clarkb	I think there are a couple of bots but it is a small number
15:57:46	bauzas	reminder : 3 mins before the nova meeting
15:58:26	bauzas	honestly, I stopped discussing this
15:58:55	dansmith	I also think that assuming everything proposed against stable is wrong until proven right is the correct approach, just FYI
15:59:44	clarkb	ok I won't worry about the bot being told it is wrong then
15:59:57	opendevreview	Stephen Finucane proposed openstack/nova master: tools: Ignore bot-generated branch creation patches https://review.opendev.org/c/openstack/nova/+/810285
15:59:59	stephenfin	dansmith: Good idea ^
16:00:23	dansmith	stephenfin: ++
16:00:51	bauzas	#startmeeting nova
16:00:51	opendevmeet	Meeting started Tue Sep 21 16:00:51 2021 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:00:51	opendevmeet	Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:00:51	opendevmeet	The meeting name has been set to 'nova'
16:01:14	bauzas	#link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting
16:01:28	bauzas	sorry for interupting you, folks :)
16:01:37	bauzas	who's around ?
16:01:45	dansmith	o/
16:01:49	lyarwood	\o
16:01:53	elodilles	o/
16:02:28	gibi	o/
16:02:55	bauzas	we have some large discussions today, let's start quickly
16:03:04	bauzas	#topic Bugs (stuck/critical)
16:03:08	bauzas	No Critical bug
16:03:14	bauzas	#link 13 new untriaged bugs (-0 since the last meeting): #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New
16:03:18	bauzas	no open bugs marked with xena-rc-potential tag #link https://bugs.launchpad.net/nova/+bugs?field.tag=xena-rc-potential
16:03:21	bauzas	please start marking release critical bugs with xena-rc-potential tag
16:03:34	bauzas	reminder, we are in RC phase
16:03:42	bauzas	meaning that we should focus on regression bugs
16:04:01	bauzas	yoga is now the master branch
16:04:10	bauzas	any bug to discuss ?
16:04:37	bauzas	#topic Gate status
16:04:43	bauzas	Nova gate bugs #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure
16:04:46	bauzas	we have a long list
16:04:53	bauzas	Placement periodic job status #link https://zuul.openstack.org/builds?project=openstack%2Fplacement&pipeline=periodic-weekly
16:05:03	bauzas	we now we failed because of a dependency issue
16:05:08	bauzas	know* we
16:05:30	bauzas	but now https://review.opendev.org/c/openstack/placement/+/810001 is merged
16:05:34	bauzas	so we can recheck
16:05:43	bauzas	any concern so far ?
16:06:04	bauzas	moving on
16:06:10	bauzas	Please look at the gate failures, file a bug, and add an elastic-recheck signature in the opendev/elastic-recheck repo (example: #link https://review.opendev.org/#/c/759967)
16:06:19	bauzas	#topic Release Planning
16:06:30	bauzas	(we'll discuss the placement dependency bump later)
16:06:37	bauzas	Release tracking etherpad #link https://etherpad.opendev.org/p/nova-xena-rc-potential
16:06:51	bauzas	as you can see, nothing fancy to tell
16:06:57	gibi	we need https://review.opendev.org/c/openstack/nova/+/810192 then an RC2 for nova
16:07:01	bauzas	most of our efforts should go to merging bugfixes
16:07:19	bauzas	gibi: right, I forgot about it
16:08:16	bauzas	strangely, LP says Fix Released for Xena https://bugs.launchpad.net/nova/+bug/1944111
16:08:20	gibi	for some reason the bug is not showing up in the rc critical query
16:08:47	gibi	feels like an LP bug around branching
16:08:57	bauzas	yup
16:09:06	bauzas	will add it in the etherpad for tracking
16:09:22	gibi	already done :)
16:09:29	bauzas	hah
16:09:35	bauzas	naïce ;)
16:09:57	bauzas	ok, let's wait a bit for releasing RC2
16:10:06	bauzas	We now have RC1 releases for both Nova and Placement #link https://review.opendev.org/c/openstack/releases/+/808706 and https://review.opendev.org/c/openstack/releases/+/808713
16:10:12	bauzas	We will need a Placement RC2 release due to #link https://review.opendev.org/c/openstack/placement/+/810001
16:10:36	bauzas	https://review.opendev.org/c/openstack/placement/+/810193 needs special treatme
16:10:41	bauzas	treatment
16:10:57	bauzas	+2d now
16:11:17	gibi	we have the last RC deadline at 1st of Oct afaik
16:11:25	bauzas	yeah
16:11:29	gibi	so yes, we can hold up RC2 a bit to see if anything else pops up
16:11:34	bauzas	hence me saying let's hold a bit for a RC2 proposal
16:11:43	bauzas	ya
16:11:54	bauzas	Remember to propose regression bugfixes for a new RC with nova-xena-rc-potential
16:12:06	bauzas	#topic Review priorities
16:12:14	bauzas	https://review.opendev.org/q/status:open+(project:openstack/nova+OR+project:openstack/placement)+label:Review-Priority%252B1
16:12:28	bauzas	this is absolutely empty
16:12:54	bauzas	cores, please enjoy this new button until we discuss other ways to use it at the PTG
16:13:29	bauzas	is there anyone wanting to have their changes be a priority for reviews ?
16:13:53	bauzas	(that's your time, folks)
16:13:59	artom	Wait, only cores can set the priority label?
16:14:15	bauzas	with the current implementation, yes
16:14:31	bauzas	I'm about to propose other possibilities at the PTG
16:14:41	bauzas	(which reminds me I have to write something in the etherpad)
16:14:46	artom	Can a non-core propose the label, or is the whole thing owned entirely by cores?

Earlier   Later