| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-09-02 | |||
| 12:16:55 | opendevreview | Merged openstack/nova master: workarounds: Remove rbd_volume_local_attach https://review.opendev.org/c/openstack/nova/+/805648 | |
| 12:18:33 | opendevreview | Federico Ressi proposed openstack/nova master: [WIP] Debug APIs call failures https://review.opendev.org/c/openstack/nova/+/806683 | |
| 12:18:57 | opendevreview | Federico Ressi proposed openstack/nova master: Debug Nova APIs call failures https://review.opendev.org/c/openstack/nova/+/806683 | |
| 12:27:06 | opendevreview | Federico Ressi proposed openstack/nova master: [WIP] Check Nova project changes with tobiko scenario test cases https://review.opendev.org/c/openstack/nova/+/806853 | |
| 12:31:28 | opendevreview | Federico Ressi proposed openstack/nova master: Check Nova project changes with Tobiko scenario test cases https://review.opendev.org/c/openstack/nova/+/806853 | |
| 12:40:55 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: Allow 'bochs' as a display device option https://review.opendev.org/c/openstack/nova/+/794796 | |
| 12:51:54 | gibi | sean-k-mooney: :D | |
| 13:13:06 | opendevreview | Takashi Natsume proposed openstack/nova master: Update compute rpc version alias for xena https://review.opendev.org/c/openstack/nova/+/807137 | |
| 13:20:54 | kashyap | sean-k-mooney: Oh, duh. In my revision I missed the extra test that stephenfin asked above. Adding that too | |
| 13:50:13 | opendevreview | Kevin Zhao proposed openstack/nova master: Support Cpu Compararion on Aarch64 Platform https://review.opendev.org/c/openstack/nova/+/763928 | |
| 14:00:17 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: Allow 'bochs' as a display device option https://review.opendev.org/c/openstack/nova/+/794796 | |
| 14:00:59 | kashyap | stephenfin: Fixed --^ That should address all you asked for. Let me know if I missed anything. And thanks for the review. | |
| 14:04:14 | opendevreview | Balazs Gibizer proposed openstack/placement master: Reproduce 404 when allocation queried with 1.38 https://review.opendev.org/c/openstack/placement/+/807154 | |
| 14:04:21 | opendevreview | Balazs Gibizer proposed openstack/placement master: Fix adding 'unknown' to the ConsumerTypeCache https://review.opendev.org/c/openstack/placement/+/807155 | |
| 14:14:57 | gibi | lyarwood, stephenfin, bauzas: can I get a second set of eyes on https://review.opendev.org/c/openstack/osc-placement/+/804458 (consumer_types osc-placement client support) | |
| 14:15:55 | bauzas | gibi: doing it now | |
| 14:17:06 | gibi | thanks you | |
| 14:24:54 | kashyap | gibi: WHen you get 20 minutes, mind have a look at this? - https://review.opendev.org/c/openstack/nova/+/763928 | |
| 14:31:58 | opendevreview | Merged openstack/osc-placement master: Add support for microversion 1.38 consumer types https://review.opendev.org/c/openstack/osc-placement/+/804458 | |
| 14:49:52 | gibi | kashyap: are you OK with that patch? | |
| 15:01:56 | kashyap | gibi: 80%; I just want to do a real migration test w/ that patch - that gives me more peace of mind. (I wanted to split it up for better reviewability but just couldn't get around to it.) | |
| 15:02:33 | kashyap | gibi: How about this: | |
| 15:03:02 | gibi | kashyap: I have no problem with the patch, as far as see it is specialized to arm64 so we cannot broke our main deployers with it :) | |
| 15:03:04 | kashyap | gibi: I'll setup a local env to do a bunch more tests on KVM (our CI tests only QEMU) | |
| 15:03:11 | kashyap | gibi: Oh, wait | |
| 15:03:24 | kashyap | gibi: I gave you the wrong patch; damn | |
| 15:03:25 | gibi | or you linked me something else :D | |
| 15:03:35 | kashyap | gibi: Yeah, grrrr me. | |
| 15:03:39 | gibi | no worries | |
| 15:03:47 | kashyap | I meant this chunky one (hence the "20 minutes") - https://review.opendev.org/c/openstack/nova/+/763928 | |
| 15:04:10 | kashyap | Feel free to say: "no, that is too much review at this point". | |
| 15:04:27 | kashyap | But I can answer any questions about that patch. | |
| 15:04:56 | kashyap | gibi: Incidentally, the commit message from the patch author is a verbatim copy/paste of what I wrote in one of the reviews :D | |
| 15:05:15 | gibi | :) | |
| 15:05:54 | gibi | you linked the wrong patch again https://review.opendev.org/c/openstack/nova/+/763928 | |
| 15:05:57 | kashyap | gibi: The short summary is - this patch will be replacing the two older libvirt CPU APIs that are now causing more problems in the new world of hardware CVE flaws | |
| 15:06:11 | kashyap | gibi: Gah, sorry, this one - https://review.opendev.org/c/openstack/nova/+/762330/ | |
| 15:06:19 | kashyap | "libvirt: Use improved guest CPU config APIs" | |
| 15:06:47 | gibi | ok that is chunky indeed :) | |
| 15:06:49 | kashyap | gibi: It's a chunky one. Actually, this hour is not good to review it. And will only make you grumpy, I'm afraid | |
| 15:07:03 | gibi | I will try and lets see how far I can get | |
| 15:07:25 | kashyap | gibi: I can split it up, if you like. (That's also the right thing in my view, and told that on the review a few times) | |
| 15:07:36 | kashyap | (And also in the original spec I wrote) | |
| 15:09:40 | kashyap | gibi: I'll copy/paste from my notes, the "outline" of the patch: | |
| 15:09:44 | kashyap | - libvirt: Introduce compare_hypervisor_cpu() method | |
| 15:09:44 | kashyap | - libvirt: Introduce baseline_hypervisor_cpu() method | |
| 15:09:44 | kashyap | - Rework _get_guest_cpu_model_config() method to take advantage of the new CPU APIs | |
| 15:09:48 | kashyap | - Update the get_capabilities() method to make use of baseline_hypervisor_cpu() | |
| 15:09:51 | kashyap | - Update the check_can_live_migrate_destination() method to use compare_hypervisor_cpu() | |
| 15:10:57 | gibi | thanks | |
| 15:38:01 | melwitt | gibi: thank you for reviewing my patch. I'm going to try a simpler fix and try to restore the original func test. if it works, I think reviewers might like it more | |
| 15:38:51 | bauzas | melwitt: you're on my plate | |
| 15:39:22 | bauzas | but I've seen gibi's concerns so I held a bit | |
| 15:39:59 | melwitt | bauzas: yes thank you for your review too, I'm going to try a simpler approach bc as you said the current patch looks pretty hacky | |
| 15:40:10 | gibi | melwitt: I have no problem with the logic of the current fix. Just had some nits about docs | |
| 15:40:36 | gibi | melwitt: but sure, if you have a simpler solution then I'm happy to review that too later | |
| 15:40:44 | melwitt | gibi: understood. I worry that it's too confusing | |
| 15:41:02 | melwitt | (for maintainability) | |
| 15:41:30 | gibi | OK | |
| 15:42:02 | gibi | btw, there is another small fix targeting consumer_types here https://review.opendev.org/c/openstack/placement/+/807155 | |
| 15:42:15 | gibi | but I think there will not be conflicts | |
| 15:43:08 | melwitt | gibi: thanks for figuring that out, I will review | |
| 15:44:15 | gibi | no problem | |
| 15:44:57 | opendevreview | Merged openstack/python-novaclient master: tests: Add missing 'nova update' unit tests https://review.opendev.org/c/openstack/python-novaclient/+/806916 | |
| 15:50:32 | opendevreview | Merged openstack/python-novaclient master: Microversion 2.90 - Configurable hostnames https://review.opendev.org/c/openstack/python-novaclient/+/806917 | |
| 16:06:46 | gibi | kashyap: timed out on reading https://review.opendev.org/c/openstack/nova/+/762330, I left some comments / questions inline. | |
| 16:06:56 | gibi | but I haven't read the driver part yet | |
| 16:29:13 | gibi | all - please review the cycle highlights and lt me know if anything is wrong or missing https://review.opendev.org/c/openstack/releases/+/800755 | |
| 16:30:40 | gibi | ending my day. see you tomorrow o/ | |
| 16:46:47 | opendevreview | Stephen Finucane proposed openstack/nova master: Allow 'bochs' as a display device option https://review.opendev.org/c/openstack/nova/+/794796 | |
| 17:59:05 | sean-k-mooney | ok i think im going to call it a day o/ | |
| 19:03:25 | opendevreview | Merged openstack/nova master: Add two new hacking rules https://review.opendev.org/c/openstack/nova/+/805668 | |
| 19:03:50 | opendevreview | Merged openstack/nova master: Support interface attach / detach with new resource request format https://review.opendev.org/c/openstack/nova/+/800089 | |
| 19:04:12 | opendevreview | Merged openstack/nova master: [func test] move unshelve test to the proper place https://review.opendev.org/c/openstack/nova/+/793621 | |
| 20:15:08 | opendevreview | Merged openstack/nova master: Update compute rpc version alias for xena https://review.opendev.org/c/openstack/nova/+/807137 | |
| 20:18:13 | opendevreview | melanie witt proposed openstack/placement master: Add reproducer for Project creation race bug https://review.opendev.org/c/openstack/placement/+/806730 | |
| 20:18:19 | opendevreview | melanie witt proposed openstack/placement master: Narrow scope of set allocations database transaction https://review.opendev.org/c/openstack/placement/+/807014 | |
| 20:24:56 | melwitt | gibi, bauzas: I rewrote the func tests and gibi I think I addressed all of your comments on the fix patch. I decided to just stay with the current approach, keeping the transaction as small as possible is likely most important | |
| 22:10:48 | opendevreview | melanie witt proposed openstack/placement master: Narrow scope of set allocations database transaction https://review.opendev.org/c/openstack/placement/+/807014 | |
| 22:18:35 | opendevreview | Federico Ressi proposed openstack/nova master: Debug Nova APIs call failures https://review.opendev.org/c/openstack/nova/+/806683 | |
| 22:21:03 | opendevreview | Federico Ressi proposed openstack/nova master: Check Nova project changes with Tobiko scenario test cases https://review.opendev.org/c/openstack/nova/+/806853 | |
| #openstack-nova - 2021-09-03 | |||
| 03:18:38 | opendevreview | Kevin Zhao proposed openstack/nova master: Support Cpu Compararion on Aarch64 Platform https://review.opendev.org/c/openstack/nova/+/763928 | |
| 07:25:53 | gibi | good morning | |
| 07:28:36 | gibi | melwitt: I will check it shortly | |
| 07:37:59 | kashyap | gibi: Morning. And that's fine - on the timeout. Thanks for the comments so far | |
| 07:38:02 | kashyap | stephenfin: Thanks for fixing the o.vo hash fails in func tests :) | |
| 07:38:17 | kashyap | Hmm, I still see a -2 from Zuul | |
| 07:38:39 | bauzas | melwitt: ack, will review | |
| 07:39:56 | gibi | kashyap: just hit some unrelated errors, I've rechecked now | |
| 07:40:26 | kashyap | gibi: Ah, thank you. Is now "unrelated" also a keyword? | |
| 07:40:43 | gibi | kashyap: you can write whatever after recheck :D | |
| 07:40:59 | kashyap | Ah, nod. | |
| 07:41:10 | gibi | but yeah, at some point I have to triage those gate failures too | |
| 07:41:27 | gibi | (or somebody else have to) | |
| 08:13:43 | bauzas | gibi: I need to do some upstream bug triage tbh | |
| 08:13:53 | gibi | bauzas: yeah, that too | |
| 08:13:54 | bauzas | gibi: but I'm not sure I'll have time for this today | |
| 08:14:39 | gibi | me neighter | |
| 11:06:44 | ralonsoh | hi folks, I don't see a better channel to make this question | |
| 11:06:48 | ralonsoh | this is about ceph | |