| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-09-02 | |||
| 15:06:19 | kashyap | "libvirt: Use improved guest CPU config APIs" | |
| 15:06:47 | gibi | ok that is chunky indeed :) | |
| 15:06:49 | kashyap | gibi: It's a chunky one. Actually, this hour is not good to review it. And will only make you grumpy, I'm afraid | |
| 15:07:03 | gibi | I will try and lets see how far I can get | |
| 15:07:25 | kashyap | gibi: I can split it up, if you like. (That's also the right thing in my view, and told that on the review a few times) | |
| 15:07:36 | kashyap | (And also in the original spec I wrote) | |
| 15:09:40 | kashyap | gibi: I'll copy/paste from my notes, the "outline" of the patch: | |
| 15:09:44 | kashyap | - libvirt: Introduce compare_hypervisor_cpu() method | |
| 15:09:44 | kashyap | - libvirt: Introduce baseline_hypervisor_cpu() method | |
| 15:09:44 | kashyap | - Rework _get_guest_cpu_model_config() method to take advantage of the new CPU APIs | |
| 15:09:48 | kashyap | - Update the get_capabilities() method to make use of baseline_hypervisor_cpu() | |
| 15:09:51 | kashyap | - Update the check_can_live_migrate_destination() method to use compare_hypervisor_cpu() | |
| 15:10:57 | gibi | thanks | |
| 15:38:01 | melwitt | gibi: thank you for reviewing my patch. I'm going to try a simpler fix and try to restore the original func test. if it works, I think reviewers might like it more | |
| 15:38:51 | bauzas | melwitt: you're on my plate | |
| 15:39:22 | bauzas | but I've seen gibi's concerns so I held a bit | |
| 15:39:59 | melwitt | bauzas: yes thank you for your review too, I'm going to try a simpler approach bc as you said the current patch looks pretty hacky | |
| 15:40:10 | gibi | melwitt: I have no problem with the logic of the current fix. Just had some nits about docs | |
| 15:40:36 | gibi | melwitt: but sure, if you have a simpler solution then I'm happy to review that too later | |
| 15:40:44 | melwitt | gibi: understood. I worry that it's too confusing | |
| 15:41:02 | melwitt | (for maintainability) | |
| 15:41:30 | gibi | OK | |
| 15:42:02 | gibi | btw, there is another small fix targeting consumer_types here https://review.opendev.org/c/openstack/placement/+/807155 | |
| 15:42:15 | gibi | but I think there will not be conflicts | |
| 15:43:08 | melwitt | gibi: thanks for figuring that out, I will review | |
| 15:44:15 | gibi | no problem | |
| 15:44:57 | opendevreview | Merged openstack/python-novaclient master: tests: Add missing 'nova update' unit tests https://review.opendev.org/c/openstack/python-novaclient/+/806916 | |
| 15:50:32 | opendevreview | Merged openstack/python-novaclient master: Microversion 2.90 - Configurable hostnames https://review.opendev.org/c/openstack/python-novaclient/+/806917 | |
| 16:06:46 | gibi | kashyap: timed out on reading https://review.opendev.org/c/openstack/nova/+/762330, I left some comments / questions inline. | |
| 16:06:56 | gibi | but I haven't read the driver part yet | |
| 16:29:13 | gibi | all - please review the cycle highlights and lt me know if anything is wrong or missing https://review.opendev.org/c/openstack/releases/+/800755 | |
| 16:30:40 | gibi | ending my day. see you tomorrow o/ | |
| 16:46:47 | opendevreview | Stephen Finucane proposed openstack/nova master: Allow 'bochs' as a display device option https://review.opendev.org/c/openstack/nova/+/794796 | |
| 17:59:05 | sean-k-mooney | ok i think im going to call it a day o/ | |
| 19:03:25 | opendevreview | Merged openstack/nova master: Add two new hacking rules https://review.opendev.org/c/openstack/nova/+/805668 | |
| 19:03:50 | opendevreview | Merged openstack/nova master: Support interface attach / detach with new resource request format https://review.opendev.org/c/openstack/nova/+/800089 | |
| 19:04:12 | opendevreview | Merged openstack/nova master: [func test] move unshelve test to the proper place https://review.opendev.org/c/openstack/nova/+/793621 | |
| 20:15:08 | opendevreview | Merged openstack/nova master: Update compute rpc version alias for xena https://review.opendev.org/c/openstack/nova/+/807137 | |
| 20:18:13 | opendevreview | melanie witt proposed openstack/placement master: Add reproducer for Project creation race bug https://review.opendev.org/c/openstack/placement/+/806730 | |
| 20:18:19 | opendevreview | melanie witt proposed openstack/placement master: Narrow scope of set allocations database transaction https://review.opendev.org/c/openstack/placement/+/807014 | |
| 20:24:56 | melwitt | gibi, bauzas: I rewrote the func tests and gibi I think I addressed all of your comments on the fix patch. I decided to just stay with the current approach, keeping the transaction as small as possible is likely most important | |
| 22:10:48 | opendevreview | melanie witt proposed openstack/placement master: Narrow scope of set allocations database transaction https://review.opendev.org/c/openstack/placement/+/807014 | |
| 22:18:35 | opendevreview | Federico Ressi proposed openstack/nova master: Debug Nova APIs call failures https://review.opendev.org/c/openstack/nova/+/806683 | |
| 22:21:03 | opendevreview | Federico Ressi proposed openstack/nova master: Check Nova project changes with Tobiko scenario test cases https://review.opendev.org/c/openstack/nova/+/806853 | |
| #openstack-nova - 2021-09-03 | |||
| 03:18:38 | opendevreview | Kevin Zhao proposed openstack/nova master: Support Cpu Compararion on Aarch64 Platform https://review.opendev.org/c/openstack/nova/+/763928 | |
| 07:25:53 | gibi | good morning | |
| 07:28:36 | gibi | melwitt: I will check it shortly | |
| 07:37:59 | kashyap | gibi: Morning. And that's fine - on the timeout. Thanks for the comments so far | |
| 07:38:02 | kashyap | stephenfin: Thanks for fixing the o.vo hash fails in func tests :) | |
| 07:38:17 | kashyap | Hmm, I still see a -2 from Zuul | |
| 07:38:39 | bauzas | melwitt: ack, will review | |
| 07:39:56 | gibi | kashyap: just hit some unrelated errors, I've rechecked now | |
| 07:40:26 | kashyap | gibi: Ah, thank you. Is now "unrelated" also a keyword? | |
| 07:40:43 | gibi | kashyap: you can write whatever after recheck :D | |
| 07:40:59 | kashyap | Ah, nod. | |
| 07:41:10 | gibi | but yeah, at some point I have to triage those gate failures too | |
| 07:41:27 | gibi | (or somebody else have to) | |
| 08:13:43 | bauzas | gibi: I need to do some upstream bug triage tbh | |
| 08:13:53 | gibi | bauzas: yeah, that too | |
| 08:13:54 | bauzas | gibi: but I'm not sure I'll have time for this today | |
| 08:14:39 | gibi | me neighter | |
| 11:06:44 | ralonsoh | hi folks, I don't see a better channel to make this question | |
| 11:06:48 | ralonsoh | this is about ceph | |
| 11:06:55 | ralonsoh | (because I want live migration) | |
| 11:07:23 | ralonsoh | I have a node with a ceph cluster | |
| 11:07:49 | ralonsoh | when I try, from the other node, to execute "sudo ceph -c /etc/ceph/ceph.conf auth get-key client.cinder" | |
| 11:07:53 | ralonsoh | I receive | |
| 11:07:56 | ralonsoh | 2021-09-03T11:04:46.531+0000 7f8c47fff700 -1 monclient(hunting): handle_auth_bad_method server allowed_methods [2] but i only support [2] | |
| 11:08:01 | sean-k-mooney2 | ceph isnet needed for live migration but if you have it help avoid copying the disk | |
| 11:08:20 | ralonsoh | well, that was the reason | |
| 11:08:30 | ralonsoh | in any case, if I can't make it work, I'll skip that part | |
| 11:08:43 | sean-k-mooney2 | we spoke about this before | |
| 11:08:46 | ralonsoh | I had the same config as when you helped me last time | |
| 11:08:48 | ralonsoh | yes | |
| 11:08:59 | sean-k-mooney2 | have you disable the cve fix | |
| 11:09:11 | ralonsoh | do you have a link?? | |
| 11:09:16 | sean-k-mooney2 | for this https://docs.ceph.com/en/latest/security/CVE-2021-20288/#cve-2021-20288 | |
| 11:09:23 | sean-k-mooney2 | ill get the link to the workaround | |
| 11:09:36 | ralonsoh | yes, I did that | |
| 11:09:59 | sean-k-mooney | and you check the keyring file is not empty this time | |
| 11:10:17 | ralonsoh | yes, I have ceph.client.admin.keyring | |
| 11:10:22 | ralonsoh | and ceph.client.cinder.keyring | |
| 11:10:28 | ralonsoh | in /etc/ceph | |
| 11:11:07 | ralonsoh | sean-k-mooney, should I copy this files from the master one? | |
| 11:11:23 | sean-k-mooney | they should have the same content | |
| 11:11:27 | ralonsoh | ooook | |
| 11:11:43 | sean-k-mooney | i assume you have configured nova with the cinder keyring too | |
| 11:12:02 | ralonsoh | I used the devstack plugin | |
| 11:12:06 | ralonsoh | I think it is | |
| 11:12:20 | ralonsoh | sean-k-mooney, ok ok | |
| 11:12:23 | ralonsoh | I think that was the problem | |
| 11:12:30 | ralonsoh | (I don't know what I did before) | |
| 11:12:39 | ralonsoh | the keyrings where different... again | |
| 11:12:45 | ralonsoh | sean-k-mooney, again, thanks a lot!! | |
| 11:12:52 | sean-k-mooney | no worries | |
| 11:13:18 | sean-k-mooney | i dont use ceph often but the auth can be a bit of a pain to get working initally | |
| 11:13:41 | ralonsoh | sean-k-mooney, how do I configure Nova not to use ceph? | |
| 11:13:53 | ralonsoh | because if I remember correctly, this is required | |
| 11:14:01 | ralonsoh | for live-migration | |
| 11:14:02 | sean-k-mooney | you need to set the libvirt secrete | |