| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-07-29 | |||
| 13:54:47 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Add test for bug #1936278 https://review.opendev.org/c/openstack/nova/+/802893 | |
| 13:54:56 | stephenfin | bauzas: FYI ^ | |
| 13:59:09 | bauzas | ta | |
| 14:16:25 | stephenfin | bauzas: lyarwood: You think you folks could look at https://review.opendev.org/c/openstack/nova/+/773643 and the patch above it to get those nice docs fixes in? Trying to close out what I can :) | |
| 14:39:24 | lyarwood | stephenfin: ack | |
| 14:56:21 | opendevreview | Stephen Finucane proposed openstack/nova master: manager: Reduce unnecessary calls https://review.opendev.org/c/openstack/nova/+/795027 | |
| 15:46:56 | opendevreview | Stephen Finucane proposed openstack/nova master: Moved all calls from _ENFORCER.authorize to a separate _authorize method https://review.opendev.org/c/openstack/nova/+/749080 | |
| 16:38:35 | bauzas | sean-k-mooney: still around ? can't find where we uppercase the RC names in https://github.com/openstack/placement/blob/3c51c6413bfc316cad8bb9d50b6fbffc83069b79/placement/objects/resource_class.py#L33 | |
| 16:39:10 | bauzas | the API accepts lowercasing for the name but I'm almost sure we do create the RC object with uppercase name | |
| 16:39:20 | bauzas | just can't find where | |
| 16:56:56 | opendevreview | Sylvain Bauza proposed openstack/nova master: Rename vgpu options to mdev https://review.opendev.org/c/openstack/nova/+/801607 | |
| 16:56:57 | opendevreview | Sylvain Bauza proposed openstack/nova master: DNM (yet) : Expose the mdev class https://review.opendev.org/c/openstack/nova/+/801743 | |
| 16:56:57 | opendevreview | Sylvain Bauza proposed openstack/nova master: WIP Provide the mdev class for every PCI device https://review.opendev.org/c/openstack/nova/+/802918 | |
| 17:00:25 | opendevreview | Sylvain Bauza proposed openstack/nova master: WIP Provide the mdev class for every PCI device https://review.opendev.org/c/openstack/nova/+/802918 | |
| 17:01:36 | melwitt | bauzas: you likely already found it but it doesn't look like lowercase is allowed https://github.com/openstack/placement/blob/3c51c6413bfc316cad8bb9d50b6fbffc83069b79/placement/schemas/common.py#L17-L21 | |
| 17:21:34 | sean-k-mooney | bauzas: sorry yes im still here | |
| 17:22:24 | sean-k-mooney | bauzas: i think there is a normalise fucntion | |
| 17:23:12 | sean-k-mooney | maybe this one https://github.com/openstack/placement/blob/3c51c6413bfc316cad8bb9d50b6fbffc83069b79/placement/util.py#L233 | |
| 17:23:54 | sean-k-mooney | well that is just checkign the query stiring but i think there is a helper util for it | |
| 17:25:28 | sean-k-mooney | bauzas: the api should not accpet lowercase | |
| 17:26:11 | sean-k-mooney | bauzas: here |https://github.com/openstack/os-resource-classes/blob/145ed791d050725394dbd786a5d45600da656812/os_resource_classes/__init__.py#L94-L113 | |
| 17:26:29 | sean-k-mooney | bauzas: its in os-resouce-classes | |
| 17:28:33 | sean-k-mooney | that used to also be in placment https://github.com/openstack/placement/blob/1257198effa3b41d206d18356dded543810da6fd/nova/rc_fields.py#L58-L66 | |
| 17:38:09 | sean-k-mooney | bauzas i think melwitt is right that the scema will rejct it if its not uppercase | |
| 17:38:23 | sean-k-mooney | bauzas: and we will not do the conversion automatically | |
| 17:38:47 | sean-k-mooney | but os-resource-class does provide teh function to do the normalisation which you should use | |
| 17:38:52 | sean-k-mooney | we do use it in nova i belive | |
| 17:39:33 | sean-k-mooney | yep we do https://github.com/openstack/nova/blob/d64edd3da2336a5c7c8f69cced45272cbaf638a9/nova/tests/functional/compute/test_resource_tracker.py#L529 | |
| 17:40:55 | sean-k-mooney | well actully here https://github.com/openstack/nova/blob/052cf963583ab7c6bbe4fcbf7bfe69f8f6733bdb/nova/scheduler/utils.py#L304 | |
| 17:41:17 | sean-k-mooney | but anytime we constoct a custom RC name we should use it really | |
| 20:52:07 | opendevreview | Samuel proposed openstack/nova-specs master: Migrate Instance Between Projects https://review.opendev.org/c/openstack/nova-specs/+/802034 | |
| 20:57:27 | opendevreview | Samuel proposed openstack/nova-specs master: Migrate Instance Between Projects https://review.opendev.org/c/openstack/nova-specs/+/802034 | |
| 22:01:15 | opendevreview | Vlad Gusev proposed openstack/nova stable/train: Reject open redirection in the console proxy https://review.opendev.org/c/openstack/nova/+/791807 | |
| 22:03:04 | opendevreview | Vlad Gusev proposed openstack/nova stable/stein: Reject open redirection in the console proxy https://review.opendev.org/c/openstack/nova/+/802935 | |
| 22:04:35 | opendevreview | Samuel proposed openstack/nova-specs master: Migrate Instance Between Projects https://review.opendev.org/c/openstack/nova-specs/+/802034 | |
| 22:26:45 | opendevreview | melanie witt proposed openstack/nova master: Add stub unified limits driver https://review.opendev.org/c/openstack/nova/+/712137 | |
| 22:26:45 | opendevreview | melanie witt proposed openstack/nova master: Assert quota related API behavior when noop https://review.opendev.org/c/openstack/nova/+/712140 | |
| 22:26:46 | opendevreview | melanie witt proposed openstack/nova master: Make unified limits APIs return reserved of 0 https://review.opendev.org/c/openstack/nova/+/712141 | |
| 22:26:46 | opendevreview | melanie witt proposed openstack/nova master: Add logic to enforce local api and db limits https://review.opendev.org/c/openstack/nova/+/712139 | |
| 22:26:47 | opendevreview | melanie witt proposed openstack/nova master: Enforce api and db limits https://review.opendev.org/c/openstack/nova/+/712142 | |
| 22:26:47 | opendevreview | melanie witt proposed openstack/nova master: Update quota_class APIs for db and api limits https://review.opendev.org/c/openstack/nova/+/712143 | |
| 22:26:48 | opendevreview | melanie witt proposed openstack/nova master: Update limit APIs https://review.opendev.org/c/openstack/nova/+/712707 | |
| 22:26:48 | opendevreview | melanie witt proposed openstack/nova master: Update quota sets APIs https://review.opendev.org/c/openstack/nova/+/712749 | |
| 22:26:49 | opendevreview | melanie witt proposed openstack/nova master: Tell oslo.limit how to count nova resources https://review.opendev.org/c/openstack/nova/+/713301 | |
| 22:26:50 | opendevreview | melanie witt proposed openstack/nova master: Enforce resource limits using oslo.limit https://review.opendev.org/c/openstack/nova/+/615180 | |
| 22:26:50 | opendevreview | melanie witt proposed openstack/nova master: Add legacy limits and usage to unified limits https://review.opendev.org/c/openstack/nova/+/713498 | |
| 22:26:52 | opendevreview | melanie witt proposed openstack/nova master: Update quota apis with keystone limits and usage https://review.opendev.org/c/openstack/nova/+/713499 | |
| 22:26:52 | opendevreview | melanie witt proposed openstack/nova master: Add reno for unified limits https://review.opendev.org/c/openstack/nova/+/715271 | |
| 23:01:14 | opendevreview | Vlad Gusev proposed openstack/nova stable/stein: Reject open redirection in the console proxy https://review.opendev.org/c/openstack/nova/+/802935 | |
| #openstack-nova - 2021-07-30 | |||
| 07:04:53 | opendevreview | Simon Li proposed openstack/nova-specs master: support ironic instance change host while it's host not up https://review.opendev.org/c/openstack/nova-specs/+/802991 | |
| 07:08:31 | opendevreview | Simon Li proposed openstack/nova-specs master: support ironic instance change host while it's host not up https://review.opendev.org/c/openstack/nova-specs/+/802991 | |
| 09:01:07 | bauzas | stephenfin: sean-k-mooney[m]: lovely reviews for my generic mdevs implementation, thanks !: | |
| 09:03:05 | artom_ | bauzas, have time to hit https://review.opendev.org/c/openstack/nova/+/802697? | |
| 09:21:27 | artom | bauzas, thanks for the review - so, I did consider doing a functional test, but given that this is 1. niche and 2. straightforward, any functional test I'd write would be either 1. a lot of groundwork to use the Ironic virt driver in the test or 2. have so much stuff mocked out, it'd be functionally (heh) identical to the existing unit test | |
| 09:29:25 | bauzas | artom: you don't need to use the ironic driver | |
| 09:29:49 | bauzas | artom: just use the standard fake driver and mock out (in the func test) the return you want | |
| 09:30:02 | artom | bauzas, that's what the unit test is doing :P | |
| 09:30:27 | artom | I mean OK, it's not using any virt driver | |
| 09:30:28 | bauzas | artom: I know but you wouldn't verify the output of a method call, right? | |
| 09:30:36 | bauzas | for the functest | |
| 09:30:51 | bauzas | you would verify the expected behaviour | |
| 09:30:54 | stephenfin | bauzas: sometimes "good enough" is okay :) | |
| 09:31:35 | bauzas | stephenfin: i know and that's why I asked whether there was urgency | |
| 09:32:04 | bauzas | the bug itself isn't about Ironic | |
| 09:32:14 | artom | bauzas, err, yes it is? | |
| 09:32:19 | artom | How else would you hit this besides Ironic? | |
| 09:32:30 | bauzas | the problem is that we raise up to the API an exception when we don't find compute nodes for a service deletion | |
| 09:32:41 | artom | ... which can only happen with Ironic :) | |
| 09:32:44 | bauzas | sure | |
| 09:33:03 | bauzas | but the regression should verify that we get an API exception | |
| 09:33:16 | bauzas | when calling the API service delete | |
| 09:33:36 | artom | self.assertRaises( | |
| 09:33:36 | bauzas | while the fix should just modify the api return | |
| 09:33:37 | artom | webob.exc.HTTPInternalServerError | |
| 09:35:23 | bauzas | I saw | |
| 09:35:25 | bauzas | anyway | |
| 09:36:11 | bauzas | I'm just asking to use a design framework | |
| 09:36:50 | bauzas | because we're an opensource community and we try to use the same frameworks in general as we want contributors to know about them | |
| 09:36:58 | bauzas | we can do this other way | |
| 09:37:07 | bauzas | and for sure this will work | |
| 09:37:29 | artom | bauzas, I mean, I could just squash the patches and avoid the reproducer alltogether :P | |
| 09:37:48 | artom | I wanted to highlight the broken behaviour first | |
| 09:37:57 | artom | But the fix itself doens't need a func test, methinks | |
| 09:38:12 | bauzas | honestly, I don't know what to say, I wasn't thinking my comment would be a concern | |
| 09:38:17 | bauzas | so, meh | |
| 09:38:38 | bauzas | +Wd | |
| 09:38:52 | bauzas | I just don't wanna take time discussing | |
| 09:48:17 | bauzas | artom: about the log level i'm asking | |
| 09:48:34 | bauzas | well, in theory, unless ironic, a service *has* a compute node, right? | |
| 09:48:54 | bauzas | and even with ironic, that's a normal situation | |
| 09:48:57 | artom | Not really, IIUC, but I'm not an expert | |
| 09:49:10 | artom | A service without nodes can be a part of normal operation | |
| 09:49:26 | artom | For instance, adding a service before adding any nodes to it, replacing all nodes associated with a service, that kind of stuff | |
| 09:49:33 | artom | In my understanding, anyways | |
| 09:50:28 | artom | So to quote pawnstars, "debug is the best I can do" | |
| 09:50:58 | artom | Actually, would you be offended if I did it in a follow-up? I need to fix the dat base typo as well | |
| 09:51:52 | artom | 'dat base: https://i.kym-cdn.com/entries/icons/original/000/000/228/DATASS.jpg | |
| 09:52:06 | artom | Err, sorry about the URL :( | |
| 09:55:26 | bauzas | artom: no, a service without a node isn't "normal" | |
| 09:55:38 | bauzas | we create the CN entry when we create the service | |