| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-07-30 | |||
| 09:55:38 | bauzas | we create the CN entry when we create the service | |
| 09:55:43 | bauzas | or CNs | |
| 09:56:07 | bauzas | artom: it's just if you rebalance ironic nodes that you end up with trampling nova | |
| 09:56:22 | bauzas | because ironic didn't manage the service/node relationship we have | |
| 09:56:41 | bauzas | so, unless you rebalance your ironic nodes, you shouldn't expect such things | |
| 09:56:53 | bauzas | hence an INFO at least | |
| 09:58:06 | artom | Fair enough, I can do INFO | |
| 09:58:14 | artom | Do you accept my FUP bargain? :) | |
| 09:59:07 | bauzas | if so | |
| 09:59:48 | artom | Hol'up though - for my own education, Ironic managed actualy physical nodes | |
| 09:59:51 | artom | *manages | |
| 10:00:11 | artom | So... how does "we create CN entry when we create the service" work if there are not physical nodes existing? | |
| 10:02:50 | jkulik | a started ironic compute driver will just write over and over again "No compute node record for host nova-compute-ironic" if there are no physical nodes existing. at least on rocky. | |
| 10:03:57 | opendevreview | Merged openstack/nova master: Reproducer unit test for bug 1860312 https://review.opendev.org/c/openstack/nova/+/802697 | |
| 10:04:41 | bauzas | artom: the compute manager gets the list of cns from the virt driver in https://github.com/openstack/nova/blob/97e1a6bece29e383f55bb969c69983153df9ffc7/nova/compute/manager.py#L1433 | |
| 10:04:52 | artom | jkulik, cheers! Confirms how I understood things | |
| 10:05:28 | artom | bauzas, I feel like that could be None/empty list though | |
| 10:06:24 | bauzas | artom: https://github.com/openstack/nova/blob/97e1a6bece29e383f55bb969c69983153df9ffc7/nova/compute/manager.py#L583 | |
| 10:06:29 | artom | Empty list, based on https://github.com/openstack/nova/blob/97e1a6bece29e383f55bb969c69983153df9ffc7/nova/virt/ironic/driver.py#L823 | |
| 10:06:34 | bauzas | here we instantiate a RT per compute node | |
| 10:07:56 | bauzas | and here we create the CN entry https://github.com/openstack/nova/blob/97e1a6bece29e383f55bb969c69983153df9ffc7/nova/compute/resource_tracker.py#L918 | |
| 10:08:02 | bauzas | every 60 secs | |
| 10:11:29 | artom | bauzas, that's called from the periodic through, not at host init | |
| 10:13:03 | bauzas | yup, my bad | |
| 10:13:08 | bauzas | but | |
| 10:13:23 | bauzas | we eventually call u_r_p at the end of the init, IIRC | |
| 10:13:59 | bauzas | it's just a post hook call and not straighlty from init_host (or something like that, can't exactly remember) | |
| 10:39:49 | opendevreview | Artom Lifshitz proposed openstack/nova master: I2f9ad3df25306e070c8c3538bfed1212d6d8682f fup: add log https://review.opendev.org/c/openstack/nova/+/803001 | |
| 11:13:35 | opendevreview | Sylvain Bauza proposed openstack/nova master: Rename vgpu options to mdev https://review.opendev.org/c/openstack/nova/+/801607 | |
| 11:13:35 | opendevreview | Sylvain Bauza proposed openstack/nova master: DNM (yet) : Expose the mdev class https://review.opendev.org/c/openstack/nova/+/801743 | |
| 11:13:36 | opendevreview | Sylvain Bauza proposed openstack/nova master: WIP Provide the mdev class for every PCI device https://review.opendev.org/c/openstack/nova/+/802918 | |
| 11:16:13 | opendevreview | Sylvain Bauza proposed openstack/nova master: WIP Provide the mdev class for every PCI device https://review.opendev.org/c/openstack/nova/+/802918 | |
| 11:16:14 | opendevreview | Sylvain Bauza proposed openstack/nova master: DNM (yet) : Expose the mdev class https://review.opendev.org/c/openstack/nova/+/801743 | |
| 11:23:09 | songwenping__ | bauzas, now we cannot batch create vgpu vms, right? | |
| 11:23:37 | bauzas | I need to go out for lunch but wdym for "batch create" ? | |
| 11:23:42 | bauzas | multi-create ? | |
| 11:23:50 | songwenping__ | yes multi-create | |
| 11:24:18 | bauzas | if so, https://bugs.launchpad.net/nova/+bug/1874664 | |
| 11:25:18 | sean-k-mooney[m] | we do not support multi create with any request that uses nested resource providers today | |
| 11:26:36 | bauzas | yup, but this doesn't impact virtual GPUs | |
| 11:26:37 | songwenping__ | there is a different exception with the bug | |
| 11:27:03 | songwenping__ | yes, the scheduler is ok | |
| 11:27:15 | songwenping__ | compute raise exception | |
| 11:28:07 | sean-k-mooney[m] | well that bug does affect vgpu | |
| 11:28:13 | bauzas | songwenping__: look at the two different tests we have for vgpus https://review.opendev.org/c/openstack/nova/+/723858/3/nova/tests/functional/libvirt/test_vgpu.py#237 | |
| 11:28:29 | bauzas | sean-k-mooney[m]: depending on your cloud capacity | |
| 11:28:56 | songwenping__ | tbe exception in my env is: mediated device /sys/bus/mdev/devices/58c9a61a-874f-414c-a8e8-91892a9fc6dd is in use by driver QEMU, domain instance-00000008\n' | |
| 11:29:19 | sean-k-mooney[m] | in any case we don’t officially support multi create with vgpu today | |
| 11:30:21 | sean-k-mooney[m] | that looks like there is a uuid collision on the host or similar reuse of the same mdev | |
| 11:30:23 | bauzas | songwenping__: oh, that's another nvidia issue https://bugs.launchpad.net/nova/+bug/1758086 | |
| 11:30:37 | bauzas | because of IOMMU | |
| 11:31:20 | bauzas | you can't bind 2 vGPUs of the same pGPU on the same guest | |
| 11:31:26 | bauzas | 2 or more vGPUs tbc | |
| 11:31:56 | sean-k-mooney[m] | oh right ya. that is noted in our docs | |
| 11:32:06 | bauzas | you can bind 2 or more vGPUs to the same guest if and only if each of those vGPU is actually provided by a different pGPU | |
| 11:32:33 | bauzas | songwenping__: oh, this exception | |
| 11:32:38 | bauzas | sorry, I misread | |
| 11:32:50 | sean-k-mooney[m] | i’m not sure that limitation applies to intel guys by the way. | |
| 11:33:00 | bauzas | that means we tried to allocate a mdev which was already assigned to another instance | |
| 11:33:06 | bauzas | sean-k-mooney[m]: nope | |
| 11:33:25 | bauzas | anyway, I'm starving | |
| 11:33:32 | sean-k-mooney[m] | right that is what i meant by collision | |
| 11:34:04 | sean-k-mooney[m] | hehe and i’m off today but i get notification on my ipad. was looking a coffee machine reviews :) | |
| 11:34:22 | sean-k-mooney[m] | ill be back on tuesday | |
| 12:21:40 | stephenfin | artom: what's going on with the commit message here? https://review.opendev.org/c/openstack/nova/+/803001 | |
| 13:10:30 | artom | stephenfin, no idea | |
| 13:11:01 | opendevreview | Artom Lifshitz proposed openstack/nova master: I2f9ad3df25306e070c8c3538bfed1212d6d8682f fup: add log https://review.opendev.org/c/openstack/nova/+/803001 | |
| 13:25:54 | opendevreview | Merged openstack/nova master: Fix request path to query a resource provider by uuid https://review.opendev.org/c/openstack/nova/+/800855 | |
| 14:48:47 | bauzas | argh, forgot this ^ | |
| 14:49:04 | bauzas | a Friday 5pm outage ? man, does it mean I should stop then ? :) | |
| 14:50:16 | bauzas | melwitt: sorry I had no time reviewing your series but I haven't forgotten, will do it hopefully on Monday morning so you'd get feedback when you're back from time off | |
| 14:50:44 | bauzas | I'll tho try to start now unti Gerrit shutdowns | |
| 14:52:31 | bauzas | stephenfin: around ? how can I verify the revisions uuids for https://review.opendev.org/c/openstack/placement/+/669170/19/placement/db/sqlalchemy/alembic/versions/422ece571366_add_consumer_types_table.py#1 ? | |
| 14:52:45 | bauzas | L25-26 | |
| 14:52:50 | stephenfin | looking | |
| 14:53:16 | stephenfin | bauzas: the revision UUID should be unique | |
| 14:53:32 | stephenfin | so if you grep for that in the migrations directory, it shouldn't find anything | |
| 14:53:37 | bauzas | ok | |
| 14:53:44 | bauzas | do we have a test running it ? | |
| 14:53:45 | stephenfin | the down_revision on the other hand should be the most recent migration | |
| 14:53:53 | stephenfin | I suspect there are migrations tests | |
| 14:53:59 | bauzas | ok | |
| 14:54:04 | stephenfin | probably in placement.tests.db.test_migrations or similar | |
| 14:54:14 | bauzas | lemme look | |
| 14:55:16 | bauzas | stephenfin: do we need to run some command in some venv for creating a new alembic migration ? | |
| 14:55:20 | bauzas | like reno, I mean | |
| 14:55:55 | stephenfin | yes, 'alembic revision' | |
| 14:56:11 | stephenfin | I've documented it for nova https://review.opendev.org/c/openstack/nova/+/800078/3 | |
| 15:13:18 | bauzas | stephenfin: I see, thanks ! | |
| 16:40:08 | opendevreview | Takashi Kajinami proposed openstack/nova stable/wallaby: Fix request path to query a resource provider by uuid https://review.opendev.org/c/openstack/nova/+/803070 | |
| 16:40:45 | opendevreview | Sylvain Bauza proposed openstack/nova master: Rename vgpu options to mdev https://review.opendev.org/c/openstack/nova/+/801607 | |
| 16:40:46 | opendevreview | Sylvain Bauza proposed openstack/nova master: Provide the mdev class for every PCI device https://review.opendev.org/c/openstack/nova/+/802918 | |
| 16:40:46 | opendevreview | Sylvain Bauza proposed openstack/nova master: DNM (yet) : Expose the mdev class https://review.opendev.org/c/openstack/nova/+/801743 | |
| 16:54:52 | opendevreview | Stephen Finucane proposed openstack/nova master: Move nova-manage db purge to nova-audit https://review.opendev.org/c/openstack/nova/+/708783 | |
| 16:54:53 | opendevreview | Stephen Finucane proposed openstack/nova master: Move nova-manage db archive_deleted_rows to nova-audit https://review.opendev.org/c/openstack/nova/+/708784 | |
| 16:54:53 | opendevreview | Stephen Finucane proposed openstack/nova master: Move nova-manage cell_v2 discover_hosts to nova-manage https://review.opendev.org/c/openstack/nova/+/708785 | |
| 16:54:54 | opendevreview | Stephen Finucane proposed openstack/nova master: Move nova-manage cell_v2 map_instances to nova-audit https://review.opendev.org/c/openstack/nova/+/708786 | |
| 16:54:54 | opendevreview | Stephen Finucane proposed openstack/nova master: Move nova-manage placement sync_aggregates to nova-audit https://review.opendev.org/c/openstack/nova/+/708787 | |
| 16:54:55 | opendevreview | Stephen Finucane proposed openstack/nova master: Move nova-manage placement heal_allocations to nova-audit https://review.opendev.org/c/openstack/nova/+/708788 | |
| 16:54:55 | opendevreview | Stephen Finucane proposed openstack/nova master: WIP: nova-audit: Use cliff instead of homegrown argparse bleh https://review.opendev.org/c/openstack/nova/+/803059 | |