| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-07-06 | |||
| 11:51:36 | gibi | sean-k-mooney: that bdm creation also just calling the db nothing realy time consuming happens there either | |
| 11:52:19 | sean-k-mooney | the current instance claim happens here in the compute https://github.com/openstack/nova/blob/052cf963583ab7c6bbe4fcbf7bfe69f8f6733bdb/nova/compute/manager.py#L2383 | |
| 11:52:33 | sean-k-mooney | so tere is not much on the comptue side before it | |
| 11:54:15 | sean-k-mooney | i dont know it kindof feels wrong to me that we dont do the instance claim and placement allocation creation at the same time | |
| 11:54:51 | sean-k-mooney | that woudl involve moveign the instnace claim even eairlier | |
| 11:58:05 | gibi | I agree that we should do placement and compute claim as close as possible | |
| 11:58:18 | gibi | for me a distance is mostly due to the RPC boundary | |
| 11:58:40 | gibi | not the code between the placemetn allocation call and the instance claim | |
| 11:58:54 | gibi | (except that cybor arq thing that also trigger external calls :/) | |
| 12:12:18 | sean-k-mooney | this is where that happens correct | |
| 12:12:20 | sean-k-mooney | https://github.com/openstack/nova/blob/052cf963583ab7c6bbe4fcbf7bfe69f8f6733bdb/nova/scheduler/filter_scheduler.py#L238-L241 | |
| 12:13:21 | sean-k-mooney | we could do it here i guess https://github.com/openstack/nova/blob/052cf963583ab7c6bbe4fcbf7bfe69f8f6733bdb/nova/scheduler/utils.py#L1255 | |
| 12:14:57 | sean-k-mooney | basiclly if the placment claim succeed we then to the instance claim | |
| 12:15:04 | gibi | if we can do that there then that would be the closest thing possible | |
| 12:15:47 | sean-k-mooney | ok ill see if i can poc that then the only issue with that is we need to make sure to release the instance_claim on the host if we fail for some reaosn but that shoudl be doable | |
| 12:15:53 | gibi | lyarwood: left some comments in the nova-manage refres connection_info spec https://review.opendev.org/c/openstack/nova-specs/+/799624 | |
| 12:16:51 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Align availability zone info with forced host https://review.opendev.org/c/openstack/nova/+/798145 | |
| 12:17:28 | gibi | sean-k-mooney: yeah, cleanup could be tricky as now a claim might need to be cleaned both from the conductor if something fails before the rpc cast or cleaned from the compute if the e.g. the virt driver fails | |
| 12:17:39 | stephenfin | bauzas: gibi: I think that matches up with what was requested? ^ | |
| 12:17:46 | stephenfin | (the AZ-host mismatch patch) | |
| 12:17:50 | gibi | stephenfin: looking | |
| 12:18:00 | bauzas | stephenfin: will look | |
| 13:40:26 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Align availability zone info with forced host https://review.opendev.org/c/openstack/nova/+/798145 | |
| 13:40:47 | stephenfin | bauzas: ^ | |
| 13:41:33 | bauzas | stephenfin: ta, will look | |
| 13:58:55 | gmann | gibi: ack, will check today | |
| 13:59:00 | gibi | gmann: thanks | |
| 14:55:10 | opendevreview | sean mooney proposed openstack/nova master: [DNM] testing os-vif use unreleased os-vif version to test live migration and upgrades https://review.opendev.org/c/openstack/nova/+/799680 | |
| 15:02:45 | bauzas | sean-k-mooney: around ? | |
| 15:15:23 | gibi | stephenfin: seems like the keystone doc job is broken since sqlalchemy 1.4 due to the the warning that is actually fixed by oslo.db 10.0.0 | |
| 15:15:57 | stephenfin | oh, wonderful. So a catch-22? | |
| 15:16:08 | gibi | a bit yes | |
| 15:16:41 | gibi | you have more knowledge about sphinx, can we temporary turn off in it to treat warnings as errors? | |
| 15:16:58 | gibi | that would be a way out | |
| 15:17:23 | stephenfin | what's the link to the patch again? | |
| 15:17:32 | gibi | btw, I'm OK to delete the keystone test, so I will abandon my patch | |
| 15:17:38 | stephenfin | wait, got it | |
| 15:17:59 | gibi | https://review.opendev.org/c/openstack/keystone/+/799670 | |
| 15:18:10 | gibi | waiting... | |
| 15:21:15 | gibi | stephenfin: at least the 10.0.0 req bump now green with a depends on on my keystone patch https://review.opendev.org/c/openstack/requirements/+/799054 | |
| 15:22:43 | stephenfin | gibi: https://review.opendev.org/c/openstack/keystone/+/799682 | |
| 15:24:04 | gibi | I'm not sure I can follow what that patch does. Does this syntax override the cache_ok.__doc__ ? | |
| 15:24:08 | ganso | bauzas, lyarwood, melwitt: When you have a minute could you please take a look at this backport https://review.opendev.org/c/openstack/nova/+/798717 ? Thanks in advance! | |
| 15:24:10 | stephenfin | yujp | |
| 15:24:14 | stephenfin | *yup | |
| 15:24:33 | gibi | jezus that feels like a bug in python :) | |
| 15:24:46 | gibi | or at least an obscure feature | |
| 15:25:29 | gibi | OK, so this will fix the doc bug, then we move your test fix top of it and then update the version bump patch to point to your test fix | |
| 15:26:48 | gibi | I will update the requirement bump patch... | |
| 15:26:56 | stephenfin | It's not Python - it's Sphinx. It's just attempting to do docstring inheritance which would be a sensible thing if you owned the entire subclassed stack | |
| 15:27:06 | stephenfin | Sounds good to me | |
| 15:27:25 | gibi | done | |
| 15:29:08 | gmann | gibi: done, it is as expected because we still support legacy policy so old token can create server. added comment and marked as invalid until author has further query on usage part https://bugs.launchpad.net/nova/+bug/1934478 | |
| 15:31:09 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Trivial style changes https://review.opendev.org/c/openstack/nova/+/799529 | |
| 15:31:09 | opendevreview | Stephen Finucane proposed openstack/nova master: WIP: db: Integrate alembic https://review.opendev.org/c/openstack/nova/+/799530 | |
| 15:31:10 | opendevreview | Stephen Finucane proposed openstack/nova master: fixup! db: Post reshuffle cleanup https://review.opendev.org/c/openstack/nova/+/799683 | |
| 15:31:10 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Normalize migrations tests https://review.opendev.org/c/openstack/nova/+/799684 | |
| 15:35:03 | gibi | gmann: thank you | |
| 15:41:34 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Post reshuffle cleanup https://review.opendev.org/c/openstack/nova/+/799526 | |
| 15:41:34 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Add initial alembic migration for main DB https://review.opendev.org/c/openstack/nova/+/799527 | |
| 15:41:35 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Add initial alembic migration for API DB https://review.opendev.org/c/openstack/nova/+/799528 | |
| 15:41:35 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Trivial style changes https://review.opendev.org/c/openstack/nova/+/799529 | |
| 15:41:36 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Normalize migrations tests https://review.opendev.org/c/openstack/nova/+/799684 | |
| 15:41:36 | opendevreview | Stephen Finucane proposed openstack/nova master: WIP: db: Integrate alembic https://review.opendev.org/c/openstack/nova/+/799530 | |
| 15:45:53 | gibi | nova meeting starts in 15 minutes here in the channel | |
| 15:49:01 | gibi | stephenfin: I only have a naming question in https://review.opendev.org/c/openstack/nova/+/798145/4/nova/tests/unit/api/openstack/compute/test_servers.py#4537 | |
| 15:55:50 | stephenfin | gibi: open to ideas on naming. I don't have anything better :) | |
| 15:56:18 | gibi | stephenfin: I'm wondering if that is really a mismatch case as both the default az is zone1 and the host is in zone1 | |
| 15:57:09 | gibi | never mind | |
| 15:57:16 | gibi | I see your reasoning in the review now | |
| 16:00:10 | gibi | #startmeeting nova | |
| 16:00:10 | opendevmeet | Meeting started Tue Jul 6 16:00:10 2021 UTC and is due to finish in 60 minutes. The chair is gibi. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 16:00:10 | opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 16:00:10 | opendevmeet | The meeting name has been set to 'nova' | |
| 16:00:18 | gibi | o/ | |
| 16:00:25 | elodilles | o/ | |
| 16:00:33 | stephenfin | o/ | |
| 16:00:40 | bauzas | \o | |
| 16:00:51 | gmann | o/ | |
| 16:01:23 | gibi | #topic Bugs (stuck/critical) | |
| 16:01:35 | gibi | no critical bugs | |
| 16:01:35 | gibi | #link 25 new untriaged bugs (+2 since the last meeting): #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New | |
| 16:01:45 | sean-k-mooney | o/ | |
| 16:01:50 | gibi | is there any specific bug that we need to talk about | |
| 16:01:51 | gibi | ? | |
| 16:03:38 | gibi | #topic Gate status | |
| 16:03:43 | gibi | Nova gate bugs #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure | |
| 16:04:06 | gibi | the latest in that list https://bugs.launchpad.net/nova/+bug/1934519 | |
| 16:04:13 | gibi | it solved itself magically | |
| 16:04:42 | gibi | is there any recent gate issue that is happening but not in this list? | |
| 16:05:55 | gibi | #topic Release Planning | |
| 16:05:55 | sean-k-mooney | just a note that i finaly fixed the os-vif gate | |
| 16:06:01 | gibi | sean-k-mooney: thanks | |
| 16:06:05 | sean-k-mooney | although the patch still needs review | |
| 16:06:14 | gibi | link it up here please | |
| 16:06:35 | sean-k-mooney | sure one sec continue on while i find it | |
| 16:06:46 | sean-k-mooney | https://review.opendev.org/c/openstack/os-vif/+/798038 | |
| 16:07:04 | sean-k-mooney | all 3 jobs were using ovn instead of the mix of backend that is fixed by that patch | |
| 16:07:08 | gibi | thanks, I will check it after the meeting | |
| 16:07:30 | gibi | so | |