| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-05-11 | |||
| 17:06:44 | bauzas | ++ | |
| 17:06:44 | bauzas | ++ | |
| 17:08:50 | gibi | bauzas: o/. | |
| 17:08:50 | gibi | bauzas: o/. | |
| 20:28:48 | melwitt | dansmith: I noticed you reviewed the rbd error sanitize patch earlier today, it depends on this one below it that re-enables the rbd unit tests, if you wanted to hit that too https://review.opendev.org/c/openstack/nova/+/790511 | |
| 20:28:48 | melwitt | dansmith: I noticed you reviewed the rbd error sanitize patch earlier today, it depends on this one below it that re-enables the rbd unit tests, if you wanted to hit that too https://review.opendev.org/c/openstack/nova/+/790511 | |
| 20:40:22 | dansmith | oh sorry | |
| 20:40:22 | dansmith | oh sorry | |
| 20:40:43 | dansmith | I actually had that one open too and then just didn't look at it | |
| 20:40:43 | dansmith | I actually had that one open too and then just didn't look at it | |
| 20:42:25 | melwitt | thanks :) | |
| 20:42:25 | melwitt | thanks :) | |
| 21:00:11 | lyarwood | *facepalm* sorry about that melwitt | |
| 21:00:11 | lyarwood | *facepalm* sorry about that melwitt | |
| 21:01:48 | melwitt | np lyarwood | |
| 21:01:48 | melwitt | np lyarwood | |
| 21:02:22 | amodi | Stable branch requires either cherry-pick -x headers or [stable-only] tag! | |
| 21:02:22 | amodi | Stable branch requires either cherry-pick -x headers or [stable-only] tag! | |
| 21:02:37 | amodi | https://review.opendev.org/c/openstack/nova/+/790724 can i not cherry=pick from gerrit ui? | |
| 21:02:37 | amodi | https://review.opendev.org/c/openstack/nova/+/790724 can i not cherry=pick from gerrit ui? | |
| 21:02:43 | amodi | what did i miss | |
| 21:02:43 | amodi | what did i miss | |
| 21:03:57 | openstackgerrit | Merged openstack/nova master: rbd: Get rbd_utils unit tests running again https://review.opendev.org/c/openstack/nova/+/790511 | |
| 21:03:57 | openstackgerrit | Merged openstack/nova master: rbd: Get rbd_utils unit tests running again https://review.opendev.org/c/openstack/nova/+/790511 | |
| 21:04:44 | melwitt | amodi: the gerrit ui only does the needed "cherry-pick -x" after the change you want to backport has merged. if you do the cherry pick in the ui before it merges, it will miss the -x option to cherry-pick | |
| 21:04:44 | melwitt | amodi: the gerrit ui only does the needed "cherry-pick -x" after the change you want to backport has merged. if you do the cherry pick in the ui before it merges, it will miss the -x option to cherry-pick | |
| 21:05:25 | amodi | melwitt: ohh, ok so i guess i need to abandon this and re-cherry-pick it? now that the change has merged | |
| 21:05:25 | amodi | melwitt: ohh, ok so i guess i need to abandon this and re-cherry-pick it? now that the change has merged | |
| 21:06:18 | melwitt | amodi: I'm not sure if there's a way to re-kick it from the ui perspective. you could try it but I'm not sure if that will work. usually we just do an edit to the commit message to add the line manually if this happens | |
| 21:06:18 | melwitt | amodi: I'm not sure if there's a way to re-kick it from the ui perspective. you could try it but I'm not sure if that will work. usually we just do an edit to the commit message to add the line manually if this happens | |
| 21:06:58 | amodi | i want to try with ui itself, one sec | |
| 21:06:58 | amodi | i want to try with ui itself, one sec | |
| 21:07:01 | openstackgerrit | melanie witt proposed openstack/nova stable/wallaby: rbd: Get rbd_utils unit tests running again https://review.opendev.org/c/openstack/nova/+/790836 | |
| 21:07:01 | openstackgerrit | melanie witt proposed openstack/nova stable/wallaby: rbd: Get rbd_utils unit tests running again https://review.opendev.org/c/openstack/nova/+/790836 | |
| 21:07:31 | openstackgerrit | Archit Modi proposed openstack/nova stable/wallaby: Fix typo in test_utils https://review.opendev.org/c/openstack/nova/+/790724 | |
| 21:07:31 | openstackgerrit | Archit Modi proposed openstack/nova stable/wallaby: Fix typo in test_utils https://review.opendev.org/c/openstack/nova/+/790724 | |
| 21:08:34 | amodi | melwitt: yeah looks like it re-kicked it correctly, https://review.opendev.org/c/openstack/nova/+/790724 | |
| 21:08:34 | amodi | melwitt: yeah looks like it re-kicked it correctly, https://review.opendev.org/c/openstack/nova/+/790724 | |
| 21:08:37 | amodi | thanks!! | |
| 21:08:37 | amodi | thanks!! | |
| 21:08:53 | melwitt | kewl | |
| 21:08:53 | melwitt | kewl | |
| #openstack-nova - 2021-05-12 | |||
| 01:01:52 | openstackgerrit | Tetsuro Nakamura proposed openstack/osc-placement master: Support auto-negotiated microversion https://review.opendev.org/c/openstack/osc-placement/+/696028 | |
| 01:01:57 | openstackgerrit | Tetsuro Nakamura proposed openstack/osc-placement master: Switch default to use latest microversion https://review.opendev.org/c/openstack/osc-placement/+/696040 | |
| 01:07:20 | openstackgerrit | likui proposed openstack/nova master: Replace getargspec with getfullargspec https://review.opendev.org/c/openstack/nova/+/790405 | |
| 01:54:25 | openstackgerrit | Tetsuro Nakamura proposed openstack/osc-placement master: Support auto-negotiated microversion https://review.opendev.org/c/openstack/osc-placement/+/696028 | |
| 01:54:26 | openstackgerrit | Tetsuro Nakamura proposed openstack/osc-placement master: Support auto-negotiated microversion https://review.opendev.org/c/openstack/osc-placement/+/696028 | |
| 01:54:30 | openstackgerrit | Tetsuro Nakamura proposed openstack/osc-placement master: Switch default to use latest microversion https://review.opendev.org/c/openstack/osc-placement/+/696040 | |
| 01:54:30 | openstackgerrit | Tetsuro Nakamura proposed openstack/osc-placement master: Switch default to use latest microversion https://review.opendev.org/c/openstack/osc-placement/+/696040 | |
| 02:51:25 | openstackgerrit | likui proposed openstack/nova master: Replace getargspec with getfullargspec https://review.opendev.org/c/openstack/nova/+/790405 | |
| 02:51:25 | openstackgerrit | likui proposed openstack/nova master: Replace getargspec with getfullargspec https://review.opendev.org/c/openstack/nova/+/790405 | |
| 09:03:46 | openstackgerrit | Merged openstack/osc-placement master: Support auto-negotiated microversion https://review.opendev.org/c/openstack/osc-placement/+/696028 | |
| 09:03:46 | openstackgerrit | Merged openstack/osc-placement master: Support auto-negotiated microversion https://review.opendev.org/c/openstack/osc-placement/+/696028 | |
| 09:03:56 | openstackgerrit | Merged openstack/osc-placement master: Switch default to use latest microversion https://review.opendev.org/c/openstack/osc-placement/+/696040 | |
| 09:03:56 | openstackgerrit | Merged openstack/osc-placement master: Switch default to use latest microversion https://review.opendev.org/c/openstack/osc-placement/+/696040 | |
| 09:12:47 | gibi | \o/ that is a real usability improvement ^^ | |
| 09:12:47 | gibi | \o/ that is a real usability improvement ^^ | |
| 09:15:02 | kashyap | gibi: or anyone: Do you know if any other non-OpenStack project using 'reno' for release notes management? | |
| 09:15:02 | kashyap | gibi: or anyone: Do you know if any other non-OpenStack project using 'reno' for release notes management? | |
| 09:15:33 | stephenfin | I use it for my own stuff | |
| 09:15:33 | stephenfin | I use it for my own stuff | |
| 09:15:36 | gibi | kashyap: I'm not aware of any but I never searched for it | |
| 09:15:36 | gibi | kashyap: I'm not aware of any but I never searched for it | |
| 09:15:38 | kashyap | Or is it closely tied to how OpenStack produces docs? | |
| 09:15:38 | kashyap | Or is it closely tied to how OpenStack produces docs? | |
| 09:15:58 | kashyap | stephenfin: I see, good to know. It's not tied to OpenStack's docs tooling, right? | |
| 09:15:58 | kashyap | stephenfin: I see, good to know. It's not tied to OpenStack's docs tooling, right? | |
| 09:16:04 | stephenfin | It's not closely tied to how we produce docs, but it is closely tied to our branching model | |
| 09:16:04 | stephenfin | It's not closely tied to how we produce docs, but it is closely tied to our branching model | |
| 09:16:19 | kashyap | stephenfin: The reason I ask is, QEMU upstream uses MediaWiki for changelog. E.g. https://wiki.qemu.org/ChangeLog/6.0 | |
| 09:16:19 | kashyap | stephenfin: The reason I ask is, QEMU upstream uses MediaWiki for changelog. E.g. https://wiki.qemu.org/ChangeLog/6.0 | |
| 09:16:27 | kashyap | stephenfin: I'm wondering if I can bring them to start using 'reno' | |
| 09:16:27 | kashyap | stephenfin: I'm wondering if I can bring them to start using 'reno' | |
| 09:16:44 | kashyap | Or any other generic Git-based rel note management. | |
| 09:16:44 | kashyap | Or any other generic Git-based rel note management. | |
| 09:17:14 | stephenfin | For example, I tried to integrate it into Sphinx, but they have a merge-back model whereby you propose things to stable branches and then periodically merge those back into master. That breaks reno, which expects branches stable branches to diverge | |
| 09:17:14 | stephenfin | For example, I tried to integrate it into Sphinx, but they have a merge-back model whereby you propose things to stable branches and then periodically merge those back into master. That breaks reno, which expects branches stable branches to diverge | |
| 09:17:20 | stephenfin | kashyap: towncrier | |
| 09:17:20 | stephenfin | kashyap: towncrier | |
| 09:18:31 | kashyap | stephenfin: Oh, I see. So, if a project has non-converging stable -> master approach, then 'reno' is good? | |
| 09:18:31 | kashyap | stephenfin: Oh, I see. So, if a project has non-converging stable -> master approach, then 'reno' is good? | |
| 09:18:33 | stephenfin | kashyap: it's not as clever, but that's possibly a good thing. No git parsing logic. You simply create news fragment files and then once, before a release, you run a manual step to combine those into once NEWS/CHANGELOG/<whatever> file | |
| 09:18:33 | stephenfin | kashyap: it's not as clever, but that's possibly a good thing. No git parsing logic. You simply create news fragment files and then once, before a release, you run a manual step to combine those into once NEWS/CHANGELOG/<whatever> file | |
| 09:18:54 | kashyap | stephenfin: Didn't know of 'towncrier'; /me looks up. | |
| 09:18:54 | kashyap | stephenfin: Didn't know of 'towncrier'; /me looks up. | |
| 09:19:00 | stephenfin | kashyap: Yes, I think that's a fair summary | |
| 09:19:00 | stephenfin | kashyap: Yes, I think that's a fair summary | |
| 09:19:30 | kashyap | stephenfin: Okay; thanks for the suggestion. I'll check w/ the QEMU upstream folks to guage the appetite | |
| 09:19:30 | kashyap | stephenfin: Okay; thanks for the suggestion. I'll check w/ the QEMU upstream folks to guage the appetite | |
| 09:19:44 | kashyap | Since I got used to 'reno', I abhor MediaWiki :D | |
| 09:19:44 | kashyap | Since I got used to 'reno', I abhor MediaWiki :D | |
| 09:20:17 | stephenfin | though you also occasionally need to go in and create a static summary changelog (or whatever you want to call them), whereby you instruct reno not to scan past commit N and simply generate a static listing | |
| 09:20:17 | stephenfin | though you also occasionally need to go in and create a static summary changelog (or whatever you want to call them), whereby you instruct reno not to scan past commit N and simply generate a static listing | |
| 09:20:33 | stephenfin | if you don't do this, the build time will continue to grow with your commit history | |
| 09:20:33 | stephenfin | if you don't do this, the build time will continue to grow with your commit history | |
| 09:21:10 | kashyap | stephenfin: Ah, that's a very useful thing to know; thanks. | |
| 09:21:10 | kashyap | stephenfin: Ah, that's a very useful thing to know; thanks. | |
| 09:21:19 | stephenfin | compare e.g. releasenotes/source/newton.rst with releasenotes/source/ocata.rst | |
| 09:21:19 | stephenfin | compare e.g. releasenotes/source/newton.rst with releasenotes/source/ocata.rst | |
| 09:21:30 | stephenfin | the git log for the former should explain some of the rationale | |