| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-05-06 | |||
| 16:53:00 | dansmith | so either we say "don't change it once you've set it" (which seems reasonable to me) or we say we're going to change everybody, so get your homework done (also reasonable) | |
| 16:53:00 | dansmith | so either we say "don't change it once you've set it" (which seems reasonable to me) or we say we're going to change everybody, so get your homework done (also reasonable) | |
| 16:53:20 | dansmith | if neutron is making some change that is going to require consistency then presumably the latter is the only option | |
| 16:53:20 | dansmith | if neutron is making some change that is going to require consistency then presumably the latter is the only option | |
| 16:59:48 | bauzas | I don't have a particular opinion on how we should fix those RPC issues, but I'm frightened by us trying to change the queue names | |
| 16:59:48 | bauzas | I don't have a particular opinion on how we should fix those RPC issues, but I'm frightened by us trying to change the queue names | |
| 17:00:04 | bauzas | as it's a impactful and visible change | |
| 17:00:04 | bauzas | as it's a impactful and visible change | |
| 17:01:06 | bauzas | anyhow, time to stop | |
| 17:01:06 | bauzas | anyhow, time to stop | |
| 17:01:26 | artom | My brain has mostly checked out at this point (I know, it's only 13:00 here), and I need to run errands anyways | |
| 17:01:26 | artom | My brain has mostly checked out at this point (I know, it's only 13:00 here), and I need to run errands anyways | |
| 17:01:34 | artom | I'll post a spec... I want to say next week? | |
| 17:01:34 | artom | I'll post a spec... I want to say next week? | |
| 17:03:04 | sean-k-mooney | well we can have this just be a workaround config option and never enable it by default | |
| 17:03:04 | sean-k-mooney | well we can have this just be a workaround config option and never enable it by default | |
| 17:12:08 | openstackgerrit | Elod Illes proposed openstack/placement master: Add periodic-stable-jobs template https://review.opendev.org/c/openstack/placement/+/775384 | |
| 17:12:08 | openstackgerrit | Elod Illes proposed openstack/placement master: Add periodic-stable-jobs template https://review.opendev.org/c/openstack/placement/+/775384 | |
| 17:15:25 | dansmith | sean-k-mooney: artom: We could probably lower() the hostname on service.create() and not service.update() in the short term | |
| 17:15:25 | dansmith | sean-k-mooney: artom: We could probably lower() the hostname on service.create() and not service.update() in the short term | |
| 17:15:43 | dansmith | that won't fix the cell mapping issue, but sounds like that's not the primary concern (or the biggest impact) | |
| 17:15:43 | dansmith | that won't fix the cell mapping issue, but sounds like that's not the primary concern (or the biggest impact) | |
| 17:18:41 | artom | So what's the call mapping issue again? | |
| 17:18:41 | artom | So what's the call mapping issue again? | |
| 17:21:15 | sean-k-mooney | dansmith: am maybe. that word normalise any new service yes | |
| 17:21:15 | sean-k-mooney | dansmith: am maybe. that word normalise any new service yes | |
| 17:21:39 | dansmith | sean-k-mooney: we could do the same for cell mappings actually | |
| 17:21:39 | dansmith | sean-k-mooney: we could do the same for cell mappings actually | |
| 17:21:41 | sean-k-mooney | dansmith: althougy we would have to ensure that compute agents used the host value form the service record not form the config when settin up rpc | |
| 17:21:41 | sean-k-mooney | dansmith: althougy we would have to ensure that compute agents used the host value form the service record not form the config when settin up rpc | |
| 17:22:02 | dansmith | sean-k-mooney: yeah | |
| 17:22:02 | dansmith | sean-k-mooney: yeah | |
| 17:23:55 | sean-k-mooney | im not actully sure where that happens i was expecting to see it here but here https://github.com/openstack/nova/blob/master/nova/cmd/compute.py but i guess its elsewhere | |
| 17:23:55 | sean-k-mooney | im not actully sure where that happens i was expecting to see it here but here https://github.com/openstack/nova/blob/master/nova/cmd/compute.py but i guess its elsewhere | |
| 17:24:09 | sean-k-mooney | proably in the compute manager | |
| 17:24:09 | sean-k-mooney | proably in the compute manager | |
| 17:26:27 | sean-k-mooney | ah | |
| 17:26:27 | sean-k-mooney | ah | |
| 17:26:28 | dansmith | it's probably buried in rpc.py | |
| 17:26:28 | dansmith | it's probably buried in rpc.py | |
| 17:26:31 | sean-k-mooney | https://github.com/openstack/nova/blob/7953c0197d1a4466cb5b78070d47626c92f9db6e/nova/compute/rpcapi.py#L53 | |
| 17:26:31 | sean-k-mooney | https://github.com/openstack/nova/blob/7953c0197d1a4466cb5b78070d47626c92f9db6e/nova/compute/rpcapi.py#L53 | |
| 17:26:43 | sean-k-mooney | proably but that is where we get the name | |
| 17:26:43 | sean-k-mooney | proably but that is where we get the name | |
| 17:26:51 | sean-k-mooney | we are using instance.host | |
| 17:26:51 | sean-k-mooney | we are using instance.host | |
| 17:28:05 | dansmith | yeah, which might also bring some problems updating those as well | |
| 17:28:05 | dansmith | yeah, which might also bring some problems updating those as well | |
| 17:28:18 | dansmith | unless we use instance.host to look up service.hostname case insensitively and then use the result | |
| 17:28:18 | dansmith | unless we use instance.host to look up service.hostname case insensitively and then use the result | |
| 17:31:49 | sean-k-mooney | we are usign instace.host for the server filed in the client | |
| 17:31:49 | sean-k-mooney | we are usign instace.host for the server filed in the client | |
| 17:32:07 | sean-k-mooney | so if we look at the srever side of the rpc it has to match | |
| 17:32:07 | sean-k-mooney | so if we look at the srever side of the rpc it has to match | |
| 17:32:26 | sean-k-mooney | which is likly using the host value form the config | |
| 17:32:26 | sean-k-mooney | which is likly using the host value form the config | |
| 17:33:56 | sean-k-mooney | https://github.com/openstack/nova/blob/7953c0197d1a4466cb5b78070d47626c92f9db6e/nova/service.py#L184-L194 | |
| 17:33:56 | sean-k-mooney | https://github.com/openstack/nova/blob/7953c0197d1a4466cb5b78070d47626c92f9db6e/nova/service.py#L184-L194 | |
| 17:34:23 | sean-k-mooney | so ya its usign self.host which shoudl be form the conf | |
| 17:34:23 | sean-k-mooney | so ya its usign self.host which shoudl be form the conf | |
| 17:34:37 | dansmith | right, | |
| 17:34:55 | dansmith | I'm saying that (a) instance.host has to be kept to match service.hostname, so we can't change one without the other | |
| 17:34:55 | dansmith | I'm saying that (a) instance.host has to be kept to match service.hostname, so we can't change one without the other | |
| 17:35:07 | sean-k-mooney | oh yes | |
| 17:35:07 | sean-k-mooney | oh yes | |
| 17:35:19 | dansmith | and (b) we could make service.hostname lowercase on create and make sure that instance.host comes from service.hostname going forward | |
| 17:35:19 | dansmith | and (b) we could make service.hostname lowercase on create and make sure that instance.host comes from service.hostname going forward | |
| 17:35:33 | dansmith | but we sill have the problem of fixing current people or just telling them "don't do that" | |
| 17:35:33 | dansmith | but we sill have the problem of fixing current people or just telling them "don't do that" | |
| 17:35:39 | sean-k-mooney | yes which i think it likely is | |
| 17:35:40 | sean-k-mooney | yes which i think it likely is | |
| 17:36:17 | sean-k-mooney | ya i dont know if this is something we woudl want to do with a nova manage command or something | |
| 17:36:17 | sean-k-mooney | ya i dont know if this is something we woudl want to do with a nova manage command or something | |
| 17:36:42 | sean-k-mooney | like "normalise_host" | |
| 17:36:42 | sean-k-mooney | like "normalise_host" | |
| 17:37:00 | sean-k-mooney | with a nova status check | |
| 17:37:00 | sean-k-mooney | with a nova status check | |
| 17:37:06 | dansmith | that'll be expensive for cern-level people | |
| 17:37:06 | dansmith | that'll be expensive for cern-level people | |
| 17:37:17 | sean-k-mooney | yep | |
| 17:37:50 | sean-k-mooney | if the out come of this is just we wont fix it that is also ok i guess but im concened by our db scema being case inseitive today | |
| 17:37:50 | sean-k-mooney | if the out come of this is just we wont fix it that is also ok i guess but im concened by our db scema being case inseitive today | |
| 17:38:43 | sean-k-mooney | i dont know if we can normalise on loading form the db? | |
| 17:38:43 | sean-k-mooney | i dont know if we can normalise on loading form the db? | |
| 17:39:16 | dansmith | well, we can't without requiring the cloud to be quiesced I think | |
| 17:39:16 | dansmith | well, we can't without requiring the cloud to be quiesced I think | |
| 17:39:32 | dansmith | you'd have to make sure that they all start normalizing at the same time I think, | |
| 17:39:32 | dansmith | you'd have to make sure that they all start normalizing at the same time I think, | |
| 17:39:43 | dansmith | or start doing a lot of extra db queries to check for consistency to decide which value to use | |
| 17:39:43 | dansmith | or start doing a lot of extra db queries to check for consistency to decide which value to use | |
| 17:40:28 | sean-k-mooney | well or a one time set this config value on all hosts now operation | |
| 17:40:28 | sean-k-mooney | well or a one time set this config value on all hosts now operation | |
| 17:40:56 | sean-k-mooney | but ya its not a simple solution in anycase | |
| 17:40:56 | sean-k-mooney | but ya its not a simple solution in anycase | |
| 17:42:10 | sean-k-mooney | i wonder if we could have the service listen on 2 queues | |
| 17:42:10 | sean-k-mooney | i wonder if we could have the service listen on 2 queues | |
| 17:42:20 | sean-k-mooney | the lowercase one and whatever is in the file | |
| 17:42:20 | sean-k-mooney | the lowercase one and whatever is in the file | |
| 17:42:56 | sean-k-mooney | ,,, | |
| 17:42:56 | sean-k-mooney | ,,, | |