| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-05-06 | |||
| 17:26:27 | sean-k-mooney | ah | |
| 17:26:27 | sean-k-mooney | ah | |
| 17:26:28 | dansmith | it's probably buried in rpc.py | |
| 17:26:28 | dansmith | it's probably buried in rpc.py | |
| 17:26:31 | sean-k-mooney | https://github.com/openstack/nova/blob/7953c0197d1a4466cb5b78070d47626c92f9db6e/nova/compute/rpcapi.py#L53 | |
| 17:26:31 | sean-k-mooney | https://github.com/openstack/nova/blob/7953c0197d1a4466cb5b78070d47626c92f9db6e/nova/compute/rpcapi.py#L53 | |
| 17:26:43 | sean-k-mooney | proably but that is where we get the name | |
| 17:26:43 | sean-k-mooney | proably but that is where we get the name | |
| 17:26:51 | sean-k-mooney | we are using instance.host | |
| 17:26:51 | sean-k-mooney | we are using instance.host | |
| 17:28:05 | dansmith | yeah, which might also bring some problems updating those as well | |
| 17:28:05 | dansmith | yeah, which might also bring some problems updating those as well | |
| 17:28:18 | dansmith | unless we use instance.host to look up service.hostname case insensitively and then use the result | |
| 17:28:18 | dansmith | unless we use instance.host to look up service.hostname case insensitively and then use the result | |
| 17:31:49 | sean-k-mooney | we are usign instace.host for the server filed in the client | |
| 17:31:49 | sean-k-mooney | we are usign instace.host for the server filed in the client | |
| 17:32:07 | sean-k-mooney | so if we look at the srever side of the rpc it has to match | |
| 17:32:07 | sean-k-mooney | so if we look at the srever side of the rpc it has to match | |
| 17:32:26 | sean-k-mooney | which is likly using the host value form the config | |
| 17:32:26 | sean-k-mooney | which is likly using the host value form the config | |
| 17:33:56 | sean-k-mooney | https://github.com/openstack/nova/blob/7953c0197d1a4466cb5b78070d47626c92f9db6e/nova/service.py#L184-L194 | |
| 17:33:56 | sean-k-mooney | https://github.com/openstack/nova/blob/7953c0197d1a4466cb5b78070d47626c92f9db6e/nova/service.py#L184-L194 | |
| 17:34:23 | sean-k-mooney | so ya its usign self.host which shoudl be form the conf | |
| 17:34:23 | sean-k-mooney | so ya its usign self.host which shoudl be form the conf | |
| 17:34:37 | dansmith | right, | |
| 17:34:55 | dansmith | I'm saying that (a) instance.host has to be kept to match service.hostname, so we can't change one without the other | |
| 17:34:55 | dansmith | I'm saying that (a) instance.host has to be kept to match service.hostname, so we can't change one without the other | |
| 17:35:07 | sean-k-mooney | oh yes | |
| 17:35:07 | sean-k-mooney | oh yes | |
| 17:35:19 | dansmith | and (b) we could make service.hostname lowercase on create and make sure that instance.host comes from service.hostname going forward | |
| 17:35:19 | dansmith | and (b) we could make service.hostname lowercase on create and make sure that instance.host comes from service.hostname going forward | |
| 17:35:33 | dansmith | but we sill have the problem of fixing current people or just telling them "don't do that" | |
| 17:35:33 | dansmith | but we sill have the problem of fixing current people or just telling them "don't do that" | |
| 17:35:39 | sean-k-mooney | yes which i think it likely is | |
| 17:35:40 | sean-k-mooney | yes which i think it likely is | |
| 17:36:17 | sean-k-mooney | ya i dont know if this is something we woudl want to do with a nova manage command or something | |
| 17:36:17 | sean-k-mooney | ya i dont know if this is something we woudl want to do with a nova manage command or something | |
| 17:36:42 | sean-k-mooney | like "normalise_host" | |
| 17:36:42 | sean-k-mooney | like "normalise_host" | |
| 17:37:00 | sean-k-mooney | with a nova status check | |
| 17:37:00 | sean-k-mooney | with a nova status check | |
| 17:37:06 | dansmith | that'll be expensive for cern-level people | |
| 17:37:06 | dansmith | that'll be expensive for cern-level people | |
| 17:37:17 | sean-k-mooney | yep | |
| 17:37:50 | sean-k-mooney | if the out come of this is just we wont fix it that is also ok i guess but im concened by our db scema being case inseitive today | |
| 17:37:50 | sean-k-mooney | if the out come of this is just we wont fix it that is also ok i guess but im concened by our db scema being case inseitive today | |
| 17:38:43 | sean-k-mooney | i dont know if we can normalise on loading form the db? | |
| 17:38:43 | sean-k-mooney | i dont know if we can normalise on loading form the db? | |
| 17:39:16 | dansmith | well, we can't without requiring the cloud to be quiesced I think | |
| 17:39:16 | dansmith | well, we can't without requiring the cloud to be quiesced I think | |
| 17:39:32 | dansmith | you'd have to make sure that they all start normalizing at the same time I think, | |
| 17:39:32 | dansmith | you'd have to make sure that they all start normalizing at the same time I think, | |
| 17:39:43 | dansmith | or start doing a lot of extra db queries to check for consistency to decide which value to use | |
| 17:39:43 | dansmith | or start doing a lot of extra db queries to check for consistency to decide which value to use | |
| 17:40:28 | sean-k-mooney | well or a one time set this config value on all hosts now operation | |
| 17:40:28 | sean-k-mooney | well or a one time set this config value on all hosts now operation | |
| 17:40:56 | sean-k-mooney | but ya its not a simple solution in anycase | |
| 17:40:56 | sean-k-mooney | but ya its not a simple solution in anycase | |
| 17:42:10 | sean-k-mooney | i wonder if we could have the service listen on 2 queues | |
| 17:42:10 | sean-k-mooney | i wonder if we could have the service listen on 2 queues | |
| 17:42:20 | sean-k-mooney | the lowercase one and whatever is in the file | |
| 17:42:20 | sean-k-mooney | the lowercase one and whatever is in the file | |
| 17:42:56 | sean-k-mooney | ,,, | |
| 17:42:56 | sean-k-mooney | ,,, | |
| 17:43:14 | sean-k-mooney | i was going to say then just start sendign to the lower case one if you trun it on in the contoler config | |
| 17:43:14 | sean-k-mooney | i was going to say then just start sendign to the lower case one if you trun it on in the contoler config | |
| 17:43:15 | dansmith | that would be a super complicated and expensive alternative to "don't rename hosts" :) | |
| 17:43:15 | dansmith | that would be a super complicated and expensive alternative to "don't rename hosts" :) | |
| 17:43:23 | sean-k-mooney | yep | |
| 17:43:47 | melwitt | or "don't use UpPerCAse" | |
| 17:43:47 | melwitt | or "don't use UpPerCAse" | |
| 17:44:19 | sean-k-mooney | ya se the thing is hostnames ans fqdns for that matter are technicaly case senseitive | |
| 17:44:19 | sean-k-mooney | ya se the thing is hostnames ans fqdns for that matter are technicaly case senseitive | |
| 17:44:30 | sean-k-mooney | but often that is ignored | |
| 17:44:30 | sean-k-mooney | but often that is ignored | |
| 17:45:34 | clarkb | I don't think dns treats them that way | |
| 17:45:34 | clarkb | I don't think dns treats them that way | |
| 17:46:08 | clarkb | DNS record types, and the values of TXT and SPF records are case sensitive, but everything else is not | |
| 17:46:08 | clarkb | DNS record types, and the values of TXT and SPF records are case sensitive, but everything else is not | |
| 17:47:00 | sean-k-mooney | good to know | |
| 17:47:00 | sean-k-mooney | good to know | |
| 17:47:57 | sean-k-mooney | i may have been mixing that up with email since the case matters there or at least it used too | |
| 17:47:57 | sean-k-mooney | i may have been mixing that up with email since the case matters there or at least it used too | |
| 17:48:47 | sean-k-mooney | although no one follows the spec when it comes to email | |
| 17:48:47 | sean-k-mooney | although no one follows the spec when it comes to email | |
| 17:54:34 | sean-k-mooney | ok im going to call it a day o/ | |
| 17:54:34 | sean-k-mooney | ok im going to call it a day o/ | |
| 17:57:28 | dansmith | right, what clarkb said | |
| 17:57:28 | dansmith | right, what clarkb said | |
| 18:25:48 | openstackgerrit | melanie witt proposed openstack/nova master: Add test coverage for requestlog X-Forwarded-For https://review.opendev.org/c/openstack/nova/+/790139 | |
| 18:25:48 | openstackgerrit | melanie witt proposed openstack/nova master: Add test coverage for requestlog X-Forwarded-For https://review.opendev.org/c/openstack/nova/+/790139 | |
| 22:49:29 | openstackgerrit | melanie witt proposed openstack/nova master: WIP Enable unified limits in the nova-next job https://review.opendev.org/c/openstack/nova/+/789963 | |
| 22:49:30 | openstackgerrit | melanie witt proposed openstack/nova master: WIP Enable unified limits in the nova-next job https://review.opendev.org/c/openstack/nova/+/789963 | |
| #openstack-nova - 2021-05-07 | |||
| 08:13:40 | brinzhang_ | gibi, gmann: hi gibi, the series of remove tenant_id patches updated, pls review if you have time, thanks | |
| 08:13:40 | brinzhang_ | gibi, gmann: hi gibi, the series of remove tenant_id patches updated, pls review if you have time, thanks | |
| 09:26:59 | gibi | brinzhang_: ack | |
| 09:26:59 | gibi | brinzhang_: ack | |
| 09:34:12 | openstackgerrit | Brin Zhang proposed openstack/nova master: Replace os-simple-tenant-usage with os-simple-project-usage https://review.opendev.org/c/openstack/nova/+/768852 | |
| 09:34:13 | openstackgerrit | Brin Zhang proposed openstack/nova master: Replace tenant_id with project_id in os-quota-sets path https://review.opendev.org/c/openstack/nova/+/768851 | |
| 09:34:13 | openstackgerrit | Brin Zhang proposed openstack/nova master: Replace tenant_id with project_id in Limits API https://review.opendev.org/c/openstack/nova/+/768862 | |