Earlier  
Posted Nick Remark
#openstack-nova - 2021-03-03
11:25:55 bauzas I don't really to vote -1 on a commit msg miss, but I feel this is important to comment the fact that we don't care about a specific DB migration
11:26:03 bauzas really like*
11:26:19 bauzas and a commit msg can't be patched by a FUP...
11:28:41 gibi slaweq: is it happens all the time or just sometimes?
11:29:46 slaweq gibi: on train I think that all the time
11:29:51 slaweq or at least very often
11:30:12 slaweq gibi: in scheduler log I see something like:
11:30:15 slaweq Mar 03 10:32:31.142569 ubuntu-bionic-rax-ord-0023272867 nova-scheduler[24545]: INFO nova.scheduler.host_manager [None req-657ecf60-4fba-4168-9613-3c57d01bdcb7 tempest-MinBwAllocationPlacementTest-1587030703 tempest-MinBwAllocationPlacementTest-1587030703-project-admin] Host filter ignoring hosts: ubuntu-bionic-rax-ord-0023272867
11:30:34 gibi slaweq: ack, give me some time to dive into the logs
11:30:39 slaweq and then next message that " There are 0 hosts available but 1 instances requested to build."
11:30:52 slaweq gibi: sure, I will open LP for that to track it
11:30:55 slaweq thx for help
11:31:02 gibi slaweq: thanks for reporting it
11:31:10 slaweq it's not very urgent for us as this is non-voting job :)
11:31:16 slaweq so take Your time
11:31:36 brinzhang stephenfin: *(songwenping_)from none -> vnc need to reboot, from vnc -> vnc donnot need to reboot* I still think from docs or a bug trace this is a good choice
11:40:24 slaweq gibi: https://bugs.launchpad.net/nova/+bug/1917610
11:40:26 openstack Launchpad bug 1917610 in OpenStack Compute (nova) "Migration and resize tests from tempest.scenario.test_minbw_allocation_placement.MinBwAllocationPlacementTest failing in neutron-tempest-dvr-ha-multinode-full" [Undecided,New]
11:40:26 slaweq reported
11:54:51 openstackgerrit Brin Zhang proposed openstack/nova master: Add missed accel_uuids for _poll_shelved_instances https://review.opendev.org/c/openstack/nova/+/778440
11:57:41 stephenfin brinzhang: I don't :(
11:57:58 openstackgerrit Stephen Finucane proposed openstack/nova master: apidb: Compact Ocata database migrations https://review.opendev.org/c/openstack/nova/+/759402
11:58:03 stephenfin bauzas: Is that okay? ^
11:58:12 stephenfin I'll rebase the rest of the series on top if so
11:58:24 brinzhang bauzas: fixed that bug, pls see https://review.opendev.org/c/openstack/nova/+/778440
12:22:04 brinzhang stephenfin: we will re-search, and make sure whether can reset passwrod and without restart the server
12:22:44 brinzhang s/and//
12:28:08 gibi slaweq: responded in https://bugs.launchpad.net/nova/+bug/1917610 with alternatives to either fix the job definition in neutron or fix the test precoditions in tempest
12:28:09 openstack Launchpad bug 1917610 in OpenStack Compute (nova) "Migration and resize tests from tempest.scenario.test_minbw_allocation_placement.MinBwAllocationPlacementTest failing in neutron-tempest-dvr-ha-multinode-full" [Undecided,New]
12:37:28 slaweq gibi: thx
12:37:42 slaweq gibi: proposed fix https://review.opendev.org/c/openstack/tempest/+/778451 and dnm test patch https://review.opendev.org/c/openstack/neutron/+/778452
12:37:49 slaweq let's check if that will help
12:38:01 gibi tht was fast :)
12:38:50 gibi wondering why this is only hit on stable/train. It should fail on any newer than train too
12:47:30 gibi lyarwood: I see an issue in https://review.opendev.org/c/openstack/nova/+/769548/12/nova/cmd/manage.py#2631
12:53:53 lyarwood ah sorry, I thought I had sorted that out
12:54:05 gibi the update command looks good, you only missed the get
12:56:26 lyarwood yeah my bad
13:47:06 openstackgerrit Balazs Gibizer proposed openstack/nova master: Fix ImageBackendFixture not to support direct_snapshot https://review.opendev.org/c/openstack/nova/+/778462
13:49:50 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Simplify device_path check in _detach_encryptor https://review.opendev.org/c/openstack/nova/+/778463
13:49:55 gibi lyarwood: also could you check my question in https://review.opendev.org/c/openstack/nova/+/774898/7/nova/tests/functional/libvirt/test_machine_type.py#388 and the follow up I pushed?
13:50:38 lyarwood gibi: I was about to ask if that was related
13:50:42 lyarwood looking now
13:50:57 lyarwood just had to push the above fix before switching back to this
13:51:07 gibi yepp it is a fixture fix
13:51:15 gibi to enable the unshelve test
13:53:17 lyarwood wonderful
13:54:00 lyarwood gibi: would you mind if I just pulled in that fix ahead of the new func test
13:54:17 gibi lyarwood: sure
13:54:20 lyarwood thanks
13:59:25 gibi lyarwood: overall I'm +2 on the machine type series I will quickly re-review it once you respin it
14:00:32 lyarwood gibi: thanks, just waiting on a local func run now and I'll push
14:00:42 gibi ack
14:04:50 openstackgerrit Lee Yarwood proposed openstack/nova master: nova-manage: Add libvirt get_machine_type command https://review.opendev.org/c/openstack/nova/+/769548
14:04:51 openstackgerrit Lee Yarwood proposed openstack/nova master: nova-manage: Add libvirt update_machine_type command https://review.opendev.org/c/openstack/nova/+/774896
14:04:51 openstackgerrit Lee Yarwood proposed openstack/nova master: nova-manage: Add libvirt list_unset_machine_type command https://review.opendev.org/c/openstack/nova/+/774897
14:04:52 openstackgerrit Lee Yarwood proposed openstack/nova master: nova-status: Add hw_machine_type check for libvirt instances https://review.opendev.org/c/openstack/nova/+/770643
14:04:52 openstackgerrit Lee Yarwood proposed openstack/nova master: Fix ImageBackendFixture not to support direct_snapshot https://review.opendev.org/c/openstack/nova/+/778462
14:04:53 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Add a config update workflow test for [libvirt]hw_machine_type https://review.opendev.org/c/openstack/nova/+/774898
14:04:53 openstackgerrit Lee Yarwood proposed openstack/nova master: docs: Add admin docs for configuring and updating machine types https://review.opendev.org/c/openstack/nova/+/774899
14:05:05 gibi on it ^^
14:13:33 gibi stephenfin: you blessing is needed on some of the patches in the machine_type series as lyarwood respined it
14:13:45 stephenfin ack, will take a look shortly
14:13:51 stephenfin (in a meeting atm :()
14:16:00 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Simplify device_path check in _detach_encryptor https://review.opendev.org/c/openstack/nova/+/778463
14:20:08 stephenfin gibi: Need your +2 again on https://review.opendev.org/c/openstack/nova/+/759402/ too. I just changed the commit message per bauzas' request
14:20:13 stephenfin Please and thanks :)
14:20:22 gibi on it
14:20:46 bauzas gibi: stephenfin: fast approved as this is only a commit msg update
14:20:53 stephenfin sweet
14:21:02 stephenfin I'll rebase the rest of that series on top of that shortly so
14:21:02 gibi stading down...
14:25:50 gibi anyhow it failed in zuul with a valid reason. unused import /o\
14:27:01 stephenfin oh, weird
14:30:56 stephenfin I think I broke Gerrit
14:31:07 stephenfin Stuck on publishing edit for at least 2 minutes /o\
14:31:14 openstackgerrit Stephen Finucane proposed openstack/nova master: apidb: Compact Ocata database migrations https://review.opendev.org/c/openstack/nova/+/759402
14:31:18 stephenfin phew
14:31:32 stephenfin gibi: bauzas: Removed that import. Conflict was due to I532c7918a8e2c887f29d2f0e1e33b80f2b3a7507
14:32:15 bauzas +Wd
14:33:15 gibi yepp
14:35:47 gibi stephenfin: this needs a +A (there is 2 +2) https://review.opendev.org/c/openstack/nova/+/757615/8
14:39:12 gibi also if somebody could +2 the https://review.opendev.org/c/openstack/nova/+/778177/2 that would be nice to unblock the hyperv rbd series
14:42:08 gmann gibi: done on 778177
14:42:15 gibi thanks!
14:42:39 gmann removing indirect deps will help in these kind of constraints issue
14:44:30 gibi gmann: we have a PTG topic around that https://etherpad.opendev.org/p/nova-xena-ptg L39
14:45:32 gmann gibi: +1 and I think by this or next week I will be able to get consensus in TC also and have some reference document too.
14:45:42 gibi cool
14:46:05 gmann stephenfin: do you need help on this? you might have forget this policy change - https://review.opendev.org/c/openstack/nova/+/765798
14:46:17 gmann last one for that BP as client one is also +A now
14:46:51 stephenfin gmann: Yes, please. I've gotten dragged into UEFI secure boot reviews and haven't been able to round back on that
14:47:03 gmann stephenfin: sure.
14:57:15 stephenfin gibi: +W on https://review.opendev.org/c/openstack/nova/+/757615/ In general I have no issues with you +W your own patches after a rebase and I do it myself all the time. I doubt anyone would disagree :)
14:57:57 gibi ack, thanks
15:11:53 openstackgerrit Stephen Finucane proposed openstack/nova master: apidb: Compact Pike database migrations https://review.opendev.org/c/openstack/nova/+/759403
15:16:23 ralonsoh hi stephenfin, I have one quick question. When you migrated to privsep, did you have any long lived process to be executed as root?
15:16:47 ralonsoh in other words, do you spawn any daemon/server/etc that requires root permissions?
15:17:38 openstackgerrit Stephen Finucane proposed openstack/nova master: apidb: Compact Queens database migrations https://review.opendev.org/c/openstack/nova/+/759404
15:17:53 stephenfin ralonsoh: I don't think so. We just escalate when we need to

Earlier   Later