| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-03-03 | |||
| 12:38:01 | gibi | tht was fast :) | |
| 12:38:50 | gibi | wondering why this is only hit on stable/train. It should fail on any newer than train too | |
| 12:47:30 | gibi | lyarwood: I see an issue in https://review.opendev.org/c/openstack/nova/+/769548/12/nova/cmd/manage.py#2631 | |
| 12:53:53 | lyarwood | ah sorry, I thought I had sorted that out | |
| 12:54:05 | gibi | the update command looks good, you only missed the get | |
| 12:56:26 | lyarwood | yeah my bad | |
| 13:47:06 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Fix ImageBackendFixture not to support direct_snapshot https://review.opendev.org/c/openstack/nova/+/778462 | |
| 13:49:50 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Simplify device_path check in _detach_encryptor https://review.opendev.org/c/openstack/nova/+/778463 | |
| 13:49:55 | gibi | lyarwood: also could you check my question in https://review.opendev.org/c/openstack/nova/+/774898/7/nova/tests/functional/libvirt/test_machine_type.py#388 and the follow up I pushed? | |
| 13:50:38 | lyarwood | gibi: I was about to ask if that was related | |
| 13:50:42 | lyarwood | looking now | |
| 13:50:57 | lyarwood | just had to push the above fix before switching back to this | |
| 13:51:07 | gibi | yepp it is a fixture fix | |
| 13:51:15 | gibi | to enable the unshelve test | |
| 13:53:17 | lyarwood | wonderful | |
| 13:54:00 | lyarwood | gibi: would you mind if I just pulled in that fix ahead of the new func test | |
| 13:54:17 | gibi | lyarwood: sure | |
| 13:54:20 | lyarwood | thanks | |
| 13:59:25 | gibi | lyarwood: overall I'm +2 on the machine type series I will quickly re-review it once you respin it | |
| 14:00:32 | lyarwood | gibi: thanks, just waiting on a local func run now and I'll push | |
| 14:00:42 | gibi | ack | |
| 14:04:50 | openstackgerrit | Lee Yarwood proposed openstack/nova master: nova-manage: Add libvirt get_machine_type command https://review.opendev.org/c/openstack/nova/+/769548 | |
| 14:04:51 | openstackgerrit | Lee Yarwood proposed openstack/nova master: nova-manage: Add libvirt update_machine_type command https://review.opendev.org/c/openstack/nova/+/774896 | |
| 14:04:51 | openstackgerrit | Lee Yarwood proposed openstack/nova master: nova-manage: Add libvirt list_unset_machine_type command https://review.opendev.org/c/openstack/nova/+/774897 | |
| 14:04:52 | openstackgerrit | Lee Yarwood proposed openstack/nova master: nova-status: Add hw_machine_type check for libvirt instances https://review.opendev.org/c/openstack/nova/+/770643 | |
| 14:04:52 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Fix ImageBackendFixture not to support direct_snapshot https://review.opendev.org/c/openstack/nova/+/778462 | |
| 14:04:53 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Add a config update workflow test for [libvirt]hw_machine_type https://review.opendev.org/c/openstack/nova/+/774898 | |
| 14:04:53 | openstackgerrit | Lee Yarwood proposed openstack/nova master: docs: Add admin docs for configuring and updating machine types https://review.opendev.org/c/openstack/nova/+/774899 | |
| 14:05:05 | gibi | on it ^^ | |
| 14:13:33 | gibi | stephenfin: you blessing is needed on some of the patches in the machine_type series as lyarwood respined it | |
| 14:13:45 | stephenfin | ack, will take a look shortly | |
| 14:13:51 | stephenfin | (in a meeting atm :() | |
| 14:16:00 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Simplify device_path check in _detach_encryptor https://review.opendev.org/c/openstack/nova/+/778463 | |
| 14:20:08 | stephenfin | gibi: Need your +2 again on https://review.opendev.org/c/openstack/nova/+/759402/ too. I just changed the commit message per bauzas' request | |
| 14:20:13 | stephenfin | Please and thanks :) | |
| 14:20:22 | gibi | on it | |
| 14:20:46 | bauzas | gibi: stephenfin: fast approved as this is only a commit msg update | |
| 14:20:53 | stephenfin | sweet | |
| 14:21:02 | stephenfin | I'll rebase the rest of that series on top of that shortly so | |
| 14:21:02 | gibi | stading down... | |
| 14:25:50 | gibi | anyhow it failed in zuul with a valid reason. unused import /o\ | |
| 14:27:01 | stephenfin | oh, weird | |
| 14:30:56 | stephenfin | I think I broke Gerrit | |
| 14:31:07 | stephenfin | Stuck on publishing edit for at least 2 minutes /o\ | |
| 14:31:14 | openstackgerrit | Stephen Finucane proposed openstack/nova master: apidb: Compact Ocata database migrations https://review.opendev.org/c/openstack/nova/+/759402 | |
| 14:31:18 | stephenfin | phew | |
| 14:31:32 | stephenfin | gibi: bauzas: Removed that import. Conflict was due to I532c7918a8e2c887f29d2f0e1e33b80f2b3a7507 | |
| 14:32:15 | bauzas | +Wd | |
| 14:33:15 | gibi | yepp | |
| 14:35:47 | gibi | stephenfin: this needs a +A (there is 2 +2) https://review.opendev.org/c/openstack/nova/+/757615/8 | |
| 14:39:12 | gibi | also if somebody could +2 the https://review.opendev.org/c/openstack/nova/+/778177/2 that would be nice to unblock the hyperv rbd series | |
| 14:42:08 | gmann | gibi: done on 778177 | |
| 14:42:15 | gibi | thanks! | |
| 14:42:39 | gmann | removing indirect deps will help in these kind of constraints issue | |
| 14:44:30 | gibi | gmann: we have a PTG topic around that https://etherpad.opendev.org/p/nova-xena-ptg L39 | |
| 14:45:32 | gmann | gibi: +1 and I think by this or next week I will be able to get consensus in TC also and have some reference document too. | |
| 14:45:42 | gibi | cool | |
| 14:46:05 | gmann | stephenfin: do you need help on this? you might have forget this policy change - https://review.opendev.org/c/openstack/nova/+/765798 | |
| 14:46:17 | gmann | last one for that BP as client one is also +A now | |
| 14:46:51 | stephenfin | gmann: Yes, please. I've gotten dragged into UEFI secure boot reviews and haven't been able to round back on that | |
| 14:47:03 | gmann | stephenfin: sure. | |
| 14:57:15 | stephenfin | gibi: +W on https://review.opendev.org/c/openstack/nova/+/757615/ In general I have no issues with you +W your own patches after a rebase and I do it myself all the time. I doubt anyone would disagree :) | |
| 14:57:57 | gibi | ack, thanks | |
| 15:11:53 | openstackgerrit | Stephen Finucane proposed openstack/nova master: apidb: Compact Pike database migrations https://review.opendev.org/c/openstack/nova/+/759403 | |
| 15:16:23 | ralonsoh | hi stephenfin, I have one quick question. When you migrated to privsep, did you have any long lived process to be executed as root? | |
| 15:16:47 | ralonsoh | in other words, do you spawn any daemon/server/etc that requires root permissions? | |
| 15:17:38 | openstackgerrit | Stephen Finucane proposed openstack/nova master: apidb: Compact Queens database migrations https://review.opendev.org/c/openstack/nova/+/759404 | |
| 15:17:53 | stephenfin | ralonsoh: I don't think so. We just escalate when we need to | |
| 15:18:23 | ralonsoh | stephenfin, without rootwrap, of course | |
| 15:18:48 | stephenfin | iirc privsep is run under a rootwrap daemon | |
| 15:18:53 | stephenfin | so rootwrap is still there | |
| 15:19:03 | ralonsoh | yes, but only privsep | |
| 15:19:30 | ralonsoh | I mean, the privsep daemon. In anycase, you still use rootwrap | |
| 15:20:44 | stephenfin | Mostly. I recall there being some rootwrap filters left for some os-brick stuff | |
| 15:21:05 | atmark | hello, is there to another option in the config to move the cold migration target to different interface? I know for live you can set live_migration_inbound_addr but how about for cold migration? | |
| 15:21:13 | ralonsoh | stephenfin, thanks!! | |
| 15:21:37 | stephenfin | atmark: I'm not aware of such a mechanism, no | |
| 15:23:12 | atmark | The cold migration still uses the management interface even if I have live_migration_inbound_addr | |
| 15:24:29 | atmark | in a different interface | |
| 15:33:30 | sean-k-mooney | atmark: yes it will | |
| 15:33:43 | sean-k-mooney | live_migration_inbound_addr is only for live migration | |
| 15:34:17 | sean-k-mooney | you can adres this via kernel routes | |
| 16:02:39 | openstackgerrit | Stephen Finucane proposed openstack/nova master: apidb: Compact Rocky database migrations https://review.opendev.org/c/openstack/nova/+/759405 | |
| 16:03:48 | openstackgerrit | Stephen Finucane proposed openstack/nova master: apidb: Compact Stein database migrations https://review.opendev.org/c/openstack/nova/+/759406 | |
| 16:05:08 | openstackgerrit | Stephen Finucane proposed openstack/nova master: apidb: Compact Train database migrations https://review.opendev.org/c/openstack/nova/+/771420 | |
| 16:18:52 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Bump the Compute RPC API to version 6.0 https://review.opendev.org/c/openstack/nova/+/761452 | |
| 16:19:20 | bauzas | dansmith: gibi: stephenfin: artom: updated based on your feedbacks ^ | |
| 16:19:31 | gibi | bauzas: looking | |
| 16:20:13 | bauzas | tl;dr: removed the unused args from the RPC methods stephenfin told + changed the numa tests to pin to 5.max instead | |
| 16:23:26 | openstackgerrit | Merged openstack/python-novaclient master: Add support for microversion v2.88 https://review.opendev.org/c/openstack/python-novaclient/+/770573 | |
| 16:25:34 | belmoreira | recently found this behaviour in Nova: https://bugs.launchpad.net/nova/+bug/1917645 and I'm not sleeping well since :) not sure if this should be Nova or Oslo. I would appreciate some guidance. | |
| 16:25:35 | openstack | Launchpad bug 1917645 in OpenStack Compute (nova) "Nova can't create instances if RabbitMQ notification cluster is down" [Undecided,New] | |
| 16:29:19 | bauzas | belmoreira: if the rabbit is down, how the conductor and scheduler could help the nova-api service to tell which host ? | |
| 16:29:43 | bauzas | that actually reminds me preemptible instances | |
| 16:29:53 | belmoreira | we have an independent rabbit for everything | |
| 16:29:58 | bauzas | some kind of instance that would be pre-created | |
| 16:30:46 | belmoreira | bauzas each cell has it's own rabbit, including one for the support conductor/scheduler. Then we have a rabbit for the notifications | |
| 16:31:15 | belmoreira | support/super | |
| 16:31:29 | bauzas | oh sorry, I missed the fact you were mentioning the notifications rabbit | |
| 16:31:42 | bauzas | and not the API MQ or the cell MQs | |