Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-01-28
16:32:15 lyarwood yeah it wasn't easy and it's just nice to have it in tree and updated in the same change as the actual bump etc
16:33:10 artom Lol, I just realized running functional tests locally that need an un-mergde os-traits patch is... dumb.
16:35:24 sean-k-mooney artom: you can do that
16:35:28 lyarwood artom: install it into the env
16:35:34 sean-k-mooney you just pip install it in the env
16:35:50 artom Right, I'm sure there are ways
16:36:25 sean-k-mooney basicaly .tox/functional/bin/python3 -m pip install -e ../os-traits
16:36:44 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: [WIP] libvirt: Remove compareCPU() check on the destination https://review.opendev.org/c/openstack/nova/+/772917
16:36:52 sean-k-mooney assuming you have os-traits cloneed and checked out beside your nova dir
17:27:58 openstackgerrit Stephen Finucane proposed openstack/nova master: mypy: Add nova.cmd, nova.conf, nova.console https://review.opendev.org/c/openstack/nova/+/705657
17:27:58 openstackgerrit Stephen Finucane proposed openstack/nova master: mypy: Add type annotations to top-level modules https://review.opendev.org/c/openstack/nova/+/705658
17:27:59 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Clean manager.Manager, service.Service signatures https://review.opendev.org/c/openstack/nova/+/764806
17:27:59 openstackgerrit Stephen Finucane proposed openstack/nova master: WIP: Expand type hints for nova.block_device https://review.opendev.org/c/openstack/nova/+/742170
17:28:00 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Remove dead code https://review.opendev.org/c/openstack/nova/+/772928
18:34:15 openstackgerrit Lee Yarwood proposed openstack/nova master: Disallow CONF.compute.max_disk_devices_to_attach = 0 https://review.opendev.org/c/openstack/nova/+/755360
18:35:24 artom Didn't melwitt already do that?
18:36:34 lyarwood artom: that was just a rebase
18:36:48 artom Ag
18:36:49 artom Ah
18:38:36 artom *facepalm*
18:39:00 artom When 0 is an "allowed" value, but None is not, don't just if <value> :(
18:39:08 artom That's a couple of hours wasted
18:54:13 sean-k-mooney its the same as the rpc workers issue we fixed a whiel back
18:54:19 sean-k-mooney jsut missign the min=1
18:54:50 sean-k-mooney ah we have -1 for unlimited
18:55:02 sean-k-mooney so so we cant do that
18:55:08 sean-k-mooney really we should have used 0 for that
18:55:21 sean-k-mooney in this case since 0 is not valid
20:12:20 ganso Hi Nova folks! I just logged this bug https://bugs.launchpad.net/nova/+bug/1913641 and while thinking about the possible ways to solve it, I started wondering whether it was intentional (and therefore not a bug) to consider shelved_offloaded instances as running, metric-wise.
20:12:21 openstack Launchpad bug 1913641 in OpenStack Compute (nova) "Incorrect Shelved_offloaded instance metrics on openstack usage show output" [Undecided,New]
21:03:34 openstackgerrit Artom Lifshitz proposed openstack/nova master: WIP: libvirt: start tracking NUMACell.socket for hosts https://review.opendev.org/c/openstack/nova/+/766816
21:03:35 openstackgerrit Artom Lifshitz proposed openstack/nova master: WIP: extra specs/image pros: add `socket PCI NUMA affinity https://review.opendev.org/c/openstack/nova/+/772748
21:03:35 openstackgerrit Artom Lifshitz proposed openstack/nova master: WIP: Add `socket` PCI NUMA affinity policy request prefilter https://review.opendev.org/c/openstack/nova/+/772749
21:03:36 openstackgerrit Artom Lifshitz proposed openstack/nova master: WIP: pci: implement the SOCKET NUMA affinity policy https://review.opendev.org/c/openstack/nova/+/772779
21:04:21 artom ganso, I *think* `openstack show usage` is about quotas, and shelved offloaded still count against the quota
21:04:53 artom But you're correct in assuming their resources (disk, VM) should not be counted...
21:10:18 ganso artom: Thanks for the response. hmm given that the metrics shown are cpu-hours, ram-hours and disk-hours, it is a constantly updating, and therefore increasing the value to be billed, if this info is used for billing, whereas quotas remain constant if the number of instances do not change. And indeed, since "count_usage_from_placement" was introduced, shelved_offloaded instances do not even have allocations anymore (nor quotas), but they are listed
21:10:18 ganso in usage show because they show up in "InstanceList". So, considering all that, sounds like a valid bug.
21:52:28 openstackgerrit Merged openstack/nova master: Allow extending an existing instance allocation https://review.opendev.org/c/openstack/nova/+/757109
22:06:13 openstackgerrit Merged openstack/nova master: Make remove allocation symmetric with add allocation https://review.opendev.org/c/openstack/nova/+/757110
22:19:40 openstackgerrit Merged openstack/nova master: Factor out port resource deallocation https://review.opendev.org/c/openstack/nova/+/757111
22:20:13 openstackgerrit Merged openstack/nova master: Refactor update_pci_request_spec_with_allocated_interface_name https://review.opendev.org/c/openstack/nova/+/757614
#openstack-nova - 2021-01-29
01:19:40 openstackgerrit Merged openstack/nova stable/queens: libvirt: Do not reference VIR_ERR_DEVICE_MISSING when libvirt is < v4.1.0 https://review.opendev.org/c/openstack/nova/+/747362
01:20:02 sapd1_x bauzas, So we need RHEL ?
07:02:17 openstackgerrit Merged openstack/nova master: Disallow CONF.compute.max_disk_devices_to_attach = 0 https://review.opendev.org/c/openstack/nova/+/755360
07:45:58 openstackgerrit Yongli He proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944
08:26:26 gibi lyarwood: Hi! I have a question in https://review.opendev.org/c/openstack/nova/+/768472
08:36:27 openstackgerrit Merged openstack/nova master: Add regression test for bug #1909120 https://review.opendev.org/c/openstack/nova/+/768351
08:36:29 openstack bug 1909120 in OpenStack Compute (nova) "n-api should reject requests to detach a volume when the compute is down" [Medium,Confirmed] https://launchpad.net/bugs/1909120 - Assigned to Lee Yarwood (lyarwood)
08:46:08 nightmare_unreal Good morning nova \0
08:46:20 nightmare_unreal is there a way to force boot from volume in a specific cell ?
09:37:09 openstackgerrit Stephen Finucane proposed openstack/nova stable/victoria: Disallow CONF.compute.max_disk_devices_to_attach = 0 https://review.opendev.org/c/openstack/nova/+/772984
09:37:39 openstackgerrit Stephen Finucane proposed openstack/nova stable/ussuri: Disallow CONF.compute.max_disk_devices_to_attach = 0 https://review.opendev.org/c/openstack/nova/+/772985
09:38:17 openstackgerrit Stephen Finucane proposed openstack/nova stable/train: Disallow CONF.compute.max_disk_devices_to_attach = 0 https://review.opendev.org/c/openstack/nova/+/772986
09:44:24 bauzas sapd__x: not exactly, the support matrix tells you the supported OSes
09:44:46 bauzas sapd__x: meaning that a RHEL-flavored OS *could* work
09:45:00 bauzas but I haven't tested it tbh
10:10:22 kashyap stephenfin: or anyone, do you know why is 'git review' failing this way? -- http://paste.openstack.org/show/802125/
10:10:34 kashyap (I see this after I rebooted on my F33 box)
10:10:59 kashyap Oh, wait ... it's the review.openstack.org URL
10:11:42 stephenfin yeah, you either need to update your URL or set the following in ~/.gitconfig
10:11:52 stephenfin [url "https://git.openstack.org/"]
10:12:04 stephenfin >-------insteadof = git://git.openstack.org/
10:12:17 stephenfin Whoops, that should be a tab instead of >------
10:17:21 kashyap Thanks!
10:23:47 kashyap stephenfin: Can you post your Git config somewhere, please? I still weirdnesses here since my reboot. Strange, as it was working yesterday
10:27:39 kashyap Ot
10:28:20 kashyap Err, typo. I meant, it's not the Git config. I still see the "unpacker error"
10:29:22 kashyap Oh, I think I know what it is.../me tinkers
10:30:38 bauzas kashyap: you need to git clean OMHO
10:31:17 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove compareCPU() check on the destination https://review.opendev.org/c/openstack/nova/+/772917
10:31:36 kashyap stephenfin: bauzas: Disregard me on that; fixed ... it is out of remotes
10:31:37 bauzas :)
10:31:53 bauzas out of remotes ?
10:32:03 kashyap bauzas: Err, out of sync, I mean :-)
10:32:19 bauzas so a fetch did the trick ?
10:32:21 kashyap A proper `git fetch gerrit` fixed it
10:32:22 kashyap Yep
10:32:47 bauzas weirdo, I was expecting git review to fetch the remote anyway before uploading
10:32:59 bauzas unless you were using the -R flag
10:33:19 bauzas (meaning, don't fetch the remote, don't compare, send my patch straight)
10:33:36 kashyap bauzas: Right; I wasn't using -R
10:33:46 bauzas oki doki
10:33:53 bauzas weirdo, still but okay
10:34:05 kashyap gibi: stephenfin: Unrelated; I'd really appreciate a look at the above small code-removal change: it should fix a real bug: https://review.opendev.org/c/openstack/nova/+/772917
10:34:15 kashyap (I'm waiting on upgrades tester to report back the result of it.)
10:34:46 kashyap bauzas: Regardless, thanks for looking :-)
10:36:22 bauzas np
10:36:44 bauzas gibi: apologies for yesterday meeting, I faced a network outage at this time
10:37:08 bauzas my faul, I stupidely upgraded my home network 30 mins before the meeting and I faced unexpected issues
10:37:52 bauzas but at least now, I'm decently covered by a good gateway (unifi USG)
10:38:28 bauzas pro-tip : don't overlap subnets between LAN and WAN connections
10:38:44 bauzas or your router will mess up
11:45:49 gibi bauzas: no worries
11:45:51 gibi kashyap: on it
11:46:21 kashyap gibi: Thank you. I'm still quietly thinking through if I'm forgetting to consider any other aspects
11:46:39 kashyap If you have any questions, can respond here, or on the change
11:49:06 gibi kashyap: If I trust the commit message the the change looks good as it does what the commit message describes
11:49:43 kashyap gibi: Heh, noted. FWIW, two libvirt CPU modelling devs also suggested the same
11:49:54 kashyap So I'm not doing this haphazardly; as this has live migration implications

Earlier   Later