Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-01-29
07:02:17 openstackgerrit Merged openstack/nova master: Disallow CONF.compute.max_disk_devices_to_attach = 0 https://review.opendev.org/c/openstack/nova/+/755360
07:45:58 openstackgerrit Yongli He proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944
08:26:26 gibi lyarwood: Hi! I have a question in https://review.opendev.org/c/openstack/nova/+/768472
08:36:27 openstackgerrit Merged openstack/nova master: Add regression test for bug #1909120 https://review.opendev.org/c/openstack/nova/+/768351
08:36:29 openstack bug 1909120 in OpenStack Compute (nova) "n-api should reject requests to detach a volume when the compute is down" [Medium,Confirmed] https://launchpad.net/bugs/1909120 - Assigned to Lee Yarwood (lyarwood)
08:46:08 nightmare_unreal Good morning nova \0
08:46:20 nightmare_unreal is there a way to force boot from volume in a specific cell ?
09:37:09 openstackgerrit Stephen Finucane proposed openstack/nova stable/victoria: Disallow CONF.compute.max_disk_devices_to_attach = 0 https://review.opendev.org/c/openstack/nova/+/772984
09:37:39 openstackgerrit Stephen Finucane proposed openstack/nova stable/ussuri: Disallow CONF.compute.max_disk_devices_to_attach = 0 https://review.opendev.org/c/openstack/nova/+/772985
09:38:17 openstackgerrit Stephen Finucane proposed openstack/nova stable/train: Disallow CONF.compute.max_disk_devices_to_attach = 0 https://review.opendev.org/c/openstack/nova/+/772986
09:44:24 bauzas sapd__x: not exactly, the support matrix tells you the supported OSes
09:44:46 bauzas sapd__x: meaning that a RHEL-flavored OS *could* work
09:45:00 bauzas but I haven't tested it tbh
10:10:22 kashyap stephenfin: or anyone, do you know why is 'git review' failing this way? -- http://paste.openstack.org/show/802125/
10:10:34 kashyap (I see this after I rebooted on my F33 box)
10:10:59 kashyap Oh, wait ... it's the review.openstack.org URL
10:11:42 stephenfin yeah, you either need to update your URL or set the following in ~/.gitconfig
10:11:52 stephenfin [url "https://git.openstack.org/"]
10:12:04 stephenfin >-------insteadof = git://git.openstack.org/
10:12:17 stephenfin Whoops, that should be a tab instead of >------
10:17:21 kashyap Thanks!
10:23:47 kashyap stephenfin: Can you post your Git config somewhere, please? I still weirdnesses here since my reboot. Strange, as it was working yesterday
10:27:39 kashyap Ot
10:28:20 kashyap Err, typo. I meant, it's not the Git config. I still see the "unpacker error"
10:29:22 kashyap Oh, I think I know what it is.../me tinkers
10:30:38 bauzas kashyap: you need to git clean OMHO
10:31:17 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove compareCPU() check on the destination https://review.opendev.org/c/openstack/nova/+/772917
10:31:36 kashyap stephenfin: bauzas: Disregard me on that; fixed ... it is out of remotes
10:31:37 bauzas :)
10:31:53 bauzas out of remotes ?
10:32:03 kashyap bauzas: Err, out of sync, I mean :-)
10:32:19 bauzas so a fetch did the trick ?
10:32:21 kashyap A proper `git fetch gerrit` fixed it
10:32:22 kashyap Yep
10:32:47 bauzas weirdo, I was expecting git review to fetch the remote anyway before uploading
10:32:59 bauzas unless you were using the -R flag
10:33:19 bauzas (meaning, don't fetch the remote, don't compare, send my patch straight)
10:33:36 kashyap bauzas: Right; I wasn't using -R
10:33:46 bauzas oki doki
10:33:53 bauzas weirdo, still but okay
10:34:05 kashyap gibi: stephenfin: Unrelated; I'd really appreciate a look at the above small code-removal change: it should fix a real bug: https://review.opendev.org/c/openstack/nova/+/772917
10:34:15 kashyap (I'm waiting on upgrades tester to report back the result of it.)
10:34:46 kashyap bauzas: Regardless, thanks for looking :-)
10:36:22 bauzas np
10:36:44 bauzas gibi: apologies for yesterday meeting, I faced a network outage at this time
10:37:08 bauzas my faul, I stupidely upgraded my home network 30 mins before the meeting and I faced unexpected issues
10:37:52 bauzas but at least now, I'm decently covered by a good gateway (unifi USG)
10:38:28 bauzas pro-tip : don't overlap subnets between LAN and WAN connections
10:38:44 bauzas or your router will mess up
11:45:49 gibi bauzas: no worries
11:45:51 gibi kashyap: on it
11:46:21 kashyap gibi: Thank you. I'm still quietly thinking through if I'm forgetting to consider any other aspects
11:46:39 kashyap If you have any questions, can respond here, or on the change
11:49:06 gibi kashyap: If I trust the commit message the the change looks good as it does what the commit message describes
11:49:43 kashyap gibi: Heh, noted. FWIW, two libvirt CPU modelling devs also suggested the same
11:49:54 kashyap So I'm not doing this haphazardly; as this has live migration implications
11:49:57 gibi we have some livemigration tests but I guess there the two node is symmetric
11:50:10 kashyap Yeah, we don't have an intergration test for this scenario in the Gate
11:50:23 kashyap gibi: gibi: So, I'm waiting on Red Hat upgrades testing folks to report back w/ the result
11:50:37 kashyap I gave them them patch to give it a try
11:50:49 gibi kashyap: OK, so RedHat will do some extra testing on it
11:50:57 gibi that sounds good to me
11:50:58 kashyap gibi: Also if you have time, please read the "Root cause anlaysis": https://bugs.launchpad.net/nova/+bug/1913716
11:50:59 openstack Launchpad bug 1913716 in OpenStack Compute (nova) "Live-migrating an instance from 'Queens' (CentOS-7) to 'Train' (CentOS-8) fails during libvirt's compareCPU() check" [Undecided,New]
11:51:02 kashyap gibi: Thank you!
11:51:18 gibi I will leave a +1 and wait for the result of the extra testing
11:51:19 kashyap I filed that bug report, based on yesterday's analysis w/ DanPB
11:51:24 kashyap gibi: Yep, understood
11:52:28 kashyap gibi: There is another occurrence in the code where we use compareCPU(). I need to carefully review the code again to see if that also can be removed, or replace it w/ the newer API. As noted in the commit message
11:52:42 gibi ack
11:52:44 kashyap But that's a separate item; not mixing up here
11:52:48 gibi cool
12:01:17 openstackgerrit Balazs Gibizer proposed openstack/nova master: libvirt: Define and emit DeviceRemovedEvent and DeviceRemovalFailedEvent https://review.opendev.org/c/openstack/nova/+/749929
12:02:43 openstackgerrit Balazs Gibizer proposed openstack/nova master: libvirt: add AsyncDeviceDetachEventsHandler https://review.opendev.org/c/openstack/nova/+/772381
12:02:43 openstackgerrit Balazs Gibizer proposed openstack/nova master: libvirt: allow querying devices from the persistent domain https://review.opendev.org/c/openstack/nova/+/772383
12:03:29 gibi lyarwood: fixed your comment in https://review.opendev.org/c/openstack/nova/+/749929
12:05:27 openstackgerrit Balazs Gibizer proposed openstack/nova master: libvirt: parse alias out from device config https://review.opendev.org/c/openstack/nova/+/772384
12:06:07 sean-k-mooney stephenfin: by the way you dont need to update teh git review url
12:07:02 sean-k-mooney stephenfin: on fedora 33 the issue with git-review is that gerrit does not implement the negociation to enable the ssh clinet to use rsa-sha2
12:07:05 openstackgerrit Balazs Gibizer proposed openstack/nova master: Replace blind retry with libvirt event waiting in detach https://review.opendev.org/c/openstack/nova/+/770246
12:07:16 stephenfin sean-k-mooney: that wasn't kashyap's issue
12:07:17 sean-k-mooney and on fedora 33 sha1 is disable
12:07:29 kashyap Yeah, as stephenfin says that wasn't my issue
12:07:42 sean-k-mooney oh you had review.openstack.org
12:07:48 sean-k-mooney not review.opendev.org
12:08:05 kashyap Right; but that doesn't needed updating; it auto-redirects and did the right thing until yesterday
12:08:36 kashyap My issue was something dumber: out of sync remotes. Just a `fetch` fixed it
12:08:47 sean-k-mooney ah
12:09:08 sean-k-mooney you should still update the url i have fond that the redirects are flaky
12:09:39 sean-k-mooney it works for https
12:09:51 sean-k-mooney havent hand the same look using ssh
12:10:22 kashyap (I did update, though, while at it)
12:45:06 openstackgerrit Balazs Gibizer proposed openstack/nova master: Replace blind retry with libvirt event waiting in detach https://review.opendev.org/c/openstack/nova/+/770246
12:47:43 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Remove dead code https://review.opendev.org/c/openstack/nova/+/772928
12:47:44 openstackgerrit Stephen Finucane proposed openstack/nova master: mypy: Add type annotations to 'nova.pci' https://review.opendev.org/c/openstack/nova/+/676209
12:47:45 openstackgerrit Stephen Finucane proposed openstack/nova master: mypy: Add nova.cmd, nova.conf, nova.console https://review.opendev.org/c/openstack/nova/+/705657
12:47:45 openstackgerrit Stephen Finucane proposed openstack/nova master: mypy: Add type annotations to top-level modules https://review.opendev.org/c/openstack/nova/+/705658
12:47:46 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Clean manager.Manager, service.Service signatures https://review.opendev.org/c/openstack/nova/+/764806
12:47:46 openstackgerrit Stephen Finucane proposed openstack/nova master: WIP: Expand type hints for nova.block_device https://review.opendev.org/c/openstack/nova/+/742170
12:54:14 openstackgerrit Merged openstack/nova master: Enable mypy on scheduler/utils.py https://review.opendev.org/c/openstack/nova/+/769942

Earlier   Later