| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-01-21 | |||
| 04:45:32 | openstackgerrit | Hemanth N proposed openstack/nova stable/stein: Update pci stat pools based on PCI device changes https://review.opendev.org/c/openstack/nova/+/761727 | |
| 05:56:43 | openstackgerrit | Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from Flavor Access APIs https://review.opendev.org/c/openstack/nova/+/767704 | |
| 05:57:22 | openstackgerrit | Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List/Show usage APIs https://review.opendev.org/c/openstack/nova/+/768509 | |
| 05:57:57 | openstackgerrit | Brin Zhang proposed openstack/nova master: Replace tenants* with projects* of policies https://review.opendev.org/c/openstack/nova/+/765315 | |
| 05:58:56 | openstackgerrit | Brin Zhang proposed openstack/nova master: Replace os-simple-tenant-usage with os-simple-project-usage https://review.opendev.org/c/openstack/nova/+/768852 | |
| 06:00:03 | openstackgerrit | Brin Zhang proposed openstack/nova master: Replace tenant_id with project_id in os-quota-sets path https://review.opendev.org/c/openstack/nova/+/768851 | |
| 06:01:09 | openstackgerrit | Brin Zhang proposed openstack/nova master: Replace tenant_id with project_id in Limits API https://review.opendev.org/c/openstack/nova/+/768862 | |
| 06:01:42 | openstackgerrit | Brin Zhang proposed openstack/nova master: Replace tenant* with project* in codes https://review.opendev.org/c/openstack/nova/+/769329 | |
| 07:13:13 | openstackgerrit | Yongli He proposed openstack/nova master: Smartnic support - cyborg drive https://review.opendev.org/c/openstack/nova/+/771362 | |
| 07:13:14 | openstackgerrit | Yongli He proposed openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363 | |
| 07:13:14 | openstackgerrit | Yongli He proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944 | |
| 08:23:31 | gibi | lyarwood: hi! looking at the ppc64 unit test results here https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/periodic/openstack-tox-py39/2021-01-19-0058-38c70ae/job-output.txt | |
| 08:23:52 | gibi | it seems that the failed tests are arch dependent | |
| 08:24:16 | gibi | as os_brick does not define connector for NVME and SCALEIO on ppc64 platform | |
| 08:25:01 | gibi | I remember you mentioned that you think we missed some arch mocking in our test. Did you mean these? Or in this case we should skip these tests on ppc64? | |
| 08:53:15 | songwenping_ | gibi, sean-k-mooney: hi, do you have any ideas why we need detach pci devices when we suspend the guest, and if the the pci devices detached, can other guest attach them? | |
| 08:58:47 | gibi | songwenping_: I don't know why we need to detach for suspend. If we only detach but does not remove the pci claim then another instance cannot claim the same device | |
| 08:59:05 | gibi | you can look at the pci_devices table to see the state the the device after the suspend | |
| 08:59:55 | songwenping_ | gibi: thanks for your guide. | |
| 09:04:39 | gibi | hm, it seems that the nova-ceph-multisore is full red since last evening https://zuul.opendev.org/t/openstack/builds?job_name=nova-ceph-multistore&project=openstack/nova | |
| 09:05:38 | lyarwood | gibi: morning | |
| 09:05:45 | gibi | lyarwood: o/ | |
| 09:06:14 | lyarwood | gibi: yeah that's an example but I can't recall if nova or os-brick are checking the arch here tbh | |
| 09:06:25 | lyarwood | gibi: either way unit tests shouldn't be checking so it needs to be mocked | |
| 09:06:26 | gibi | lyarwood: yes it does check the arc | |
| 09:06:47 | lyarwood | gibi: and I'm not sure that we should be allowing calls to reach down into os-brick in our unit tests anyway right? | |
| 09:06:49 | gibi | it has different list of connectors on different platform | |
| 09:07:05 | lyarwood | gibi: we should be mocking things outside of tree | |
| 09:07:10 | lyarwood | of our* | |
| 09:07:12 | gibi | lyarwood: yeah, hitting os_brick is also a bit dirty | |
| 09:07:14 | gibi | in unit test | |
| 09:07:35 | bauzas | lyarwood: sorry was on PTO yesterday | |
| 09:07:47 | gibi | lyarwood: did you have a patch that poisons the arch checking code? | |
| 09:08:03 | gibi | that would make these errors visible in our gate too | |
| 09:08:34 | lyarwood | gibi: https://review.opendev.org/c/openstack/nova/+/769920 but in this case it's os-brick looking up the arch | |
| 09:08:56 | lyarwood | gibi: so to fix this we just need to mock out the os-brick calls, I'll file a bug and submit something later today | |
| 09:09:08 | gibi | lyarwood: thanks | |
| 09:09:21 | lyarwood | bauzas: np, was that ping about the spec? https://review.opendev.org/c/openstack/nova-specs/+/771474 reviews still welcome if you have time today | |
| 09:09:24 | lyarwood | gibi: ^ also btw | |
| 09:09:31 | gibi | there is a mail on the ML from aditi Dukle running the ppc64 unit test | |
| 09:09:32 | bauzas | lyarwood: indeed, and sure | |
| 09:09:32 | gibi | s | |
| 09:19:01 | gibi | the gate is broken https://bugs.launchpad.net/nova/+bug/1912607\ | |
| 09:19:03 | openstack | Launchpad bug 1912607 in OpenStack Compute (nova) "test_attach_cloned_encrypted_volume fails in nova-ceph-multistore job permanently " [Critical,New] | |
| 09:23:07 | lyarwood | gibi: looking | |
| 09:23:43 | lyarwood | gibi: can you add a direct link to the example failure logs in the bug? | |
| 09:24:11 | lyarwood | this smells like a cinder bug tbh | |
| 09:24:21 | gibi | lyarwood: done | |
| 09:25:12 | gibi | lyarwood: there was not much patch merged in cinder yesterday | |
| 09:25:48 | lyarwood | yeah that test only landed yesterday | |
| 09:27:07 | lyarwood | where they don't have coverage of our nova-ceph-multistore job | |
| 09:28:07 | gibi | ohh, so do we need to revert the test? | |
| 09:28:17 | gibi | stephenfin: do you have a blueprint for https://review.opendev.org/q/topic:%22bp%252Fsmarter-usb-devices%22+(status:open%20OR%20status:merged) ? | |
| 09:30:34 | openstackgerrit | Merged openstack/nova-specs master: libvirt: Add support for flavor and image defined ephemeral encryption https://review.opendev.org/c/openstack/nova-specs/+/771474 | |
| 09:32:54 | stephenfin | gibi: Hmm, I don't. That was more bugfix than feature. I can create one now though? | |
| 09:33:11 | stephenfin | (despite the topic) | |
| 09:34:36 | lyarwood | gibi: https://github.com/openstack/nova/blob/b9c48afd1516023839dd32b96f3eece36b164a8c/.zuul.yaml#L379-L382 - I guess we add it to the blacklist | |
| 09:43:51 | openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Skip test_attach_cloned_encrypted_volume in nova-ceph-multistore https://review.opendev.org/c/openstack/nova/+/771777 | |
| 09:44:35 | lyarwood | gibi: ^ yup lets skip it | |
| 09:46:37 | lyarwood | gibi: https://review.opendev.org/c/openstack/nova/+/754702 - would you mind hitting this today so we can start on the above removals and version bumps please? | |
| 09:59:36 | bauzas | any help for the gate issue ? | |
| 09:59:50 | bauzas | lyarwood: gibi: ^ | |
| 10:01:16 | lyarwood | bauzas: reviews on https://review.opendev.org/c/openstack/nova/+/754702 would help thanks | |
| 10:01:25 | bauzas | ack on it | |
| 10:01:28 | gibi | stephenfin: no worries if this is a bugfix then lets handle that that way | |
| 10:02:44 | bauzas | lyarwood: why isn't it just a revert of https://review.opendev.org/c/openstack/nova/+/746210 ? | |
| 10:03:06 | bauzas | I guess because of https://review.opendev.org/c/openstack/nova/+/746981 ? | |
| 10:07:12 | lyarwood | conflicts iirc | |
| 10:07:22 | lyarwood | oh wait sorry that wasn't the gate issue | |
| 10:07:29 | lyarwood | https://review.opendev.org/c/openstack/nova/+/771777 is for the gate issue | |
| 10:07:40 | stephenfin | gibi: Actually, the stuff that's merged is a bugfix but "libvirt: Add support for virtio-based input devices" isn't really. I can create a BP for that | |
| 10:09:44 | gibi | lyarwood: thanks, fast approved https://review.opendev.org/c/openstack/nova/+/771777 | |
| 10:10:16 | bauzas | gibi: already added my +2 ;) | |
| 10:10:19 | stephenfin | gibi: https://blueprints.launchpad.net/nova/+spec/smarter-usb-devices | |
| 10:11:19 | stephenfin | gibi: related discussion here http://lists.openstack.org/pipermail/openstack-discuss/2020-November/018713.html | |
| 10:17:55 | stephenfin | lyarwood: Any chance you could re-add your +2 here https://review.opendev.org/c/openstack/nova/+/756551/3 The discussion on the mailing list concluded. melwitt deferred to others on whether the 'hw_input_bus' idea (the next patch) was a good idea or not. I still think it is, obv | |
| 10:18:36 | gibi | bauzas: you stole my justified fast approve :) | |
| 10:18:41 | gibi | stephenfin: thanks | |
| 10:25:18 | gibi | stephenfin: wiil you bring it up the smarter-usb-device bp on the today's meeting for a last minute approval? | |
| 10:25:24 | stephenfin | sure | |
| 10:25:26 | gibi | cool | |
| 10:29:05 | openstackgerrit | Mark Goddard proposed openstack/nova master: Fix PCI passthrough race on reschedule (claims) https://review.opendev.org/c/openstack/nova/+/710847 | |
| 10:29:06 | openstackgerrit | Mark Goddard proposed openstack/nova master: Fix PCI passthrough race on reschedule (refresh) https://review.opendev.org/c/openstack/nova/+/710848 | |
| 10:34:25 | openstackgerrit | Mark Goddard proposed openstack/nova master: Functional test test_boot_reschedule_with_proper_pci_device_count https://review.opendev.org/c/openstack/nova/+/760354 | |
| 11:21:13 | sean-k-mooney | stephenfin: i can quickly update the upgrage impact section in the vdpa spec if you like | |
| 11:21:19 | stephenfin | fine by me | |
| 11:21:20 | sean-k-mooney | without hte triat it just become None | |
| 11:21:24 | stephenfin | follow-up is also good | |
| 11:21:35 | sean-k-mooney | ok ill do it in a patch on top | |
| 11:26:00 | openstackgerrit | sean mooney proposed openstack/nova-specs master: [FUP] remove final reference to trait in vdpa spec https://review.opendev.org/c/openstack/nova-specs/+/771796 | |
| 11:26:37 | stephenfin | lyarwood, gibi: when live migrating on API microversion >= 2.25, is there any reason to set block_migration to any value *except* auto? | |
| 11:26:46 | stephenfin | i.e. to explicitly request block or shared migration | |
| 11:27:07 | sean-k-mooney | stephenfin: not that i no of | |
| 11:27:47 | stephenfin | okay, so would it make sense to simply ignore the '--block-migration' and '--shared-migration' flags of 'openstack server migrate --live-migration' on suitable microversions | |
| 11:27:51 | stephenfin | with a log, of course | |
| 11:38:17 | lyarwood | stephenfin: I guess as a workaround when auto doesn't detect that things either are or are not shared? | |
| 11:38:40 | stephenfin | Does that happen? | |
| 11:38:58 | lyarwood | I've never seen it, just playing devils advocate | |
| 11:39:17 | stephenfin | fair. I've gone with an overrideable default so we should be good | |
| 11:39:31 | lyarwood | I guess that's why we allow three values instead of just dropping the param and always going auto under the covers | |