| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-01-21 | |||
| 09:05:45 | gibi | lyarwood: o/ | |
| 09:06:14 | lyarwood | gibi: yeah that's an example but I can't recall if nova or os-brick are checking the arch here tbh | |
| 09:06:25 | lyarwood | gibi: either way unit tests shouldn't be checking so it needs to be mocked | |
| 09:06:26 | gibi | lyarwood: yes it does check the arc | |
| 09:06:47 | lyarwood | gibi: and I'm not sure that we should be allowing calls to reach down into os-brick in our unit tests anyway right? | |
| 09:06:49 | gibi | it has different list of connectors on different platform | |
| 09:07:05 | lyarwood | gibi: we should be mocking things outside of tree | |
| 09:07:10 | lyarwood | of our* | |
| 09:07:12 | gibi | lyarwood: yeah, hitting os_brick is also a bit dirty | |
| 09:07:14 | gibi | in unit test | |
| 09:07:35 | bauzas | lyarwood: sorry was on PTO yesterday | |
| 09:07:47 | gibi | lyarwood: did you have a patch that poisons the arch checking code? | |
| 09:08:03 | gibi | that would make these errors visible in our gate too | |
| 09:08:34 | lyarwood | gibi: https://review.opendev.org/c/openstack/nova/+/769920 but in this case it's os-brick looking up the arch | |
| 09:08:56 | lyarwood | gibi: so to fix this we just need to mock out the os-brick calls, I'll file a bug and submit something later today | |
| 09:09:08 | gibi | lyarwood: thanks | |
| 09:09:21 | lyarwood | bauzas: np, was that ping about the spec? https://review.opendev.org/c/openstack/nova-specs/+/771474 reviews still welcome if you have time today | |
| 09:09:24 | lyarwood | gibi: ^ also btw | |
| 09:09:31 | gibi | there is a mail on the ML from aditi Dukle running the ppc64 unit test | |
| 09:09:32 | bauzas | lyarwood: indeed, and sure | |
| 09:09:32 | gibi | s | |
| 09:19:01 | gibi | the gate is broken https://bugs.launchpad.net/nova/+bug/1912607\ | |
| 09:19:03 | openstack | Launchpad bug 1912607 in OpenStack Compute (nova) "test_attach_cloned_encrypted_volume fails in nova-ceph-multistore job permanently " [Critical,New] | |
| 09:23:07 | lyarwood | gibi: looking | |
| 09:23:43 | lyarwood | gibi: can you add a direct link to the example failure logs in the bug? | |
| 09:24:11 | lyarwood | this smells like a cinder bug tbh | |
| 09:24:21 | gibi | lyarwood: done | |
| 09:25:12 | gibi | lyarwood: there was not much patch merged in cinder yesterday | |
| 09:25:48 | lyarwood | yeah that test only landed yesterday | |
| 09:27:07 | lyarwood | where they don't have coverage of our nova-ceph-multistore job | |
| 09:28:07 | gibi | ohh, so do we need to revert the test? | |
| 09:28:17 | gibi | stephenfin: do you have a blueprint for https://review.opendev.org/q/topic:%22bp%252Fsmarter-usb-devices%22+(status:open%20OR%20status:merged) ? | |
| 09:30:34 | openstackgerrit | Merged openstack/nova-specs master: libvirt: Add support for flavor and image defined ephemeral encryption https://review.opendev.org/c/openstack/nova-specs/+/771474 | |
| 09:32:54 | stephenfin | gibi: Hmm, I don't. That was more bugfix than feature. I can create one now though? | |
| 09:33:11 | stephenfin | (despite the topic) | |
| 09:34:36 | lyarwood | gibi: https://github.com/openstack/nova/blob/b9c48afd1516023839dd32b96f3eece36b164a8c/.zuul.yaml#L379-L382 - I guess we add it to the blacklist | |
| 09:43:51 | openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Skip test_attach_cloned_encrypted_volume in nova-ceph-multistore https://review.opendev.org/c/openstack/nova/+/771777 | |
| 09:44:35 | lyarwood | gibi: ^ yup lets skip it | |
| 09:46:37 | lyarwood | gibi: https://review.opendev.org/c/openstack/nova/+/754702 - would you mind hitting this today so we can start on the above removals and version bumps please? | |
| 09:59:36 | bauzas | any help for the gate issue ? | |
| 09:59:50 | bauzas | lyarwood: gibi: ^ | |
| 10:01:16 | lyarwood | bauzas: reviews on https://review.opendev.org/c/openstack/nova/+/754702 would help thanks | |
| 10:01:25 | bauzas | ack on it | |
| 10:01:28 | gibi | stephenfin: no worries if this is a bugfix then lets handle that that way | |
| 10:02:44 | bauzas | lyarwood: why isn't it just a revert of https://review.opendev.org/c/openstack/nova/+/746210 ? | |
| 10:03:06 | bauzas | I guess because of https://review.opendev.org/c/openstack/nova/+/746981 ? | |
| 10:07:12 | lyarwood | conflicts iirc | |
| 10:07:22 | lyarwood | oh wait sorry that wasn't the gate issue | |
| 10:07:29 | lyarwood | https://review.opendev.org/c/openstack/nova/+/771777 is for the gate issue | |
| 10:07:40 | stephenfin | gibi: Actually, the stuff that's merged is a bugfix but "libvirt: Add support for virtio-based input devices" isn't really. I can create a BP for that | |
| 10:09:44 | gibi | lyarwood: thanks, fast approved https://review.opendev.org/c/openstack/nova/+/771777 | |
| 10:10:16 | bauzas | gibi: already added my +2 ;) | |
| 10:10:19 | stephenfin | gibi: https://blueprints.launchpad.net/nova/+spec/smarter-usb-devices | |
| 10:11:19 | stephenfin | gibi: related discussion here http://lists.openstack.org/pipermail/openstack-discuss/2020-November/018713.html | |
| 10:17:55 | stephenfin | lyarwood: Any chance you could re-add your +2 here https://review.opendev.org/c/openstack/nova/+/756551/3 The discussion on the mailing list concluded. melwitt deferred to others on whether the 'hw_input_bus' idea (the next patch) was a good idea or not. I still think it is, obv | |
| 10:18:36 | gibi | bauzas: you stole my justified fast approve :) | |
| 10:18:41 | gibi | stephenfin: thanks | |
| 10:25:18 | gibi | stephenfin: wiil you bring it up the smarter-usb-device bp on the today's meeting for a last minute approval? | |
| 10:25:24 | stephenfin | sure | |
| 10:25:26 | gibi | cool | |
| 10:29:05 | openstackgerrit | Mark Goddard proposed openstack/nova master: Fix PCI passthrough race on reschedule (claims) https://review.opendev.org/c/openstack/nova/+/710847 | |
| 10:29:06 | openstackgerrit | Mark Goddard proposed openstack/nova master: Fix PCI passthrough race on reschedule (refresh) https://review.opendev.org/c/openstack/nova/+/710848 | |
| 10:34:25 | openstackgerrit | Mark Goddard proposed openstack/nova master: Functional test test_boot_reschedule_with_proper_pci_device_count https://review.opendev.org/c/openstack/nova/+/760354 | |
| 11:21:13 | sean-k-mooney | stephenfin: i can quickly update the upgrage impact section in the vdpa spec if you like | |
| 11:21:19 | stephenfin | fine by me | |
| 11:21:20 | sean-k-mooney | without hte triat it just become None | |
| 11:21:24 | stephenfin | follow-up is also good | |
| 11:21:35 | sean-k-mooney | ok ill do it in a patch on top | |
| 11:26:00 | openstackgerrit | sean mooney proposed openstack/nova-specs master: [FUP] remove final reference to trait in vdpa spec https://review.opendev.org/c/openstack/nova-specs/+/771796 | |
| 11:26:37 | stephenfin | lyarwood, gibi: when live migrating on API microversion >= 2.25, is there any reason to set block_migration to any value *except* auto? | |
| 11:26:46 | stephenfin | i.e. to explicitly request block or shared migration | |
| 11:27:07 | sean-k-mooney | stephenfin: not that i no of | |
| 11:27:47 | stephenfin | okay, so would it make sense to simply ignore the '--block-migration' and '--shared-migration' flags of 'openstack server migrate --live-migration' on suitable microversions | |
| 11:27:51 | stephenfin | with a log, of course | |
| 11:38:17 | lyarwood | stephenfin: I guess as a workaround when auto doesn't detect that things either are or are not shared? | |
| 11:38:40 | stephenfin | Does that happen? | |
| 11:38:58 | lyarwood | I've never seen it, just playing devils advocate | |
| 11:39:17 | stephenfin | fair. I've gone with an overrideable default so we should be good | |
| 11:39:31 | lyarwood | I guess that's why we allow three values instead of just dropping the param and always going auto under the covers | |
| 11:39:46 | lyarwood | which FWIW I'd be fine with | |
| 11:39:51 | lyarwood | and if that fails raise a bug | |
| 11:40:03 | lyarwood | but that's another microversion | |
| 11:43:02 | sean-k-mooney | i think we just did not remove it because we need the code for the lower microverions so did not see the point | |
| 11:43:18 | lyarwood | yeah that's fair | |
| 11:44:00 | sean-k-mooney | stephenfin: you should not eed to pass --block-migration or --shared-migration however when using --live-migration i think | |
| 11:44:31 | sean-k-mooney | e.g. if osc requires either today we should dorp that requirement with microversion >=2.25 | |
| 12:30:13 | gibi | stephenfin: defaulting to auto works for me | |
| 12:30:41 | stephenfin | Cool. That's here https://review.opendev.org/c/openstack/python-openstackclient/+/771801 | |
| 12:31:14 | stephenfin | Along with what I hope to be the remainder of the feature gap closing patches for OSC. My doc of novaclient gaps is now empty save for things I don't think we need | |
| 12:37:29 | gibi | stephenfin: ack, will try to get to it | |
| 12:37:42 | gibi | sean-k-mooney: I approved the vdpa spec and the fup. but I have a question | |
| 12:38:03 | gibi | sean-k-mooney: do you have some link to a ticket that tracks the live migration support for vdpa in QEMU? | |
| 12:38:31 | gibi | (suddenly my downstream product mgr got really interested in all the vdpa stuff) | |
| 12:40:04 | sean-k-mooney | ah good question. there are mail threads on that topic let me see if we have something in bugzilla. i get periodic updates form our qemu folks but not directly tracking it myself | |
| 12:40:21 | sean-k-mooney | also thanks :) | |
| 12:41:28 | sean-k-mooney | gibi: by the way vdpa will support block devices at some point to | |
| 12:41:43 | sean-k-mooney | so that will evenruatly become and rfe | |
| 12:42:04 | sean-k-mooney | it provides a way to offload thinks like nvme over rdma to the nic and pass it though to the guest | |
| 12:42:17 | gibi | sounds interesting | |
| 12:42:33 | sean-k-mooney | but also provides a way to take a local ssd and use sriov/vdpa to devide it up | |