| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-01-15 | |||
| 13:55:34 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: WIP/DNM libvirt: Start emitting DeviceRemovedEvent and DeviceRemovalFailedEvent events https://review.opendev.org/c/openstack/nova/+/749929 | |
| 13:55:35 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: DNM try to replace retry with libvirt event in detach https://review.opendev.org/c/openstack/nova/+/770246 | |
| 13:59:34 | bauzas | sean-k-mooney: yeah, provisioning them directly | |
| 14:00:00 | bauzas | once the operator modifies the config | |
| 14:00:22 | sean-k-mooney | what config? | |
| 14:00:40 | bauzas | their own config for telling which vgpu type for each pGPU | |
| 14:00:45 | sean-k-mooney | we are talking about recreating them after a host reboot | |
| 14:01:14 | sean-k-mooney | the cyborg spec currently say after a host reboot when we reboot the instance that we will do a arq show | |
| 14:01:25 | bauzas | I haven't seen it | |
| 14:01:26 | sean-k-mooney | and that show will do an rpc to the agent to create the mdev | |
| 14:01:28 | bauzas | if so, -1 for me | |
| 14:01:59 | sean-k-mooney | im suggesting that instead on start up the agent shoucl check what instance are on the current host and ensure there mdevs exist | |
| 14:02:15 | sean-k-mooney | and that arqs should have 2 newe states | |
| 14:02:25 | sean-k-mooney | unknon meaning the agent missed it heart beat | |
| 14:02:35 | sean-k-mooney | and provisioning meaning its currenlty seting up the mdev | |
| 14:03:18 | sean-k-mooney | so when we do the show arq binding call if its in provisioning or unknow we wait for the async event | |
| 14:03:27 | sean-k-mooney | if its in bound we know cyborg is done and we proceed | |
| 14:10:53 | bauzas | sean-k-mooney: then I agree with you | |
| 14:11:21 | bauzas | have you provided those comments in the spec ? | |
| 14:11:43 | sean-k-mooney | yes although not that cohently initally so i reference the irc logs above | |
| 14:11:59 | sean-k-mooney | i had give that feedbac in patch set 7 or 9 too | |
| 14:22:30 | bauzas | ++ | |
| 14:22:41 | bauzas | I'll then add my comments then too | |
| 14:39:41 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: trivial: Resolve (most) flake8 3.x issues https://review.opendev.org/c/openstack/nova/+/770943 | |
| 14:39:42 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: WIP/DNM Switch to hacking 2.x https://review.opendev.org/c/openstack/nova/+/770944 | |
| 14:47:45 | stephenfin | lyarwood: Does this need a blueprint, I wonder? It is kind of feature'ish https://review.opendev.org/c/openstack/nova/+/770926 | |
| 15:03:28 | lyarwood | stephenfin: likely, I was procrastinating this morning and wrote that without thinking | |
| 15:07:14 | lyarwood | gibi: ^ re this, should I create a blueprint for this? | |
| 15:08:33 | gibi | lyarwood: yeah, a bp would be good for that it is adding a feature basically | |
| 15:09:20 | gibi | or we can phrase the whole thing as a bug | |
| 15:09:34 | gibi | we forget to log resetState into the instance actions | |
| 15:09:40 | gibi | so meh, either a bp or a bug would be good | |
| 15:10:05 | gibi | no structural API impact so definetly not a spec | |
| 15:19:55 | lyarwood | gibi: ack let me spin this into a bug | |
| 15:20:04 | gibi | works for me | |
| 15:21:25 | openstackgerrit | Stephen Finucane proposed openstack/nova master: api-ref: Clarify 'all_tenants' command https://review.opendev.org/c/openstack/nova/+/770947 | |
| 15:21:38 | stephenfin | That's the easiest "bugfix" anyone will see this week ^ | |
| 15:24:39 | gibi | stephenfin: +@ | |
| 15:24:41 | gibi | stephenfin: +2 | |
| 15:24:58 | stephenfin | thanks :) | |
| 15:30:29 | dansmith | ahh, the rare but coveted +@ vote | |
| 15:30:36 | openstackgerrit | Lee Yarwood proposed openstack/nova master: api: Log os-resetState as an instance action https://review.opendev.org/c/openstack/nova/+/770926 | |
| 15:39:05 | gibi | dansmith: :) | |
| 15:41:14 | stephenfin | Is https://docs.openstack.org/ down for anyone else? | |
| 15:42:41 | stephenfin | nvm, it's back | |
| 15:43:43 | lyarwood | stephenfin: rate limited again? :D | |
| 16:06:14 | openstackgerrit | Lee Yarwood proposed openstack/nova master: api: Log os-resetState as an instance action https://review.opendev.org/c/openstack/nova/+/770926 | |
| 16:06:19 | lyarwood | stephenfin: well you did ask me to write another bloody reno ;) ^ | |
| 16:09:30 | dansmith | stephenfin: really nice job on the db compaction series... you made validating them as easy as I hoped, so I hope we'll get at least another core or two to do it :) | |
| 16:12:40 | stephenfin | oh, thanks. Hopefully | |
| 16:28:38 | stephenfin | melwitt: quota question: if I create a server in a server group, should I expect the server_group_members.in_use count seen in 'nova quota-show --detail' to increment? | |
| 16:29:25 | melwitt | stephenfin: that might be one that stays stuck at zero. let me look and refresh my memory | |
| 16:32:27 | melwitt | stephenfin: yeah, that is one of the two that stays at zero (legacy behavior that hasn't been changed) https://github.com/openstack/nova/blob/master/nova/quota.py#L178-L182 | |
| 16:32:39 | melwitt | so you would expect it not to ever increment | |
| 16:32:56 | stephenfin | okay, great. Thanks for the confirmation | |
| 16:33:04 | openstack | Launchpad bug 1909269 in OpenStack Compute (nova) "I create a server_groups vm , but server_group_members doesn't add one." [Undecided,New] | |
| 16:43:59 | lyarwood | stephenfin: did you plan on wiring up openstack server migration show btw? | |
| 16:45:15 | stephenfin | oh, fair point | |
| 16:45:25 | stephenfin | I don't think there's a patch open for that. I can add one | |
| 16:45:26 | stephenfin | https://etherpad.opendev.org/p/compute-api-microversion-gap-in-osc | |
| 16:46:00 | lyarwood | stephenfin: cool happy to also look at that post m2 | |
| 16:46:39 | lyarwood | in the context of https://bugs.launchpad.net/nova/+bug/1910781 btw | |
| 16:46:42 | openstack | Launchpad bug 1910781 in OpenStack Compute (nova) "Live migration to different host returns complete but nothing has happened" [Undecided,New] | |
| 16:46:48 | lyarwood | looks like there's another bug there with --wait | |
| 17:06:40 | openstackgerrit | Merged openstack/nova master: Fix typo in warning message https://review.opendev.org/c/openstack/nova/+/770067 | |
| 17:57:39 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: libvirt: Skip encryption metadata lookups if secret already exists on host https://review.opendev.org/c/openstack/nova/+/765772 | |
| 19:23:10 | gmann | dansmith: melwitt if you are around can you check these two reviews for JSON->YAMl policy file migration - https://review.opendev.org/c/openstack/placement/+/764394 https://review.opendev.org/c/openstack/nova/+/763487 | |
| 19:52:23 | dansmith | gmann: you replace a function ref with a (function, dict) tuple.. do the upgrade checks support that for args? | |
| 19:54:28 | dansmith | functools.partial or lambda would make that a little clearer, but I'm not sure what exactly parses this | |
| 20:10:56 | gmann | dansmith: I added the support for tuple in oslo.upgradecheck - https://github.com/openstack/oslo.upgradecheck/blob/a962943bdaa746ad238f003f56556eb02d1ea8e8/oslo_upgradecheck/upgradecheck.py#L104 | |
| 20:11:24 | dansmith | gmann: okay | |
| 20:11:46 | dansmith | gmann: left you another question | |
| 20:12:29 | gmann | dansmith: this one? https://review.opendev.org/c/openstack/nova/+/763487/9/nova/policy.py#79 | |
| 20:12:31 | melwitt | gmann: ack, will look | |
| 20:12:36 | dansmith | gmann: yar | |
| 20:12:46 | dansmith | oh sorry | |
| 20:12:50 | gmann | we have covered the test on oslo side, you want to keep existing nova test too | |
| 20:13:35 | dansmith | no, | |
| 20:13:39 | dansmith | I just want to make sure we know what is and isn't changing | |
| 20:14:16 | dansmith | are you saying that oslo.policy controls CONF.policy_file, and is handling the CONF.find_file behavior? | |
| 20:14:20 | gmann | ok, yeah be default this fallback is maintained in oslo side until oslo.policy remove the JSON support | |
| 20:14:35 | dansmith | oh wait wait, I see | |
| 20:14:49 | dansmith | because we're calling into policy.Enforcer... nevermind | |
| 20:14:53 | dansmith | sorry | |
| 20:15:01 | gmann | yeah https://github.com/openstack/oslo.policy/blob/0a228dea2ee96ec3eabed3361ca22502d0bbd4a1/oslo_policy/policy.py#L533 | |
| 20:15:02 | openstackgerrit | Merged openstack/nova stable/stein: [stable-only] Fix lower-constraints job https://review.opendev.org/c/openstack/nova/+/769809 | |
| 20:35:40 | openstackgerrit | Ghanshyam proposed openstack/placement master: [goal] Deprecate the JSON formatted policy file https://review.opendev.org/c/openstack/placement/+/764394 | |
| 20:35:45 | gmann | dansmith: ^^ updated | |
| 20:38:00 | melwitt | gmann: one comment on the nova change, looks like the code you need is in 1.2.0, did you want to go ahead and keep it at 1.3.0? | |
| 20:38:57 | gmann | melwitt: i remember something extra i fixed in 1.3.0, let me check | |
| 20:39:17 | melwitt | gmann: ok, completely up to you. just pointed it out in case it isn't what you intended | |
| 20:40:52 | gmann | melwitt: CLI opt registration things added in 1.30 - https://github.com/openstack/oslo.upgradecheck/blob/1.3.0/oslo_upgradecheck/common_checks.py#L29 | |
| 20:40:56 | gmann | replied in gerrit too | |
| 20:41:08 | melwitt | gmann: ok, great. thanks for clarifying that | |
| 20:53:08 | gmann | thanks dansmith melwitt for review, have a nice weekend | |
| 20:53:16 | dansmith | gmann: you as well :) | |
| 20:54:23 | gmann | thx :) | |
| 20:58:23 | melwitt | gmann: have a nice weekend o/ | |
| 22:44:12 | openstackgerrit | Merged openstack/nova master: Reuse code from oslo lib for JSON policy migration https://review.opendev.org/c/openstack/nova/+/763487 | |
| #openstack-nova - 2021-01-16 | |||
| 05:49:15 | openstackgerrit | Merged openstack/nova master: api-ref: Clarify 'all_tenants' command https://review.opendev.org/c/openstack/nova/+/770947 | |