| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-01-15 | |||
| 15:43:43 | lyarwood | stephenfin: rate limited again? :D | |
| 16:06:14 | openstackgerrit | Lee Yarwood proposed openstack/nova master: api: Log os-resetState as an instance action https://review.opendev.org/c/openstack/nova/+/770926 | |
| 16:06:19 | lyarwood | stephenfin: well you did ask me to write another bloody reno ;) ^ | |
| 16:09:30 | dansmith | stephenfin: really nice job on the db compaction series... you made validating them as easy as I hoped, so I hope we'll get at least another core or two to do it :) | |
| 16:12:40 | stephenfin | oh, thanks. Hopefully | |
| 16:28:38 | stephenfin | melwitt: quota question: if I create a server in a server group, should I expect the server_group_members.in_use count seen in 'nova quota-show --detail' to increment? | |
| 16:29:25 | melwitt | stephenfin: that might be one that stays stuck at zero. let me look and refresh my memory | |
| 16:32:27 | melwitt | stephenfin: yeah, that is one of the two that stays at zero (legacy behavior that hasn't been changed) https://github.com/openstack/nova/blob/master/nova/quota.py#L178-L182 | |
| 16:32:39 | melwitt | so you would expect it not to ever increment | |
| 16:32:56 | stephenfin | okay, great. Thanks for the confirmation | |
| 16:33:04 | openstack | Launchpad bug 1909269 in OpenStack Compute (nova) "I create a server_groups vm , but server_group_members doesn't add one." [Undecided,New] | |
| 16:43:59 | lyarwood | stephenfin: did you plan on wiring up openstack server migration show btw? | |
| 16:45:15 | stephenfin | oh, fair point | |
| 16:45:25 | stephenfin | I don't think there's a patch open for that. I can add one | |
| 16:45:26 | stephenfin | https://etherpad.opendev.org/p/compute-api-microversion-gap-in-osc | |
| 16:46:00 | lyarwood | stephenfin: cool happy to also look at that post m2 | |
| 16:46:39 | lyarwood | in the context of https://bugs.launchpad.net/nova/+bug/1910781 btw | |
| 16:46:42 | openstack | Launchpad bug 1910781 in OpenStack Compute (nova) "Live migration to different host returns complete but nothing has happened" [Undecided,New] | |
| 16:46:48 | lyarwood | looks like there's another bug there with --wait | |
| 17:06:40 | openstackgerrit | Merged openstack/nova master: Fix typo in warning message https://review.opendev.org/c/openstack/nova/+/770067 | |
| 17:57:39 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: libvirt: Skip encryption metadata lookups if secret already exists on host https://review.opendev.org/c/openstack/nova/+/765772 | |
| 19:23:10 | gmann | dansmith: melwitt if you are around can you check these two reviews for JSON->YAMl policy file migration - https://review.opendev.org/c/openstack/placement/+/764394 https://review.opendev.org/c/openstack/nova/+/763487 | |
| 19:52:23 | dansmith | gmann: you replace a function ref with a (function, dict) tuple.. do the upgrade checks support that for args? | |
| 19:54:28 | dansmith | functools.partial or lambda would make that a little clearer, but I'm not sure what exactly parses this | |
| 20:10:56 | gmann | dansmith: I added the support for tuple in oslo.upgradecheck - https://github.com/openstack/oslo.upgradecheck/blob/a962943bdaa746ad238f003f56556eb02d1ea8e8/oslo_upgradecheck/upgradecheck.py#L104 | |
| 20:11:24 | dansmith | gmann: okay | |
| 20:11:46 | dansmith | gmann: left you another question | |
| 20:12:29 | gmann | dansmith: this one? https://review.opendev.org/c/openstack/nova/+/763487/9/nova/policy.py#79 | |
| 20:12:31 | melwitt | gmann: ack, will look | |
| 20:12:36 | dansmith | gmann: yar | |
| 20:12:46 | dansmith | oh sorry | |
| 20:12:50 | gmann | we have covered the test on oslo side, you want to keep existing nova test too | |
| 20:13:35 | dansmith | no, | |
| 20:13:39 | dansmith | I just want to make sure we know what is and isn't changing | |
| 20:14:16 | dansmith | are you saying that oslo.policy controls CONF.policy_file, and is handling the CONF.find_file behavior? | |
| 20:14:20 | gmann | ok, yeah be default this fallback is maintained in oslo side until oslo.policy remove the JSON support | |
| 20:14:35 | dansmith | oh wait wait, I see | |
| 20:14:49 | dansmith | because we're calling into policy.Enforcer... nevermind | |
| 20:14:53 | dansmith | sorry | |
| 20:15:01 | gmann | yeah https://github.com/openstack/oslo.policy/blob/0a228dea2ee96ec3eabed3361ca22502d0bbd4a1/oslo_policy/policy.py#L533 | |
| 20:15:02 | openstackgerrit | Merged openstack/nova stable/stein: [stable-only] Fix lower-constraints job https://review.opendev.org/c/openstack/nova/+/769809 | |
| 20:35:40 | openstackgerrit | Ghanshyam proposed openstack/placement master: [goal] Deprecate the JSON formatted policy file https://review.opendev.org/c/openstack/placement/+/764394 | |
| 20:35:45 | gmann | dansmith: ^^ updated | |
| 20:38:00 | melwitt | gmann: one comment on the nova change, looks like the code you need is in 1.2.0, did you want to go ahead and keep it at 1.3.0? | |
| 20:38:57 | gmann | melwitt: i remember something extra i fixed in 1.3.0, let me check | |
| 20:39:17 | melwitt | gmann: ok, completely up to you. just pointed it out in case it isn't what you intended | |
| 20:40:52 | gmann | melwitt: CLI opt registration things added in 1.30 - https://github.com/openstack/oslo.upgradecheck/blob/1.3.0/oslo_upgradecheck/common_checks.py#L29 | |
| 20:40:56 | gmann | replied in gerrit too | |
| 20:41:08 | melwitt | gmann: ok, great. thanks for clarifying that | |
| 20:53:08 | gmann | thanks dansmith melwitt for review, have a nice weekend | |
| 20:53:16 | dansmith | gmann: you as well :) | |
| 20:54:23 | gmann | thx :) | |
| 20:58:23 | melwitt | gmann: have a nice weekend o/ | |
| 22:44:12 | openstackgerrit | Merged openstack/nova master: Reuse code from oslo lib for JSON policy migration https://review.opendev.org/c/openstack/nova/+/763487 | |
| #openstack-nova - 2021-01-16 | |||
| 05:49:15 | openstackgerrit | Merged openstack/nova master: api-ref: Clarify 'all_tenants' command https://review.opendev.org/c/openstack/nova/+/770947 | |
| 12:14:08 | openstackgerrit | Merged openstack/nova master: Cyborg shelve/unshelve support https://review.opendev.org/c/openstack/nova/+/729563 | |
| 14:52:41 | openstackgerrit | Merged openstack/nova stable/stein: Change default num_retries for glance to 3 https://review.opendev.org/c/openstack/nova/+/764963 | |
| #openstack-nova - 2021-01-17 | |||
| 04:53:55 | Mamduhala | sean-k-mooney, I have pushed backporting patches for the (Fix - os-vif fails to get the correct UpLink Representor | |
| 04:53:55 | Mamduhala | ) for versions ussuri to queens | |
| 04:54:24 | Mamduhala | Can you please give it a review | |
| 04:54:38 | Mamduhala | https://review.opendev.org/c/openstack/os-vif/+/765419 | |
| 04:54:50 | Mamduhala | https://review.opendev.org/c/openstack/os-vif/+/765967 | |
| 07:58:53 | openstackgerrit | Brin Zhang proposed openstack/nova master: [Trivial] Rename host/node to hostname/nodename in conductor manager https://review.opendev.org/c/openstack/nova/+/762499 | |
| 08:09:22 | openstackgerrit | Brin Zhang proposed openstack/nova master: [Trivial] Rename host/node to hostname/nodename in conductor manager https://review.opendev.org/c/openstack/nova/+/762499 | |
| 08:54:19 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Replace blind retry with libvirt event waiting in detach https://review.opendev.org/c/openstack/nova/+/770246 | |
| 11:04:32 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Replace blind retry with libvirt event waiting in detach https://review.opendev.org/c/openstack/nova/+/770246 | |
| 14:30:25 | openstackgerrit | Merged openstack/nova master: Modify PciDevice.uuid generation code https://review.opendev.org/c/openstack/nova/+/530487 | |
| 14:31:12 | openstackgerrit | Merged openstack/nova master: Add an online migration for PciDevice.uuid https://review.opendev.org/c/openstack/nova/+/530905 | |
| 17:57:34 | openstackgerrit | Merged openstack/nova stable/victoria: Reproduce bug 1907522 in functional test https://review.opendev.org/c/openstack/nova/+/769736 | |
| 17:57:36 | openstack | bug 1907522 in OpenStack Compute (nova) "test_*_with_qos_min_bw_allocation fails in the nova-multi-cell job with: nova.exception.MigrationPreCheckError: Migration pre-check error: Failed to create port bindings for host |
|
| #openstack-nova - 2021-01-18 | |||
| 02:06:41 | openstackgerrit | Keigo Noha proposed openstack/nova stable/rocky: Change default num_retries for glance to 3 https://review.opendev.org/c/openstack/nova/+/771120 | |
| 07:04:55 | openstackgerrit | Adit Sarfaty proposed openstack/nova master: Retry on vmware create_vm when it fails https://review.opendev.org/c/openstack/nova/+/764586 | |
| 09:20:12 | openstackgerrit | Lee Yarwood proposed openstack/nova master: api: Log os-resetState as an instance action https://review.opendev.org/c/openstack/nova/+/770926 | |
| 09:20:41 | lyarwood | ^ stephenfin should be good now, there was however a weird but unrelated grenade failure in the last run | |
| 09:20:53 | lyarwood | https://bugs.launchpad.net/tempest/+bug/1912178 | |
| 09:20:55 | openstack | Launchpad bug 1912178 in tempest "Links are not allowed as constraints (pip 20.2.4)" [Undecided,New] | |
| 09:20:55 | stephenfin | ack | |
| 10:08:17 | lyarwood | did we depreacte xen support in the libvirt driver? | |
| 10:10:08 | lyarwood | https://review.opendev.org/c/openstack/nova/+/749055 yup | |
| 10:10:40 | lyarwood | stephenfin: you didn't have a series to remove xen already did you? | |
| 10:10:52 | stephenfin | from libvirt? | |
| 10:10:57 | stephenfin | I did, yeah | |
| 10:11:15 | lyarwood | ah where? I only see the xenapi stuff | |
| 10:11:26 | stephenfin | https://review.opendev.org/q/topic:%22bp%252Fremove-deprecated-libvirt-virt-types%22+(status:open%20OR%20status:merged) | |
| 10:11:42 | lyarwood | *facepalm* sorry the same topic, of course! | |
| 10:12:07 | lyarwood | I'll rebase my version bump on that series and give it a review | |
| 10:36:33 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_VIR_ERR_DEVICE_MISSING https://review.opendev.org/c/openstack/nova/+/754702 | |
| 10:36:34 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Drop support for UML https://review.opendev.org/c/openstack/nova/+/743230 | |
| 10:36:35 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Drop support for Xen https://review.opendev.org/c/openstack/nova/+/743231 | |
| 10:36:35 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION and NEXT_MIN_{LIBVIRT,QEMU}_VERSION https://review.opendev.org/c/openstack/nova/+/754700 | |
| 10:36:38 | lyarwood | okay done ^ gibi I've put the MIN_LIBVIRT_VIR_ERR_DEVICE_MISSING removal patch at the base of that series so we don't hold up your device detach rewrite | |
| 11:11:21 | gibi | lyarwood: thanks. I rebased my effort top of that | |
| 11:11:52 | gibi | lyarwood: btw, the event handling patch seems to work well on the gate, I still have to add some unit tests and I will consider splitting the patch as it is getting huge | |
| 11:13:46 | lyarwood | gibi: ack cool, it's on my list to review later today either way | |
| 11:14:04 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: trivial: Resolve (most) flake8 3.x issues https://review.opendev.org/c/openstack/nova/+/770943 | |
| 11:14:05 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: Switch to hacking 2.x https://review.opendev.org/c/openstack/nova/+/770944 | |
| 11:14:15 | gibi | lyarwood: have you heard back from libvirt folks about the timeout length in libvirt? | |
| 11:14:21 | lyarwood | elod: ^ not sure how you feel about this btw | |
| 11:15:01 | lyarwood | gibi: oh I didn't reach out to them after our discussion last week as it looks like the failure case is sync and doesn't have a timeout | |
| 11:15:15 | lyarwood | gibi: I can confirm with them if you'd like | |